| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates UI feedback upon successful installation of an extension. An InfoBubble is shown containing the install icon and some information about how to manage extensions.
TEST=Install a packaged extension. Verify the InfoBubble is shown, with the install icon and some description. The InfoBubble should disappear when the bubble looses focus (click elsewhere). For a browserAction, the bubble should point to the browserAction icon. For a pageAction **that has a "default_icon" set in it's manifest (see the samples/subscribe_page_action in this CL)**, it should point to a temporarily shown pageAction icon that will be hidden when the bubble closes. Otherwise it should point to the wrench menu.
BUG=21412
Review URL: http://codereview.chromium.org/362022
TBR=rafaelw@chromium.org
Review URL: http://codereview.chromium.org/375019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
least ruling some things out. These traces will be
either be removed (once I get more data).
TBR=jcampan
BUG=16447
TEST=This is changing a test
Review URL: http://codereview.chromium.org/373019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
don't have a process.
BUG=NONE
TEST=Open two chrome windows, navigate one to extensions management UI. Install an extension that has no background process in the other. Management UI should show the installed extension automatically, without reload.
Review URL: http://codereview.chromium.org/371043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates UI feedback upon successful installation of an extension. An InfoBubble is shown containing the install icon and some information about how to manage extensions.
TEST=Install a packaged extension. Verify the InfoBubble is shown, with the install icon and some description. The InfoBubble should disappear when the bubble looses focus (click elsewhere). For a browserAction, the bubble should point to the browserAction icon. For a pageAction **that has a "default_icon" set in it's manifest (see the samples/subscribe_page_action in this CL)**, it should point to a temporarily shown pageAction icon that will be hidden when the bubble closes. Otherwise it should point to the wrench menu.
BUG=21412
Review URL: http://codereview.chromium.org/362022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Followup to http://codereview.chromium.org/293019 .
BUG=none
TEST=Open 2 tabs, go to first tab, go to google.com, make sure that web has focus, hit cmd-w. Chrome shouldn't crash.
Review URL: http://codereview.chromium.org/372034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When dragging a link out of web content, pin the tab so that it
doesn't close out from under the drag.
BUG=26134
TEST=See bug for test.html. View test.html. Dragging link out should cause page to not close, and app should no longer crash.
Review URL: http://codereview.chromium.org/372023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserWindow.xib change was to add newtab_p as the image for the alternate
state for the new tab button.
BUG=26205
TEST=1) mouse over the new tab button and it should highlight.
2) Click and hold on the new tab button and its state should change
3) Release, and watch new tab get created. Verify that new button state
changes appropriately
4) Create a full tab strip of tabs. Verify that button state stays
correct as you click on the new tab button and new tabs are created but
the button doesn't move.
5) Create 2 tabs, and move the mouse button into the newtab button.
See that it highlights. hit cmd-w to close a tab. As the newtab button
moves away from under the cursor make sure it loses its highlight.
Review URL: http://codereview.chromium.org/372009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/372016
Patch from Akira <akira@yayakoshi.net>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
be NULL, which throws and exception.
BUG=26883
TEST=dragging things into the content area (urls, images, text, etc)
Review URL: http://codereview.chromium.org/373016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
which has since been fixed.
TEST=none
BUG=25746
Review URL: http://codereview.chromium.org/377011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wrench menu item is right above "Preferences...". Chrome menu item will be added in a future CL right above "Clear Browsing Data...". Sync menu items are hidden if bookmark sync is disabled (the current default for OS X). UI decisions were made after consulting with Cole.
Added code in browser_window_controller.mm to update sync menu item dynamically.
Added unit tests.
BUG=23073
TEST=manual testing, trybots, unittests
Review URL: http://codereview.chromium.org/363017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
render views.
BUG=25287
Review URL: http://codereview.chromium.org/375011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
There are still some issues with context menus. The context menu doesn't respect links, for example. That is, if you tab to a link and hit the menu button, it will act as if you right clicked on the upper left pixel of the web page (both in content and position of the menu). This seems to be a webkit bug/missing feature as safari 4 on windows does the same. However, some cases do work as expected, for example if you select text and hit the menu button. Anyway, I'll do the webkit side of this fix as some later patch.
BUG=26811
Review URL: http://codereview.chromium.org/371033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Get rid of sync_char16 from syncapi
- Use wstring for title in syncapi since that gets converted to wstring
later on anyway.
- Use GURL for urls in syncapi
- Return const string references from syncapi instead of pointers to
C-style strings.
- Make appropriate changes to calling code.
BUG=26342
TEST=Already exist.
Review URL: http://codereview.chromium.org/362019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gtkfixed business.
The straw that broke this camel's back was when I realized that showing the findbar in fullscreen mode would inescapably mean an extra 1 pixel border at the top.
Also fix z-ordering problems for findbar that have been around since I introduced the floating bookmark bar (the fact that no one filed a bug on this suggests that it's not that noticeable).
BUG=none
TEST=find bar still works. find bar works in fullscreen. the toolbar bottom border still exists at all times. there are no z-ordering problems. the find bar still gets out of way of find results.
Review URL: http://codereview.chromium.org/373007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26835
Review URL: http://codereview.chromium.org/372003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TreeAdapter.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/374007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wrench menu item is right above "Preferences...". Chrome menu item will be added in a future CL right above "Clear Browsing Data...". Sync menu items are hidden if bookmark sync is disabled (the current default for OS X). UI decisions were made after consulting with Cole.
Added code in browser_window_controller.mm to update sync menu item dynamically.
Added unit tests.
BUG=23073
TEST=manual testing, trybots, unittests
Review URL: http://codereview.chromium.org/363017
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/374017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The ctrl-key behavior matches what Safari does: We first send a keydown for ctrl-key, and only if the key is not an emacs shortcut, we send a keypress.
The cmd-key behavior is slightly different from Safari: Safari triggers menu items after the keypress command has not been swallowed by javascript. We trigger menu items after keydown. That means that if the user hits cmd-key, we send a keydown and only send a keypress if the shortcut doesn't trigger a menu item. Safari always sends both keydown and keypress.
BUG=25249
TEST=Go to http://unixpapa.com/js/testkey.html . Hit ctrl-a, only a keydown should be generated. Hit ctrl-s, both keydown and keypress should be generated. Hit cmd-a, only a keydown should be generated. Hit cmd-shift-a, both keypress and keydown should be generated. Also, ctrl-1 now makes something a heading in google docs. Cmd-s and Cmd-f should still work in docs.
Review URL: http://codereview.chromium.org/293019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
development' andshould not DCHECK when uninstalling a disabledextension.I also reordered the links on the page, now thatwe show the Reload link conditionally, sinceit is weird to enable extensions after this change.The order starts out as...Disable - Reload - Uninstall... then when you press Disable it becomes: Enable - Uninstallpress Enable, it becomes:Disable - Reload - UninstallNotice how the Reload link pops up where Enable linkwas and where you'd expect Disable to be?TEST=Open chrome://extensions and make sure extensionsloaded with --load-extension have the Reload optionand when you disable an extension it does not DCHECKin debug version of Chrome.BUG=http://crbug.com/26901, http://crbug.com/26910
Review URL: http://codereview.chromium.org/374014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Wrench menu item is right above "Preferences...". Chrome menu item will be added in a future CL right above "Clear Browsing Data...". Sync menu items are hidden if bookmark sync is disabled (the current default for OS X). UI decisions were made after consulting with Cole.
Added code in browser_window_controller.mm to update sync menu item dynamically.
Added unit tests.
BUG=23073
TEST=manual testing, trybots, unittests
Review URL: http://codereview.chromium.org/363017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We should show the "blank page" favicon for pages which don't have their own (this favicon is used everywhere else for this purpose), not the "globe" (nav.pdf) favicon.
BUG=26953
TEST=Go to, e.g., "about:blank" and check the favicon in the tab in the tab strip.
Review URL: http://codereview.chromium.org/373012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out that the v10 -> v11 database migration code had a bug
where the destination file (SyncData.sqlite3) wasn't copied into the
correct directory. I fixed that problem too.
BUG=21834
Review URL: http://codereview.chromium.org/366011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=24672
TEST=None
Original patch by Thiago Farina <thiago.farina@gmail.com> at
http://codereview.chromium.org/296004
Review URL: http://codereview.chromium.org/373013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Without this call, the RWH didn't actually change size and was
always 0x0.
BUG=26927
Review URL: http://codereview.chromium.org/376011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
indicates the node is null, which should only happen if adding the
bookmark failed. Adding a bookmark can fail if the url isn't valid.
BUG=26858
TEST=make sure star button still works
Review URL: http://codereview.chromium.org/371011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=4360
Review URL: http://codereview.chromium.org/366032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't revert the autocomplete. The current approach of sprinkling
Revert throughout the code is easy to forget. I've put the code in
Browser so that everyone should pick it up.
If you're ok with this, I'll see if there are some calls to Revert I
can remove.
BUG=25842
TEST=add the home button to the toolbar, navigate to a page other than
the home page, type some text in the omnibox, click the home button,
make sure the text in the omnibox changes to show the url of the home
page.
Review URL: http://codereview.chromium.org/361008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
opens in foreground to allow changes to the path of the url to open in
current tab.
BUG=26490
TEST=none
Review URL: http://codereview.chromium.org/372001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=26948
Review URL: http://codereview.chromium.org/371024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Somehow pending_render_view_host_ in RenderViewHostManager is deleted
without being NULLed, which I still don't know why.
Hoefully the NOTREADED() in there will be hit by somehow and help shed
some light on the conditions.
BUG=23411
TEST=Make sure navigating across sites and closing tabs and browsers while
navigating works as expected.
Review URL: http://codereview.chromium.org/378001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/372022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
process commands. This fixes the problem where the auto-reconnect posts a
login command just after the client connects, just before a listen for updates
command is posted.
BUG=24245
TEST=Send a CMD_LISTEN_FOR_UPDATES immediately after the CMD_LOGIN in
MediatorThreadImpl::Login() Chromium will no longer crash.
Review URL: http://codereview.chromium.org/372011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/372005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the process/route which generated it. It might not be the same tab that's showing the infobar, particularly if it comes from an extension.
BUG=26859
TEST=request notifications permission from an extension and allow it.
Review URL: http://codereview.chromium.org/378005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
expands and contracts when its title changes.
BUG= none
TEST= Open report bug dialog; choose "Send phishing report" and note that cancel button moves as send button expands.
Review URL: http://codereview.chromium.org/372021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
performed, caused by some strange context menu interactions. This doesn't fix why we're in this situation, only a band-aid for any problems it could cause.
BUG=25682
TEST=clicking tabs, dragging tabs, closing tabs, anything with tabs, and the case covered in the bug to ensure there are no crashes.
Review URL: http://codereview.chromium.org/355027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
you'd dragged a tab out, then back in, then out again.
BUG=21580
TEST=tab dragging
Review URL: http://codereview.chromium.org/373011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Small shuffle to the basics page to make things look a little better
- Support for the three areas that get really wide in the prefs ui forcing the window wider, this will make sure nothing is clipped in any language.
BUG=26586
TEST=try french, german, etc. to make sure no buttons extend off the side of the prefs window.
Review URL: http://codereview.chromium.org/378012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
selection on a find next.
BUG=20883
TEST=included
Review URL: http://codereview.chromium.org/335012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG= 26855
TEST= See bug report for repro steps.
Review URL: http://codereview.chromium.org/371012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=apavlov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/377005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also explicitly hold a reference to the URLRequestContextGetter as long as the task is outstanding on the IO thread.
BUG=26893
Review URL: http://codereview.chromium.org/371016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The bustage seems to be a WebKit change upstream. It is not reverted in
WebKit and merger. So bring the innocent change back in.
TBR=jam
TEST=green tree
Review URL: http://codereview.chromium.org/375009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/373009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
SafeBrowsing code.
BUG=26012
TEST=None
Review URL: http://codereview.chromium.org/360059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
host browser for
ChromeFrame's host network stack implementation can register itself as a protocol factory for http/https
instead of using the mechanism to intercept HTTP requests which Gears and the App cache use. This ensures
that Gears works partially with ChromeFrame.
The protocol factory mechanism also has the same limitation as the intercept mechanism, i.e. it does not
support chaining.
Partial fix for http://code.google.com/p/chromium/issues/detail?id=23992
Bug=23992
Review URL: http://codereview.chromium.org/365009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that we can add in Database, LocalStorage, and Appcache next
to the cookies for an origin.
BUG=26713
TEST=cookies_tree_model_unittest.cc
Review URL: http://codereview.chromium.org/365005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jam
Review URL: http://codereview.chromium.org/375007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31206 0039d316-1c4b-4281-b951-d872f2087c98
|