| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Depends on http://codereview.chromium.org/8247009/
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8362006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=100874
TEST=Manual. Launched login screen on Aura.
Review URL: http://codereview.chromium.org/8402026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Component extensions and policy-installed extensions shouldn't be affected by the policy blacklist: The former are considered internal UI that happens to be part of an extension, and they should have first-class policy knobs if we want to disable them. For the latter, the admin specifying them is enough indication that they should be installed, and requiring them to explicitly white-listed in some cases is redundant.
BUG=chromium-os:16702, chromium-os:21281
TEST=On ChromeOS, configure ExtensionInstallBlacklist = * and load chrome://bookmarks
Review URL: http://codereview.chromium.org/8380006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Profile::GetDefaultRequestContext.
BUG=89396
TEST=The translate features work as usual
Review URL: http://codereview.chromium.org/8365033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Moving cookie-spesific logic from HostContentSettingsMap to CookieSettings.
Making it explicit that the "is cookie session only" decision only depends on the
primary url.
Also removes the migration code for the obsolete kCookieBehavior preference.
BUG=93335
TEST=CookieSettings.*
Review URL: http://codereview.chromium.org/8383004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
state changes
R=dmazzoni@chromium.org
BUG=chromium-os:21760
TEST=Change the network state with a11y turned on
Review URL: http://codereview.chromium.org/8402023
TBR=zork@chromium.org
Review URL: http://codereview.chromium.org/8400057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change adds a SpellCheckSubMenuObserver class and move code of the "spell-checker options" submenu there.
BUG=93746
TEST=none
Review URL: http://codereview.chromium.org/8363042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- Whether notifications setup is done once already.
- Whether the user has disabled notifications.
Review URL: http://codereview.chromium.org/8399022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=dmazzoni@chromium.org
BUG=chromium-os:21760
TEST=Change the network state with a11y turned on
Review URL: http://codereview.chromium.org/8402023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Propagate that flag up a few levels and add CHECKs. Since the old code
crashed, CHECKing is no worse.
Rename some functions to add *ForTest suffixes.
BUG=100907
TEST=
Review URL: http://codereview.chromium.org/8402014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:20044
TEST=Add two or more users. Check that you can tab to all users and remove buttons, and that you can remove users.
Review URL: http://codereview.chromium.org/8396032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=penghuang@chromium.org
BUG=chromium-os:22107
TEST=Install two IME extensions, and ensure that they both work.
Review URL: http://codereview.chromium.org/8393038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107682 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove some obsolete code and simplify some of the code's expectations.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8351027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderViewHost instance created when a desktop notification bubble is displayed in CF
with the AutomationResourceMessagefilter. This ensures that any HTTP requests issued by this bubble go through
the host network stack implemenation.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=64251
BUG=64251
Review URL: http://codereview.chromium.org/8414005
TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/8416031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=102030
Review URL: http://codereview.chromium.org/8400052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107677 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This hooks up the DownloadProtectionService to run after a download finishes. For now, this does not send a download pingback since the flag defaults to off.
TEST=DownloadProtectionServiceTest
BUG=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107528
Review URL: http://codereview.chromium.org/8345033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107674 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bubble is displayed in CF
with the AutomationResourceMessagefilter. This ensures that any HTTP requests issued by this bubble go through
the host network stack implemenation.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=64251
BUG=64251
Review URL: http://codereview.chromium.org/8414005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=101963
TEST=Running unit_tests --gtest_filter=AppNotificationManagerSyncTest.* should
not leave around any empty temp directories (and there should be no error log
messages from ScopedTempDir's desctructor about being unable to delete the
underlying temp dir).
Review URL: http://codereview.chromium.org/8415004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shortcuts.
When a balloon popup is open, the target of the close window/tab keyboard shortcut is still the main browser window. Update our custom menu item rejiggering code to pay attention to the main window, rather than to the popup window, when a popup is open.
BUG=95169
TEST=(see bug)
Review URL: http://codereview.chromium.org/8302021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
-rename URLFetcherFactory to URLFetcherImplFactory
-rename GetUrl to GetURL and GetOriginalUrl to GetOriginalURL
-get rid of request_type in TestURLFetcher's constructor
BUG=98716
Review URL: http://codereview.chromium.org/8416020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Most consumers on all platforms (including windows!) were converting the font family/GetFontName() result to UTF8. (Windows was still having to convert for the SkTypeface calls.) On Linux, we're performing a UTF16ToUTF8 on each string print (and this is showing up in pprof output.)
BUG=100803
TEST=none
Review URL: http://codereview.chromium.org/8392017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This happens when the HistoryService starts closing the backend, and the
ExpireHistoryBackend then tries to notify HistoryBackend of a deletion.
BUG=101999
TEST=none
R=brettw@chromium.org
Review URL: http://codereview.chromium.org/8341087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:21732
TEST=manual
Review URL: http://codereview.chromium.org/8341046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's valid to call SetEncryptEverything after turning on encryption as long
as you're not trying to turn it off.
BUG=none
TEST=set a custom passphrase after turning on encryption
Review URL: http://codereview.chromium.org/8416008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100347
TEST=NONE
Review URL: http://codereview.chromium.org/8416009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100348
TEST=NONE
Review URL: http://codereview.chromium.org/8343034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
initializers) - Fix test snapshotting on linux by creating a separate automation path for
snapshots outside of the thumbnail generator.
BUG=69370,66371,63022
TEST=none
Review URL: http://codereview.chromium.org/8294030
TBR=kkania@chromium.org
Review URL: http://codereview.chromium.org/8416022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
snapshots outside of the thumbnail generator.
BUG=69370,66371,63022
TEST=none
Review URL: http://codereview.chromium.org/8294030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the StatusTray is not deleted before the BackgroundModeManager. Technically this should not be an issue, but it can occur if the NOTIFICATION_APP_TERMINATING notification is not sent.
BUG=101082
TEST=passes existing, but there are no repro steps for the crash to test
Review URL: http://codereview.chromium.org/8393028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:22140
TEST=Visit system settings page, click "Find devices" button, observe UI and read chrome logs.
Change-Id: Idb0aa1650663f9c95d4c44194d6fa3b7e660d668
Review URL: http://codereview.chromium.org/8233042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=101994
TEST=none
R=sky@chromium.org
Review URL: http://codereview.chromium.org/8418010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is just a temporary workaround for dogfood.
BUG=97831
TEST=test app on crbug.com/101413
Review URL: http://codereview.chromium.org/8393014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=98347
TEST=none
Review URL: http://codereview.chromium.org/8400032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=86536
TEST=None
Review URL: http://codereview.chromium.org/8395053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
on the Vista Debug bot.
BUG=101984
Review URL: http://codereview.chromium.org/8400042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
chrome/common/cloud_print. They don't belong in content.
TBR=abodenha
Review URL: http://codereview.chromium.org/8341079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was just an oversight. Along the way, update comments in
dbus_thread_manager.h about callbacks.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/8341073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=101390
TEST=ui tests continue to pass.
Review URL: http://codereview.chromium.org/8390041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=101938
TEST=none
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/8417004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, rename the class to SensorsClient, to be consistent with
other classes in the directory, and do some minor cleanup.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8400034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=ben
BUG=run out of VRAM
TEST=open and close many tabs on touch device; VRAM should remain roughly constant
Review URL: http://codereview.chromium.org/8411002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
page 5 times before it eventually gives up and shows service unavailable error.
Expanded frame sniffer to send an event when a frame which is being watched gets finally loaded. From the sent error (or its absence) and this new event, we can finally reconstruct on the browser side if a given iframe was loaded successfully or not.
BUG=chromium-os:20525, chromium-os:21738
TEST=tricky one to test since it repros on 3g network flakyness. one can edit /usr/lib/cromo/config/madison.ini and put a bad value for olp_root there to trigger this.
Review URL: http://codereview.chromium.org/8341037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Look at about:flags and see 'Disable Panels'. Should be off by default.
Review URL: http://codereview.chromium.org/8416003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a cached page.
The problem is that the same ResourceLoadTiming struct is re-used for each
redirect. So, we record the deltas for connect time, headers, send request, etc.,
for each redirect. But, after the last redirect, we simply have a cache hit. So,
the base_time is updated for that cache hit, but the deltas are still relative
to the old base_time value. When we apply the old deltas to the new base_time,
we end up with a time in the future.
To fix this, I clear ResourceLoadTimingInfo after each redirect.
I've added a UI test for this. I could've done a unit test, but we have no end-
to-end Navigation Timing tests and it'd be easy for this to be broken by some
unrelated change to NetLog and redirects, so I prefer having this test be a
safe guard.
On a related note, I noticed that LoadTimingObserver::OnAddURLRequestEntry() is
called at least twice for each source.id. Once for the normal URLRequest, and
once for the AppCacheURLRequest. Fortunately, they're only 100 ns apart, so it
doesn't screw up the times. But, it was a surprise to me. Perhaps we should
ignore the AppCache requests?
BUG=None
TEST=ui_tests
Review URL: http://codereview.chromium.org/8336012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commented out a line that reliably fails the tests, although the real
cause seems to be chromium:101665.
BUG=
TEST=
Review URL: http://codereview.chromium.org/8363054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=97248
TEST=manually
Review URL: http://codereview.chromium.org/8402031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=101593
TEST=instant_browsertest
Review URL: http://codereview.chromium.org/8373010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107585 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=ivankr@chromium.org
BUG=chromium-os:22125
TEST=Verify that for users with default profile picture it's not downloaded and shown on image screen or change picture page.
Review URL: http://codereview.chromium.org/8399005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107584 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=88316
TEST=AppApiTest.{AppProcess,AppProcessInstances} not flaky
Review URL: http://codereview.chromium.org/8401023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes BrowserNonClientFrameViewAura act as if it has a
zero-height top resize border to avoid weird resizing when
dragging that region up or down. In the longer term, this
change should be reverted and the Aura shell should instead
be responsible for disabling resizes (and preventing the
cursor from changing as well, I suppose).
BUG=101830
TEST=manual: checked that dragging the top of the frame only moves the window instead of resizing it
Review URL: http://codereview.chromium.org/8400011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107579 0039d316-1c4b-4281-b951-d872f2087c98
|