summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Don't leak the RenderProcessHost when running site instance unit tests bybrettw@chromium.org2009-04-221-0/+4
| | | | | | | | | flusing the message queue (containing the delete message). BUG=10782 Review URL: http://codereview.chromium.org/92023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14208 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: move X operations from the IO to UI2 thread.agl@chromium.org2009-04-2210-59/+208
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | (r14075 take two) Currently we perform several X operations on the IO thread including geometry and clipboard work. This is causing races inside Xlib and crashing the browser. These are the result of synchronous calls from the renderer, so we cannot route these requests to the UI thread without risking deadlock. Thus we introduce the UI2 thread. This thread has a second connection to the X server and can perform X operations safely the without UI thread. Work remains to be done: Since we still have the hack where we pass GtkWidget pointers into the renderer and back, we still have to access these structures from the IO and UI2 threads. This still needs to be fixed, but this is not the patch for it. Also, not all the X calls from the IO thread have been moved over in this patch; just a few small ones. http://codereview.chromium.org/67145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14206 0039d316-1c4b-4281-b951-d872f2087c98
* Add Australian English spell check support.sidchat@google.com2009-04-221-1/+4
| | | | | | | Issue=8934 Review URL: http://codereview.chromium.org/89006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14204 0039d316-1c4b-4281-b951-d872f2087c98
* Properly construct shell filters (forgetting the asterisk means it works but ↵avi@chromium.org2009-04-221-1/+1
| | | | | | | | | | doesn't show existing files). BUG=10734 Review URL: http://codereview.chromium.org/93019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14202 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/87034apavlov@chromium.org2009-04-2212-79/+89
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14187 0039d316-1c4b-4281-b951-d872f2087c98
* An experimental fix for Issue 9718.hbono@chromium.org2009-04-221-17/+64
| | | | | | | | | This change enables the keyboard shortcuts "control + right-shift" and "control + left-shift" only on a PC having RTL languages (i.e. Arabic or Hebrew) installed. BUG=9718 "Regression: Only use RCtrl + RShift to change directionality if RTL input languages are installed" Review URL: http://codereview.chromium.org/67296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14179 0039d316-1c4b-4281-b951-d872f2087c98
* Enable BookmarkContextMenuTest under Linux.erg@google.com2009-04-221-2/+9
| | | | | | Review URL: http://codereview.chromium.org/89011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14163 0039d316-1c4b-4281-b951-d872f2087c98
* Provide an override for Webview drop effect.tc@google.com2009-04-221-6/+0
| | | | | | | | | | | | | | | | | | | | | Used for gears file drag & drop in chrome, provide a setter api to override the default webview drop effect. If gears overrides the drop_effect, then either a "copy" or "none" cursor is shown to the user. Otherwise, the drop effect shown is the default for the webview (controlled by WebKit). Also remove a TODO: during drag and drop, remember the drop accept state of the webview (in drag enter, drag over). Use that to prevent drops on webviews that can't accept the drop data. BUG=7995 Original patch from Noel Gordon via http://codereview.chromium.org/67297 Review URL: http://codereview.chromium.org/88073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14162 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r14146 which refactors DialogButton into cross platformtc@google.com2009-04-2157-185/+191
| | | | | | | | | | code. This is the same as the last change except I renamed class MessageBox to class MessageBoxFlags to avoid conflicting with the same name in windows.h. Review URL: http://codereview.chromium.org/87065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14159 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes xji@chromium.org2009-04-211-13/+36
| | | | | | | | | | | | | | | | | issue 6125 - [edit search engines] after hitting right ctrl+shift, can't change insertion point with the mouse and issue 8686 - RTL: Can't select RTL text from Chrome UI boxes The problem is cursor positioning and cursor selection in CRichEditCtrl in RTL layout. (cursor positioning is fine even for RTL characters in LTR layout, but cursor positioning is not working even for LTR characters in RTL layout). The fix is correctly calculation of input boundary in ClipXCoordToVisibleText(), and the fix is mostly part of Nick Carter's un-committed fix in https://svn.corp.google.com/review/chrome/desc/cb/ncarter/rtl_richedit_fixes@50605 BUG=6125 BUG=8686 Review URL: http://codereview.chromium.org/86003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14158 0039d316-1c4b-4281-b951-d872f2087c98
* Better omnibox handling of numeric input. Now we search based on the user's ↵pkasting@chromium.org2009-04-213-11/+46
| | | | | | | | | | original input instead of a transformed dotted quad when typing numeric hostnames; this should help noticeably in countries like China where such hostnames ("56.com") are popular. Original patch by Fumitoshi Ukai (see http://codereview.chromium.org/88011 ), r=me. BUG=10054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14156 0039d316-1c4b-4281-b951-d872f2087c98
* Merge BookmarkContextMenuGtk back into BookmarkContextMenu.erg@google.com2009-04-219-544/+178
| | | | | | Review URL: http://codereview.chromium.org/87038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14155 0039d316-1c4b-4281-b951-d872f2087c98
* Reland this change from yesterday. Gets basic text in omnibox2 popup ↵ben@chromium.org2009-04-212-40/+53
| | | | | | working. Ugly. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14149 0039d316-1c4b-4281-b951-d872f2087c98
* posix: URLFixerUpper would DCHECK on input "/".evan@chromium.org2009-04-212-6/+17
| | | | | | | | Also, add some more tests to cover this case. Review URL: http://codereview.chromium.org/87048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14148 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor DialogDelegate so the DialogButton enum is in cross platform"tc@google.com2009-04-2153-147/+163
| | | | | | | | | | | | This reverts commit r14146. MessageBox is redefined to MessageBoxW by windows. I need to rename the class. Review URL: http://codereview.chromium.org/87064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14147 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor DialogDelegate so the DialogButton enum is in cross platformtc@google.com2009-04-2153-163/+147
| | | | | | | | | | | | | | | | | code. This is mostly a find & replace in our code to use the new location of the enum. I also deleted some GetDialogButtons methods in child classes because they were identical to the parent version in DialogDelegate. This will allow more code to be enabled on linux/mac in the automation provider. Review URL: http://codereview.chromium.org/88008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14146 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it possible to mock URLFetcher.sky@chromium.org2009-04-214-4/+157
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/87035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14141 0039d316-1c4b-4281-b951-d872f2087c98
* Fix hang seen in plugin process because plugin creation ended up having to ↵jam@chromium.org2009-04-214-97/+104
| | | | | | | | | | wait on UI thread. Instead of using sync messages, the plugin hwnd is initially parented to the RenderWidgetHost's HWND. It's then lazily reparented to an intermediate HWND on the UI thread when it comes time to move it. BUG=10711 TEST=added regression tests, but testers please confirm plugins on top video sites are placed correctly. Review URL: http://codereview.chromium.org/67285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14137 0039d316-1c4b-4281-b951-d872f2087c98
* Implement (kinda) ProcessSingleton for the Mac.avi@google.com2009-04-212-4/+38
| | | | | | Review URL: http://codereview.chromium.org/88031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14136 0039d316-1c4b-4281-b951-d872f2087c98
* Handle file drops and URL open requests. Along with declaring that we handle ↵avi@google.com2009-04-212-9/+69
| | | | | | | | the http scheme, this allows Chromium to be set as a default browser for the Mac. Review URL: http://codereview.chromium.org/87043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14134 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak accelerators, and add ctrl+_ for zoom out.estade@chromium.org2009-04-211-1/+5
| | | | | | Review URL: http://codereview.chromium.org/87041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14133 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Properly escape download item label markup.estade@chromium.org2009-04-211-9/+10
| | | | | | | | BUG=10766 Review URL: http://codereview.chromium.org/88055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in the download shelf.estade@chromium.org2009-04-211-2/+5
| | | | | | | | | | Windows doesn't explicitly delete the DownloadItemView objects because the View destructor deletes child views automatically. BUG=10739 Review URL: http://codereview.chromium.org/88044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14131 0039d316-1c4b-4281-b951-d872f2087c98
* Fix #include (.h, not .cc).sgk@google.com2009-04-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/88050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14127 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up alt-d on linux.estade@chromium.org2009-04-211-2/+2
| | | | | | | | | | Also clean up some accelerators. BUG=10803 Review URL: http://codereview.chromium.org/90008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14123 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 2674 - search engine name containing parenthesis is not ↵xji@chromium.org2009-04-215-10/+16
| | | | | | | | | | | | | | displayed correctly in Omnibox NavSuggest drop-down list. The fix is to adjust the search engine name according to locale direction so that the search engine name containing parenthesis are marked with RLE-PDF to be displayed correctly in RTL UI. BUG=2674 Review URL: http://codereview.chromium.org/79005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14119 0039d316-1c4b-4281-b951-d872f2087c98
* I missed this file in my last checkinestade@chromium.org2009-04-211-4/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14118 0039d316-1c4b-4281-b951-d872f2087c98
* Add open/close animations to infobar, download shelf.estade@chromium.org2009-04-216-48/+214
| | | | | | | | Animations are implemented by packing the native widget structure into a GtkFixed which resizes and moves its contents around based on AnimationDelegate callbacks. Review URL: http://codereview.chromium.org/88005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14116 0039d316-1c4b-4281-b951-d872f2087c98
* Handle a race between the remove tab animation resizing the closing tab and ↵jhawkins@chromium.org2009-04-211-1/+11
| | | | | | | | | the gtk mouse events. Fixes a crash where the hover index would become stale before a leave-notify event. BUG=10776 Review URL: http://codereview.chromium.org/88037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14115 0039d316-1c4b-4281-b951-d872f2087c98
* Unit test for sad tab view.pinkerton@chromium.org2009-04-211-0/+39
| | | | | | Review URL: http://codereview.chromium.org/87028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14099 0039d316-1c4b-4281-b951-d872f2087c98
* Unit tests for button cells we use in the UI.pinkerton@chromium.org2009-04-212-0/+83
| | | | | | Review URL: http://codereview.chromium.org/87023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14098 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak introduced in http://codereview.chromium.org/62061dkegel@google.com2009-04-211-2/+2
| | | | | | | | | | | | | | Fixes valgrind warning 09:57:13 valgrind_analyze.py [ERROR] Leak_DefinitelyLost 1 bytes in 1 blocks are definitely lost in loss record 2 of 260 operator new(unsigned int) (vg_replace_malloc.c:195) FileVersionInfo::CreateFileVersionInfoForCurrentModule() (base/file_version_info_linux.cc:21) AutomationProvider::ConnectToChannel(std::basic_string<wchar_t, std::char_traits<wchar_t>, std::allocator<wchar_t> > const&) (chrome/browser/automation/automation_provider.cc:811) Review URL: http://codereview.chromium.org/79087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14097 0039d316-1c4b-4281-b951-d872f2087c98
* Review URL: http://codereview.chromium.org/77006apavlov@chromium.org2009-04-217-41/+51
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14096 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bunch of basic unit tests for view classes.pinkerton@chromium.org2009-04-215-0/+200
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14095 0039d316-1c4b-4281-b951-d872f2087c98
* Rework the RWHV so that when it gets a paint message from the renderer it ↵avi@google.com2009-04-212-45/+57
| | | | | | | | immediately paints. Also, implement the fix for updates done for the other platforms in http://codereview.chromium.org/66013 . Review URL: http://codereview.chromium.org/89001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14093 0039d316-1c4b-4281-b951-d872f2087c98
* More solid detection of browser process in chrome_process_util_linux.cc:phajdan.jr@chromium.org2009-04-211-1/+2
| | | | | | | | | | | | | | | | - use GetAppOutput instead of popen - make unexpected conditions fatal (otherwise the tests using this code would mistakenly assume that there is no running browser process) Also add a constant for SingletonSocket. Make necessary adjustments to GetAppOutput - ignore stderr (because fuser prints the file name to stderr and having stderr in |output| would require more parsing). Review URL: http://codereview.chromium.org/77031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14091 0039d316-1c4b-4281-b951-d872f2087c98
* Rename web_contents_view to tab_contents_view to fix the mac build.brettw@chromium.org2009-04-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/88019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14086 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak of the NavigationController during many tests. A duplicatebrettw@chromium.org2009-04-214-22/+14
| | | | | | | | | | NavigationController was begin created from when we had to create this separately. BUG=10781 Review URL: http://codereview.chromium.org/88018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14084 0039d316-1c4b-4281-b951-d872f2087c98
* Rename web_contents_view* files to tab_contents_view* to reflect my previousbrettw@chromium.org2009-04-2123-55/+48
| | | | | | | rename of the classes. Review URL: http://codereview.chromium.org/87009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14083 0039d316-1c4b-4281-b951-d872f2087c98
* I managed to break test_shell. Reverting. I'll fix tomorrow.agl@chromium.org2009-04-2110-208/+59
| | | | | | | Reverts r14075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14080 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: move X operations from the IO to UI2 thread.agl@chromium.org2009-04-2110-59/+208
| | | | | | | | | | | | | | | | | | | | | | | | | | | Currently we perform several X operations on the IO thread including geometry and clipboard work. This is causing races inside Xlib and crashing the browser. These are the result of synchronous calls from the renderer, so we cannot route these requests to the UI thread without risking deadlock. Thus we introduce the UI2 thread. This thread has a second connection to the X server and can perform X operations safely the without UI thread. Work remains to be done: Since we still have the hack where we pass GtkWidget pointers into the renderer and back, we still have to access these structures from the IO and UI2 threads. This still needs to be fixed, but this is not the patch for it. Also, not all the X calls from the IO thread have been moved over in this patch; just a few small ones. http://codereview.chromium.org/67145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14075 0039d316-1c4b-4281-b951-d872f2087c98
* Disable check for active window when it doesn't look like Chromium is the frontpam@chromium.org2009-04-201-4/+21
| | | | | | | | | | | | | | app. This should fix the buildbots but still allow a manual test. TBR=erikkay BUG=5278 TEST=run ui_tests with another app at the front. Make sure TabRestoreUITest.* pass with no "is_active" failures. Review URL: http://codereview.chromium.org/88012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14068 0039d316-1c4b-4281-b951-d872f2087c98
* Roll back this change until I can understand why it's having adverse effects.ben@chromium.org2009-04-202-53/+40
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14067 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure to free any remaining tabs on tabstrip destruction. There are two ↵jhawkins@chromium.org2009-04-201-0/+10
| | | | | | | | cases where the remove tab animation is not used when closing tabs, and we were leaking these tabs in those cases. Review URL: http://codereview.chromium.org/87004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14066 0039d316-1c4b-4281-b951-d872f2087c98
* posix: port PrependCommand to Windows and use for the plugin launcher.evan@chromium.org2009-04-201-5/+2
| | | | | | Review URL: http://codereview.chromium.org/88006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14065 0039d316-1c4b-4281-b951-d872f2087c98
* Rename WebContentsView* to TabContentsView* in preparation for mergingbrettw@chromium.org2009-04-2020-191/+187
| | | | | | | | | | TabContents and WebContents. This also removes the Destroy method from the print manager's header file. I removed the impl in a previous change but forgot the header. Review URL: http://codereview.chromium.org/90004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14063 0039d316-1c4b-4281-b951-d872f2087c98
* When restoring a closed tab using either ctrl-shift-T or the context menu, putpam@chromium.org2009-04-208-5/+187
| | | | | | | | | | | | | | | | | | | it back into the window it came from, at the tabstrip index it occupied before, and activate (select) both the window and the tab. Restoring a tab from the New Tab Page replaces the NTP, as before. If the window the tab was in no longer exists, put the tab at the end of the current window's tabstrip. This behavior may change in a later patch. BUG=5278 TEST=Open two windows, with >1 tabs each. Close a tab, not the one at the end, in one of the windows. Switch to the other window and choose "Undo Closed Tab" from the tabstrip context menu, or type ctrl-shift-T. The tab should be restored where it was, and activated (selected and brought to the front). Review URL: http://codereview.chromium.org/69015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14062 0039d316-1c4b-4281-b951-d872f2087c98
* First round of getting text into the omnibox2 popup. Looks ugly and has no ↵ben@chromium.org2009-04-202-40/+53
| | | | | | | | bolding. Review URL: http://codereview.chromium.org/89005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14060 0039d316-1c4b-4281-b951-d872f2087c98
* Only create a What You Typed match when it's likely to be relevant. See bug ↵pkasting@chromium.org2009-04-203-102/+121
| | | | | | | | for detailed algorithm.I elected to go the simple route of just not constructing a match for non-inline-autocompleting "UNKNOWN" inputs. The win from the "force this to appear" proposal just doesn't seem to justify the code complexity and lost popup slot.BUG=4037 Review URL: http://codereview.chromium.org/79062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14054 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land my change to clean up TabContents/WebContents ownership. Thisbrettw@chromium.org2009-04-2071-1340/+1001
| | | | | | | | | | | | | | | | | | | | | | | | is the same except in tab_strip_model_unittest I fixed a leak by making a WebContents on the stack, I added a factory to the SiteInstance unittest to prevent another leak, and I re-added a NULL set to the external_tab_container. Fix the ownership model of TabContents and NavigationController. Previously the NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Previous review URL: http://codereview.chromium.org/69043 Review URL: http://codereview.chromium.org/67294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14053 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 19:34:48 +0000