summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Asynchronous threaded volume get/set/initscherkus@chromium.org2010-07-075-224/+248
| | | | | | | | | | | | | | | | | | | | Non-blocking version of init is now being called, and asynchronous set/get of mute and volume is implmenented at PulseAudioMixer level. The logic has been updated in SystemKeyEventListener so that the audio key behavior follows the latest doc 'Chrome OS Audio Scenarios': Increase volume key: unmutes aduio if muted, otherwise increases volume. Decrease volume key: do nothing if muted, otherwise decrease volume. Mute volume key: always mutes volume. UI is displayed after any volume key press. Currently only the init is being called asynchronously, but the next step will be to add a call allowing asynchronous operation of the volume adjust/unmute sequence from SystemKeyEventListener, and move the ShowVolumeBubble() calls into AudioHandler so that the volume bubble will update once the calls complete on their own thread. Patch by davej@chromium.org: http://codereview.chromium.org/2769008/show BUG=2910 Test=Play video or audio in ChromeOS, and press the system volume up, down, and mute keys to see they follow the above behavior. Alternating Mute and Increment Volume presses should always bring the volume back to the same level and not creep it upwards. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51786 0039d316-1c4b-4281-b951-d872f2087c98
* Fix valgrind / heapcheck error in 51743hclam@chromium.org2010-07-071-10/+4
| | | | | | | | | | | | Handles to the sync socket should be released. The leak of 4 bytes apprantly is the leaked SyncSocket object. BUG=51743 TBR=cbentzel Review URL: http://codereview.chromium.org/2818047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51784 0039d316-1c4b-4281-b951-d872f2087c98
* First semi-successful attempt at mac accessibility.feldstein@chromium.org2010-07-076-5/+591
| | | | | | | | | | | Right now the accessibility tree is shipped over at page load, so this doesn't account for any changes to the html, or scrolling/resizing. BUG=27112 TEST=Use accessibility inspector to inspect various elements of the webpage. Review URL: http://codereview.chromium.org/2642001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51782 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmarks: Fix position of context menu when opened using the keyboard.arv@chromium.org2010-07-071-3/+24
| | | | | | | | | | | After fixing the contextmenu event in WebKit we can no longer rely on the bug/hack/feature that screenX was 0 when the event was generated using the keyboard. We now keep track of keydown and keyup and if the right key was down then we know it was a context menu generated by the keyboard. BUG= 40073 TEST=Select an bookmark item (or a folder in the bookmark tree). Press Shift+F10. The context menu should be positioned relative to the selected item. Review URL: http://codereview.chromium.org/2845042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51779 0039d316-1c4b-4281-b951-d872f2087c98
* Removed extra/unused </style> tag.csilv@chromium.org2010-07-071-1/+0
| | | | | | | | BUG=none TEST=Verify chrome:options loads when using --enable-tabbed-options. Review URL: http://codereview.chromium.org/2888007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51778 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bugs in wrench menu when shown rtl:sky@chromium.org2010-07-071-3/+17
| | | | | | | | | | | | | . borders of buttons were drawn incorrectly. . I was repainting the correct bounds, resulting in mouse hover effects not showing up correctly. BUG=48012 TEST=see bug Review URL: http://codereview.chromium.org/2845040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51774 0039d316-1c4b-4281-b951-d872f2087c98
* Inform the SSLClientAuthHandler that a request was cancelleddavidben@chromium.org2010-07-071-0/+2
| | | | | | | | | | | | Otherwise it may access a freed URLRequest. R=agl BUG=48210 TEST=close tab while certificate selection dialog is open, then submit Review URL: http://codereview.chromium.org/2858047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51772 0039d316-1c4b-4281-b951-d872f2087c98
* - First round implementation of the Advanced (Under the Hood) options panel.csilv@chromium.org2010-07-0719-91/+767
| | | | | | | | | | | | | | | - All checkboxes are functional, partial functionality for buttons. - Download path controls TBD. - Security SSL checkboxes on non-Mac platform TBD. - Added placeholder files for Browser and Personal option panels. - Moved placeholder CSS into a new options_page.css file. - Unit testing TBD. BUG=48482 TEST=Launch browser with --enable-tabbed-options and bring up options window. Review URL: http://codereview.chromium.org/2830036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51770 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug in DeleteAllForURL; deletes entire store instead of justrdsmith@google.com2010-07-071-1/+1
| | | | | | | | | | | | | | | cookies related to URL (found by inspection.) Also changed name and semantics to more closely reflect usage of primary caller (extension data deleter), and added test for that set of semantics. BUG=none TEST=Linux CookieMonsterTest.*:ParsedCookieTest.* (especially new CookieMonsterTest.DeleteAllHost) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51544 Review URL: http://codereview.chromium.org/2857029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51766 0039d316-1c4b-4281-b951-d872f2087c98
* Start at cleaning up BrowserMain().viettrungluu@chromium.org2010-07-074-361/+524
| | | | | | | | | BUG=none (or is there?) TEST=trybots and tests Review URL: http://codereview.chromium.org/2234006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51763 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51748 - [Mac] Restore the individually selected tab from a window ↵rsesek@chromium.org2010-07-071-17/+5
| | | | | | | | | | | | | | when using the History menu, rather than always (mistakenly) restoring the first one. BUG=47779 TEST=Open a new window, navigate three tabs. Close the window. Select History-->3 Tabs and then choose the middle tab. It is restored properly. Review URL: http://codereview.chromium.org/2802029 TBR=rsesek@chromium.org Review URL: http://codereview.chromium.org/2806051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51759 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Restore the individually selected tab from a window when using the ↵rsesek@chromium.org2010-07-071-5/+17
| | | | | | | | | | | History menu, rather than always (mistakenly) restoring the first one. BUG=47779 TEST=Open a new window, navigate three tabs. Close the window. Select History-->3 Tabs and then choose the middle tab. It is restored properly. Review URL: http://codereview.chromium.org/2802029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51748 0039d316-1c4b-4281-b951-d872f2087c98
* [chromeos]Update the display name of UK keyboard layout.suzhe@chromium.org2010-07-071-1/+2
| | | | | | | | | BUG=http://crosbug.com/2951 TEST=The name of the UK keyboard layout should be "English (UK) keyboard layout" Review URL: http://codereview.chromium.org/2810049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51744 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite AudioRendererHost to use AudioControllerhclam@chromium.org2010-07-075-783/+906
| | | | | | | | | | | | | | | | | | | | | | | | This change will move all the audio device methods calls to AudioController so we can move all the audio related methods calls off the IO thread. This change will let AudioRendererHost to use the AudioController API. This involves rewriting the whole AudioRendererHost. After this patch we can implement proper pause operations that is only possible if they are hosted on a separated thread due to their blocking nature. Normal latency mode is fully covered by unit tests, including audio control operations and data conversation. Low latency mode using SyncSocket is tested only for stream creation and still need to handle cases during shutdown when we want SyncSocket to return immediately. TEST=unit_tests --gtest_filter=AudioRendererTest.* BUG=39885 Review URL: http://codereview.chromium.org/2850016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51743 0039d316-1c4b-4281-b951-d872f2087c98
* Log whenever the network IP address changes.eroman@chromium.org2010-07-074-16/+122
| | | | | | | | | This logs to both LOG(INFO), and also to the NetLog (about:net-internals). BUG=46822 Review URL: http://codereview.chromium.org/2815046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51740 0039d316-1c4b-4281-b951-d872f2087c98
* Put Chromoting plugin behind a flag.ajwong@chromium.org2010-07-072-2/+7
| | | | | | | | | BUG=48093 TEST=tested that plugin doesn't load w/o --enable-chromoting. Review URL: http://codereview.chromium.org/2818043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51738 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Initial implementation of app tabs. Loads the app and displays the ↵andybons@chromium.org2010-07-078-31/+83
| | | | | | | | | | | | | | | correct icon (http://cl.ly/97c1b5e22eb32075d497). Still to be done: o there should be a much smaller overlap of app tabs with other tabs. o The toolbar should hide when necessary. o The context menu for the tab should have the option of hiding/showing the toolbar on a per-app basis. TEST=none BUG=45539 Review URL: http://codereview.chromium.org/2847052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51737 0039d316-1c4b-4281-b951-d872f2087c98
* Autocomplete and AutoFill entries are shown combined in the suggestions popup.dhollowa@chromium.org2010-07-074-20/+114
| | | | | | | | | | | These changes merge popup menu suggestions for Autocomplete and AutoFill. Suggestions are collected from both sources and returned to the renderer as a single list. This combined list is given to WebKit to display in the suggestions popup. When the user selects an item in the popup the appropriate result gets filled in the fields. BUG=41328 TEST=AutoFillManagerTest.* Review URL: http://codereview.chromium.org/2878020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51736 0039d316-1c4b-4281-b951-d872f2087c98
* Adding labs to the chromeos options pagedhg@chromium.org2010-07-078-36/+109
| | | | | | Review URL: http://codereview.chromium.org/2800035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51733 0039d316-1c4b-4281-b951-d872f2087c98
* Replaced IsOnlyLeftMouseButton() with IsLeftMouseButton() in ↵stevenjb@chromium.org2010-07-071-1/+1
| | | | | | | | | | | | PanelController::TitleMousePressed. http://code.google.com/p/chromium-os/issues/detail?id=4255 BUG=chromium-os:4255 TEST=See Issue for repro Review URL: http://codereview.chromium.org/2834037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51732 0039d316-1c4b-4281-b951-d872f2087c98
* Add Iceweasel to the list of browsers shown in about:memory.evan@chromium.org2010-07-071-0/+3
| | | | | | | | BUG=44602 Based on a patch from Giuseppe Iuculano <giuseppe@iuculano.it>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51730 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ThumbnailStore - replaced by TopSites.nshkrob@chromium.org2010-07-078-946/+1
| | | | | | | | | BUG=none TEST=open New Tab page, see thumbnails. Same with chrome --top-sites. Review URL: http://codereview.chromium.org/2815045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51728 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sync startup ordering to make sense and be less broken (though not ↵tim@chromium.org2010-07-0717-272/+339
| | | | | | | | | | | | | | | | | | | | | | perfect yet). Trigger OnBackendInitialized when the syncable::Directory is opened, and cue the DataTypeManager when that happens. Fix a bug where entering the wrong password on re-login UI results in inability to log in to sync forever, as the UI gets stuck in the "Authenticating...' state. Overhaul the tests to 1) actually use the abstract superclass and not copy/paste the same code (and redefine the same variables, shadowing protected ones in the super!), 2) to not use two SyncBackendHost objects, which makes it really confusing to follow what's happening, 3) not rely on anonymous OnStateChanged() notifications to perform crucial init tasks (which was also really confusing and brittle) by either a) removing the need to listen altogether, or b) listen for specific notifications. 4) unify root node creation, and 5) kill verbose and self proclaimed "uninteresting" gmock output. BUG=47957 TEST=unit_tests (ProfileSync*) Review URL: http://codereview.chromium.org/2834032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51724 0039d316-1c4b-4281-b951-d872f2087c98
* Improves responsiveness when rapdily clicking to close tabs. If thesky@chromium.org2010-07-076-3/+45
| | | | | | | | | | | | | | tab is already closing it's possible for the tab to no longer contain the coordinates of the release event. I've changed it so that if the tab is closing and the tab doesn't contain the mouse on the release event we see if another tab does and if so close it. BUG=48209 TEST=none Review URL: http://codereview.chromium.org/2841038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51723 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes menus when shown by way of pressing alt-f. I need to turn onsky@chromium.org2010-07-071-2/+0
| | | | | | | | | | | | | | | | nested tasks as in some situations the menu may be shown when the message loop is processing a task. If the message loop is processing a taskand we don't set nested tasks allowed to true then none of the tasks scheduled by the menu (paints, delays...) are processed and the menu appears totally broken. BUG=48102 TEST=give focus to the page, press alt-f, press arrow keys and make sure the menu updates appropriately. Review URL: http://codereview.chromium.org/2836044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51719 0039d316-1c4b-4281-b951-d872f2087c98
* Bye bye tab close dot, we hardly knew you.sky@chromium.org2010-07-076-186/+28
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2813045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51718 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing chromeos build of the options. They were asserting becuase of a lack ↵dhg@chromium.org2010-07-072-16/+3
| | | | | | | | | | of a setting. BUG=none TEST=none. Review URL: http://codereview.chromium.org/2858048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51716 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug effectively disabling the default plugin.bauerb@chromium.org2010-07-071-2/+1
| | | | | | | | | | | Also, re-enable DefaultPluginUITest.DefaultPluginLoadTest. BUG=48388,46662 TEST=DefaultPluginUITest.DefaultPluginLoadTest Review URL: http://codereview.chromium.org/2854041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51713 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Change translate infobar gradients to light grey.jeremy@chromium.org2010-07-071-17/+7
| | | | | | | | | BUG=39813 TEST=translate infobars should have a very light gray gradient background. Review URL: http://codereview.chromium.org/2814049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51707 0039d316-1c4b-4281-b951-d872f2087c98
* Pass the correct flag to input_method::GetInputMethodIdsFromLanguageCode() ↵yusukes@google.com2010-07-071-1/+1
| | | | | | | | | | | function. BUG=chromium-os:4575 TEST=see the bug Review URL: http://codereview.chromium.org/2884017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51700 0039d316-1c4b-4281-b951-d872f2087c98
* Remove false warning.yusukes@google.com2010-07-071-1/+1
| | | | | | | | | | | Obviously we don't have to write an error log when |type| is kKeyboardLayoutsOnly. BUG=none TEST=manual Review URL: http://codereview.chromium.org/2871037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51699 0039d316-1c4b-4281-b951-d872f2087c98
* Add string resources for ibus-chewing.yusukes@google.com2010-07-071-1/+5
| | | | | | | | | BUG=chromium-os:4570 TEST=started ibus-chewing, toggled properties, then verified there were no errors in /home/chronos/chrome_log. Review URL: http://codereview.chromium.org/2836049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51698 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in input_method_util.cc.yusukes@google.com2010-07-071-1/+4
| | | | | | | | | BUG=chromium-os:4565 TEST=none Review URL: http://codereview.chromium.org/2888002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51694 0039d316-1c4b-4281-b951-d872f2087c98
* Do not show shortcut labels when labels are set to empty.satorux@chromium.org2010-07-071-26/+56
| | | | | | | | | | | | In particular, we should not show shortcut labels when ibus-mozc shows suggestions. BUG=chromium-os:4563 TEST=manually with ibus-mozc Review URL: http://codereview.chromium.org/2855033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51693 0039d316-1c4b-4281-b951-d872f2087c98
* Move default_plugin from webkit/ to chrome/thakis@chromium.org2010-07-072-2/+1
| | | | | | | | | | | Second try, first try at http://codereview.chromium.org/2803035 . Also contains http://codereview.chromium.org/2838044 , changes to DEPS files (mostly cleanups), and a change to webkit/glue/plugins/webplugin_delegate_impl_win.cc . BUG= 48419 TEST=everything still builds Review URL: http://codereview.chromium.org/2813047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51692 0039d316-1c4b-4281-b951-d872f2087c98
* Remove logging in SetImeConfig().yusukes@google.com2010-07-071-2/+0
| | | | | | | | | | | The LOG() is too verbose now since it is ensured that the call succeeds. BUG=none TEST=none Review URL: http://codereview.chromium.org/2803038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51689 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify LanguageConfigModelsatorux@chromium.org2010-07-074-36/+28
| | | | | | | | | | | | | | | Get rid of Init() method from LanguageConfigModel, and add a call to NotifyPrefChanged() in the constructor. Along the way, fix a sytle issue in LanguageConfigView. Per the style guide, model should look like model_, as it's a member variable. TEST=manually on the netbook. BUG=none Review URL: http://codereview.chromium.org/2872031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51688 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51681 - Move default_plugin out of webkit.thakis@chromium.org2010-07-071-1/+1
| | | | | | | | | | | BUG=48419 Review URL: http://codereview.chromium.org/2803035 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/2819043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51684 0039d316-1c4b-4281-b951-d872f2087c98
* Move default_plugin out of webkit.thakis@chromium.org2010-07-071-1/+1
| | | | | | | | BUG=48419 Review URL: http://codereview.chromium.org/2803035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51681 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Add tooltip to download item.thakis@chromium.org2010-07-073-2/+19
| | | | | | | | | BUG=41195 TEST=Download file with long name. Dangerous download view shouldn't have tooltip, normal download button should. Review URL: http://codereview.chromium.org/2835036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51680 0039d316-1c4b-4281-b951-d872f2087c98
* Add IssueAuthToken and unit tests to GaiaAuthenticator2.chron@chromium.org2010-07-063-6/+6
| | | | | | | | | | | GaiaAuthConsumer pure virtuals now optional since you can choose to not listen to ClientLogin subscriptions. Renamed ClientLoginError to a general GaiaAuthError. BUG=47093 TEST=Unit tests included Review URL: http://codereview.chromium.org/2834042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51678 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the current version of the history index DBs, because of the switch ↵dumi@chromium.org2010-07-061-2/+4
| | | | | | | | | | | | from fts2 to fts3. BUG=none TEST=none Review URL: http://codereview.chromium.org/2825037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51677 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusted both user and camera image size to 256x256.avayvod@chromium.org2010-07-062-25/+35
| | | | | | | | | | | | Eliminated resizing the image upon receiving each frame. BUG=None TEST=Test that video image from camera is the same as the selected image on image screen and positioned at the same level. Review URL: http://codereview.chromium.org/2817050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51674 0039d316-1c4b-4281-b951-d872f2087c98
* Add Notifications pane to content settings.thakis@chromium.org2010-07-0615-39/+196
| | | | | | | | | | | | | | | | | | THIS CHANGES THE BEHAVIOR OF HOW PERMISSIONS WORK: Previosly an infobar was shown every time an application requested notification permissions. Now, this is shown only the first time an application requests permissions, and the choice is remembered thereafter. If the kDesktopNotificationDefaultContentSetting preference is set, no infobar is shown at all. This CL also adds content settings UI to manage the exceptions list on mac, win, and linux. xib changes: Add a new pane to the content settings tab view, with the right title, radio box strings, actions, and bindings. BUG=45547 TEST=Go to a site that shows notifications. It should only ask for permissions once, and remember the user choice after that. Content Settings->Notifications->Exceptions should show the exceptions list. The content settings pane should be fully functional, and the radio button options ("don't ask") should have an effect on pages that weren't visited before. Review URL: http://codereview.chromium.org/2825028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51673 0039d316-1c4b-4281-b951-d872f2087c98
* Backend changes for notifications content settings.thakis@chromium.org2010-07-067-66/+458
| | | | | | | | | | | | | NotificationExceptionsTableModel is now functional, and DesktopNotificationService::GetContentSetting contains the new permission behavior. Both aren't used anywhere yet, so still no functionality change (but this is the last CL without functionality changes). Also add a ton of tests. BUG=45547 TEST=unit tests Review URL: http://codereview.chromium.org/2868042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51669 0039d316-1c4b-4281-b951-d872f2087c98
* Rename IDS_GEOLOCATION_EXCEPTION_DIALOG to IDS_SIMPLE_CONTENT_EXCEPTION_DIALOGthakis@chromium.org2010-07-062-4/+4
| | | | | | Review URL: http://codereview.chromium.org/2850044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51667 0039d316-1c4b-4281-b951-d872f2087c98
* chocobo's comments on http://codereview.chromium.org/2769007/showjoth@chromium.org2010-07-061-6/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2847023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51666 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: follow up to r51661 (64bit build fix).pfeldman@chromium.org2010-07-061-2/+2
| | | | | | Review URL: http://codereview.chromium.org/2808047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51662 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add stub for HTTP-based remote debugger interface.pfeldman@chromium.org2010-07-068-40/+373
| | | | | | Review URL: http://codereview.chromium.org/2802032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51661 0039d316-1c4b-4281-b951-d872f2087c98
* An experimental fix for Issue 48361.hbono@chromium.org2010-07-061-1/+1
| | | | | | | | | | This change just adds [shadow release] to release the NSShadow object used in the function. (I'm not totally sure if it is a correct fix, though.) BUG=48361 TEST=make the "Chromium Mac UI (valgrind)(2)" bot greener. Review URL: http://codereview.chromium.org/2859044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51657 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 15:35:14 +0000