summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup some rotten references to old command line switches.nick@chromium.org2009-10-062-4/+2
| | | | | | Review URL: http://codereview.chromium.org/243105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28131 0039d316-1c4b-4281-b951-d872f2087c98
* Modify extension request IPC messages to pass a ListValue instead of a string.mpcomplete@chromium.org2009-10-0617-46/+47
| | | | | | | | | | | | This allows us to pass binary values through extension requests. I use this in my next CL to pass SkBitmaps. BUG=23269 TEST=no Review URL: http://codereview.chromium.org/251093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28130 0039d316-1c4b-4281-b951-d872f2087c98
* DOMView: avoid double-detaching.nick@chromium.org2009-10-061-1/+1
| | | | | | | | | | | | | I'm seeing ~DOMView happen after NativeViewHost::Detach has already been done as part of WM_DESTROY. BUG=20339 TEST=cancel the sync login dialog and create app shortcuts dialogs. Review URL: http://codereview.chromium.org/258028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28129 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show popup browser actions in the wrench menu.erikkay@chromium.org2009-10-066-19/+31
| | | | | | | | | BUG=23834 TEST=none Review URL: http://codereview.chromium.org/257048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28119 0039d316-1c4b-4281-b951-d872f2087c98
* (please review thoroughly since this touches many moving parts).jeremy@chromium.org2009-10-0620-478/+673
| | | | | | | | | | | | | | | | | | | | | | | Refactor ImporterHost as preparation for OOPprofile import. ImporterHost currently requires substantial infrastructure in order to run which we don't need or can't have in a utility process. This change splits ImporterHost into a couple of subclasses so that the profile import process can remain light weight and doesn't need to initialize Profile, etc. ImporterList: Manages the list of importers, this class will allow the utility process to locate and instantiate an importer without initializing the world. ImprterBridge/InProcessImporterBridge: Provides an abstract interface for the importers to interact with the rest of the App. The idea is to stick the IPC boundary in using this interface. There may still be some rough spots in the separation (e.g. Firefox locking and surrounding UI) but I'll sort those out in a followup CL that makes the OOP stuff work. For now I'm trying to keep these CLs as small as I can. BUG=14458 TEST=Profile import should continue to work on Windows/Linux & Mac. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27996 Review URL: http://codereview.chromium.org/242091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28117 0039d316-1c4b-4281-b951-d872f2087c98
* Turns out a cleanup change I made a while ago was wrong. This could result ↵pkasting@chromium.org2009-10-061-1/+5
| | | | | | | | | | in odd text colors in the Omnibox when typing. BUG=none TEST=Visit m/, then type a letter into the omnibox and make sure it's black. Review URL: http://codereview.chromium.org/259054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28116 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmit http://codereview.chromium.org/243096 with gcc compile error fixed.erikkay@chromium.org2009-10-063-3/+33
| | | | | | | | | BUG=23832 TBR=mpcomplete Review URL: http://codereview.chromium.org/257056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28115 0039d316-1c4b-4281-b951-d872f2087c98
* Change the Windows build to statically link the sync library.nick@chromium.org2009-10-062-34/+7
| | | | | | | | | | | Update installer files so that they don't reference syncapi.dll. Add a reference to iphlpapi, and make it and pthreads lazy-loaded. BUG=23609 TEST=interactive testing of two sync clients with notifications. Review URL: http://codereview.chromium.org/242118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28112 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the url of the main menu.sky@chromium.org2009-10-061-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/255088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28111 0039d316-1c4b-4281-b951-d872f2087c98
* Prevents a duplicate beforeunload dialog after window.close().creis@google.com2009-10-062-1/+26
| | | | | | | | | | | | | If the renderer tells the browser to close a window, we no longer run the unload events, because the renderer already has. BUG=11647 TEST=BrowserTest.SingleBeforeUnloadAfterWindowClose Review URL: http://codereview.chromium.org/246080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28110 0039d316-1c4b-4281-b951-d872f2087c98
* Removed omnibox images from the bundle.thomasvl@chromium.org2009-10-061-5/+20
| | | | | | | | | | Update the code to pull the omnibox images from the pak files instead. TEST=Omnibox still has all the right images next to the things it lists BUG=20230 Review URL: http://codereview.chromium.org/246101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28104 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: bring devtools tests back.pfeldman@chromium.org2009-10-061-17/+17
| | | | | | Review URL: http://codereview.chromium.org/243107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28099 0039d316-1c4b-4281-b951-d872f2087c98
* Revert.jorlow@chromium.org2009-10-061-2/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28098 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the DOM Storage ui tests that worked orginally.jorlow@chromium.org2009-10-061-9/+2
| | | | | | | | | | | Next step: enable ones that should work, but (for some reason) don't. TEST=It runs. BUG=none Review URL: http://codereview.chromium.org/256070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28097 0039d316-1c4b-4281-b951-d872f2087c98
* Generate IDs for --load-extension by hashing the path insteadaa@chromium.org2009-10-067-43/+32
| | | | | | | | | | | | | of incrementing a static counter. BUG=21281 TEST=Load an unpacked extension from chrome://extensions/ that does not have an ID in its manifest. The resulting ID should be random-looking, not something like "aaaaaa". Review URL: http://codereview.chromium.org/256049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28095 0039d316-1c4b-4281-b951-d872f2087c98
* Implement --enable-web-sockets flag.ukai@chromium.org2009-10-062-0/+3
| | | | | | | | | BUG=12497 TEST=none Review URL: http://codereview.chromium.org/255075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28093 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly activeIgnoringOtherApps from IDC_NEW{,_INCOGNITO}_WINDOWsgk@google.com2009-10-062-3/+11
| | | | | | | | | | | in app_controller_mac.mm, under the assumption we're either already the foreground app or should become the foreground mac (when created from the dock menu). BUG=22595 TEST="New Window" or "New Incognito Window" from dock menu with other app in foreground Review URL: http://codereview.chromium.org/256054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28091 0039d316-1c4b-4281-b951-d872f2087c98
* Initial CL for fixing some of the proxy auth issues.chron@chromium.org2009-10-066-32/+87
| | | | | | | | | | | | | | Auth_cache is contained in the http session. We need to share the http session with the parent profile request context in order to retain http authentication. Weirdly enough, Profile::GetDefaultRequestContext() is not the same as profile_->GetRequestContext(), It does NOT yet pop up a dialog if the user hasn't done so already. BUG=19581 TEST=Included. Review URL: http://codereview.chromium.org/241001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28086 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for specifying the BrowserFlags DWORD value when we register ↵ananta@chromium.org2009-10-062-0/+29
| | | | | | | | | | | | | | | | | | | | | | the ChromeFrame Active Document server. This allows the document server to receive a number of menu events like Find, View->Text Size, etc. Thanks to Stoyan for helping me debug this :) Clicking on Edit->Find in the menu in IE with this causes IEFrame to call our Active document's Exec implementation with the IDM_FIND command. The handling here is to invoke our default Find handling. Added support for honoring user text size selections. The next thing to be done is to honor the current text size setting while launching Chrome. I also fixed the rgs files to have LF as the terminating character. This fixes Bug http://code.google.com/p/chromium/issues/detail?id=23667 Bug=23667 Review URL: http://codereview.chromium.org/243082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28085 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize message_loop_ in gaia authenticator.timsteele@google.com2009-10-061-1/+2
| | | | | | | | BUG=23906 Review URL: http://codereview.chromium.org/257058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28084 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: check module for NULL before calling GetProcAddress.mattm@chromium.org2009-10-061-1/+3
| | | | | | | | | | CID=5168,5169 TEST=none BUG=none Review URL: http://codereview.chromium.org/257043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28082 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build.erg@google.com2009-10-061-1/+1
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/246100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28077 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix crash while dragging a tab alone in a window.viettrungluu@chromium.org2009-10-062-1/+13
| | | | | | | | | | | | | Specifically, the crash could be repro'ed as follows (it also occurred under other circumstances as well): Have a window with one or more tabs in it. Create a new window with a single tab. Drag the tab in the new window, and while dragging right-click (and release). This patch also prevents right-clicks while dragging from stopping the drag. BUG=23591 TEST=See above. Review URL: http://codereview.chromium.org/242139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28075 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Implements the special bookmark bar on NTP.erg@chromium.org2009-10-0623-208/+575
| | | | | | | | | | | | | Based mostly on Ben's patch, but made it compile, work, and descoped moving the bookmark bar around the view heiarchy. XIB modification: The root view is now a BookmarkBarToolbarView instead of an NSView and is [BookmarkBarController view]. BUG=17625 Review URL: http://codereview.chromium.org/246034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28074 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Refactor some things so GTK doesn't touch the on disk image cache.erg@google.com2009-10-053-41/+64
| | | | | | | | | | Hopefully will solve crash. BUG=23588 Review URL: http://codereview.chromium.org/258020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28066 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Eliminate unintended "menu" method overrides.viettrungluu@chromium.org2009-10-059-53/+54
| | | | | | | | | | | This had the bad effect of showing bad/strange menus upon right-click on various buttons or, worse, crashing. BUG=22148,23606 TEST=Right click on back/forwards buttons (after some navigation so that they're active), page/wrench buttons, and bookmark bar off-the-side button and make sure no menu is shown (and it that it doesn't crash). Also do so when the menu is active/highlighted with menu already showing. Review URL: http://codereview.chromium.org/251091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28064 0039d316-1c4b-4281-b951-d872f2087c98
* Remove references to DOMUIContents. It looks like the class doesn't exist.tony@chromium.org2009-10-052-5/+1
| | | | | | Review URL: http://codereview.chromium.org/257055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28063 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting the NativeViewHostWin focus refactoring.jcampan@chromium.org2009-10-0510-24/+25
| | | | | | | | | | | It seems the added subclassing is causing crashers in the field. BUG=23861 TEST=None TBR=beng Review URL: http://codereview.chromium.org/259052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28061 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: mpcompleteerikkay@chromium.org2009-10-053-33/+3
| | | | | | revert previous checkin (compile failure due to bad merge resolution) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28057 0039d316-1c4b-4281-b951-d872f2087c98
* Change flag "auto-spell-correct" to "experimental-spellchecker-features". I ↵sidchat@chromium.org2009-10-053-5/+5
| | | | | | | | | | will be making a series of new features in spellchecking, and will keep all of them under this flag till they become mature enough for default use. BUG=none TEST=none Review URL: http://codereview.chromium.org/260006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28055 0039d316-1c4b-4281-b951-d872f2087c98
* Allow popups to close themselves with window.close().erikkay@chromium.org2009-10-053-3/+33
| | | | | | | | | | | | This also fixes an issue where not all of the parts of WebPreferences were being serialized/deserialized across IPC. BUG=23832 TEST=run set_page_color extension, when it sets the color, the popup should close Review URL: http://codereview.chromium.org/243096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28053 0039d316-1c4b-4281-b951-d872f2087c98
* Make the main menu open at full screen and provides command linesky@chromium.org2009-10-051-16/+65
| | | | | | | | | | | switches for changing the url and size. BUG=none TEST=none Review URL: http://codereview.chromium.org/246091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28051 0039d316-1c4b-4281-b951-d872f2087c98
* Up the new tab paint observer timeout from 2s to 5s. Trying to seetony@chromium.org2009-10-051-2/+2
| | | | | | | | | | | | if this gets us more accurate data on new tab times. BUG=21398 TBR=evanm (ok'ed in person) Review URL: http://codereview.chromium.org/257052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28050 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Allocate |cache| after we have a logic path where we can return ↵jhawkins@chromium.org2009-10-051-2/+1
| | | | | | | | | | | and leak. CID=6380 BUG=none TEST=none Review URL: http://codereview.chromium.org/255081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28044 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a Dev Tools test that got missed.pkasting@chromium.org2009-10-051-1/+1
| | | | | | | | BUG=23858 TEST=none Review URL: http://codereview.chromium.org/242147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28043 0039d316-1c4b-4281-b951-d872f2087c98
* Fix disabled DCHECK by giving kImpossibleNumberOfPopups real storage.pkasting@chromium.org2009-10-053-2/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/259050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28037 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable the dev tools unit tests. They were broken by the ↵jparent@chromium.org2009-10-051-16/+16
| | | | | | | | | | | webkit merge from 49050:49097. TEST=none BUG=23858 Review URL: http://codereview.chromium.org/257049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28036 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the RenderProcessHost from the list of renderer processes when we ↵jam@chromium.org2009-10-051-1/+7
| | | | | | | | | call DeleteSoon, not in the destructor. Otherewise the process can be reused in the meantime. This matches what we do in ChildProcessHost. BUG=21038 Review URL: http://codereview.chromium.org/257028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28034 0039d316-1c4b-4281-b951-d872f2087c98
* Adds command line flag to enable desktop notifications.johnnyg@chromium.org2009-10-051-0/+2
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/249057/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28031 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTREACHED from the keyword editor dialog. To hit,tony@chromium.org2009-10-051-3/+2
| | | | | | | | open the keyword editor dialog and press enter. Review URL: http://codereview.chromium.org/259029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28028 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: check TemplateURL::url return value.mattm@chromium.org2009-10-051-1/+4
| | | | | | | | | | CID=6325 BUG=none TEST=none Review URL: http://codereview.chromium.org/256045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28023 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Refactor ImporterHost as preparation for OOP switch", which caused ↵mattm@chromium.org2009-10-0520-670/+475
| | | | | | | | | | | | | | | | | | | purify XP leak: std::_W::_Allocate(unsigned int,wchar_t *) [unit_tests.exe] Alloc Location ... chrome/browser/importer/ie_importer.cc IEImporter::StartImport(ProfileInfo,WORD,ImporterBridge *) base/tuple.h ?DispatchToMethod@VImporter@@P81@AEXUProfileInfo@@GPAVImporterBridge@@@ZU2@GV?$scoped_refptr@VImporterBridge@@@@@@YAXPAVImporter@@P80@AEXUProfileInfo@@GPAVImporterBridge@@@ZABU?$Tuple3@UProfileInfo@@GV?$scoped_refptr@VImporterBridge@@@@@@@Z ^^^ This reverts commit r28007 and r27996. TBR=jeremy Review URL: http://codereview.chromium.org/260011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28019 0039d316-1c4b-4281-b951-d872f2087c98
* Move nsimage_cache into base so that it can be accessed from outside of chrome.mark@chromium.org2009-10-0512-101/+12
| | | | | | | | | | This is in support of the next round of rebundling. TEST=does it still build, do the unit tests still pass, does it still work? BUG=14610 Review URL: http://codereview.chromium.org/243100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28016 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing include.craig.schlenter@chromium.org2009-10-051-0/+1
| | | | | | Review URL: http://codereview.chromium.org/242144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28007 0039d316-1c4b-4281-b951-d872f2087c98
* Task Manager: show right click context menu no matter where you click on the ↵estade@chromium.org2009-10-052-4/+1
| | | | | | | | | | task manager window. discoverability++ Review URL: http://codereview.chromium.org/203047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28005 0039d316-1c4b-4281-b951-d872f2087c98
* Add a dummy call to icu::TimeZone.createDefault() before the sandbox kicks in.jshin@chromium.org2009-10-051-0/+9
| | | | | | | | | | | This is necessary to get the datetime formatting work correctly in a renderer process (e.g. FTP directory list that is now done in a renderer process.) BUG=23361,23082 TEST=... Review URL: http://codereview.chromium.org/243060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27999 0039d316-1c4b-4281-b951-d872f2087c98
* Do not use the utility process on linux.asargent@chromium.org2009-10-055-8/+43
| | | | | | | | | | | We don't currently use the zygote to spawn the utility process, so after browser updates bad bugs can occur with mismatched subprocesses. See crbug.com/23327 and crbug.com/22703. BUG=23327 TEST=Extensions installation/autoupdate and New Tab Page tip download should still work. Review URL: http://codereview.chromium.org/256036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27997 0039d316-1c4b-4281-b951-d872f2087c98
* (please review thoroughly since this touches many moving parts).jeremy@chromium.org2009-10-0520-475/+669
| | | | | | | | | | | | | | | | | | | | | Refactor ImporterHost as preparation for OOPprofile import. ImporterHost currently requires substantial infrastructure in order to run which we don't need or can't have in a utility process. This change splits ImporterHost into a couple of subclasses so that the profile import process can remain light weight and doesn't need to initialize Profile, etc. ImporterList: Manages the list of importers, this class will allow the utility process to locate and instantiate an importer without initializing the world. ImprterBridge/InProcessImporterBridge: Provides an abstract interface for the importers to interact with the rest of the App. The idea is to stick the IPC boundary in using this interface. There may still be some rough spots in the separation (e.g. Firefox locking and surrounding UI) but I'll sort those out in a followup CL that makes the OOP stuff work. For now I'm trying to keep these CLs as small as I can. BUG=14458 TEST=Profile import should continue to work on Windows/Linux & Mac. Review URL: http://codereview.chromium.org/242091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27996 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Insert views into the proper place in the view hierarchy when tearing ↵rohitrao@chromium.org2009-10-053-28/+11
| | | | | | | | | | | | off tabs. BUG=http://crbug.com/19320 BUG=http://crbug.com/23407 BUG=http://crbug.com/20555 TEST=Tearing off a tab with an open infobar should not show a blank transparent space. After tearing off a tab, both find in page and fullscreen should work properly. Review URL: http://codereview.chromium.org/258012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27992 0039d316-1c4b-4281-b951-d872f2087c98
* Infobar l10n passthomasvl@chromium.org2009-10-052-65/+90
| | | | | | | | | | | | | | | | | | - remove the close button outlet (unused) - add a helper to hide the buttons and resize the text field to use the same. - if no image, move the text field - tweak the xib to make it clear the values aren't used - tweak the xib to remove the NSEveryone image - make the link text use the control's font so it matches what's in the xib and other infobar modes (if we ever had to tweak it). - use the GTM helper for autosizing buttons - reflow how we position the buttons/textfield for the button infobars so it updates the textfield once. TEST=if you make the window skinny, any infobars that don't have buttons shouldn't reserve space for them. the the plugin crashed info bar shouldn't show a bogus graphic (currently we have none set). BUG=20535 BUG=19183 Review URL: http://codereview.chromium.org/251075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27983 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-22 11:06:03 +0000