summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Fix loading bubble not disappearing with corrupt theme image.mirandac@chromium.org2009-09-031-0/+7
| | | | | | | | | BUG= http://crbug.com/21044 TEST= try installing a theme with a corrupt image. note that loading bubble disappears. Review URL: http://codereview.chromium.org/196016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25401 0039d316-1c4b-4281-b951-d872f2087c98
* Add some DCHECKS and asserts to debug why ExtensionApiTest.Tabs is flakey ↵rafaelw@chromium.org2009-09-032-1/+3
| | | | | | | | | | and Reenable. BUG=20828 Review URL: http://codereview.chromium.org/193013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25394 0039d316-1c4b-4281-b951-d872f2087c98
* Sleep and poll (yuck!) in DownloadTest while verifying Internet ZoneIdentifier.phajdan.jr@chromium.org2009-09-031-21/+41
| | | | | | | | | | | | | There seems to be no other reliable way to do that due to Windows file semantics. This should decrease the flakiness. TEST=Covered by ui_tests. http://crbug.com/20809 Review URL: http://codereview.chromium.org/192010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25390 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing focus in location bar and accelerators on Linux toolkit views.jcampan@chromium.org2009-09-0311-2/+62
| | | | | | | | | | | | | | | BUG=None TEST=Focus the location bar, deactive/reactivate the browser window with Alt-Tab, the focus should still be on the location bar. Click few links on a page to have a history navigation. Focus the location bar, use backspace to delete some text. Focus a text area in a web page, make sure backspace works as expected (deletes text). Now click on a non text area, press backspace. You should trigger a navigate back. Review URL: http://codereview.chromium.org/185014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25389 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r25382: blame Windowsagl@chromium.org2009-09-034-148/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25386 0039d316-1c4b-4281-b951-d872f2087c98
* Add "loading..." message to theme install to counter jank.mirandac@chromium.org2009-09-035-0/+251
| | | | | | | | | BUG= http://crbug.com/17696 TEST= Install a theme. Note that a "loading" message appears to notify you that a theme is loading. Review URL: http://codereview.chromium.org/191011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25383 0039d316-1c4b-4281-b951-d872f2087c98
* ForceTLS: persist to diskagl@chromium.org2009-09-034-6/+148
| | | | | | | | | | | | | | | With this patch, we'll persist ForceTLS state to disk. It's saved as a JSON file (ForceTLSState) in the user data directory for the moment. You still need the --force-https flag in order to trigger any ForceTLS behaviour, however. For the moment, this state isn't cleared when the rest of the browser state it. That's ok because it's still behind a flag. http://codereview.chromium.org/186014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25382 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust color spaces so that Mac Chrome renders colors properly.amanda@chromium.org2009-09-031-10/+4
| | | | | | | | | | | BUG=19951,20552 TEST=compare pages rendered in Chromium and Safari. They should appear the same. mark: review jrg/brettw: FYI Review URL: http://codereview.chromium.org/194013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25380 0039d316-1c4b-4281-b951-d872f2087c98
* Fix views linux build.estade@chromium.org2009-09-031-2/+2
| | | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/198012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25379 0039d316-1c4b-4281-b951-d872f2087c98
* GTK file picker: Use mime type filters instead of shell-style glob filters.estade@chromium.org2009-09-031-12/+9
| | | | | | | | BUG=12347 Review URL: http://codereview.chromium.org/192011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25377 0039d316-1c4b-4281-b951-d872f2087c98
* Add external protocol dialog for Linux.estade@chromium.org2009-09-036-80/+180
| | | | | | | | | | This exposes a bug where \n in a string resource is rendered literally when it is displayed. I don't know at what point on Windows the '\' + 'n' is translated to a line return, I have filed crbug.com/20943 BUG=20731 Review URL: http://codereview.chromium.org/194002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25373 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing headers for Release.finnur@chromium.org2009-09-031-0/+2
| | | | | | | | | TBR=jcampan BUG=None TEST=Release build should work now. Review URL: http://codereview.chromium.org/196008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25369 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 9867: Activating the previous/next buttons with the keyboard in the find ↵finnur@chromium.org2009-09-0373-120/+175
| | | | | | | | | | | | | bar should not change the focus. Add param const Event& event to ButtonPressed, so that recipients can find out more about the event that generated the ButtonPress message. BUG=9687 TEST=Open www.google.com and open Find-in-page, search for 'e'. Press FindNext button with mouse and note that the focus should be on the textfield. Now press Tab twice to put focus on the FindNext button and press SpaceBar a few times. Note that the focus should stay on the FindNext button. Review URL: http://codereview.chromium.org/188016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25367 0039d316-1c4b-4281-b951-d872f2087c98
* (Mac) Make the Page/Wrench buttons place their menu in the right place.viettrungluu@chromium.org2009-09-037-27/+216
| | | | | | | | | | | | | | | | | | | | | | Also makes the buttons drag-able -- you can drag or click and wait to open their menu. Lucky for me, I wrote reusable code. To do (not now): The "off-the-end" button on the bookmark bar needs the same fix. Bug (not to be fixed now): The menu doesn't do the right thing when the window is moved off the left edge to the screen -- it doesn't open to the right in the correct fashion. Nor does it do the proper thing when you move the window off the bottom edge of the screen -- it doesn't open upwards entirely correctly. <shrug> BUG=18572 TEST=Click on the Page and Wrench menu buttons and observe. Also test \ dragging to open. Review URL: http://codereview.chromium.org/174556 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25362 0039d316-1c4b-4281-b951-d872f2087c98
* Fix theme cache corruption.mirandac@chromium.org2009-09-032-34/+42
| | | | | | | | | BUG= http://crbug.com/20957 TEST= Install many themes quickly, with many windows open. Close browser and reopen. Theme should not be corrupted. Review URL: http://codereview.chromium.org/197010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25359 0039d316-1c4b-4281-b951-d872f2087c98
* Add "other bookmarks" to bookmark menu.jrg@chromium.org2009-09-033-31/+93
| | | | | | | | | | | | | | | | | BUG=http://crbug.com/18734 TEST=Launch Chrome. Add some bookmarks then open the bookmark menu. You should see all "bookmark bar" bookmarks, followed by a separator line, followed by an "Other bookmarks" submenu at the end. Go to a bookmark then click on STAR. Change folder to "other bookmarks". Now open bookmark menu; see item moved from "main page" to the "other bookmarks" folder at the end. Undo that change by clicking on STAR, changing parent. Make sure back to normal. Review URL: http://codereview.chromium.org/195001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25357 0039d316-1c4b-4281-b951-d872f2087c98
* Properly show/hide "off the side" button/menu (chevron) on bookmark bar as ↵jrg@chromium.org2009-09-033-17/+12
| | | | | | | | | | | | | | | | | | | needed. BUG=http://crbug.com/17852 TEST=delete all bookmarks. No chevron. Add one bookmark to bookmark bar. No chevron. Make window real wide. Add some more bookmarks (but not enough that it spills over). No chevron. Make window thinner. Chevron appears! Widen window until chevron hides. Add more bookmarks until it appears again. Review URL: http://codereview.chromium.org/201005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25356 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Disable Omnibox editing in popup windows.shess@chromium.org2009-09-031-2/+2
| | | | | | | | | | | http://crbug.com/20243 TEST=Go to www.popuptest.com. Select test #2, allow one of the popups through. Try to edit in the omnibox. Should be able to select and copy, but not enter text. Review URL: http://codereview.chromium.org/183043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25351 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make I-beam cursor match editing area.shess@chromium.org2009-09-033-2/+22
| | | | | | | | | | | | Due to our tweaking of the text area, the I-beam cursor was sometimes janky. http://crbug.com/20238 TEST=I don't even know how to really test this. Review URL: http://codereview.chromium.org/181011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25346 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obsolete comment about a test being disabled.asargent@chromium.org2009-09-031-1/+0
| | | | | | | | | BUG=16106 TEST=none Review URL: http://codereview.chromium.org/176016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25341 0039d316-1c4b-4281-b951-d872f2087c98
* Make the omnibox 2 hover code a tiny bit less goofy by removing a now-unused ↵pkasting@chromium.org2009-09-037-37/+20
| | | | | | | | | | | | function (although it may have to come back eventually) and using the Model's conception of hover state instead of direct hot-tracking in the view. Unfortunately, there are still problems, including bogus mousemove events for the same point and no WM_MOUSELEAVE events, all of which the old code handled. I think fixing this is going to require implementing a TODO in the code to hoist mouse handling to the main dropdown view, at which point I can probably address issue 13703 as well. BUG=13279 TEST=none Review URL: http://codereview.chromium.org/187002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25336 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Allow DOMUI pages to call window.open(), giving DOMUI ↵mpcomplete@chromium.org2009-09-0314-93/+210
| | | | | | | | | | | | privileges to the new"" Second attempt at r25250. The tests were broken in Release mode due to a race. Should be fixed. BUG=17636 Review URL: http://codereview.chromium.org/172120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25329 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Workaround Skia and Pango measuring font heights differently by ↵evan@chromium.org2009-09-031-1/+1
| | | | | | | | | asking Pango" This reverts commit r25131. It seems to have regressed Linux startup; will track perf builder after committing this to be sure. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25325 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't have a blank line in bookmark folder tooltips.erg@google.com2009-09-031-1/+4
| | | | | | Review URL: http://codereview.chromium.org/198006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25322 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Fix link and link underline colorsarv@google.com2009-09-037-34/+125
| | | | | | | | | | | | | The fall back color for the link underline is the link color with the alpha channel set to 1/3 of the link color. BUG=20697 TEST=All links on the NTP should have different underline color. Also, try with different themes. Review URL: http://codereview.chromium.org/194004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25318 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Add basic unit tests for gtk themes.erg@google.com2009-09-033-7/+149
| | | | | | Review URL: http://codereview.chromium.org/186019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25317 0039d316-1c4b-4281-b951-d872f2087c98
* The iterator used to walk through the set of throbbers might become invalidmark@chromium.org2009-09-031-4/+11
| | | | | | | | | | | if a throbber decides it's done animating during the walk. This might happen for toast throbbers, like the sad tab icon. TEST=none, really BUG=20907 Review URL: http://codereview.chromium.org/185016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25316 0039d316-1c4b-4281-b951-d872f2087c98
* Disable flaky ExtensionApi tests. #1 source of flakiness.phajdan.jr@chromium.org2009-09-032-2/+4
| | | | | | | | | TEST=none http://crbug.com/19866, http://crbug.com/20828 Review URL: http://codereview.chromium.org/195003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25314 0039d316-1c4b-4281-b951-d872f2087c98
* Make theme setup a little faster by not blurring images for tab backgrounds.mirandac@chromium.org2009-09-031-5/+5
| | | | | | | | | BUG= http://crbug.com/20956 TEST= Install themes, note that tab backgrounds look good. Review URL: http://codereview.chromium.org/198003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25312 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: re-enable sanity tests disabled during the deps roll.pfeldman@chromium.org2009-09-031-2/+2
| | | | | | | | BUG=20835 TBR=yurys Review URL: http://codereview.chromium.org/194010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25305 0039d316-1c4b-4281-b951-d872f2087c98
* Restore r25049 (back out r25295) to isolate it as the cause of bug 20872.mark@chromium.org2009-09-031-7/+8
| | | | | | | | | TBR=pinkerton BUG=20872 TEST=watch perf Review URL: http://codereview.chromium.org/194008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25296 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily back out r25049 to isolate it as the cause of bug 20872.mark@chromium.org2009-09-031-8/+7
| | | | | | | | | TBR=pinkerton BUG=20872 TEST=watch perf Review URL: http://codereview.chromium.org/196002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25295 0039d316-1c4b-4281-b951-d872f2087c98
* Add an auto-update now button to chrome://extensions pageasargent@chromium.org2009-09-037-8/+42
| | | | | | | | | | | | BUG=http://crbug.com/17853 TEST=Install an old version of an extension with an available update, then go to chrome://extensions and hit the auto-update now button. The extension should update. Review URL: http://codereview.chromium.org/184005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25293 0039d316-1c4b-4281-b951-d872f2087c98
* A crasher can happen in the AlternateNavURLFetcher if the fetch finishes ↵jcampan@chromium.org2009-09-031-2/+14
| | | | | | | | | | | | | after the tab has been closed. At that point the navigation controller the AlternateNavURLFetcher has been deleted and should not be accessed. This CL also addresses a memory leak that would happen when the fetch would fail. BUG=http://crbug.com/17044 TEST=Navigate to an internal URL (ex: http//mylocalserver) by only typing its name (mylocalserver), an infobar asking whether you want to go to http//mylocalserver should be shown. Review URL: http://codereview.chromium.org/187016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25289 0039d316-1c4b-4281-b951-d872f2087c98
* Add warnings around the new tab page command line switch and its use so peoplebrettw@chromium.org2009-09-031-0/+4
| | | | | | | | | | don't get confused and copy this pattern (as happened recently). BUG=none TEST=none Review URL: http://codereview.chromium.org/186018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25282 0039d316-1c4b-4281-b951-d872f2087c98
* Move status area view to the chromeos directory.brettw@chromium.org2009-09-034-6/+6
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/192001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25279 0039d316-1c4b-4281-b951-d872f2087c98
* Set the focus ring color to match the Gtk theme focus color.estade@chromium.org2009-09-031-0/+12
| | | | | | | | BUG=8540 Review URL: http://codereview.chromium.org/173642 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25278 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to ensure IO thread is created when ExtensionUpdater needs it.asargent@chromium.org2009-09-031-1/+2
| | | | | | | | | | | | In some cases on MacOS it turned out that the IO Thread hadn't been created at the time we were asking for it. BUG=http://crbug.com/20794 TEST=none Review URL: http://codereview.chromium.org/184024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25277 0039d316-1c4b-4281-b951-d872f2087c98
* Adding in memory log of history visit database. Thishuanr@chromium.org2009-09-024-0/+178
| | | | | | | | | | | | log will be saved in crash dump (to be done in next CL) to help debug the corruption in history thread. TEST=Added unit test. BUG=16591 Review URL: http://codereview.chromium.org/187004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25276 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at a fix for ExtensionBrowserTest.MessagingContentScript.mpcomplete@chromium.org2009-09-022-3/+4
| | | | | | | | | BUG=20795 TEST=no Review URL: http://codereview.chromium.org/191010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25273 0039d316-1c4b-4281-b951-d872f2087c98
* Make the EV cert message disappear while typing in the omnibox.pkasting@chromium.org2009-09-021-0/+3
| | | | | | | | BUG=20917 TEST=Visit paypal.com, then type in the omnibox. While typing, the EV cert message on the right side of the omnibox should disappear. Review URL: http://codereview.chromium.org/172118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25267 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude specific browser_tests that don't yet work on Mac.paul@chromium.org2009-09-022-0/+13
| | | | | | | | | BUG=16322 (http://crbug.com/16322) TEST=Covered by browser_tests. Review URL: http://codereview.chromium.org/189007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25265 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a DCHECK that I hit while working on the extension shelf for OS X.thakis@chromium.org2009-09-023-0/+32
| | | | | | | | | BUG=Part of 19073 TEST=unittest in CL Review URL: http://codereview.chromium.org/185015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25261 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r25250: "Allow DOMUI pages to call window.open(), giving DOMUI ↵mpcomplete@chromium.org2009-09-0214-224/+93
| | | | | | | | privileges to the new" Review URL: http://codereview.chromium.org/171127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25256 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash on Mac by passing an owning window to SelectFile() when loadingpamg@google.com2009-09-021-1/+2
| | | | | | | | | | an unpacked extension from chrome://extensions. BUG=20860 TEST=go to chrome://extensions on Mac, click "Load unpacked extensions...", don't crash Review URL: http://codereview.chromium.org/171121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25253 0039d316-1c4b-4281-b951-d872f2087c98
* Allow DOMUI pages to call window.open(), giving DOMUI privileges to the newmpcomplete@chromium.org2009-09-0214-93/+224
| | | | | | | | | | | window (assuming it is on the same site instance). BUG=17636 TEST=no Review URL: http://codereview.chromium.org/173649 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25250 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make the columns in the task manager avoid causing scroll bars.mdm@chromium.org2009-09-021-6/+23
| | | | | | | | | BUG=17930 TEST=open the task manager and load some pages; the network column shouldn't force a horizontal scrollbar Review URL: http://codereview.chromium.org/186001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25245 0039d316-1c4b-4281-b951-d872f2087c98
* Share one timer for all of the throbbers in the application.mark@chromium.org2009-09-021-27/+144
| | | | | | | | | BUG=20907 19268 TEST=Make lots of throbbers spin simultaneously. There should be no reduction in animation speed or smoothness. Review URL: http://codereview.chromium.org/191009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25238 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk first run: Remove obsolete warning for unimplemented privacy features.mattm@chromium.org2009-09-022-19/+28
| | | | | | | | | | | Add learn more link after crash reporting checkbox. BUG=none TEST=build google release build, launch with empty user-data-dir, click learn more link - should open in default browser. Review URL: http://codereview.chromium.org/178025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25237 0039d316-1c4b-4281-b951-d872f2087c98
* Infrastructure to allow putting Extension Shelf on top along with Bookmarks.sidchat@google.com2009-09-026-408/+556
| | | | | | | | BUG=http://code.google.com/p/chromium/issues/detail?id=20517 TEST=none Review URL: http://codereview.chromium.org/173613 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25236 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-20 19:00:46 +0000