summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Better location for setting the size of tab contents. This should"tony@chromium.org2009-08-132-14/+23
| | | | | | | | | | | This reverts commit r23358. TBR=japhet Review URL: http://codereview.chromium.org/165489 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23365 0039d316-1c4b-4281-b951-d872f2087c98
* Argh, reverting the change to remove the "crx" file extensionaa@chromium.org2009-08-131-3/+17
| | | | | | | | | | | | | | | | | | hack in DownloadManager. For those playing along at home, this change makes it so that we once again consider any file that ends in ".crx" an extension. The problem is that file:// URLs are not-sniffable, so with this change we cannot install extensions from file:// URLs. We need to fix things so that we consider file associations for local files, I guess. TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23362 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=http://crbug.com/17986jrg@chromium.org2009-08-131-3/+0
| | | | | | | | | | | Original CL: http://codereview.chromium.org/164500 TEST=see original CL Landing an LGTMed CL for rsesek@gmail.com Review URL: http://codereview.chromium.org/165484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23361 0039d316-1c4b-4281-b951-d872f2087c98
* Make confirm info bar buttons support mnemonics.tony@chromium.org2009-08-131-2/+6
| | | | | | | | | | | | I think this is temporary because we're past string freeze and the undo text is borrowed from elsewhere. I should have caught this in the last change. :( Review URL: http://codereview.chromium.org/164490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23360 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Disable sanity tests while merging the DOMAgent commit upstream. ↵pfeldman@chromium.org2009-08-131-0/+6
| | | | | | | | (Re-apply 23350). Review URL: http://codereview.chromium.org/164514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23359 0039d316-1c4b-4281-b951-d872f2087c98
* Better location for setting the size of tab contents. This shouldtony@chromium.org2009-08-132-23/+14
| | | | | | | | | | | | | | | catch all code paths. I noticed that middle clicking a bookmark wasn't working, so I found a single place to do this. This code is always run when a tab is added and it sizes the contents when it's loading in the background. BUG=619 Review URL: http://codereview.chromium.org/165473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23358 0039d316-1c4b-4281-b951-d872f2087c98
* Renames the NavigationEntry::display_url() to virtual_url().tony@chromium.org2009-08-1314-52/+52
| | | | | | | | | | | | | BUG=6970 (http://crbug.com/6970) TEST=None Patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/164383 Review URL: http://codereview.chromium.org/165485 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23357 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback 23350. Fix build breakage: no object file generated.pfeldman@chromium.org2009-08-131-5/+0
| | | | | | | TBR=mnaganov git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23356 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Disable sanity tests while merging the DOMAgent commit upstream.pfeldman@chromium.org2009-08-131-0/+5
| | | | | | | TBR=mnaganov Review URL: http://codereview.chromium.org/164505 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23350 0039d316-1c4b-4281-b951-d872f2087c98
* Add some paranoid CHECKs to the ExtensionMessageService to track down a crash.mpcomplete@chromium.org2009-08-131-0/+11
| | | | | | | | | BUG=19067 TEST=no Review URL: http://codereview.chromium.org/165431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23345 0039d316-1c4b-4281-b951-d872f2087c98
* Make drag-to-activate session history dropdowns less sensitive. Patch from ↵pinkerton@chromium.org2009-08-131-2/+13
| | | | | | | | | | viettrunglu@gmail.com BUG=19273 TEST=Make your mouse really sensitive; see if you can accidentally activate the back/forward history dropdowns. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23334 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at fixing anchor links opening in background tabs on linux.tony@chromium.org2009-08-132-2/+22
| | | | | | | | | | | | | | | | Also fix a code path that seems to be missing on Windows (maybe this regressed?). This time make sure RWHV is not NULL. BUG=619 TEST=http://code.google.com/p/chromium/issues/detail?id=619#c6 Review URL: http://codereview.chromium.org/165468 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23332 0039d316-1c4b-4281-b951-d872f2087c98
* Correcting a possible race between adding and removing automation resource ↵robertshield@chromium.org2009-08-132-9/+25
| | | | | | | | message filters. Review URL: http://codereview.chromium.org/165395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23331 0039d316-1c4b-4281-b951-d872f2087c98
* Clear an error message from the throbber space.paul@chromium.org2009-08-131-2/+4
| | | | | | | | | | | | | | | When an update fails, we display an error string and allow the user to try again by manually pressing the update button. When the user does that, we should clear the error message so that the update throbber doesn't draw over the text, which looks ugly. BUG=19272 (http://crbug.com/19272) TEST=Difficult to repro: try to update chrome and fail, press the update button and notice that the error message disappears when the throbber is active. Review URL: http://codereview.chromium.org/165462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23329 0039d316-1c4b-4281-b951-d872f2087c98
* Simple cleanup.maruel@chromium.org2009-08-131-1/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/164424 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23327 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix up use_system_{libxml,libxslt,sqlite3}agl@chromium.org2009-08-131-1/+6
| | | | | | | http://codereview.chromium.org/164450 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23324 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where infobars were not getting replaced on linux. Thistony@chromium.org2009-08-132-6/+38
| | | | | | | | | | | | | | | | | | was added to the info bar api in r22711. There's a tiny flicker when the infobars are replaced, but it's a lot better than the jerky animation there used to be. I imagine mac will still have this bug. BUG=19101 TEST=Install 2 themes from the theme gallery. The second theme should be displayed. Review URL: http://codereview.chromium.org/164456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23323 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix anchor links opening in background tabs on linux. Also fix"tony@chromium.org2009-08-132-20/+2
| | | | | | | | | | | | | Some tab opening crashes, I need to null check some pointers. TBR=estade This reverts commit r23317. Review URL: http://codereview.chromium.org/164486 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23320 0039d316-1c4b-4281-b951-d872f2087c98
* Fix anchor links opening in background tabs on linux. Also fixtony@chromium.org2009-08-132-2/+20
| | | | | | | | | | | | | a code path that seems to be missing on Windows (maybe this regressed?). BUG=619 TEST=http://code.google.com/p/chromium/issues/detail?id=619#c6 Review URL: http://codereview.chromium.org/164452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23317 0039d316-1c4b-4281-b951-d872f2087c98
* Add privacy_blacklists key to extension manifest and validate it.phajdan.jr@chromium.org2009-08-131-0/+12
| | | | | | | | | | | This is the first step towards shipping privacy blacklists in extensions. TEST=Covered by unit_tests. BUG=none Review URL: http://codereview.chromium.org/164349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23316 0039d316-1c4b-4281-b951-d872f2087c98
* Disable RTTI and C++ exceptions in the Mac build. Disable RTTI in the Linuxmark@chromium.org2009-08-133-7/+16
| | | | | | | | | | | | build, where C++ exceptions are already disabled. BUG=19094 12248 TEST=Mac release-mode Google Chrome.app should shrink by about 6MB. Mac disk image should shrink by about 1.5MB. Linux binary and package should shrink too. Review URL: http://codereview.chromium.org/165330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23304 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 23286jorlow@chromium.org2009-08-131-0/+7
| | | | | | | | | | TBR=michaeln TEST=none BUG=none Review URL: http://codereview.chromium.org/164463 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23297 0039d316-1c4b-4281-b951-d872f2087c98
* Another attempt to enable the local storage ui test based layout tests.jorlow@chromium.org2009-08-131-7/+0
| | | | | | | | | | TBR=michaeln TEST=none BUG=none Review URL: http://codereview.chromium.org/164461 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23286 0039d316-1c4b-4281-b951-d872f2087c98
* Removes unneeded include in download_request_dialog_delegate.sky@chromium.org2009-08-131-1/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164444 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23278 0039d316-1c4b-4281-b951-d872f2087c98
* Implement http auth login dialog for OS X.thakis@chromium.org2009-08-138-14/+363
| | | | | | | | | | | The login sheet looks very bare-bones…but that's probably ok for now. BUG=12043 TEST=Go to a page that uses http auth, e.g. http://www.pagetutor.com/keeper/mystash/secretstuff.html . A sheet should come up that asks for login and password. Escape should cancel the sheet, return should confirm it. The sheet should be per-tab, e.g. tab switching while the sheet is open should work. Review URL: http://codereview.chromium.org/164391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23276 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Omnibox popup metrics.shess@chromium.org2009-08-132-9/+31
| | | | | | | | | | | | | | | | | Use en-dash instead of em-dash to separate match and description. Popup font a little smaller than field font. Make cell taller, and no gap between cells. Use BaseFont from ResourceBundle instead of field's default font (this is what Windows uses, I think). http://crbug.com/19184 Review URL: http://codereview.chromium.org/164418 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23273 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: One more acceleratorestade@chromium.org2009-08-131-1/+2
| | | | | | | | BUG=19122 Review URL: http://codereview.chromium.org/165411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23266 0039d316-1c4b-4281-b951-d872f2087c98
* I have taken over this patch, original authored by Adam Hunter (adamhunter).rafaelw@chromium.org2009-08-135-0/+95
| | | | | | | | | | | | | | | | | | | | | | | The original issue is: http://codereview.chromium.org/144019 -------------- Functionality has been requested in the Extension API for Javascript to take screenshots of the currently visible tab. This changelist builds this function, chrome.tabs.getVisibleScreenCapture. This function takes a single callback function and returns to that function a data URL of a JPEG image of the current screen. A simple sample extension is provided as a use case. BUG=14760 TEST=There is an extension in chrome\test\data\extensions\samples\screenshot, load this extension. It creates a toolstrip button. Click this button, you should get a page with a screenshot of the active tab. The API function is found at chrome.tabs.getVisibleScreenCapture. Review URL: http://codereview.chromium.org/160228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23259 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two URLRequestContext leaks in HttpBridgeTest and reenable the test. It ↵tim@chromium.org2009-08-121-11/+16
| | | | | | | | | | | | was previously failing the purify step. BUG=19002 TEST=HttpBridgeTest Review URL: http://codereview.chromium.org/165363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23254 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: autocomplete popup size and shape mirrors star/go buttons.shess@chromium.org2009-08-121-3/+86
| | | | | | | | | | Also line up image and title columns under star and field. http://crbug.com/19182 Review URL: http://codereview.chromium.org/164415 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23253 0039d316-1c4b-4281-b951-d872f2087c98
* Fix early return/DCHECK importing Safari bookmarks.jeremy@chromium.org2009-08-121-6/+9
| | | | | | | | BUG=19167 Review URL: http://codereview.chromium.org/164442 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23250 0039d316-1c4b-4281-b951-d872f2087c98
* Move IDMap from base/ to common/phajdan.jr@chromium.org2009-08-122-2/+2
| | | | | | | | | | | Nothing in base/ uses it, and I'm going to make some non-trivial changes to it. TEST=none http://crbug.com/19202 Review URL: http://codereview.chromium.org/164428 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23243 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the unittest "DnsMasterTest.OsCachesLookupsTest".eroman@chromium.org2009-08-121-72/+5
| | | | | | | | | | | | This test was checking that the system host resolver maintains an internal cache, by doing actual DNS resolves (which introduces a network dependency in the unit tests). This could be flaky on linux, which doesn't cache resolves. As of r18236 however, chromium maintains its own host cache. So the DNS prefetcher does not need to rely on the OS caching DNS resolves in order to be a win. BUG=http://crbug.com/18766 Review URL: http://codereview.chromium.org/164350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23239 0039d316-1c4b-4281-b951-d872f2087c98
* So it turns out that gdk already has a function that does exactly what we want.estade@chromium.org2009-08-121-2/+2
| | | | | | | | http://www.google.com/codesearch/p?hl=en&sa=N&cd=2&ct=rc#eSCqYNcHl48/gtk%2B-2.4.10/gdk/gdkevents.c&q=gdk_event_get_time Review URL: http://codereview.chromium.org/164429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23234 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for the URLRequestAutomationJob object which issues HTTP ↵ananta@chromium.org2009-08-123-14/+33
| | | | | | | | | | | | | | | | requests through automation to receive persistent cookies from the automation client. These cookies are passed in when the automation client notifies Chrome that a HTTP request was started. The URLRequestAutomationJob object now informs Chrome whether an automation URL request was redirected. The ExternalTabContainer now handles the NEW_FOREGROUND_TAB and displays a popup window in response. This gets around an ASSERT. This fixes bug http://b/issue?id=2048046 Bug=2048046 Review URL: http://codereview.chromium.org/165350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23233 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors OSExchangeData for easier portability.sky@chromium.org2009-08-1211-89/+99
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23230 0039d316-1c4b-4281-b951-d872f2087c98
* First step to create application shortcuts on Linux.phajdan.jr@chromium.org2009-08-127-8/+260
| | | | | | | | | | | Create a working desktop shortcut. For now it displays no UI, but the backend works. TEST=none http://crbug.com/17251 Review URL: http://codereview.chromium.org/164280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23226 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make autocomplete popup track autocomplete field resizes.shess@chromium.org2009-08-121-0/+26
| | | | | | | | | http://crbug.com/17402 TEST=Enter text in the omnibox and resize the window. Popup size should follow. Review URL: http://codereview.chromium.org/165332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23225 0039d316-1c4b-4281-b951-d872f2087c98
* (Mac) Place back/forward toolbar menu correctly when there's a bookmarkavi@chromium.org2009-08-121-11/+9
| | | | | | | | | | | | | | | | bar. It turns out that the frame is in the DelayedMenuButton's coordinate system, but a fudge is needed to make things line up. (I don't understand these fudges, especially vertically.) Patch by viettrungluu. BUG=http://crbug.com/19174 TEST=Surf a bit, check back menu with and without bookmark bar. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23216 0039d316-1c4b-4281-b951-d872f2087c98
* Move the menu bar l10n into the xib file.thomasvl@chromium.org2009-08-123-19/+27
| | | | | | | | | | | | Localize the menu bar titles. Have the browser platform delegate startup the resource bundle system so we can fetch localization data. Make l10n_util::GetApplicationLocale return what cocoa says for the language so we match what the UI is using. TEST=everything still works. BUG=17380 Review URL: http://codereview.chromium.org/164413 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23215 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SyncSetupWizardTest again.tim@chromium.org2009-08-121-1/+3
| | | | | | | | | TBR=cmp BUG=19002 Review URL: http://codereview.chromium.org/165400 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23213 0039d316-1c4b-4281-b951-d872f2087c98
* Checkpoint for event automation porting.estade@chromium.org2009-08-124-7/+82
| | | | | | | | Partially based on patch by Dan Kegel. Review URL: http://codereview.chromium.org/164371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23209 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Playback Rate from the context menu.scherkus@chromium.org2009-08-121-91/+0
| | | | | | | | | | This feature is better implemented as an extension rather than being put into the absolute-core UI. Review URL: http://codereview.chromium.org/164301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23208 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two leaks in SyncSetupWizard test caused by the mock infrastructuretim@chromium.org2009-08-121-6/+19
| | | | | | | | | | | not doing the cleanup that happens in real life. BUG=19002 TEST=SyncSetupWizardTest Review URL: http://codereview.chromium.org/164370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23207 0039d316-1c4b-4281-b951-d872f2087c98
* Make text on NNTP popup menu blue, so it can be read in all themes.mirandac@chromium.org2009-08-121-2/+3
| | | | | | | | | BUG= http://crbug.com/18471 TEST= Open new tab page in any theme, click "Change page layout" dropdown menu, note that text is always blue on white. Review URL: http://codereview.chromium.org/165389 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23205 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TransformProcessType from the browser process now that LSUIElementmark@chromium.org2009-08-121-31/+10
| | | | | | | | | | is gone. BUG=8044 TEST=Dock icon still works properly Review URL: http://codereview.chromium.org/165384 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23196 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unused variable on GCC.phajdan.jr@chromium.org2009-08-121-2/+1
| | | | | | | | | TBR=wtc http://crbug.com/18697 Review URL: http://codereview.chromium.org/164410 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23194 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile on Windows.phajdan.jr@chromium.org2009-08-121-0/+2
| | | | | | | | | TBR=wtc http://crbug.com/18697 Review URL: http://codereview.chromium.org/165391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23193 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash with new FTP in Incognito mode.phajdan.jr@chromium.org2009-08-121-1/+12
| | | | | | | | | TEST=See bug. http://crbug.com/18697 Review URL: http://codereview.chromium.org/165386 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23190 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Popup notification should have transparent rounded corners.erg@google.com2009-08-124-44/+93
| | | | | | | | Also uses the new consistent border color in GTK theme mode. Review URL: http://codereview.chromium.org/165356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23189 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 18:57:44 +0000