| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Windows XP doesn't have inet_pton and it crashes XP bots.
Removed GaiaAuth class. Gtalk login will now fail immediately instead of trying (in vain) to gaiaauth.
Removed nowunneeded parameters.
BUG=38034
TEST=manual with and without invalidatesyncxmpplogin
Review URL: http://codereview.chromium.org/885008
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/983005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally described here:
http://code.google.com/p/chromium/wiki/InfoBarExtensionAPI
The API is simple:
chrome.experimental.infoBar.show(
{"htmlPath": "infobar.html"}, function(window) {
// |window| is where the infobar was shown.
});
To close it, you can simply call window.close() from within the InfoBar (infoBar.hide is not provided).
The api is privileged (not available to content scripts directly).
The minimum height for the infobar is regular height for our infobars (32 pixels), maximum is twice that and the actual size is determined by the content (within these constraints mentioned).
See screenshot in bug. The icon on the far left is an extension icon with a dropdown menu showing the menu that shows when you right-click on the extension icon in the Omnibox/browser action container.
BUG=26463
TEST=None (for now).
Review URL: http://codereview.chromium.org/1049001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChildProcessHost::Iterator instead. This change fixes the crash that occured if the browser was closed while the NaCl module was still running (found by nacl_ui_tests).
Also make nacl_ui_tests depend on nacl win64 binary (required to run the tests on Win64)
BUG=none
TEST=nacl_ui_tests
Review URL: http://codereview.chromium.org/875005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=build works again
Review URL: http://codereview.chromium.org/1051002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41803 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added AddSystemNotification to add system notification
and UpdateNotification to update a notification.
* refactored NotificationObjectProxy and added NotificationDelegate class.
* Added notification_browser.cc.
BUG=33306
TEST=added notification_browser.cc with minimal test. I'll add more in next step.
Review URL: http://codereview.chromium.org/1013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41801 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fix some issues on GTK concerning the proper behavior when adding/removing browser actions (container sizing + chevron visibility).
Windows uses a different pref (kBrowserActionContainerWidth), which is measured in pixels; it should be migrated to the new pref.
Also, register extension prefs during startup.
BUG=32101
TEST=manual
Review URL: http://codereview.chromium.org/841007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only the chromium part is for review. The webkit part shows how that will look when I create the patch for webkit later. This can be landed without the change to webkit.
TODO later:
- use the image on windows, mac
- implement the other DragImageRef functions
TEST=drag an image from the render view in GTK
BUG=11457
Review URL: http://codereview.chromium.org/668125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Match addr1, addr2 for Address Line 1/2.
* Match pcode for postal/zip code.
* Fix the termination condition for the address matching loop.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/1006004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now it is bound to the temporary URL "chrome://net2", since the frontend is under construction.
(Loading this page right now just shows a dummy HTML page.)
This change is a first step to transitioning the about:net-internals / about:network pages from C++ to javascript.
Note that the network stuff needs to run on the IO thread, however the DOMUI infrastructure is all set up to run on the UI thread.
I work around this by proxying things back and forth through the IO thread. Hopefully in subsequent iterations this overhead can be removed, by exposing a sort of "IO thread DOMUI".
BUG=37421
Review URL: http://codereview.chromium.org/1036001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed GaiaAuth class. Gtalk login will now fail immediately instead of trying (in vain) to gaia-auth.
Removed now-unneeded parameters.
BUG=38034
TEST=manual with and without --invalidate-sync-xmpp-login
Review URL: http://codereview.chromium.org/885008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
already been destroyed.
BUG=chromium-os:1697
TEST=manual: switch to compact nav bar mode (ctrl-shift-c), move mouse to a tab to open compact location bar,
then open app launcher. Type in something in the address bar and select from suggestion list.
Review URL: http://codereview.chromium.org/1048003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41788 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I hijacked the extension install/uninstall dialog, and added another type that
it can transmogrify into.
BUG=32365
Review URL: http://codereview.chromium.org/1041002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=37809,268629
TEST=test passes
Review URL: http://codereview.chromium.org/997004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
items".
Adds correct expand icons to the AutoFill dialog. The icons were added in a separate CL.
Moves asynchronous access to the database inside the dialog (it now shows "Loading..." while db is being connected)
Also fixes memory leak.
BUG=36601
TEST=in the bug
Review URL: http://codereview.chromium.org/669076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/969005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=20318
TEST=Visit a url having auth credentials. Check history db to see url stored without credentials.
Review URL: http://codereview.chromium.org/1012001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41773 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35063
TEST=see bug
Review URL: http://codereview.chromium.org/1030001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/845003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
messages through the NetLog.
BUG=37421
Review URL: http://codereview.chromium.org/1052002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41768 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the size of the icon when the tab is in the background and the title
changes.
BUG=37333
TEST=none
Review URL: http://codereview.chromium.org/974003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
accepts the AutoFill InfoBar. Save a one-time initial profile to the WebDB if the user dismisses the InfoBar or the InfoBar closes.
BUG=38104,38096
TEST=AutoFillInfoBarDelegateTest
Review URL: http://codereview.chromium.org/974004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
- Drag and drop of browser actions wouldn't work properly from an incognito
window.
- Installing an extension from an incognito window raised a DCHECK.
Review URL: http://codereview.chromium.org/983004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Created a X-GOOGLE-TOKEN-only SaslHandler class for use by sync.
BUG=38034
TEST=manual
Review URL: http://codereview.chromium.org/904006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41761 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The main difference is that we are now using $1 - $9 instead of %s. This is more consistent with the C++ code as well.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/1045003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- coding style fixes for ivars
- fixed some 10.6 toolchain warnings from the xib
- provide custom getters for two properties to always return false when the matching controls are hidden.
- Autosize the window to handle any possible l10n now
- Make headers, buttons, and all by the stats/breakpad checkbox force the window to grow as needed.
- Wrap the stats/breakpad checkbox to the resulting width (it will never fit otherwise).
- Layout/shuffling things based on the views that get hidden (no other browsers to import from, not stats pref).
BUG=37743
TEST=text isn't clipped in any language
Review URL: http://codereview.chromium.org/995002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41758 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/790006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
extensions.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/898004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41749 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
resolution independence.
BUG=http://crbug.com/19476, http://crbug.com/36366
TEST=click the star in RI and the bubble should position itself correctly; status bubble should have adequate height for text
Review URL: http://codereview.chromium.org/851009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
into a base
LoginHandler class. As pointed out by erg, it would be cleaner to use a
separate controller class, but this simple refactor should make that easier.
Contributed by tonyg@chromium.org
BUG=14909
TEST=ui_tests gtest_filter=LoginPromptTest*
Review URL: http://codereview.chromium.org/834001
Patch from tonyg@chromium.org.
TBR=erg@chromium.org
Review URL: http://codereview.chromium.org/989004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41746 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Return the link role for the Link view.
Return the grouping role for BookmarkBarInstructionsView.
Support the link role in views accessibility types.
Updated browser views accessibility tests.
- Verify BrowserRootView accessibility info.
- Verify BrowserView accessibility info.
- Verify BookmarkBarView accessibility info.
- In TestViewAccessibilityObject don't SetAccessible name, we should be testing that this name is correctly set.
Set the accessible name for the application in BrowserRootView instead of OpaqueBrowserFrameView
BUG=36281
TEST=Verify bookmarks bar tree in AccExplorer32.exe
Review URL: http://codereview.chromium.org/652156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41744 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This currently only works on Posix, not windows.
Network changes are monitored, and the test is repeated each time interfaces
change (which is a subset of any IP addresses changing).
The test performed is performed on a worker thread, so latency should not
be an issue (even if we created much slower tests).
The current test appears to takes in the raneg of 50-100ms, and probably
(under the covers) does some reading from files).
BUG=25680
BUG=12754
r=wtc,eroman
Review URL: http://codereview.chromium.org/1006001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LoginHandler class. As pointed out by erg, it would be cleaner to use a
separate controller class, but this simple refactor should make that easier.
Contributed by tonyg@chromium.org
BUG=14909
TEST=ui_tests --gtest_filter=LoginPromptTest*
Review URL: http://codereview.chromium.org/834001
Patch from tonyg@chromium.org.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=MetricsServiceTest.CrashRenderers passes on Linux with and without breakpad.
Review URL: http://codereview.chromium.org/1010001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
FormField::ParseEmptyText which encapsulates matching an empty text field.
BUG=38264
TEST=FormStructureTest.HeuristicsSample6
Review URL: http://codereview.chromium.org/994002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enhanced screen bounds determination.
BUGS=none
TEST=Launch with --login-manager --login-screen-size=1024,600 and verify
that wizard screen is centered within the background window and the window
is centered within the monitor. Launch with --login-manager
--login-screen=network and change language. Verify that nothing craches with
segmentation fault.
Review URL: http://codereview.chromium.org/971002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=24390
TEST=When *not* fullscreen, menu items (under View in main menu and in app menu) should be "Enter Full Screen"; when fullscreen, they should be "Exit Full Screen"; menu items should still work; keyboard shortcuts should still work.
Review URL: http://codereview.chromium.org/1011002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
call PumpAuxiliaryLoops to run the 3 (!!:(!!) other loops associated with this thread. There was previously a race where
quit would be called and set a cancellation flag before the posted task would
get executed.
BUG=37771
Review URL: http://codereview.chromium.org/984001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to base::Time
BUG=http://code.google.com/p/chromium/issues/detail?id=37510
TEST=unit_tests --gtest_filter=geol*
Review URL: http://codereview.chromium.org/776001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- use localized strings for IME properties.
- use std::wstring in FormatInputLanguage() function so that an input language string is trimmed at a character boundary.
This CL depends on http://codereview.chromium.org/948001 .
BUG=none
TEST=manual.
Review URL: http://codereview.chromium.org/882004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
checkboxes other than the last one.
BUG=none
TEST=open the configuration dialog, click all checkboxes, verify that all IMEs are activated.
Review URL: http://codereview.chromium.org/1024002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual.
Review URL: http://codereview.chromium.org/1042001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the section name in System Options.
BUG=None
TEST=compiles
Review URL: http://codereview.chromium.org/935001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ukai
TEST=disabled
BUG=38225
Review URL: http://codereview.chromium.org/1002003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Replaced TestQueueing with one that makes more sense on ChromeOS.
BUG=33306
TEST=Replaced TestQueueing with TestManyNotifications.
Review URL: http://codereview.chromium.org/791004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
To workaround crbug.com/38266, implment TableModel as part of
LanguageConfigView, rather than a separate class.
TEST=manually
BUG=38266
Review URL: http://codereview.chromium.org/992004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
important return values are not ignored.
The macro used here, WARN_UNUSED_RESULT, takes effect only for GCC,
but that's enough since we have bots for all platforms.
Adding these warnings already detected some cases where a return value
was ignored. In some of them the test was trying to get the information
about success "some other way", in some it could sometimes confuse test
failure with test success.
TEST=ui_tests
BUG=none
Review URL: http://codereview.chromium.org/948002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The changes to passive_log_collector.cc are a speculative fix for crash seen in dom_perf.
TBR=willchan
Review URL: http://codereview.chromium.org/969004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41695 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
IBus IME engines send some strings written in English (e.g. IME names and IME property names) to its language bar module (i.e. Chrome). This change adds a function that converts the english string into a Chrome's resource ID, then converts the ID into a localized string, and returns it.
BUG=crosbug.com/1699
TEST=run the unittest
Review URL: http://codereview.chromium.org/948001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit r41641 because all the devtools interactive_ui_tests
are failing.
TBR=xiyuan
Review URL: http://codereview.chromium.org/1007004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1021002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41690 0039d316-1c4b-4281-b951-d872f2087c98
|