summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Linux: make the "change proxy settings" button able to start several proxy ↵mdm@chromium.org2009-08-201-47/+87
| | | | | | | | | | | | config utilities. Currently it still only ever starts gnome-network-properties but it is now easy to update. BUG=none TEST=none Review URL: http://codereview.chromium.org/174106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23910 0039d316-1c4b-4281-b951-d872f2087c98
* Mock the LinkDoctor for tests. Should greatly decrease ErrorPage test flakiness.phajdan.jr@chromium.org2009-08-208-49/+108
| | | | | | | | | | | Not getting rid of WaitForTitleMatching because I have to add few more calls to the automation framework (http://crbug.com/19395) to wait properly after navigating back and forward. TEST=Covered by ui_tests and browser_tests. http://crbug.com/18365, http://crbug.com/19361 Review URL: http://codereview.chromium.org/174179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23906 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r23840 - Also return bookmark index through bookmarks API.kuchhal@chromium.org2009-08-201-1/+4
| | | | | | Review URL: http://codereview.chromium.org/173155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23903 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Update the tooltip state whenever the tab is resized.jhawkins@chromium.org2009-08-203-14/+41
| | | | | | | | BUG=19754 TEST=Open a new window and browse to google.com. Hover the mouse over the tab and notice that the tooltip does not display. Open enough new tabs so that the google.com tab title is ellipsized. Hover the mouse over the tab and notice that the tooltip displays. Review URL: http://codereview.chromium.org/174188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23899 0039d316-1c4b-4281-b951-d872f2087c98
* Disable some blocked popup container tests to green the tree.estade@chromium.org2009-08-201-5/+5
| | | | | | | | | | | | I will fix these later today. http://code.google.com/p/chromium/issues/detail?id=19881 TBR=brg Review URL: http://codereview.chromium.org/174182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23895 0039d316-1c4b-4281-b951-d872f2087c98
* Disable mute/unmute when media does not have an audio track.scherkus@chromium.org2009-08-201-2/+7
| | | | | | | | | BUG=18970 TEST=test matrix videos ending in 0 should have mute context menu disabled Review URL: http://codereview.chromium.org/174018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23889 0039d316-1c4b-4281-b951-d872f2087c98
* Don't abandon or cancel in-progress field editors when the window closes.pinkerton@chromium.org2009-08-201-5/+12
| | | | | | | | BUG=17864 TEST=contents of fields are saved regardless of in-progress editing. Review URL: http://codereview.chromium.org/174166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23887 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark STAR bubble.jrg@chromium.org2009-08-2021-12/+802
| | | | | | | | | | | | | | | | | | | BUG=http://crbug.com/14929 Sample image attached to bug. TEST=Click the STAR to add a bookmark. Watch bubble come up. Title is "Bookmark added!" Confirm fields are OK. Switch tabs and see bubble go away. Click STAR again. Watch bubble come up. Title is "Bookmark" Make sure all the buttons work (Edit, Close, Remove). Make sure you can change the title and parent folder. Make sure "Choose another folder..." opens edit window. Review URL: http://codereview.chromium.org/171016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23886 0039d316-1c4b-4281-b951-d872f2087c98
* Remove include of IPC headers from headers they crept into. This slows down ↵jam@chromium.org2009-08-206-3/+9
| | | | | | | | the build. Review URL: http://codereview.chromium.org/174148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23884 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: more interactive tests porting.estade@chromium.org2009-08-206-69/+142
| | | | | | | | | | The most noteworthy change here is the implementation of SendMouseMove() and SendMouseClick() in ui_controls. I've combed the interwebs and I don't think it's possible to figure out the GdkWindow that is showing for a given (x,y) coordinate pair (except perhaps by delving into X), so we have to just send clicks to wherever the pointer lies. This is unfortunate in that it means we have to move the pointer, wait for it to get where it's going, and only then make the click. But on the bright side there's this super helpful function called gdk_display_warp_pointer() which makes moving the mouse a breeze. BUG=19076 Review URL: http://codereview.chromium.org/174113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23880 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Theme: Fix corner offsets on the find bar.erg@google.com2009-08-201-5/+5
| | | | | | | | http://crbug.com/19811 Review URL: http://codereview.chromium.org/173140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23879 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile errorpkasting@chromium.org2009-08-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23878 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the Bookmarks ExtensionAPITest becuase it is flaky.brettw@chromium.org2009-08-201-1/+2
| | | | | | Review URL: http://codereview.chromium.org/173149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23877 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize all new booleans in unittest constructor.pkasting@chromium.org2009-08-201-0/+2
| | | | | | | | | TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/173148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23876 0039d316-1c4b-4281-b951-d872f2087c98
* Fix uninitialized memory read in autocomplete tests.brettw@chromium.org2009-08-201-0/+1
| | | | | | Review URL: http://codereview.chromium.org/173142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23872 0039d316-1c4b-4281-b951-d872f2087c98
* Close the autocomplete popup when the user tries to move thetony@chromium.org2009-08-202-9/+8
| | | | | | | | | | | | | window with the custom frame, when the user tries to resize the window with the custom frame, and when the window switches between maximized/restored state. BUG=19636 Review URL: http://codereview.chromium.org/174109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23866 0039d316-1c4b-4281-b951-d872f2087c98
* Removed personalization_strings.h and moved all the strings into ↵idana@chromium.org2009-08-208-122/+68
| | | | | | | | | | | | | generated_resources.grd. I'll take care of the Setup Wizard strings/resources in my next patch. BUG=none TEST=none Review URL: http://codereview.chromium.org/173069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23863 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gcc warning about possible unused variable experienced with Apple gcc 4.2mark@chromium.org2009-08-201-2/+2
| | | | | | | in an -O3 experiment. Review URL: http://codereview.chromium.org/173124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23860 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to minimize omnibox flicker, without increasing lag too much.pkasting@chromium.org2009-08-202-96/+151
| | | | | | | | | | This also updates a bunch of comments, mostly to keep terminology like "results" and "matches" consistent, occasionally to fix grammar or other issues. BUG=18369 TEST=none Review URL: http://codereview.chromium.org/173031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23859 0039d316-1c4b-4281-b951-d872f2087c98
* Check for NULL Profile::GetDefaultRequestContext().ericroman@google.com2009-08-202-10/+29
| | | | | | | | | | | | | | | | | | | This papers over a chrome-bot crash. The problem is that the ChromeURLRequestContexts have a split life between the UI thread and IO thread. Although conceptually they live on the IO thread, they are lazy-initialized on the UI thread, and are contained by a Profile which also lives on the UI thread. What happens in this crash, is ResolveProxyMsgHelper (the class which handles IPCs from the plugin process for proxy resolving) calls Profile::GetDefaultRequestContext() to get at the main URLRequestContext from the IO thread. Well, during the shutdown sequence, ~ProfileImpl NULLs the default request context before the IO thread is torn down, so consumers on the IO thread may get NULL. Or even worse, might get a non-NULL pointer to a request context that has already been freed. With this patch I hack past the NULL case. Really we need a proper solution to managing URLRequestContexts split personality... I did a quick survey of the code and found other consumers that use GetDefaultRequestContext from the IO thread, so this bug may be happening elsewhere. BUG=http://crbug.com/18358 Review URL: http://codereview.chromium.org/172085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23854 0039d316-1c4b-4281-b951-d872f2087c98
* Move MediaPlayerAction out of context_menu.h into webview.h since it's ↵ajwong@chromium.org2009-08-202-0/+2
| | | | | | | | really only used by webview. Review URL: http://codereview.chromium.org/174143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23850 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the extension's "Current Version" file.mpcomplete@chromium.org2009-08-2010-281/+240
| | | | | | | | | | | | The entire manifest.json value is now stored in the prefs file. This will allow for quick extension checks on startup. BUG=18293 TEST=Make sure installing/upgrading/uninstalling extensions works as expected. Review URL: http://codereview.chromium.org/174036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23848 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Also return bookmark index through bookmarks API."kuchhal@chromium.org2009-08-201-4/+1
| | | | | | | | Revert r23840 Review URL: http://codereview.chromium.org/173133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23847 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "During uninstall if Chrome is set as default,"kuchhal@chromium.org2009-08-205-222/+104
| | | | | | | | | | allow user to choose another browser as default." reverting r23841 Review URL: http://codereview.chromium.org/173131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23845 0039d316-1c4b-4281-b951-d872f2087c98
* Disable two tests while I investigate why Purify doesnt like them.kuchhal@chromium.org2009-08-201-2/+2
| | | | | | | | BUG=19820 Review URL: http://codereview.chromium.org/174153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23844 0039d316-1c4b-4281-b951-d872f2087c98
* During uninstall if Chrome is set as default, allow user to choose another ↵kuchhal@chromium.org2009-08-205-104/+222
| | | | | | | | | | | browser as default. BUG=14023 TEST=Make sure the option of choosing a different browser shows up during uninstall (and works as intended) iff chrome is set as default browser. Review URL: http://codereview.chromium.org/172080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23841 0039d316-1c4b-4281-b951-d872f2087c98
* Also return bookmark index through bookmarks API.kuchhal@chromium.org2009-08-201-1/+4
| | | | | | Review URL: http://codereview.chromium.org/173074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23840 0039d316-1c4b-4281-b951-d872f2087c98
* Fix theme install on 64 bit chromium builds.tony@chromium.org2009-08-201-4/+4
| | | | | | | | | | Extension signature sizes are always 4 bytes, not variable depending on platform. Review URL: http://codereview.chromium.org/173104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23837 0039d316-1c4b-4281-b951-d872f2087c98
* Make new FTP the default on Windows. Use the --wininet-ftpwtc@chromium.org2009-08-201-8/+7
| | | | | | | | | | | | command-line switch to select the old WinInet-based FTP implementation. R=phajdan.jr BUG=http://crbug.com/4965 TEST=none Review URL: http://codereview.chromium.org/173099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23836 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Attempt #2 at updating PRIMARY selection on Ctrl-C in omnibox.derat@chromium.org2009-08-202-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r23596 was the original attempt; r23714 reverted it. Using gtk_text_buffer_copy_clipboard() gives the GtkTextBuffer ownership of the GtkClipboard and appears to prevent it from unhighlighting its text. Tested as follows: 1. Select text in webkit and hit Ctrl-C; check that both the PRIMARY and CLIPBOARD selections contain it. 2. Click in the omnibox. All of the text gets highlighted. Check that the PRIMARY selection contains the omnibox text and the CLIPBOARD selection contains the webkit text. 3. Type Ctrl-C and confirm that the CLIPBOARD selection now contains the omnibox text. 4. Copy webkit text back to both selections. 5. Type Ctrl-L. The omnibox text gets highlighted but both selections still contain the webkit text. 6. Type Ctrl-C and confirm that both selections now contain the omnibox text. 7. Try hitting Ctrl-C again while the omnibox text is on the CLIPBOARD selection to make sure that a bizarre GTK crash doesn't occur (see comment in code). BUG=19648 TESTED=see above Review URL: http://codereview.chromium.org/173098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23834 0039d316-1c4b-4281-b951-d872f2087c98
* Remove personalization.h/cc by putting things in final resting placestim@chromium.org2009-08-2014-378/+137
| | | | | | Review URL: http://codereview.chromium.org/173085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23833 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the compile for TOOLKIT_VIEWS.phajdan.jr@chromium.org2009-08-201-1/+1
| | | | | | | | TBR=tony Review URL: http://codereview.chromium.org/174146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23829 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Reapply r23734, fixing destruction order issues.erg@google.com2009-08-203-9/+131
| | | | | | | | http://crbug.com/18856 Review URL: http://codereview.chromium.org/174100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23828 0039d316-1c4b-4281-b951-d872f2087c98
* Add (incomplete) UI for creating application shortcuts on Linuxphajdan.jr@chromium.org2009-08-203-4/+123
| | | | | | | | | TEST=none http://crbug.com/17251 Review URL: http://codereview.chromium.org/171082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23827 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Make sure that the window tooltip is within the browser viewport.arv@google.com2009-08-201-8/+18
| | | | | | | | | | | | | | BUG=18534 TEST=Open a new window. Open several tabs in this window and then close the window. An item representing this window should be shown on the new tab page. Hover this item (or tab to it). The tooltip should be repositioned so that it is not clipped by the window viewport. Review URL: http://codereview.chromium.org/173100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23825 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Remove the DownloadsHandler from the new tab page.arv@google.com2009-08-202-16/+0
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/174099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23824 0039d316-1c4b-4281-b951-d872f2087c98
* Do extensions update manifest XML parsing in a sandboxed process.asargent@chromium.org2009-08-207-423/+222
| | | | | | | | | | | | | | | | This involves moving the xml parsing code from static functions in extension_updater.cc to a UpdateManifest class, and switching from logging any errors directly to collecting them up and passing them across the IPC channel. BUG=http://crbug.com/12677 TEST=extensions auto-update should still work correctly Review URL: http://codereview.chromium.org/164541 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23822 0039d316-1c4b-4281-b951-d872f2087c98
* Various omnibox UI fixes:rohitrao@chromium.org2009-08-203-37/+80
| | | | | | | | | | | | | * Truncate match contents to 70% of the available width, reserving 30% for the description. * Animate omnibox shrinkage. BUG=14898 TEST=Omnibox should animate smaller, but not bigger/opened/closed. Match description should always be partially visible, if present. Review URL: http://codereview.chromium.org/173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23821 0039d316-1c4b-4281-b951-d872f2087c98
* Change default memory model from MEDIUM to HIGH.mbelshe@google.com2009-08-201-1/+1
| | | | | | | | | | | | | | | This will eliminate the workingsetsize reductions that we currently do in the browser. Memory usage will increase by about 25%. But it should alleviate swapping issues that some users are seeing. BUG=none TEST=none Review URL: http://codereview.chromium.org/173057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23818 0039d316-1c4b-4281-b951-d872f2087c98
* Essentially revert r16636. We get no speedup from using CIImage and we are ↵avi@chromium.org2009-08-201-14/+3
| | | | | | | | | | | susceptible to random leaks. BUG=http://crbug.com/18661 TEST=throbbers should work just fine Review URL: http://codereview.chromium.org/171110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23813 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 23805.abarth@chromium.org2009-08-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23807 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the XSSAuditor by default. Please watch out for compatibility issues.abarth@chromium.org2009-08-201-1/+1
| | | | | | Review URL: http://codereview.chromium.org/174013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23805 0039d316-1c4b-4281-b951-d872f2087c98
* Splits the menu classes into individual files in anticipation ofsky@chromium.org2009-08-207-7/+16
| | | | | | | | | | | porting them. BUG=none TEST=make sure to thorougly test bookmark menus on windows. Review URL: http://codereview.chromium.org/173091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23801 0039d316-1c4b-4281-b951-d872f2087c98
* Make unit_tests UtilityProcessHostTest use the helper app on the Mac.mark@chromium.org2009-08-201-5/+5
| | | | | | | | | | BUG=none, not worth it for this TEST=unit_tests '--gtest_filter=UtilityProcessHostTest*' runs Chromium Helper, not Chromium. No application icon should appear in the dock during this test. Review URL: http://codereview.chromium.org/174061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23792 0039d316-1c4b-4281-b951-d872f2087c98
* Try to shutdown the browser more peacefully before using more brutal methods.phajdan.jr@chromium.org2009-08-191-17/+17
| | | | | | | | | | | | | Also, do proper cleanup before browser shutdown in MetricsService UI test. I hope this will reduce the flakiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/173023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23780 0039d316-1c4b-4281-b951-d872f2087c98
* Support navigating to absolute index through automation.amit@chromium.org2009-08-194-9/+49
| | | | | | | | | | | | Also, send more information in AutomationMsg_DidNavigate BUG=none TEST=none Review URL: http://codereview.chromium.org/165333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23776 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Limit the dragged item to the viewport boundaries.arv@google.com2009-08-191-2/+17
| | | | | | | | | | | | BUG=16361, 15099 TEST=Drag the thumbnails on the new tab page and make sure that the visual representation is never clipped. Also make sure that no new scrollbars show up due to dragging. Review URL: http://codereview.chromium.org/173090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23775 0039d316-1c4b-4281-b951-d872f2087c98
* When importing a lot of history, the NOTREACHED in ↵vandebo@chromium.org2009-08-193-2/+22
| | | | | | | | | | | VisitedLinkMaster::AddFingerprint is reached. This causes an exit on debug builds, for production builds part of the history would silently not get imported. The root cause is that the initial size of the hash table only considers one of the two sources of input. BUG=none TEST=VisitedLinkTest::BigImport Review URL: http://codereview.chromium.org/164419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23773 0039d316-1c4b-4281-b951-d872f2087c98
* Cache the left and right tab curve images. We were spending a lottony@chromium.org2009-08-192-33/+73
| | | | | | | | | | | | | | | | of time regenerating the images for all the tabs. This speeds up the time needed to paint a tab by about 30%. This helps a bit, but we're still slow. We need to calculate damage rects and only redraw damage rects (most of the remaining time is spent on painting to the canvas now). BUG=15872 Review URL: http://codereview.chromium.org/174095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23771 0039d316-1c4b-4281-b951-d872f2087c98
* Renable ShowModalDialogTest test with a longer timeout. Until we have a way ↵jam@chromium.org2009-08-191-4/+5
| | | | | | | | of executing JS in the renderer from a ui test, we'll have to use hacks like this. Review URL: http://codereview.chromium.org/165090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23770 0039d316-1c4b-4281-b951-d872f2087c98