| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
compact location bar menu to experimental and place both items
there. The two are mutually exclusive, so toggling one untoggles the
other. Also makes the status bubble not overlap the tabstrip for side tabs.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2340001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45261
TEST=none
Review URL: http://codereview.chromium.org/2319001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In r47478, I removed the hbox that the page and app menus were in because I
though that with the new left/right toolbar boxes, they were unnecessary.
But they're needed to group the two buttons together with no space between
them, but with padding on the right.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2375002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(This way don't need to give separate instructions on bug reports depending on what version of chrome they are using, can still just say "copy dump from about:net-internals")
Review URL: http://codereview.chromium.org/2365002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=45157
TEST=Try adding a context menu item with the chrome.experimental.contextMenu
API, and then adding another one whose parentId is set to the id of the first
one. This should now succeed.
Review URL: http://codereview.chromium.org/2296002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=3650
TEST=none
Review URL: http://codereview.chromium.org/2343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
features to work on, but it's in a usable state.
When an extension is installed that specifies an omnibox keyword in its manifest, we add that keyword to the user's list of Search Engines. The user can then edit this keyword later.
I'm leveraging most of the original search engine keyword code. An extension keyword has a special URL that identifies it as an extension keyword. There is some special case code to treat these keywords slightly differently throughout
the omnibox code.
BUG=38884
Review URL: http://codereview.chromium.org/2078021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45271
TEST=none
Review URL: http://codereview.chromium.org/2343001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2345002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=45124
Review URL: http://codereview.chromium.org/2263005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add test that verifies web-page to chrome communication.
BUG=cros/3177
TEST=out/Debug/browser_tests --gtest_filter=AccountScreenTest.TestSchemeInspector
Review URL: http://codereview.chromium.org/2291002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
correctness.
BUG=none
TEST=n/a
Review URL: http://codereview.chromium.org/2273003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Querying the plugin path and actual mime type is moved from creation of the
WebPluginDelegate to creation of the WebPlugin. This cleaned up some code.
R=jam
BUG=45289
TEST=none
Review URL: http://codereview.chromium.org/2262002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding initial implementation of the PartnerCustomization classes.
BUG=chromiumos:3176
TEST=Run out/Debug/unit_tests. Run out/Debug/chrome --login-manager --startup-manifest=./chrome/browser/chromeos/testdata/startup_manifest.json. There should be no asserts.
TBR=avayvod
Review URL: http://codereview.chromium.org/2333004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Select a language with keyboard layouts in the IME option window.
Review URL: http://codereview.chromium.org/2309001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
event on Windows.
This change just adds ImeInput::CancelIME() and use it when receiving an IME_CANCEL_COMPOSITION event. (I'm not sure it works well with all IMEs, though.)
BUG=9883
TEST=none
Review URL: http://codereview.chromium.org/2099012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Adding accessibility setting to System options
Review URL: http://codereview.chromium.org/2127014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium OS did not persist sync cookies.
TEST=included unit tests
BUG=http://crosbug.com/2786
Review URL: http://codereview.chromium.org/2124020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
The bad macro caused the test to be wrongly enabled on windows.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
widget not at the root of the UI heirarchy. Also contains misc fixes for setting correct name/role for controls found in the Options dialog.
BUG=9621
TEST=none
Review URL: http://codereview.chromium.org/2174002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Disable UnloadTest.BrowserCloseTabWhenOtherTabHasListener on windows because it is failing.
BUG=45281
TEST=tree is green
Review URL: http://codereview.chromium.org/2279006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Split WorkerService CreateWorker into distinct methods for 'shared' vs 'dedicated' workers.
* Include additional appcache params in WorkerService CreateSharedWorker and CreateDedicatedWorker methods.
* Store those additional params in WorkerInstance object.
* Pass those additional params to the worker process.
* Use those additional params when initiating the appcache host for the worker when calling SelectCacheForWorker and SelectCacheForSharedWorker.
* Add browser process message handlers and dispatching for the SelectCacheForWorker and SelectCacheForSharedWorker IPC messages.
* Runtime enable the appcache feature in the worker processes.
BUG=39368
TEST=manual for now, but i need to create layout tests for this
Review URL: http://codereview.chromium.org/2238001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2303002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to use asynchronous interfaces.
BUG=26730
TEST=unittest
Review URL: http://codereview.chromium.org/2168004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=14428
TEST=TabRestoreUITest.*
Review URL: http://codereview.chromium.org/2228004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and disabled for windows.
Contributed by tessamac@chromium.org
BUG=43575
TEST=none
Review URL: http://codereview.chromium.org/2224004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
hidden would leave blank spaces instead of re-arranging the remaining ones.
BUG=42792
TEST=Manual
Review URL: http://codereview.chromium.org/2286003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RedirectTest.ClientServerServer passes locally so I'm trying reenabling it.
file a bug for RedirectTest.ClientCancelledByNewNavigationAfterProvisionalLoad .
file a bug for SessionHistoryTest.CrossFrameFormBackForward
mark SessionHistoryTest.LocationReplace as failing rather than disabled
fix UnloadTest.BrowserCloseTabWhenOtherTabHasListener (the popup was being caught by the popup blocker)
TEST=buildbots
BUG=12913
Review URL: http://codereview.chromium.org/2264001
TBR=estade@chromium.org
Looks like UnloadTest.BrowserCloseTabWhenOtherTabHasListener still unhappy on bot?
http://buildbot.jail.google.com/buildbot/chromium/builders/XP%20Tests/builds/20319/steps/ui_tests/logs/stdio
[----------] Global test environment tear-down
[==========] 315 tests from 72 test cases ran. (1089094 ms total)
[ PASSED ] 308 tests.
[ FAILED ] 7 tests, listed below:
[ FAILED ] MouseLeaveTest.FLAKY_TestOnMouseOut
[ FAILED ] HistoryTester.FAILS_VerifyHistoryLength2
[ FAILED ] HistoryTester.FAILS_VerifyHistoryLength3
[ FAILED ] WorkerTest.FLAKY_WorkerHttpLayoutTests
[ FAILED ] UnloadTest.BrowserCloseTabWhenOtherTabHasListener
[ FAILED ] SessionHistoryTest.FAILS_LocationReplace
[ FAILED ] SessionHistoryTest.FLAKY_HistorySearchXSS
Review URL: http://codereview.chromium.org/2225009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Waiting for proxy tunnel..."
Add a message for waiting for the SSL Handshake to complete:
"Establishing secure connection..."
Also make the waiting messages work for SPDY connections.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2262003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The mcphee.com site demonstrates two issues. One is label scraping for forms that use <dl> <dt> and <dd> elements to partition labels and input elements. The other is dynamic html where JavaScript is used to manipulate the form elements dynamically as the user proceeds through checkout. These changes address both. Label scraping is implemented for <dl> <dt> and <dd> elements. Form filling, both at the FormManager and AutoFillManager levels are now more robust in the face of changing form structure between the time of page load and form fill.
This does not "fix" the mcphee page though, as we still do not fill the elements that are added to the page after the initial page load.
BUG=44323
TEST=AutoFillManagerTest.FormChangesRemoveField, AutoFillManagerTest.FormChangesAddField, FormManagerTest.LabelsInferredFromTableCellNested, FormManagerTest.LabelsInferredFromDefinitionList, FormManagerTest.FillFormChangedFormDataFields, manual tests using mphee.html and mcphee2.html sample files attached to bug report and original bug steps using live mcphee checkout.
Review URL: http://codereview.chromium.org/2240004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
classes.
BUG=chromiumos:3176
TEST=Run out/Debug/unit_tests. Run out/Debug/chrome loginmanager startupmanifest=./chrome/browser/chromeos/testdata/startup_manifest.json. There should be no asserts.
Review URL: http://codereview.chromium.org/2101021
TBR=denisromanov@chromium.org
Build error below. I don't immediately see how this CL caused the
problem, but the only other things on the blamelist are valgrind
suppressions which don't change code.
Linking...
LINK : warning LNK4224: /OPT:NOWIN98 is no longer supported; ignored
Creating library C:\b\slave\chromium-rel-builder\build\src\build\Release\lib\npchrome_frame.lib and object C:\b\slave\chromium-rel-builder\build\src\build\Release\lib\npchrome_frame.exp
chrome_tab.obj : error LNK2001: unresolved external symbol "unsigned int (__stdcall* ATL::g_pfnGetThreadACP)(void)" (?g_pfnGetThreadACP@ATL@@3P6GIXZA)
chrome_frame_ie.lib(chrome_active_document.obj) : error LNK2001: unresolved external symbol "unsigned int (__stdcall* ATL::g_pfnGetThreadACP)(void)" (?g_pfnGetThreadACP@ATL@@3P6GIXZA)
chrome_frame_npapi.lib(utils.obj) : error LNK2001: unresolved external symbol "unsigned int (__stdcall* ATL::g_pfnGetThreadACP)(void)" (?g_pfnGetThreadACP@ATL@@3P6GIXZA)
C:\b\slave\chromium-rel-builder\build\src\build\Release\servers\npchrome_frame.dll : fatal error LNK1120: 1 unresolved externals
Error executing link.exe (tool returned code: 1120)
2 build system warning(s):
- VS settings folder not found
- Interoperability reenabled
Review URL: http://codereview.chromium.org/2224008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromiumos:3176
TEST=Run out/Debug/unit_tests. Run out/Debug/chrome --login-manager --startup-manifest=./chrome/browser/chromeos/testdata/startup_manifest.json. There should be no asserts.
Review URL: http://codereview.chromium.org/2101021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This should help reduce confusion when reading logs that have a mixture of passive and actively captured events (since there may have been some loss of information along the boundaries).
Review URL: http://codereview.chromium.org/2094020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- RedirectTest.ClientServerServer passes locally so I'm trying re-enabling it.
- file a bug for RedirectTest.ClientCancelledByNewNavigationAfterProvisionalLoad .
- file a bug for SessionHistoryTest.CrossFrameFormBackForward
- mark SessionHistoryTest.LocationReplace as failing rather than disabled
- fix UnloadTest.BrowserCloseTabWhenOtherTabHasListener (the popup was being caught by the popup blocker)
TEST=buildbots
BUG=12913
Review URL: http://codereview.chromium.org/2264001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Can't be sure these aren't flaky, but surely they should not be DISABLED.
BUG=21321,14731,19394
Review URL: http://codereview.chromium.org/2230002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also make one execute significantly faster.
BUG=45021
TEST=they pass consistently
Review URL: http://codereview.chromium.org/2296001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
questions can contain non-ASCII characters.
They lead the error message to be garbled and an non-ASCII path to turn
empty.
BUG=44145,45009
TEST=See bugs
Review URL: http://codereview.chromium.org/2148004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LoginScreen.
NewUserView will be reused for other user login on images login screen.
TEST=No visible changes.
BUG=crosbug.com/2320
Review URL: http://codereview.chromium.org/2253004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
will be enabled at 50% of chance.
BUG=45022
TEST=Use command-line flag --chrome-sxs to force the browser as SxS, go to gmail.com,
login/logout, check about:histograms, you should see xx_spdytrial_xxx histograms.
Review URL: http://codereview.chromium.org/2188001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeOS needs to be able to show notification before a user logged in (such as battery, update notification).
Currently, all attempt to show notification results in crash because BalloonHost assume all profile has
extension service, which is not the case for login profile that ChromeOS uses.
John, I didn't ifdef'ed because BalloonHost is not assuming extension_function_dispacher is allways present.
Please let me now if I should limit this change to OS_CHROMEOS.
BUG=http://crosbug.com/3491
TEST=none
Review URL: http://codereview.chromium.org/2221003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use separate tints for icons in the omnibox and the other icons like page/app menu. We don't pick the tinting color to be the skyline accent color, but instead create one based off the accent color and the contrast between the window background and the label color.
BUG=43853
TEST=1) Darklooks should have white icons (both the page icons and in the omnibox) 2) DarkRoom should have page/app menu icons that match the label color on the "Other Bookmarks" button while the icons in the omnibox which are on a white background should visually be more orange and contrast with the white. 3) Ambiance/Radiance should have icons that contrast with their background instead of fading into it. 4) New Wave should have dark rust orange instead of light neon orange (again, contrasting with the background).
Review URL: http://codereview.chromium.org/2266004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We use to not need them since we would simply overinstall them all the time.
But now that overinstall is allowed and reset the extension state (e.g., close and reopen the background page), we can't simply install exploded extensions at will anymore, we must first check if it was already installed or not (which means GetEnabledExtensions must return them) and only install them when they are not already there.
BUG=0
TEST=none
Review URL: http://codereview.chromium.org/2303004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows builds more similar to linux/mac, which already treat signed/
unsigned equality comparisons as warnings (and hence errors).
BUG=44471
TEST=none
Review URL: http://codereview.chromium.org/2222002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to FAILS
BUG=38572,45168
TEST=N/A
Review URL: http://codereview.chromium.org/2280005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uses libgps / gpsd to get gps fixes. Modified the location arbitrator to use GPS instead of network location provider.
Current version requires manual code edit to enable (ENABLE_LIBGPS_LOCATION_PROVIDER) See http://docs.google.com/View?id=dfbnm49n_1g8ktswhr for demo instructions (work in progress)
BUG=43868
TEST=Built with ENABLE_LIBGPS_LOCATION_PROVIDER and used gpsd's gpsfake script (see linked doc above)
Review URL: http://codereview.chromium.org/2032010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45203
TEST=as described in the bug
Review URL: http://codereview.chromium.org/2265003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45050
TEST=see bug
Review URL: http://codereview.chromium.org/2285001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2224003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3601
TEST=Log in as new user, confirm mouse is faster
(can check with "synclient -l" on the command line...MaxSpeed
should be "1")
TBR:chocobo
Review URL: http://codereview.chromium.org/2296003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Remove modify_database flag.
Make sure we delete data structures on the WebKit thread.
Handle single process mode.
Review URL: http://codereview.chromium.org/2125017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48387 0039d316-1c4b-4281-b951-d872f2087c98
|