summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Fix handling of 'Use system proxy settings' policygfeher@chromium.org2010-12-086-15/+54
| | | | | | | | | | | | | | | | The problem is that using system proxy settings is triggered when the internal proxy prefs of Chrome are set to their default values. Unfortunately it is possible that these prefs are set to their defaults but they are not controlled by the default pref store. This CL fixes this by checking for the default values and not only for the origin of prefs. A longer term solution is described in http://crbug.com/65732 BUG=65736 TEST=manual Review URL: http://codereview.chromium.org/5664001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68591 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in ExtensionPrefTestbattre@chromium.org2010-12-082-3/+40
| | | | | | | | | BUG=65642 TEST=look at valgrind build bots, introduced new unit test Review URL: http://codereview.chromium.org/5511010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68590 0039d316-1c4b-4281-b951-d872f2087c98
* Enable DevToolsSanityTest.TestProfilerTab.mnaganov@chromium.org2010-12-081-2/+1
| | | | | | | | | | | | Works OK locally, let's see what will happen on bots. TBR=pfeldman@chromium.org BUG=54592 TEST=DevToolsSanityTest.TestProfilerTab Review URL: http://codereview.chromium.org/5608006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68585 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new GetInstance() method for singleton classes, take 2.satish@chromium.org2010-12-083-6/+6
| | | | | | | | | | | | | | | | | | This is a small step towards making all singleton classes use the Singleton<T> pattern within their code and not expect the callers to know about it. This CL includes all files except those under chrome/browser, chrome/net, chrome/service and third_party/WebKit (these will be done in future CLs). Suggested files to focus for reviewers: - joi@ for files under src/ceee - tommi@ for files under src/chrome_frame - maruel@ for the rest of the files. BUG=65298 TEST=all existing tests should continue to pass. Review URL: http://codereview.chromium.org/5581008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68577 0039d316-1c4b-4281-b951-d872f2087c98
* Tracking down flakiness in PrepopulateRespectBlank.finnur@chromium.org2010-12-081-1/+3
| | | | | | | | | | | | | | | It seems the problem with the crash_service window eating input has been eliminated, but there is still some flakiness left. My traces indicate that probably no window has focus, so lets try to force the browser window to have focus, like we do in the browser focus tests. BUG=62937 TEST=Fixing a test. Review URL: http://codereview.chromium.org/5566006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68576 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up pref change notification handling.mnissler@chromium.org2010-12-0825-1411/+1427
| | | | | | | | | | | | | | | This is a complete overhaul of PrefValueStore, PrefStore, PrefNotifier, and PrefService. Specifically: - Add an observer interface to PrefStore that can be used to notify the upper layers of the pref system about value changes. Currently, it's unused mostly, but that'll change when we refactor ExtensionPrefStore and ConfigurationPolicyPrefStore. - Make PrefNotifier be a dependency of PrefValueStore. That helps in keeping the pref change detection handling local to PrefValueStore. - Clean up related unit tests, removing redundant mocks and gmockify others. BUG=64893 TEST=Compiles and passes tests Review URL: http://codereview.chromium.org/5441002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68574 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed minor atomicity issue in PrefProxyConfigService::GetLatestProxyConfig ↵battre@chromium.org2010-12-083-15/+15
| | | | | | | | | | | | | and remaining comments of 5005002. See http://codereview.chromium.org/5005002. BUG=48930 TEST=none Review URL: http://codereview.chromium.org/5537002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68573 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser crash in ExtensionPrefs.finnur@chromium.org2010-12-081-0/+2
| | | | | | | | | | | | | | | | | | I am unable to repro this, despite numerous attempts, but from looking at the crash dump it seems that we get a valid ExtensionPrefs pointer but a NULL DictionaryValue pointer. Looking at the other callers for GetExtensionPref shows that they all expect a potentially NULL result, for example in GetExtensionState (which even documents that it can be NULL for --load-extension). I think a NULL check here is therefore in order too. BUG=64853 TEST=QA will need to test this manually because I can't get it to crash for me. Review URL: http://codereview.chromium.org/5601005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68572 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Fixed crash on XMPP reconnectionakalin@chromium.org2010-12-086-58/+133
| | | | | | | | | | | | | | | Tied lifetime of invalidation packet callback to ChromeInvalidationClient. Added some tests for ChromeInvalidationClient. Created FakeBaseTask class for testing. BUG=64652 TEST=New unittests Review URL: http://codereview.chromium.org/5625010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68571 0039d316-1c4b-4281-b951-d872f2087c98
* Mark BrowserKeyEventsTest.ReservedAccelerators as flaky.phajdan.jr@chromium.org2010-12-081-1/+2
| | | | | | | | | | | TBR=suzhe BUG=65847 TEST=interactive_ui_tests Review URL: http://codereview.chromium.org/5572006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68570 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up automation provider side:phajdan.jr@chromium.org2010-12-084-215/+145
| | | | | | | | | | | | | | | - remove unneeded code - get rid of poorly written code like private inheritation - simplify the thread-related code - remove a few fatal assertions from test code - minor style cleanups BUG=none TEST=none Review URL: http://codereview.chromium.org/5510002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68568 0039d316-1c4b-4281-b951-d872f2087c98
* Adds NULL checks to AeroPeekManager.hbono@chromium.org2010-12-081-9/+25
| | | | | | | | | | This change just adds NULL checks to prevent crashes when TabStipModel calls its observers with NULL pointers. BUG=63854 TEST=launch Chromium with a '--enable-aero-peek-tabs' option. Review URL: http://codereview.chromium.org/5275004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68566 0039d316-1c4b-4281-b951-d872f2087c98
* Fix support for --disable-extensions flag.jstritar@chromium.org2010-12-083-17/+60
| | | | | | | | | BUG=65137 TEST=ExtensionsServiceTest Review URL: http://codereview.chromium.org/5533005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68560 0039d316-1c4b-4281-b951-d872f2087c98
* Re-design the phishing interstitial page. The change is mostly about: make ↵lzheng@chromium.org2010-12-082-13/+49
| | | | | | | | | | | | | | | the 'go back' button big and green in a central place, and put the 'proceed' into a link at the bottom of the page. sample screenshot: https://docs1.google.com/document/d/1peJV0yfVSgjbdydInshy8FSU2Q9kUivTtdyMpIDIP1w/edit?authkey=CLCQl9sE# Patch from Ke Wang <kewang@google.com> BUG=60813 TEST=unit_tests. To see the UI change, start the browser and try load some sites in malware blacklist. Review URL: http://codereview.chromium.org/5560003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68548 0039d316-1c4b-4281-b951-d872f2087c98
* [Chrome OS] Richer error reporting for SignedSettings subsystemcmasone@chromium.org2010-12-088-89/+168
| | | | | | | | | | | | | Callers need to be able to distinguish between settings ops that fail for key/signature-related reasons from ops that fail simply because a value is not found. BUG=chromium-os:9666 TEST=unit tests, updated BWSI mode setting and whitelist on device. Review URL: http://codereview.chromium.org/5592006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68547 0039d316-1c4b-4281-b951-d872f2087c98
* Makes instant not access sites that return a 403 status code.sky@chromium.org2010-12-087-10/+132
| | | | | | | | | BUG=59429 TEST=none Review URL: http://codereview.chromium.org/5631004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68543 0039d316-1c4b-4281-b951-d872f2087c98
* Correct an html attribute in tabbed options.estade@chromium.org2010-12-071-1/+1
| | | | | | | | | BUG=none TEST=location list sorta works Review URL: http://codereview.chromium.org/5634006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68538 0039d316-1c4b-4281-b951-d872f2087c98
* Don't re-save autofill profiles to the web database if they haven't changed.isherman@chromium.org2010-12-073-0/+184
| | | | | | | | | BUG=65129 TEST=manual (see bug) Review URL: http://codereview.chromium.org/5559012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68536 0039d316-1c4b-4281-b951-d872f2087c98
* Move more code from headers to implementation.erg@google.com2010-12-0714-53/+116
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5624002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68534 0039d316-1c4b-4281-b951-d872f2087c98
* Importer: Fix ImporterList::DetectSourceProfiles to run on the FILE thread, asjhawkins@chromium.org2010-12-0714-264/+461
| | | | | | | | | | | it access the file system. Fix up a few call sites. BUG=60825 TEST=none Review URL: http://codereview.chromium.org/5566003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68533 0039d316-1c4b-4281-b951-d872f2087c98
* Turn off field trials and reporting of metrics when running benchmarking.mbelshe@google.com2010-12-071-1/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5628005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68532 0039d316-1c4b-4281-b951-d872f2087c98
* Invert the speech input API enable check and enable only on dev channel.satish@chromium.org2010-12-071-3/+3
| | | | | | | | | | | For official builds, enable speech input only on the dev channel. For non-official builds it is enabled by default and that remains the same. BUG=61103 TEST=manually, beta and stable builds should have speech input API disabled by default. Review URL: http://codereview.chromium.org/5597008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68527 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a DCHECK which fired in ChromeFrame which indicated that we had a ↵ananta@chromium.org2010-12-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | pending request which is created when we switch into ChromeFrame and the URL request received from Chrome was for a different URL. This scenario occurs when we receive requests from Chrome for the current page which is being navigated away from while a new document is coming up. Fix is to disallow these requests while we have a pending request. The other fix is in the ExternalTabContainer where a spurious DCHECK was being fired in the BeforeUnload code path. Fixes bug http://code.google.com/p/chromium/issues/detail?id=65295 BUG=65295 TEST=As described in the bug. Review URL: http://codereview.chromium.org/5632003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68526 0039d316-1c4b-4281-b951-d872f2087c98
* Put BG mode back behind a flag for now.atwilson@chromium.org2010-12-072-6/+3
| | | | | | | | | | | | Just makes Windows functionality match mac/linux by gating background mode on an about:flags setting. BUG=65657 TEST=Install extension with background page, no wrench menu badge Review URL: http://codereview.chromium.org/5552004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68523 0039d316-1c4b-4281-b951-d872f2087c98
* Wrap GlobalDescriptors singleton in accessor method.evan@chromium.org2010-12-072-3/+3
| | | | | | | | | | | When I switched GlobalDescriptors to using LeakySingletonTraits in r67627, it didn't occur to me I had to fix all users of it. TEST=compiles Review URL: http://codereview.chromium.org/5517006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68518 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Move options.html into options/ and refactor the javascript in said filejhawkins@chromium.org2010-12-074-385/+381
| | | | | | | | | | | into options.js. BUG=none TEST=none Review URL: http://codereview.chromium.org/5617006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68517 0039d316-1c4b-4281-b951-d872f2087c98
* Disable printing context menus on the print preview page. (resubmit)thestig@chromium.org2010-12-075-10/+44
| | | | | | | | | | BUG=none TEST=none Original review: http://codereview.chromium.org/5320001/ Review URL: http://codereview.chromium.org/5625008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68515 0039d316-1c4b-4281-b951-d872f2087c98
* Disables instant preview for search engines that don't support thesky@chromium.org2010-12-072-15/+25
| | | | | | | | | | | | instant API. BUG=65590 TEST=Turn on instant, switch to a search engine other than google and make sure you don't see any instant results. Review URL: http://codereview.chromium.org/5599005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68514 0039d316-1c4b-4281-b951-d872f2087c98
* gtk - Stop the instant commit animation when the user moves the cursor.estade@chromium.org2010-12-072-4/+15
| | | | | | | | | BUG=65399 TEST=manual Review URL: http://codereview.chromium.org/5530007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68511 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the GetVersionEnvKey method from BrowserDistribution.tommi@chromium.org2010-12-071-2/+2
| | | | | | | | | | | This function is not used by the installer and since we're moving towards using shared binaries, all components should rely on using the same version env var. It's also one less thing that the chrome code relies on from the installer code. TEST=Should be no change. BUG=61609 Review URL: http://codereview.chromium.org/5602001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68505 0039d316-1c4b-4281-b951-d872f2087c98
* Add support to get addlist from store.lzheng@chromium.org2010-12-076-12/+104
| | | | | | | | TEST=safe_browsing_store_file_unittest BUG=61675 Review URL: http://codereview.chromium.org/5124002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68503 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash and flakiness in TaskManagerBrowserTest.NoticeExtensionChanges.creis@google.com2010-12-071-14/+10
| | | | | | | | | BUG=31663 TEST=TaskManagerBrowserTest.* Review URL: http://codereview.chromium.org/5646004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68494 0039d316-1c4b-4281-b951-d872f2087c98
* Added in basic DOMui login page with stubbed authentication.rjkroege@google.com2010-12-0717-4/+1184
| | | | | | | | | | | | | This is the beginning of the implementation of the infrastructure to support a DOMui based login screen. The login page that is in this is not meant to be a final version. The authentication currently does not actually use libcros, but instead is stubbed. I have uploaded this to get some review before proceeded with the authentication and hooking this into the system. The login page is reached in the browser from chrome://login. BUG=none TEST=none Review URL: http://codereview.chromium.org/4457003 Patch from Ryan Harrison <rharrison@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68488 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability for the browser to specify additional headers to use.sky@chromium.org2010-12-073-0/+12
| | | | | | | | | BUG=59429 TEST=none Review URL: http://codereview.chromium.org/5574004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68487 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up PluginGroup and related code.jkummerow@chromium.org2010-12-0712-69/+64
| | | | | | | | | | | To avoid data races, do not pass pointers to PluginGroup around. Instead, create copies as plain objects. BUG=61210 TEST=existing unit tests still work; TSan no longer reports the race (see bug) Review URL: http://codereview.chromium.org/5516004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68471 0039d316-1c4b-4281-b951-d872f2087c98
* fix extension_prefs.cc compilation for gcc 4.5.battre@chromium.org2010-12-071-3/+3
| | | | | | | | | BUG=50726 TEST=none Review URL: http://codereview.chromium.org/5633005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68461 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Find regression where text is not selected once youfinnur@chromium.org2010-12-0711-5/+137
| | | | | | | | | | | | switch to a tab that had the Find box selected. BUG=56326 TEST=FindInPageTest.FocusRestoreOnTabSwitch Review URL: http://codereview.chromium.org/5553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68459 0039d316-1c4b-4281-b951-d872f2087c98
* Also register read cookies in the content settings delegate.jochen@chromium.org2010-12-079-22/+96
| | | | | | | | | BUG=63663 TEST=unit tests Review URL: http://codereview.chromium.org/5318002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68458 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFillProfile: Don't clobber data on self-assignmentisherman@chromium.org2010-12-074-0/+36
| | | | | | | | | BUG=none TEST=unit_test --gtest_filter=AutoFillProfileTest.AssignmentOperator:CreditCardTest.AssignmentOperator Review URL: http://codereview.chromium.org/5521005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68449 0039d316-1c4b-4281-b951-d872f2087c98
* It turns out the Cleanup() method in JsModalDialog is notaa@chromium.org2010-12-072-36/+23
| | | | | | | | | | | | | | | | | | | | needed. The check in it was reversed, causing it to never do anything, except in the case where the delegate had been deleted, in which case it would crash. The thing it was trying to do is already being done elsewhere in the case of OnAccept() and OnCancel(). That just leaves OnClose(). There are other things in here that really need cleanup, but I will do those separately. BUG=63732 TEST=See bug Review URL: http://codereview.chromium.org/5548001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68447 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue that causes some extensions to be disabled right after installation.jstritar@chromium.org2010-12-071-0/+3
| | | | | | | | | | | Add an option to Extension::GetDistinctHosts that strips the RCDs off the hosts. BUG=65138 TEST=ExtensionsServiceTest, ExtensionTest Review URL: http://codereview.chromium.org/5642001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68446 0039d316-1c4b-4281-b951-d872f2087c98
* Don't update icon of chrome app shortcuts from the favicon of the hosted URL.skerner@chromium.org2010-12-074-24/+60
| | | | | | | | | | | | | Panel apps should always launch in a panel. Get rid of the non-extension OpenApplicationWindow(). Add TODO to continue untangling. BUG=65632 TEST=Create a desktop shortcut for a hosted app. Quit chrome, open the shortcut. Icon should not change. Review URL: http://codereview.chromium.org/5560007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68442 0039d316-1c4b-4281-b951-d872f2087c98
* Update valid URLPattern schemes in ExtensionPrefs::GetGrantedPermissions.jstritar@chromium.org2010-12-072-1/+7
| | | | | | | | | | | | Adds SCHEME_CHROMEUI as a valid URLPattern scheme in GetGrantedPermissions. Ensures these schemes stay in sync with those in Extension. BUG=65309 TEST=ExtensionPrefsGrantedPermissions Review URL: http://codereview.chromium.org/5626004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68439 0039d316-1c4b-4281-b951-d872f2087c98
* Re-load instant results when user text has whitespace changes.estade@chromium.org2010-12-071-2/+6
| | | | | | | | | BUG=65688 TEST=see bug Review URL: http://codereview.chromium.org/5657002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68438 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Clean up importer.jhawkins@chromium.org2010-12-073-34/+46
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5606008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68424 0039d316-1c4b-4281-b951-d872f2087c98
* sync: more debugging for crash in ChromeSystemResourcestim@chromium.org2010-12-072-12/+28
| | | | | | | | | BUG=64652 TEST=none Review URL: http://codereview.chromium.org/5517004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68422 0039d316-1c4b-4281-b951-d872f2087c98
* Add extension API test for FileSystem API.kinuko@chromium.org2010-12-071-0/+9
| | | | | | | | | BUG=61534 TEST=ExtensionApiTest.FileAPI Review URL: http://codereview.chromium.org/5392001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68418 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 68414 - sync: remove tabstrip and encryption tab from customize UItim@chromium.org2010-12-071-1/+5
| | | | | | | | | | | | BUG=62613 TEST=Set up sync, get to configure screen (second one), note no tabstrip or encryption options. Review URL: http://codereview.chromium.org/5560008 TBR=tim@chromium.org Review URL: http://codereview.chromium.org/5662001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68417 0039d316-1c4b-4281-b951-d872f2087c98
* JavaScript to Value bridge.scottbyer@google.com2010-12-073-30/+141
| | | | | | | | | | | | Add more values that we can get back from JavaScript. Very useful for writing additional DOMUI browser test, and maybe in other cases as well. BUG=none TEST=RenderViewHostTest.ExecuteJavascriptInWebFrameNotifyResult Review URL: http://codereview.chromium.org/4924001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68416 0039d316-1c4b-4281-b951-d872f2087c98
* sync: remove tabstrip and encryption tab from customize UItim@chromium.org2010-12-071-5/+1
| | | | | | | | | BUG=62613 TEST=Set up sync, get to configure screen (second one), note no tabstrip or encryption options. Review URL: http://codereview.chromium.org/5560008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68414 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-28 20:38:23 +0000