summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Update unit tests to honor the concept that an ok: call makes thejrg@chromium.org2009-10-151-55/+70
| | | | | | | | | BookmarkEditorController invalid for subsequent bookmark manipulation (e.g. it can and does do a remove/add instead of an in-place edit). Review URL: http://codereview.chromium.org/274039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29128 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the include of nsimage_cache_mac since it's not used in these files ↵thomasvl@chromium.org2009-10-152-2/+0
| | | | | | | | | | any more. BUG=none TEST=none Review URL: http://codereview.chromium.org/268037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29124 0039d316-1c4b-4281-b951-d872f2087c98
* Show "Loading" bubble while loading a theme.avi@chromium.org2009-10-1512-30/+289
| | | | | | | | | BUG=http://crbug.com/22219 TEST=load a theme, see "Loading..." Review URL: http://codereview.chromium.org/267031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29121 0039d316-1c4b-4281-b951-d872f2087c98
* Add DownloadMimeTest to the flaky list.nsylvain@chromium.org2009-10-151-1/+2
| | | | | | | BUG:24889 Review URL: http://codereview.chromium.org/276043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29111 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Stack autocomplete popup window directly on top of the browser's ↵suzhe@chromium.org2009-10-155-23/+34
| | | | | | | | | | | toplevel window. BUG=19082 "Linux: Omnibox auto-complete popup is on top of IME candidate window when using SCIM" TEST=Please refer to the bug report for how to test. Review URL: http://codereview.chromium.org/274046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29102 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: enable DevToolsSanityTest.TestCompletionOnPause that failed ↵yurys@google.com2009-10-151-1/+1
| | | | | | | | | because WebKit@49557 was not rolled. BUG=24805 Review URL: http://codereview.chromium.org/271100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29101 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r29095 (removes wrench integration foraa@chromium.org2009-10-1511-245/+181
| | | | | | | | | | | | browser actions). Test failure was a fluke. I forgot that changing resources always makes the first bot run fail. TBR=mpcomplete@chromium.org BUG=24379,24671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29098 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r29095 (removes wrench integration foraa@chromium.org2009-10-1511-181/+245
| | | | | | | | | browser actions). TBR=mpcomplete@chromium.org BUG=24379,24671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29097 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the implicit wrench menu items for browser actions.aa@chromium.org2009-10-1511-245/+181
| | | | | | | | | | | Also, allow browser actions with no initial icons, and add some better tests. BUG=24379,24671 Review URL: http://codereview.chromium.org/276010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29095 0039d316-1c4b-4281-b951-d872f2087c98
* Re-try r29078: Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-157-12/+14
| | | | | | | | | | | | | With the previous patch, the try bots failed with mysterious messages, so I ignored them, patched it into my windows box and tested it there manually, and found no problems. As it turns out, the try failures were real :(. But nsylvain and I found the problem: the behavior of file_util::GetDirectoryFromPath() differs from DirName() when the path is empty (officially, GetDirectoryFromPath is not supposed to support non-absolute paths, but that is not enforced). Here is a green win try result: http://build.chromium.org/buildbot/try-server/builders/win/builds/3705 mac: http://build.chromium.org/buildbot/try-server/builders/mac/builds/3491 linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/3466 I also applied this patch locally in Windows to test that it doesn't break the chrome frame compile or tests, since that's not covered by the trybots yet. Review URL: http://codereview.chromium.org/271099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29094 0039d316-1c4b-4281-b951-d872f2087c98
* Mark HistorySearchXSS as flaky.nsylvain@chromium.org2009-10-151-1/+2
| | | | | | | | BUG:22111 Review URL: http://codereview.chromium.org/278016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29089 0039d316-1c4b-4281-b951-d872f2087c98
* Revert wstring patch (r29078 and follow up commits). It is causing failures ↵estade@chromium.org2009-10-157-14/+12
| | | | | | | | | | on the buildbots. TBR=nsylvain Review URL: http://codereview.chromium.org/280004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29085 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some deprecated file_util wstring functions.estade@chromium.org2009-10-157-12/+14
| | | | | | | | | | | death to the wstring TEST=trybots BUG=none Review URL: http://codereview.chromium.org/276016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29078 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some warnings on Mac that are treated as errors:munjal@chromium.org2009-10-155-28/+13
| | | | | | | | | | | | | | The warnings indicate that a public/protected method of a class visible outside of a .cc file returns a type that's declared in the anonymous namespace in that file (and hence not visible outside the file). BUG=23073 TEST=none Review URL: http://codereview.chromium.org/273058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29075 0039d316-1c4b-4281-b951-d872f2087c98
* Move the sqlite error handler to a single locationcpu@chromium.org2009-10-157-44/+95
| | | | | | | | | | | | | | - Eliminate code duplication - Cover other 3 databases - Still doing the same as before, sending UMA histograms BUG=11908 TEST=none Review URL: http://codereview.chromium.org/270101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29073 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a bug with interstitial pages triggered with malware.jcampan@chromium.org2009-10-153-5/+64
| | | | | | | | | BUG=http://crbug.com/17627 TEST=See bug. Review URL: http://codereview.chromium.org/273022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29071 0039d316-1c4b-4281-b951-d872f2087c98
* Update browser actions api to be like new design doc.aa@chromium.org2009-10-159-44/+60
| | | | | | | | | BUG=23879 TEST=Install sample gmail browser action sample. Review URL: http://codereview.chromium.org/264046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29068 0039d316-1c4b-4281-b951-d872f2087c98
* Add histogram for how tab closing time. Did some cleanup along the way. ↵jam@chromium.org2009-10-1412-57/+63
| | | | | | | | Moved the is_showing_before_unload_dialog_ stuff from RenderViewHost to TabContents since we need that bit there as well. Review URL: http://codereview.chromium.org/274057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29063 0039d316-1c4b-4281-b951-d872f2087c98
* Hides the control buttons for browser when maximized on chromesky@chromium.org2009-10-142-11/+39
| | | | | | | | | | | | os. maximized is the default state on chrome os, so this effectively gives us no window controls just as we have now. BUG=none TEST=none Review URL: http://codereview.chromium.org/273055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29061 0039d316-1c4b-4281-b951-d872f2087c98
* Small cleanup to extension function registration to avoid scattered definitions.mpcomplete@chromium.org2009-10-1422-211/+98
| | | | | | | | BUG=no Review URL: http://codereview.chromium.org/274059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29059 0039d316-1c4b-4281-b951-d872f2087c98
* Don't hide task manager key binding from web pages.mmoss@chromium.org2009-10-141-2/+1
| | | | | | | | | | | | | This allows shift-esc to work again in Gmail chat windows. BUG=none TEST=Open Gmail, start a chat, repeatedly press SHIFT+ESC and watch it switch between the chat "window" and the mail list. The Task Manager should not open. Review URL: http://codereview.chromium.org/274028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29055 0039d316-1c4b-4281-b951-d872f2087c98
* For sync exponential backoff, allow one nudge per exponential backoff ↵tim@chromium.org2009-10-143-151/+347
| | | | | | | | | | | | | | | | | | | interval. If the nudge still leaves the syncer with more work to do, don't accept any further nudges for this interval, and keep the exponent stage for exponential backoff the same. As a result of the patch, the unittest can now explicitly determine if exponential backoff kicked in or not. We really need to wire this up directly to the error codes to be precise, because the current impl (and it's the same with my patch) appears to trigger exponential backoff in other cases (ShouldSyncAgain). TEST=SyncerThreadTest Review URL: http://codereview.chromium.org/275015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29053 0039d316-1c4b-4281-b951-d872f2087c98
* Disable "Reset to Default Theme" button in Google Chrome Options / Personal ↵mirandac@chromium.org2009-10-142-0/+7
| | | | | | | | | | | Stuff when the default theme is already set, Windows side. BUG= http://crbug.com/18585 TEST= Install a default theme, note that button is disabled. Install a non-default theme, note that button is enabled. Review URL: http://codereview.chromium.org/279005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29050 0039d316-1c4b-4281-b951-d872f2087c98
* Disable "Reset to Default Theme" button in Google Chrome Options / Personal ↵mirandac@chromium.org2009-10-143-2/+27
| | | | | | | | | | | | | Stuff when the default theme is already set. This change is for the Mac OS; Windows change in a separate patch. BUG= http://crbug.com/18585 TEST= Install a default theme, note that button is disabled. Install a non-default theme, note that button is enabled. Rinse, repeat. Review URL: http://codereview.chromium.org/278004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29047 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extension canceling; the CFUserNotification functionality gets a bit weird.avi@chromium.org2009-10-141-2/+3
| | | | | | | | | BUG=http://crbug.com/23405 TEST=try to cancel extension load; it should work. Review URL: http://codereview.chromium.org/279006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29046 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate char/wchar_t conversions, probably-unsafe statics, and disk accessmark@chromium.org2009-10-141-2/+1
| | | | | | | | | | when determining the framework and helper app paths on the Mac. BUG=24833 TEST=app still works, tests still pass Review URL: http://codereview.chromium.org/267102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29034 0039d316-1c4b-4281-b951-d872f2087c98
* Moving one test to appear last to see if it makes a difference.finnur@chromium.org2009-10-141-10/+10
| | | | | | | | | | TBR=jcampan BUG=None TEST=None Review URL: http://codereview.chromium.org/276031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29029 0039d316-1c4b-4281-b951-d872f2087c98
* Gets the full screen bubble to work on views/gtk.sky@chromium.org2009-10-144-32/+67
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/264059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29027 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: colorize the "bookmarks go here" text to match the theme.avi@chromium.org2009-10-141-0/+35
| | | | | | | | | BUG=http://crbug.com/23536 TEST=as in bug Review URL: http://codereview.chromium.org/278008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29025 0039d316-1c4b-4281-b951-d872f2087c98
* Add ChromeOS controls to BrowserViewoshima@chromium.org2009-10-145-4/+225
| | | | | | | | | | | | * Added BrowserExtender class to isolate ChromeOS specific controls from BrowserView * Extender currently adds main menu and status area view only. * System menu is not enabled because using SetContextMenuController on NonClientFrameView didn't work. I need to investigate how. * PanelController support will be added in next CL. Review URL: http://codereview.chromium.org/269078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29021 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilePath in URLRequestMocks.evan@chromium.org2009-10-1412-55/+78
| | | | | | | | | BUG=24672 TEST=compiles Review URL: http://codereview.chromium.org/271066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29013 0039d316-1c4b-4281-b951-d872f2087c98
* Marking DISABLED test as FLAKY so I can investigate on the bots. finnur@chromium.org2009-10-141-1/+21
| | | | | | | | | | | Also adding traces. BUG=None TEST=None Review URL: http://codereview.chromium.org/276030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29011 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Prevent another Chrome instance when First Run UI is active.kuchhal@chromium.org2009-10-144-23/+31
| | | | | | | | | BUG=24485 TEST=On Ubuntu, delete 'First Run' file and launch Chrome to bring up First Run UI and then again launch Chrome which should not crash. Review URL: http://codereview.chromium.org/278006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29007 0039d316-1c4b-4281-b951-d872f2087c98
* Make the multiple download request dialog an infobar.estade@chromium.org2009-10-1413-486/+213
| | | | | | | | | | | | The icon is a placeholder until Glen makes a pretty one. BUG=24047 TEST=go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html allow, deny, closing infobar, and closing tab all work as expected Review URL: http://codereview.chromium.org/275011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29006 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the RenderViewTest printing tests on the Mac.stuartmorgan@chromium.org2009-10-141-2/+2
| | | | | | | | | | | | | | | Migrates some test APIs from wstring path names to FilePath objects, and fixes some gcc compilation issues, to allow the tests to build on Mac. Moves rendering logic and some other pdf logic into PdfMetafile to avoid duplication with unit test code. Switches rendering from the deprecated CGContextDrawPDFDocument to the newer (but less convenient) CGContextDrawPDFPage. Added debugging helpers to PdfMetafile: SaveTo, matching the other platform metafiles, and context retain count checking to get early warning of issues that will cause printing failure. BUG=24750 TEST=N/A Review URL: http://codereview.chromium.org/274052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29003 0039d316-1c4b-4281-b951-d872f2087c98
* Map ctrl+, to open options settings page for Chrome OS.chocobo@google.com2009-10-141-3/+2
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/267095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28998 0039d316-1c4b-4281-b951-d872f2087c98
* Originally in http://codereview.chromium.org/270096 but got lost somehow.jrg@chromium.org2009-10-141-1/+1
| | | | | | | | | BUG=http://crbug.com/24758 TBR=mrossetti Review URL: http://codereview.chromium.org/273054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28997 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: check return of SafeBrowsingProtocolParser::ParseGetHash.mattm@chromium.org2009-10-141-8/+8
| | | | | | | | | | CID=6428 TEST=none BUG=none Review URL: http://codereview.chromium.org/261034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28996 0039d316-1c4b-4281-b951-d872f2087c98
* Clear media cache when clearing browsing datahclam@chromium.org2009-10-141-2/+15
| | | | | | | | | | | | | | | BUG=24765 BUG=24813 TEST=run Chromium with --enable-byte-range-support, watch a movie, clear browsing data, Media Cache folder shouldn't have the cache files. Clear media cache when clearing browsing data. What's missing in this patch is that disk_cache in HttpCache is lazily initialized, so it has to be used at least once before we can clear it. Review URL: http://codereview.chromium.org/275013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28992 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that the correct URL and title is displayed in the host browser if ↵ananta@chromium.org2009-10-142-4/+20
| | | | | | | | | | | | | | | | | | | | | | the browser tab is attached to an existing external tab. This can happen if a script running in chrome invokes window.open which opens a popup window. To ensure that the title and URL display correctly we send over the navigation state changed IPC from Chrome when we receive an IPC from ChromeFrame indicating that it connected to the external tab. I also made a change to the function which sends over the navigation state to chrome to ensure that we set the title to the URL if it is empty. This mimics Chrome and the other browser's behavior. This should fix http://code.google.com/p/chromium/issues/detail?id=24024 Bug=24024 Review URL: http://codereview.chromium.org/274035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28991 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug to select initial wifi network when options page opens.chocobo@google.com2009-10-141-10/+27
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/276023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28989 0039d316-1c4b-4281-b951-d872f2087c98
* Readability fixes for server_connection_manager.nick@chromium.org2009-10-142-67/+93
| | | | | | Review URL: http://codereview.chromium.org/267029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28988 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression in menu button. I converted a call from GetWidget tosky@chromium.org2009-10-141-2/+2
| | | | | | | | | | | | | GetWindow, the problem is in certain scenarios GetWindow can return null. I've changed the code back to GetWidget and converted Screen from taking a NativeWindow to a NativeView. BUG=none TEST=none Review URL: http://codereview.chromium.org/269076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28986 0039d316-1c4b-4281-b951-d872f2087c98
* Disable parse feed test again.finnur@chromium.org2009-10-141-1/+1
| | | | | | | | | | TBR=jcampan BUG=None TEST=None Review URL: http://codereview.chromium.org/278003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28985 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for memory leak in unit test. The test used to leak SiteInstance objectrogerta@chromium.org2009-10-141-22/+34
| | | | | | | | | | | returned from GetSiteInstanceForURL(). BUG=24769 TEST=None Review URL: http://codereview.chromium.org/271088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28982 0039d316-1c4b-4281-b951-d872f2087c98
* Fix line endings on merge_and_sync.html in repo, it is breaking svn.tim@chromium.org2009-10-141-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28977 0039d316-1c4b-4281-b951-d872f2087c98
* A patch from contributor Thiago Farina:finnur@chromium.org2009-10-141-1/+12
| | | | | | | | | | | | | | | | | [Windows] Improve the usage of "Open the following pages:" table. - Allow multiple selection. - Select the next row after the last row deleted or nothing when the row doesn't have any items. - Select the item in table when the user add an url. BUG=19150 TEST=add a bunch of urls, remove them, in different orders, should work fine. Review URL: http://codereview.chromium.org/267094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28976 0039d316-1c4b-4281-b951-d872f2087c98
* Updates for Under the Hood prefs from Cole:thomasvl@chromium.org2009-10-141-7/+17
| | | | | | | | | | | | - Make the scroller the width of the window. - Resize the content so any wrapping text fields have the full width. - Tweak the scroller so only bot bottom border shows. BUG=20538 TEST=Under the hood prefs scroller is the width of the window and goes to the bottom of the toolbar. Review URL: http://codereview.chromium.org/276019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28973 0039d316-1c4b-4281-b951-d872f2087c98
* More style nits.erg@google.com2009-10-1471-147/+163
| | | | | | | | (Working on cleaning chrome/ so hopefully we can lint it by default.) Review URL: http://codereview.chromium.org/274040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28971 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily re-enabling ParseFeed test.finnur@chromium.org2009-10-141-1/+1
| | | | | | | | | | TBR=jcampan BUG=23686 TEST=None Review URL: http://codereview.chromium.org/269077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28970 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 08:08:30 +0000