summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Mac: add encoding meta-tag to HTML provided with NSHTMLPboardType.viettrungluu@chromium.org2010-04-301-1/+8
| | | | | | | | | | | Otherwise, US-ASCII is assumed. BUG=42661 TEST=dragging text from, e.g., Chinese-language web sites into TextEdit works Review URL: http://codereview.chromium.org/1820001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46029 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak app windows. The signature to AddTabWithURL had changed, but in a ↵aa@chromium.org2010-04-301-3/+3
| | | | | | | | compatible way. This was causing the initial tab to get added to an app window with some odd properties. Review URL: http://codereview.chromium.org/1703023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46028 0039d316-1c4b-4281-b951-d872f2087c98
* Rename a bunch of DOMUI shared resources.arv@chromium.org2010-04-3017-171/+14
| | | | | | | | BUG=None TEST=manual git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46027 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r46023: "Detect new instance of the browser when running in the ↵willchan@chromium.org2010-04-307-147/+33
| | | | | | | | | | background in persistent" Broke the build. Review URL: http://codereview.chromium.org/1718024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46025 0039d316-1c4b-4281-b951-d872f2087c98
* Detect new instance of the browser when running in the background in persistentprasadt@chromium.org2010-04-307-33/+147
| | | | | | | | | | | | | | | | | | mode, shutdown and restart the new instance. This is already done for Windows, this CL enables the functionality for Linux. We don't yet have a unit test for this. Local testing is done by: 1) Reducing the timer to 30 seconds. 2) Changing BrowserList::IsInPersistentMode to return true. 3) Setting BrowserProcessImpl::autoupdate_timer_ to 30 seconds interval. 4) Running "touch" command on chrome exe to pretend there is an update. BUG=40975 TEST=none Review URL: http://codereview.chromium.org/1633021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46023 0039d316-1c4b-4281-b951-d872f2087c98
* NTP - Refactor the most visited code to uncouple it from the rest of the NTP.arv@chromium.org2010-04-309-1048/+1181
| | | | | | | | | | | The goal of this refactoring is to allow splitting the different parts of the NTP into different reusable components. BUG=None TEST=Manually Review URL: http://codereview.chromium.org/1695022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46021 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the mediaplayer so it starts over when the clip is finished.dhg@chromium.org2010-04-292-57/+99
| | | | | | Review URL: http://codereview.chromium.org/1745004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46009 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Dropping in the bookmark managerfeldstein@chromium.org2010-04-291-3/+8
| | | | | | | | | | | | | | | | | Originally we were clearing the dragData member in a few places, including experimental.bookmarkManager.onDrop. This was triggered before the javascripts drop event so when it got to that point to drop a valid bookmark, it had already cleared itself out. Now it just posts a task with 0ms delay to let the real drop event handle the data before clearing it. Also clear the data on mouse up, which wasn't being handled in the case where you drag an element just a tiny bit, and no action is performed. BUG=none TEST=Ensure you can still drop stuff in the bmm Review URL: http://codereview.chromium.org/1780015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46006 0039d316-1c4b-4281-b951-d872f2087c98
* Implement UI automation on the Mac.jrg@chromium.org2010-04-2914-53/+323
| | | | | | | | | | | | | | | | | | | Code is untested. From gChat: me: do you have a good test I can use to make sure mac impl of ui_controls for sending events works OK? Or would you prefer I send you CLs to play with and we iterate by hand? Joe: I would like the CL to play with to see if I can get it to work with the code I wrote Warning to Joe: mouse moved events currently use the Mac coordinate frame (0,0 is bottom-left not top-left). That's easy to switch; I'd like to do whatever is easiest to get WebDriver working. BUG=26102 Review URL: http://codereview.chromium.org/1701006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46005 0039d316-1c4b-4281-b951-d872f2087c98
* Changing filebrowser to append a number on the end of an existing directory.dhg@chromium.org2010-04-291-2/+15
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1736006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46004 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Tweak the top bar behavior a bit.arv@chromium.org2010-04-291-13/+18
| | | | | | | | | | | | Empty searches are not shown now, instead we go to "Bookmarks bar" folder. Clicking the logo button clears the search and takes the user to the "Bookmarks bar" folder. BUG=None TEST=See above Review URL: http://codereview.chromium.org/1816001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45995 0039d316-1c4b-4281-b951-d872f2087c98
* Remove accidental #if's. Make old folder window menu go away when mousing ↵mrossetti@chromium.org2010-04-292-15/+4
| | | | | | | | | | | over a non-folder bookmark in the bookmark bar. BUG=None. TEST=Pop up a folder bookmark item on the bookmark bar then mouse over a non-folder bookmark and verify that the old folder menu is dismissed. Review URL: http://codereview.chromium.org/1752020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45991 0039d316-1c4b-4281-b951-d872f2087c98
* Changing linux platform for chromeos. This involved moving platform_util ↵dhg@chromium.org2010-04-2944-40/+707
| | | | | | | | | | and extension_error_reporter to browser, so that the UIs surrounding them can be in the browser. BUG=none TEST=none Review URL: http://codereview.chromium.org/1705009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45986 0039d316-1c4b-4281-b951-d872f2087c98
* Add shared images from bookmark manager to chrome://resources/images/arv@chromium.org2010-04-296-5/+5
| | | | | | | | | | | This fixes a bug where we would have missing images in the bookmark manager. BUG=42817 TEST=Open the bookmark manager. No icons should be missing. Review URL: http://codereview.chromium.org/1697017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45983 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dragging a tab out of a window when the only tabs left behind are ↵pinkerton@chromium.org2010-04-294-2/+19
| | | | | | | | | | phantom tabs. BUG=42698 TEST=per bug. Might want to re-test dragging single tabs and dragging tabs out when there are pinned tabs (not phantoms). Review URL: http://codereview.chromium.org/1727013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45982 0039d316-1c4b-4281-b951-d872f2087c98
* Http cache: Add support for a dedicated cache thread.rvargas@google.com2010-04-291-3/+3
| | | | | | | | | | | | This is an interface-only change, nothing is really moving to another thread yet. BUG=26730 TEST=none Review URL: http://codereview.chromium.org/983007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45974 0039d316-1c4b-4281-b951-d872f2087c98
* Fix runtime exception.skerner@chromium.org2010-04-291-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1708016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45973 0039d316-1c4b-4281-b951-d872f2087c98
* Remove CHECK()s from directory backing store and check return values.zork@chromium.org2010-04-294-43/+61
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1739019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45971 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ability to export the captured NetLog data to a formatted text file, ↵eroman@chromium.org2010-04-293-26/+270
| | | | | | | | | | | | | | or to JSON. This is similar to the display of about:net-internals, and is intended to be used when attaching log info to bug reports. The formatting is still fairly crude, and there are some remaining TODOs. BUG=37421 Review URL: http://codereview.chromium.org/1703018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45967 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: more signal handler foolproofing.estade@chromium.org2010-04-2910-110/+80
| | | | | | | | | BUG=40735 TEST=manual clicking about, trybots Review URL: http://codereview.chromium.org/1783010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45966 0039d316-1c4b-4281-b951-d872f2087c98
* Add and implement cut/copy/paste to the bookmark bar and folder context ↵mrossetti@chromium.org2010-04-2913-220/+1512
| | | | | | | | | | | | | | | | | | | | | | | | | | | menus.Prevent dropping bookmark folders onto their children to avoid creating cycles and crashing. Keep folder menu windows open after a cut/copy/paste/delete and drop operation. Add test helpers for easing comparison of bookmark model changes. BUG=41217,36614,32064, 41404 Add and implement cut/copy/paste to the bookmark bar and folder context menus.Prevent dropping bookmark folders onto their children to avoid creating cycles and crashing. Keep folder menu windows open after a cut/copy/paste/delete and drop operation. TEST=1) Present the context menu for the bookmark bar in various places and insure that the cut/copy/paste menu items are shown and properly enabled or disabled. 2) Present the context menu for a folder menu in various places and insure that the cut/copy/paste menu items are shown and properly enabled or disabled. 3) Perform cut/copy/paste/delete operations in a folder menu and subfolder menu and verify that the menu remains presented after the operation completes. 4) Drag a bookmark item from the bar to another location on the bar and verify that the button no longer shows up in the old location but does show up in the new location. 5) Drag a bookmark item from the bar to be within a folder located _after_ the item being dragged. Verify the bar no longer shows the bookmark item. Verify the folder does show the bookmark item. Verify that the folder window has shifted to the left so that it remains aligned with it corresponding bar folder indicator. 6) Drag a bookmark item from the bar to be within a folder located _before_ the item being dragged. Verify the bar no longer shows the bookmark item. Verify the folder does show the bookmark item. Verify that the folder window has _not_ shifted to the left and that it remains aligned with it corresponding bar folder indicator. 7) Drag a bookmark around within the same folder and verify that the folder window does not move. 8) Drag a bookmark item from a folder to the bar in a position _after_ the folder form which the item comes. The folder menu window should close. 9) Drag a bookmark item from a folder to a different folder and verify that the original folder closes and the new folder remains open. 10) Drag an item from a parent folder to a child folder and verify that both folders remain open. Verify that the subfolder remains aligned to its associated folder icon in the parent folder. 11) Drag an item from a child folder to a parent folder. Verify that the child folder closes and the parent folder remains open. 12) Try dragging a parent folder onto a child folder and verify that the drag is not allowed to complete. 13) Hover over a folder item in a folder menu window. Verify that the folder opens up a subview menu window. Now drag the original folder (the one being hovered over) and verify that its subfolder menu automatically closes. 14) Slowly shrink window width until "off the side" menu appears; make sure it appears as soon as the last button gets removed. Now slowly grow window and make sure it goes away at the right time. 15) Add enough bookmarks to the bookmark bar to nearly fill the width of the window. Verify that the off-the-side chevron is not showing. Slowly shrink the width of the window until the off-the-side-chevron appears. Verify that the right-most bookmark button has disappeared and does not draw over the top of the chevron. Continue to shrink the window and verify that bookmark buttons disappear. View the contents of the chevron and verify that the bookmark buttons which previously appeared on the bar now appear in the chevron. Slowly grow the window and verify that bookmark buttons reappear without drawing over the top of the chevron. Verify that those bookmark buttons no longer appear in the chevron when it is popped up. Continue growing the window until all bookmark buttons appear in the bar and the chevron disappears. 16) Shrink the window so that the off-the-side chevron appears and contains three or more bookmarks. Pop open the chevron. Drag bookmarks up and down in the chevron menu and verify that moves and copies are performed. Drag a bar bookmark into the chevron and verify that the chevron pops up and allows the drag. Verify that the bar and chevron contents rearrange such that buttons on the bar fill but do not overflow the bar. Drag a chevron bookmark out onto the bar. Once again verify that the bar and chevron buttons rearrange such that the bar is full but not overflowing. Review URL: http://codereview.chromium.org/1742003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45965 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Make Chrome use enums from libcros to talk to WM.derat@chromium.org2010-04-2917-238/+70
| | | | | | | | | | | | | | | | | | | | We currently have two copies of these enums, one in Chrome and one in Chrome OS. I'm switching us to have a single copy in the libcros repo. This reverts r45955, which reverted r45952. I've added third_party/cros to the browser directory's DEPS file to fix the checkdeps.py failure. http://codereview.chromium.org/1811002/show contains the review of the original change. BUG=none TEST=built it and ran checkdeps.py manually Review URL: http://codereview.chromium.org/1705017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45964 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up some Observer code. Original patch by Thiago Farina (see ↵pkasting@chromium.org2010-04-292-43/+25
| | | | | | | | | http://codereview.chromium.org/1725007 ), r=me. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45963 0039d316-1c4b-4281-b951-d872f2087c98
* Enable mouse enter/exit events for the content area on Macstuartmorgan@chromium.org2010-04-292-0/+34
| | | | | | | | | | | Fixes mouse-exit events for plugins touching the edge of the content area; likely also fixes similar bugs in HTML. BUG=33100 TEST=Plugins should receive mouse exit events on edges touching the content area edge. Review URL: http://codereview.chromium.org/1774014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45962 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding http://codereview.chromium.org/1746009/showjcivelli@chromium.org2010-04-2935-2489/+2679
| | | | | | | | | | | | | | | | | | (fixed the ChromeOS build). The app launcher now uses the location bar (instead of the autocomplete edit), so it has "tab to search" and the icons on the left side, Also split location_bar_view.cc so that every inner-class gets its own .h and .cc file. BUG=None TEST=Make sure the location bar works as expected (tab to search, bookmark star, page actions...). Open the app launcher, make sure "tab to search" works as expected. Review URL: http://codereview.chromium.org/1792010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45957 0039d316-1c4b-4281-b951-d872f2087c98
* Add automation hooks for setting/gettting preferences.nirnimesh@chromium.org2010-04-292-19/+87
| | | | | | | | | | | | | | | | Add a test which excercises this, update old test. Also, - Remove some old prefs hooks. They were not easy to use and required the user to know what a preference type was, with no way of listing them out. - replace if-else statements for json handlers with a map. - Fix json error strings. json prefers " over ' (automation_provider.cc) BUG=42701 TEST=python chrome/test/functional/prefs.py Review URL: http://codereview.chromium.org/1712019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45956 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r45952: broke checkdeps.willchan@chromium.org2010-04-2916-69/+238
| | | | | | Review URL: http://codereview.chromium.org/1692017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45955 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Chrome OS to load the user's nssdb later.cmasone@google.com2010-04-291-4/+33
| | | | | | Review URL: http://codereview.chromium.org/1730001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45954 0039d316-1c4b-4281-b951-d872f2087c98
* Move common code into process_util.cc.maruel@chromium.org2010-04-293-9/+8
| | | | | | | | | | | | | Fix namespace usage. Change ProcessEntry to have a common interface accross platforms and change ProcessFilter::Includes() to make use of it. Split NamedProcessIterator in two. BUG=none TEST=none Review URL: http://codereview.chromium.org/1689012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45953 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Make Chrome use enums from libcros to talk to WM.derat@chromium.org2010-04-2916-238/+69
| | | | | | | | | | | | | We currently have two copies of these enums, one in Chrome and one in Chrome OS. I'm switching us to have a single copy in the libcros repo. BUG=none TEST=built it Review URL: http://codereview.chromium.org/1811002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45952 0039d316-1c4b-4281-b951-d872f2087c98
* Minor polish to the Extensions management page.finnur@chromium.org2010-04-291-2/+1
| | | | | | | | | | | | | The space after the extension name was included in the link. BUG=29739 TEST=chrome://extensions, make sure the link does not contain a space. Review URL: http://codereview.chromium.org/1699025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45950 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ExtensionApiTest.Incognito as flaky.phajdan.jr@chromium.org2010-04-291-1/+2
| | | | | | | | | | | TBR=mpcomplete TEST=flaky BUG=42844 Review URL: http://codereview.chromium.org/1705014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45948 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ExtensionTestBrowserEvents.RunTest as flaky.phajdan.jr@chromium.org2010-04-291-1/+2
| | | | | | | | | | | TBR=rogerta TEST=flaky BUG=37554 Review URL: http://codereview.chromium.org/1695024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45947 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of BookmarkEditor::Handler entirely.viettrungluu@chromium.org2010-04-295-31/+14
| | | | | | | | | | | (Part of aftermath of eliminating the native bookmark managers.) BUG=38908 TEST=everything keeps working Review URL: http://codereview.chromium.org/1745021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45939 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45936 - The app launcher now uses the location bar (instead of the ↵jcivelli@chromium.org2010-04-2935-2679/+2493
| | | | | | | | | | | | | | | | | | | | autocomplete edit), so it has "tab to search" and the icons on the left side, Also split location_bar_view.cc so that every innerclass gets its own .h and .cc file. BUG=None TEST=Make sure the location bar works as expected (tab to search, bookmark star, page actions...). Open the app launcher, make sure "tab to search" works as expected. Review URL: http://codereview.chromium.org/1746009 TBR=jcivelli@google.com Review URL: http://codereview.chromium.org/1737021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45937 0039d316-1c4b-4281-b951-d872f2087c98
* The app launcher now uses the location bar (instead of the autocomplete ↵jcivelli@google.com2010-04-2935-2493/+2679
| | | | | | | | | | | | | | | | | edit), so it has "tab to search" and the icons on the left side, Also split location_bar_view.cc so that every inner-class gets its own .h and .cc file. BUG=None TEST=Make sure the location bar works as expected (tab to search, bookmark star, page actions...). Open the app launcher, make sure "tab to search" works as expected. Review URL: http://codereview.chromium.org/1746009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45936 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Rename OnLoadFont->OnPreCacheFontjeremy@chromium.org2010-04-292-7/+7
| | | | | | | | | | | | | | | I'm working on a Mac specific change where we'll need an IPC message to load a font and pass the font data back to the renderer process. To prevent confusion this CL preemptively renames a Windows message which actually causes a font to be cached by the browser. The distinction between these two operations is subtle but I thought it best to try to prevent future confusion by making sure the IPC messages don't have similar names. BUG=None TEST=None Review URL: http://codereview.chromium.org/1805002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45931 0039d316-1c4b-4281-b951-d872f2087c98
* Adding dchecks that may help diagnose the issue http://crosbug.com/2743oshima@chromium.org2010-04-292-1/+16
| | | | | | | | | BUG=http://crosbug.com/2743 TEST=none Review URL: http://codereview.chromium.org/1711017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45920 0039d316-1c4b-4281-b951-d872f2087c98
* Memory leak fix.oshima@chromium.org2010-04-293-4/+39
| | | | | | | | | | | | We're releasing panel controller but never deleted. Handle edge case where a renderer requests resize after the panel is closed. BUG=none TEST=added new test case TestCloseOpen to verify it. Review URL: http://codereview.chromium.org/1687011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45919 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45916 - Python implementation of sync server, for testing.nick@chromium.org2010-04-292-75/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Implement the server side of chromium sync inside of testserver.py. The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured. Make the sync_integration_tests run by default against the test server. An externallyprovided syncurl will give the old behavior. Protocol buffers stuff: The test sync server requires Python generated code for .proto files. I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf). This might be a bad place, or a bad name open to suggestions. The main thing is that there will be runtime dependencies on it, so it didn't seem right to put it in obj/. Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory. The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore. Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port. Very useful if a test failure leaves a server running. Tested this against all combos of protocols, and it seems to work. Flakiness fix: Port sync_integration_tests to the outofprocess test runner. Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure. BUG=20905,40980 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44708 Review URL: http://codereview.chromium.org/1622012 TBR=nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45918 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some more BookmarkEditor::Handlers (in Mac code this time).viettrungluu@chromium.org2010-04-2910-68/+32
| | | | | | | | | | | (Continuing aftermath of native bookmark manager removal....) BUG=38908 TEST=everything continues to work Review URL: http://codereview.chromium.org/1747020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45917 0039d316-1c4b-4281-b951-d872f2087c98
* Python implementation of sync server, for testing.nick@chromium.org2010-04-292-1/+74
| | | | | | | | | | | | | | | | | | | | | | | | Implement the server side of chromium sync inside of testserver.py. The implementation supports at most one account (and ignores authentication credentials), but is otherwise reasonably full featured. Make the sync_integration_tests run by default against the test server. An externally-provided --sync-url will give the old behavior. Protocol buffers stuff: The test sync server requires Python generated code for .proto files. I've put generated code, as well as the python protocol buffers runtime library, in the output directory + "/python" (e.g, on windows, src/chrome/Debug/python/google/protobuf). This might be a bad place, or a bad name -- open to suggestions. The main thing is that there will be run-time dependencies on it, so it didn't seem right to put it in obj/. Flakiness fix: In the InProcessBrowserTest framework, improve the mechanism for tests that want to manually set up a user data directory. The new way ensures that the user data directory is always wiped; tests can't accidentally forget to do this anymore. Flakiness fix: Make testserver try to /kill any old instance that might be hogging the port. Very useful if a test failure leaves a server running. Tested this against all combos of protocols, and it seems to work. Flakiness fix: Port sync_integration_tests to the out-of-process test runner. Flakiness fix: For IN_PROC_BROWSER_TESTS, don't run the test body if the setup triggered a fatal (ASSERT_) failure. BUG=20905,40980 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44708 Review URL: http://codereview.chromium.org/1622012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45916 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45906 - Relands your patch to have an option for enabling vertical ↵sky@chromium.org2010-04-2932-380/+84
| | | | | | | | | | | | | | | | | | tabs. I've added the following additions: . made the layout work for opaque_browser_frame. . Only show the menu if the user supplied enableverticaltabs. BUG=none TEST=none Review URL: http://codereview.chromium.org/1708014 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/1795010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45915 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 45894. http://codereview.chromium.org/1732015aa@chromium.org2010-04-292-4/+91
| | | | | | | | TBR=erikkay@chromium.org Review URL: http://codereview.chromium.org/1705012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45914 0039d316-1c4b-4281-b951-d872f2087c98
* Change report bad webpage to be a web tab instead of native dialogfeldstein@chromium.org2010-04-294-12/+27
| | | | | | | | | | | | Change all 3 implementations of the report broken page dialog to just use one web form. BUG=none TEST=Make sure you can report bad pages on each platform Review URL: http://codereview.chromium.org/1737016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45908 0039d316-1c4b-4281-b951-d872f2087c98
* Created a MessageLoopProxy interface. This provides a thread-safe refcounted ↵sanjeevr@chromium.org2010-04-293-14/+121
| | | | | | | | | | | | interface to the Post* methods of a message loop. This class can outlive the target message loop. Changed ChromeThread to vend an implementation of this proxy. BUG=None TEST=ChromeThread unit-tests modified. Review URL: http://codereview.chromium.org/1800008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45907 0039d316-1c4b-4281-b951-d872f2087c98
* Relands your patch to have an option for enabling vertical tabs. I'vesky@chromium.org2010-04-2932-84/+380
| | | | | | | | | | | | | added the following additions: . made the layout work for opaque_browser_frame. . Only show the menu if the user supplied --enable-vertical-tabs. BUG=none TEST=none Review URL: http://codereview.chromium.org/1708014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45906 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes one of the AddTabWithURL variants.sky@chromium.org2010-04-2921-106/+105
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1736022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45902 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Update layout of the header part.arv@chromium.org2010-04-293-8/+7
| | | | | | | | | | | | Remove the search button, use input[type=search] and set a placeholder text. BUG=42214 TEST=Open bookmarks manager and do some searching Review URL: http://codereview.chromium.org/1737020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45901 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: avoid a dcheckestade@chromium.org2010-04-292-8/+11
| | | | | | | | | | | don't use an OwnedWidgetGtk for GtkWindows, which are no longer floating by the time the constructor returns. BUG=42807 TEST=launch a debug build in a compositing window manager Review URL: http://codereview.chromium.org/1795009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45900 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-01 15:24:09 +0000