summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* 2 experiments: DNS prefetch limit concurrency: TCP split a packetjar@chromium.org2010-03-202-4/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Some firewalls apparently try to preclude a "syn flood to host" by limiting the number of syn's (used to open a TCP/IP socket) that are outstanding without having received a syn-ack. Presumably this is to prevent a user from participating in a syn-flood attack (which traditional sends a lot of syn packets, with false return addresses, resulting in no responses). Apparently this firewall technology has in some cases been extended to include UDP sessions for which there has been no response, and this may include DNS resolutions. Since the prefetcher currently resolves as many as 8 names simultaneously, this is remarkably close to the reported threshold of 10 un-answered connections. This test attempts to limit connections to 2, 4, or 6, so that we can see if this helps users. In TCP, the RTO remains (under windows) at a full 3 seconds until after the first ack is received. As a result, if the first data packet sent (after the SYN) is lost, then TCP won't resend until after 3 seconds without an ack. As a test, we split up the first packet into two parts (the second part containing only one byte). This is done as an A/B test, and we'll see if we get a measurable improvement in page-load-time latency. Finally, to get better page load stats, I adjusted the PLT histograms so that we record a "final" time for abandoned pages when they are closed (even if they didn't finish rendering, etc.). This should give a much more fair PLT comparison for all network latency experiments. BUG=3041 BUG=12754 r=mbelshe,darin Review URL: http://codereview.chromium.org/1088002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42181 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r42156, r42157, r42160. Allow dynamic switching in and out of ↵thestig@chromium.org2010-03-2032-337/+59
| | | | | | | | | | | | sidetabs mode. Reliability bot and Linux CrOS browser_tests all had crashes in ~TabStrip. BUG=none TEST=none Review URL: http://codereview.chromium.org/1141005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42176 0039d316-1c4b-4281-b951-d872f2087c98
* Enable tabbed bookmark manager by default.arv@chromium.org2010-03-199-122/+147
| | | | | | | | | | | | | | Second try with the following changes: - Remove FLAKY_ from Feed tests and makes sure they pass. BUG=4890,38609 TEST=browser_test.exe Run Chrome, Press Ctrl+Shift+B. The new bookmark manager should open in a tab. Review URL: http://codereview.chromium.org/1127006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42165 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix menu display logic for people with top/down xinerama setups, part 2.thestig@chromium.org2010-03-191-11/+27
| | | | | | | | BUG=14184 TEST=see bug Review URL: http://codereview.chromium.org/1105006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42162 0039d316-1c4b-4281-b951-d872f2087c98
* Don't change the panel state when deleting notifications (and mouse is on ↵oshima@chromium.org2010-03-194-7/+101
| | | | | | | | | | | | | the panel) so that a user can delete multiple notification by clicking mouse on the same position. BUG=33306 TEST=none. I will add tests next week. Review URL: http://codereview.chromium.org/1147003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42161 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2010-03-191-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42160 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2010-03-191-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42157 0039d316-1c4b-4281-b951-d872f2087c98
* Allow dynamic switching in and out of sidetabs mode.ben@chromium.org2010-03-1930-59/+333
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1001003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42156 0039d316-1c4b-4281-b951-d872f2087c98
* Incognito download appearance for items in Incognito downloads pagearv@chromium.org2010-03-191-89/+133
| | | | | | | | | BUG=36587 TEST=Open an incognito window and open the Downloads page for it. Now download something in the OTR window. The item should show up in the downloads page but it should be lighter and have a OTR icon background. Review URL: http://codereview.chromium.org/1126005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42155 0039d316-1c4b-4281-b951-d872f2087c98
* Notification for battery with <= 15 minutes remaining.seanparent@google.com2010-03-196-3/+244
| | | | | | | | | BUG=521 TEST=none Review URL: http://codereview.chromium.org/1079007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42153 0039d316-1c4b-4281-b951-d872f2087c98
* Add a dcheck to make sure we launch the dialog box on the main UIfeldstein@chromium.org2010-03-191-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1075010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42147 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmit 1025006: Refactor app-related manifest propertiesaa@chromium.org2010-03-1912-55/+50
| | | | | | | | so that they don't include the name 'app'. TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42146 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Set the kAutoFillInfoBarShown pref to true if the user opens the ↵jhawkins@chromium.org2010-03-193-1/+22
| | | | | | | | | | AutoFill dialog. If the user has opened the dialog, AutoFill is implicitly enabled. BUG=38538 TEST=none Review URL: http://codereview.chromium.org/1077003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42139 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the integration test harness by using the max_local_timestamptim@chromium.org2010-03-194-8/+44
| | | | | | | | | | | from the sync engine rather than waiting for "a couple syncs" to happen before declaring sync "done". BUG=37351 Review URL: http://codereview.chromium.org/1042008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42134 0039d316-1c4b-4281-b951-d872f2087c98
* Add ability to show/hide password in login dialog.chocobo@chromium.org2010-03-192-1/+29
| | | | | | | | BUG=none TEST=open login dialog, type in password, and click on the lock image to toggle showing password. Review URL: http://codereview.chromium.org/1113004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42133 0039d316-1c4b-4281-b951-d872f2087c98
* Removing AddDefaultBookmark related code as we are takinghuanr@chromium.org2010-03-192-25/+0
| | | | | | | | | | | bookmark import approach. BUG=32728 TEST=existing test passes Review URL: http://codereview.chromium.org/1122002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42130 0039d316-1c4b-4281-b951-d872f2087c98
* views: Add accessibility support to the Textfield control.ctguil@chromium.org2010-03-191-2/+4
| | | | | | | | | BUG=9619 TEST=open AccExplorer.exe, open bookmarks manager dialog, point it to the search Textfield (edit box) and see it if has the correct information for role (editable text), name (the label within it's connected) and state (read only). Review URL: http://codereview.chromium.org/1058002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42128 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a constant which was the hardcoded value of 2*kNumBytesToSniff. When I rvargas@google.com2010-03-191-2/+6
| | | | | | | | | | | | | | changed kNumBytesToSniff in 41687, it was left behind. Contributed by tonyg@chromium.org (original review http://codereview.chromium.org/1111003/show) BUG=15314 TEST=There is no clear way to test this, ideas? Review URL: http://codereview.chromium.org/1153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42125 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash due to UserScriptListener unregistering notifications on the wrongmpcomplete@chromium.org2010-03-193-0/+12
| | | | | | | | | | thread, then being sent a notification after it was deleted. BUG=38374 Review URL: http://codereview.chromium.org/995007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42120 0039d316-1c4b-4281-b951-d872f2087c98
* Enables chrome to do programmatic auth without helper binaries/pam modules.cmasone@google.com2010-03-1920-90/+471
| | | | | | | | | Functionality protected behind --in-chrome-auth flag. TEST=unittests, also run on Chromium OS with --in-chrome-auth flag. Log in should work. Review URL: http://codereview.chromium.org/1026001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42116 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Make automation timeouts more sane.phajdan.jr@chromium.org2010-03-191-1/+1
| | | | | | | | | | | | | | | | | | Do not expose command execution timeout outside ui_test.cc. This way people have less timeouts to choose from, which leaves less space for confusion. The option to manipulate the command execution timeout is still available, because it's still used and makes sense. Also updated misleading comments and names in ui_test.cc. TEST=ui_tests BUG=none Review URL: http://codereview.chromium.org/1078003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42112 0039d316-1c4b-4281-b951-d872f2087c98
* AppLauncher cleanup.oshima@chromium.org2010-03-193-21/+18
| | | | | | | | | | | Pass browser to ctor as AppLauncher is created per browser instance. BUG=chromium-os:1795 TEST=none Review URL: http://codereview.chromium.org/1085006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42111 0039d316-1c4b-4281-b951-d872f2087c98
* Fix extension installed bubble, so that it points to the correct page action ↵mirandac@chromium.org2010-03-193-18/+19
| | | | | | | | | | | icon when more than one page action is visible. BUG= 38255 TEST= see bug report; this should no longer be reproducible. Review URL: http://codereview.chromium.org/1083002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42110 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks for login panels:sky@chromium.org2010-03-193-10/+37
| | | | | | | | | | | | | | | . Allows widget to go transparent even if wm says it isn't supported. See comment I added as to why I'm allowing it. . Makes font bold. . Sets property on window so window manager knows chrome has painted. This avoids the gray flash. BUG=none TEST=none Review URL: http://codereview.chromium.org/1149001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42108 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42091 - Refactor apprelated manifest properties so that they don'tandybons@chromium.org2010-03-1912-50/+55
| | | | | | | | | | | | | | | include the name 'app'. I think these will be useful for normal extensions, too. Also extract an ExtensionExtent class out of Extension. I think this will be useful for passing by value to the IO thread. Review URL: http://codereview.chromium.org/1025006 TBR=aa@chromium.org Review URL: http://codereview.chromium.org/1120005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42104 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 42061 - Enable tabbed bookmark manager by default due to ↵andybons@chromium.org2010-03-199-136/+109
| | | | | | | | | | | | | | browser_tests and chrome frame breaking. BUG=4890 TEST=None Review URL: http://codereview.chromium.org/1139001 TBR=arv@chromium.org Review URL: http://codereview.chromium.org/1146004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42103 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dependency from webkit on chrome/common by moving files to src/app.pinkerton@chromium.org2010-03-1932-37/+37
| | | | | | | | BUG=37985 TEST=no functional change. Review URL: http://codereview.chromium.org/1060001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42101 0039d316-1c4b-4281-b951-d872f2087c98
* Uses GURL instead of host for requesting Geolocation permission.bulach@chromium.org2010-03-194-191/+36
| | | | | | | | | Tidy up GeolocationPermissionContext. (in preparation for http://codereview.chromium.org/1033004). Review URL: http://codereview.chromium.org/1074004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42099 0039d316-1c4b-4281-b951-d872f2087c98
* Status area update fix on language switches.glotov@google.com2010-03-191-0/+2
| | | | | | | | | | | BUG=35248 TEST=Switch the language used by the ChromiumOS using the top left corner menu of the Network selection wizard. Or you may use the following command on desktop using Chromium (built with GYP_DEFINES="chromeos=1"): out/Debug/chrome --login-manager --login-screen=network Review URL: http://codereview.chromium.org/1107003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42092 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor app-related manifest properties so that they don'taa@chromium.org2010-03-1912-55/+50
| | | | | | | | | | | | include the name 'app'. I think these will be useful for normal extensions, too. Also extract an ExtensionExtent class out of Extension. I think this will be useful for passing by value to the IO thread. Review URL: http://codereview.chromium.org/1025006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42091 0039d316-1c4b-4281-b951-d872f2087c98
* Move text_elider from app/gfx to app/ben@chromium.org2010-03-1917-18/+18
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42090 0039d316-1c4b-4281-b951-d872f2087c98
* Honor select-all on tab-away when omnibar is empty (gtk)tony@chromium.org2010-03-192-5/+26
| | | | | | | | | | | | | | | | | Also added a browser test for this case. The bug is an ordering error, possibly because the programmer was unaware that GetStateForTabSwitch can actually mutate the selection state, for the odd case outlined in bug 38385. BUG=38385 TEST=Delete URL from omnibar. Create tab, delete tab. URL should be reverted and selected. Patch by Matthew Willis <appamatto@gmail.com> Review URL: http://codereview.chromium.org/1047004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42085 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files to toplevel gfx.ben@chromium.org2010-03-1955-64/+64
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42071 0039d316-1c4b-4281-b951-d872f2087c98
* Extension popups now stay open and drag while inspector is open, when ↵rafaelw@chromium.org2010-03-191-4/+14
| | | | | | | | | | | browser is dragged BUG=24477 TEST=go to chrome://extensions, turn on dev mode. install an extension with a browser action. right click->inspect popup, then drag browser window. popup should stay open and follow browser window Review URL: http://codereview.chromium.org/1109006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42070 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Issue 33145: Content Editable Move Image or Selected Block of Text Brokenrolandsteiner@chromium.org2010-03-191-2/+8
| | | | | | | | | | | | | The cause was that the original source mask only specified "Copy" as allowed operations, while the destination operation is "Move". Changed the code to allow both "Copy" and "Move" (in line with the GTK implementation). Note that this patch does not touch or implement the TODO(snej) issues, i.e., allow for operations other than move or copy. BUG=33145 TEST=see bug description Review URL: http://codereview.chromium.org/1097001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42069 0039d316-1c4b-4281-b951-d872f2087c98
* Win7: Show download progress in superbar.mhm@chromium.org2010-03-191-1/+38
| | | | | | | | | | | Use ITaskbarList3 interface to show progress bar when downloading items. BUG=8039 TEST=Download a couple of files, notice it progress. Look at the screenshot in the main issue. Review URL: http://codereview.chromium.org/944001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42066 0039d316-1c4b-4281-b951-d872f2087c98
* Add GeolocationContentSettingsMap, a geolocation-specific variant of ↵pkasting@chromium.org2010-03-197-1/+576
| | | | | | | | | | | | | HostContentSettingsMap. This was originally written by bulach and posted at http://codereview.chromium.org/1033004 ; modified and landed by me. BUG=37206 TEST=Tested by unittests TBR=bulach,joth Review URL: http://codereview.chromium.org/1084005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42064 0039d316-1c4b-4281-b951-d872f2087c98
* Enable tabbed bookmark manager by default. arv@chromium.org2010-03-199-109/+136
| | | | | | | | | BUG=4890 TEST=None Review URL: http://codereview.chromium.org/1139001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42061 0039d316-1c4b-4281-b951-d872f2087c98
* Modification of ExtensionPopup views to allow for pop-up views to share the ↵twiz@chromium.org2010-03-1911-33/+163
| | | | | | | | | | | | same network stack as their hosting views. A new RenderViewHostDelegate interface has been added, AutomationRequestRouting, which can be implemented on RenderViewHost objects to return the data-structures used to pass network requests through Chrome-Frame host networking, or the native Chrome network stack. BUG=None TEST=None Review URL: http://codereview.chromium.org/906003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42057 0039d316-1c4b-4281-b951-d872f2087c98
* Removing unnecessary DCHECK from SafeBrowsing interstitial.jschuh@google.com2010-03-191-1/+0
| | | | | | | | | BUG=30079 TEST=None. Review URL: http://codereview.chromium.org/1131003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42049 0039d316-1c4b-4281-b951-d872f2087c98
* Combine similar code from sync unit tests and add additional unit tests for ↵zork@chromium.org2010-03-194-204/+233
| | | | | | | | | | | typed url syncing. BUG=none TEST=run unit tests Review URL: http://codereview.chromium.org/1124002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42048 0039d316-1c4b-4281-b951-d872f2087c98
* Disable SessionHistoryTest.HistoryLength as it's hanging the Win Dbg bot.jhawkins@chromium.org2010-03-191-0/+4
| | | | | | | | BUG=38583 TEST=none Review URL: http://codereview.chromium.org/1092004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42039 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Prevent entering raw control characters in Omnibox.shess@chromium.org2010-03-193-1/+67
| | | | | | | | | | | | | The code already intercepted some of the shady ways for entering raw control characters. This also handles some cases which weren't intercepted by doCommandBySelector:. BUG=38345 TEST=Try to enter Ctrl-Q Enter, C-Q TAB, Ctrl-Alt-Enter and Ctrl-Alt-TAB in Omnibox. Review URL: http://codereview.chromium.org/1008003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42036 0039d316-1c4b-4281-b951-d872f2087c98
* Remove button padding work around now that WebKit has been fixed.arv@chromium.org2010-03-192-11/+0
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/1128005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42035 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeOS: Label LoginPromptTest.TestDigestAuth as flaky. It's failing under ↵thestig@chromium.org2010-03-191-0/+4
| | | | | | | | | | Valgrind sometimes. BUG=38580 TEST=ChromeOS Valgrind stays consistently green. Review URL: http://codereview.chromium.org/1123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42032 0039d316-1c4b-4281-b951-d872f2087c98
* Fix launching Clear Browsing Data dialog from the history page.feldstein@chromium.org2010-03-182-2/+14
| | | | | | | | | | | | | | | | | | | | The problem here was that the modal dialog would block, while it didn't block on windows. Since it was launched from a standard Chrome task (the DOMUI call), it would block all other Chrome tasks. The callbacks from the BrowsingDataRemover to let the window know to close was a Chrome task, and so would deadlock since it couldn't tell the dialog to close until the dialog was closed. I spun it off into a cocoa event using |performSelector:afterDelay:| with 0 delay which freed up Chrome tasks to be processed again. BUG=37976 TEST=Launch clear browsing data dialog from history and make sure you can clear the history and it closes itself. Also ensure it still works as expected from menu and preferences. Review URL: http://codereview.chromium.org/1129002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42028 0039d316-1c4b-4281-b951-d872f2087c98
* When adding a new page in the bookmark bar, allow the "new folder" to be the ↵jrg@chromium.org2010-03-181-6/+16
| | | | | | | | | | | | | | | | | parent. BUG=36531 TEST=\ 1) In bookmark bar, "Add Page" from context menu. Create a new folder, select it. Type something in the URL and name then OK. Make sure the new bookmark is in the new folder. 2) Same thing but make 2 (nested) "add folder"s with the bookmark down in there. Review URL: http://codereview.chromium.org/1136001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42027 0039d316-1c4b-4281-b951-d872f2087c98
* Disable ProcessSingletonWinTest.StartupRaceCondition as it's failing ↵jhawkins@chromium.org2010-03-181-2/+2
| | | | | | | | | | | consistently. TBR=thestig BUG=38572 TEST=none Review URL: http://codereview.chromium.org/1139002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42024 0039d316-1c4b-4281-b951-d872f2087c98
* Send session history offset and length parameters in the Navigate message todarin@chromium.org2010-03-188-38/+53
| | | | | | | | | | | | | keep the renderer's notion of those values properly synchronized with the NavigationController. R=brettw BUG=18062 TEST=see session_history_uitest.cc Review URL: http://codereview.chromium.org/1090002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42022 0039d316-1c4b-4281-b951-d872f2087c98
* Move clock menu button to the right as per UI design.chocobo@chromium.org2010-03-181-6/+6
| | | | | | | | BUG=none TEST=The order of status menu buttons from left to right are: language, network, power, clock Review URL: http://codereview.chromium.org/1134003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42019 0039d316-1c4b-4281-b951-d872f2087c98