summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Move alternate error page loading out of WebFrame.darin@chromium.org2009-08-021-35/+126
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make the RenderView be in charge of loading alternate error pages. While working on this change, I noticed several related bugs: 1- Loading an URL with an invalid host name from the new tab page results in an error page. If you hit back and then forward, you will be left with an empty location bar. In a debug build this trips an assertion in ClassifyNavigation because the given page_id is -1. This problem is caused by not duplicating the NavigationState of the failed load when creating a load for the error page. Hence, the pending_page_id of the forward navigation is lost. 2- Loading an URL with an invalid host name as a subframe results in an extra navigation in session history. One navigation for the main frame and one navigation for the error page load. This is another symptom of the problem described in #1. However, the solution is different. Here, we need to know that the subframe load is an AUTO_SUBFRAME load so that we load the error page using 'replace' semantics (so that WebCore does not generate a new session history entry). Finally, I decided to restrict alternative DNS error pages to only work for the main frame to match what we do for alternative 404 error pages. It doesn't seem worth it to show link doctor results for subframes since their primary purpose is to assist people who mis-type an URL. R=tony,brettw BUG=15648 TEST=covered by errorpage_uitest.cc Review URL: http://codereview.chromium.org/159575 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22253 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling back change 22245.chrome-bot@google.com2009-08-0216-459/+125
| | | | | | | | | | | | Too much red :-( BUG=None TEST=None TBR=erikkay Review URL: http://codereview.chromium.org/159763 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22247 0039d316-1c4b-4281-b951-d872f2087c98
* mole expand/collapse API, callable from a toolstrip for manual operationerikkay@chromium.org2009-08-0116-125/+459
| | | | | | Review URL: http://codereview.chromium.org/160276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22245 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to land: http://codereview.chromium.org/160483aa@chromium.org2009-08-0111-190/+375
| | | | | | | | | | | | | | | | | | Ever closer. Extract a client interface out of CrxInstaller and use it to implement ExtensionInstallUI. There is (still) no dialog here. But the next CL will, um, definitely have it. Also, fixed the issue with theme preview infobars not updating if you install a theme while another one is already previewed. TBR=mpcomplete@chromium.org BUG=17932 Review URL: http://codereview.chromium.org/160501 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22244 0039d316-1c4b-4281-b951-d872f2087c98
* Update Hunspell to the latest stable version to use the latest bdict format.mhm@chromium.org2009-08-012-5/+5
| | | | | | | | | | Updated Hunspell to version 1.2.8 which properly deals with UTF8 and fixes many bugs. This CL will use the BDict format and remove the usage of FileMgr. Removed the unwanted "key" parameter constructors from hunspell since we are managing them through bdict. Removed all line numbers from the errors since we don't support that. BUG= 14756 (http://crbug.com/14756) TEST= Compiled Hunspell, Compiled Chromium, Ran Chromium, Fixed some of my spelling mistakes. Ran unit tests for SpellCheckTest.* Review URL: http://codereview.chromium.org/155841 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22243 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Fix painting issues where GTK theme engine was painting over ↵erg@chromium.org2009-08-011-12/+12
| | | | | | | | | | | | | | buttons. So it looks like some themeing engines in distros more recent than Hardy paint random boxes of the default background if you don't pass an explicit clip area to gtk_paint_shadow(). http://crbug.com/18129 Review URL: http://codereview.chromium.org/159754 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22242 0039d316-1c4b-4281-b951-d872f2087c98
* retry r2226, with a fix for a case where we could double free.estade@chromium.org2009-08-016-29/+102
| | | | | | Review URL: http://codereview.chromium.org/160495 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22241 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix Valgrind error in VisitedLinkEventsTest.Coalescense.derat@chromium.org2009-08-011-1/+5
| | | | | | | | | | | | | | I introduced the error in r22193; it shows up when there's no X server to connect to. I get a "GLib-GObject-CRITICAL **: g_object_get: assertion `G_IS_OBJECT (object)' failed" message with this change, but I'm not sure if it's from my code or if it was already there, and the tests still pass. TEST=ran VisitedLinkEventsTest.Coalescense under Valgrind with DISPLAY=:6 Review URL: http://codereview.chromium.org/159753 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22240 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile error.nsylvain@chromium.org2009-08-011-1/+1
| | | | | | Review URL: http://codereview.chromium.org/159755 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22236 0039d316-1c4b-4281-b951-d872f2087c98
* revert 22226 as it caused some ui test crashesestade@chromium.org2009-08-016-103/+29
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/160491 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22235 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unrelated bustage... ALLOW_THIS...ben@chromium.org2009-08-011-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22233 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback 22228aa@chromium.org2009-08-0111-374/+189
| | | | | | TBR=mpcomplete@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22231 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak of GtkWidgets in NativeViewHost, and in doing so fix a crash on ↵ben@chromium.org2009-08-011-0/+6
| | | | | | | | | | | | | shutdown due to a check in OwnedWidgetGtk for unbalanced refcnt. The NativeViewHostGtk now owns the GtkWidget attached to it for the lifetime of its attachment. This removes my crazy ownership games from before and makes it a lot simpler. BUG=none TEST=none Review URL: http://codereview.chromium.org/159751 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22230 0039d316-1c4b-4281-b951-d872f2087c98
* Status bubble limping in TOOLKIT_VIEWS.ben@chromium.org2009-08-012-63/+25
| | | | | | | | | | | Add CreateTransparentFloatingWidget method to Widget and add Init/SetContentsView methods. BUG=none TEST=none Review URL: http://codereview.chromium.org/160474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22229 0039d316-1c4b-4281-b951-d872f2087c98
* Ever closer. Extract a client interface out of CrxInstaller andaa@chromium.org2009-07-3111-189/+374
| | | | | | | | | | | | | | | use it to implement ExtensionInstallUI. There is (still) no dialog here. But the next CL will, um, definitely have it. Also, fixed the issue with theme preview infobars not updating if you install a theme while another one is already previewed. BUG=17932 Review URL: http://codereview.chromium.org/160483 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22228 0039d316-1c4b-4281-b951-d872f2087c98
* Typo fixestade@chromium.org2009-07-311-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22227 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Theme our link button.estade@chromium.org2009-07-316-29/+103
| | | | | | | | BUG=17772 Review URL: http://codereview.chromium.org/159748 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22226 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some character literals to use the right escape string.pkasting@chromium.org2009-07-311-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/159714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22222 0039d316-1c4b-4281-b951-d872f2087c98
* Since bookmark copy/paste is not impl on non-Windows platforms, don't remove ↵estade@chromium.org2009-07-311-0/+5
| | | | | | | | | | | | | nodes when cutting. BUG=18152 TEST=none TBR=erg Review URL: http://codereview.chromium.org/160488 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22221 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we tried to get the position of the tabstriptc@google.com2009-07-312-9/+18
| | | | | | | | | | | | | but the tabstrip wasn't in our widget hierarchy for app mode windows. Now we always put the tabstrip in the hierarchy, even if we don't show it. BUG=18202 Review URL: http://codereview.chromium.org/159745 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22218 0039d316-1c4b-4281-b951-d872f2087c98
* Fix or/|| mistake in ifdefstuartmorgan@google.com2009-07-311-1/+1
| | | | | | | | | | TBR=mark BUG=none TEST=none Review URL: http://codereview.chromium.org/160487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22216 0039d316-1c4b-4281-b951-d872f2087c98
* CHECK that IOBuffer::data_ in AsyncResourceHandler is not NULL before ↵willchan@chromium.org2009-07-311-0/+2
| | | | | | | | | | caching it. BUG=http://crbug.com/16371 Review URL: http://codereview.chromium.org/159730 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22214 0039d316-1c4b-4281-b951-d872f2087c98
* LocationBarView::PageActionImageView::LoadImageTask::Run() may pass a NULL ↵mirandac@chromium.org2009-07-311-0/+2
| | | | | | | | | | | image pointer through to OnImageLoaded; make sure that the pointer is not dereferenced in these cases. BUG= http://crbug.com/18140 TEST= none. Review URL: http://codereview.chromium.org/159711 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22213 0039d316-1c4b-4281-b951-d872f2087c98
* Convert parts of SavePage UI tests to more reliable browser tests.phajdan.jr@chromium.org2009-07-313-50/+126
| | | | | | | | | | | Use a real notification for download completion - that's the main unflakying point. TEST=none http://crbug.com/3791 Review URL: http://codereview.chromium.org/160480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22212 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds accelerators to the Linux toolkit views.jcampan@chromium.org2009-07-314-6/+8
| | | | | | | | | | | The MessageLoop had to be modified to support Dispatchers on Linux. BUG=None TEST=On Windows and Linux, make sure the accelerators still work as expected. On Linux toolkit views, build and run the unit-tests. Review URL: http://codereview.chromium.org/159046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22210 0039d316-1c4b-4281-b951-d872f2087c98
* Switch on plugins by default for the Macstuartmorgan@google.com2009-07-311-1/+1
| | | | | | | | | BUG=10809 TEST=Visit a sit with Flash content. Playback should work, interacting with the plugin is still buggy. Review URL: http://codereview.chromium.org/159729 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22209 0039d316-1c4b-4281-b951-d872f2087c98
* Revert changes from r22198 to r22204 and r22194. None of these changes werekuchhal@chromium.org2009-07-313-35/+31
| | | | | | | | | supposed to be commited. Seems like git took all the temporary commits from the base branch and uploaded them to svn. Review URL: http://codereview.chromium.org/159736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22206 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix cast breakage from 22193 (hopefully).derat@chromium.org2009-07-311-3/+6
| | | | | | Review URL: http://codereview.chromium.org/159737 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22205 0039d316-1c4b-4281-b951-d872f2087c98
* cleanupkuchhal@chromium.org2009-07-312-11/+11
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22200 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring of master preferences parsing before adding a new preference.kuchhal@chromium.org2009-07-313-30/+34
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22198 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Autodetect whether the custom frame should be used.derat@chromium.org2009-07-314-3/+56
| | | | | | | | | | | | | | | | | | | | | | | Listing a bunch of strings from WMs' source sucks, but I can't think of any way to detect tiling WMs that don't support the EWMH (see the bug and the comment in this CL), so this seems safer. Tested with the following: - wiped out related prefs and started chrome under ion3; custom frame not used - quit and started under metacity; custom frame *was* used - toggled custom frame pref off and restarted under metacity again; custom frame not used - toggled it back on and restarted under ion3; custom frame was used BUG=15861 TEST=see above Review URL: http://codereview.chromium.org/160374 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22193 0039d316-1c4b-4281-b951-d872f2087c98
* Enable dragging of images to desktop (Finder), Preview, etc. (on Mac).thakis@chromium.org2009-07-314-141/+452
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This hooks up drag-and-drop of file promises, lazy writing to the drag pasteboard, drag-sourcing of TIFF images (via Cocoa) and file contents. Patch Set 5 improvements: Adds asynchronous writing of promised files. Patch Set 4 improvements: Big refactoring -- drag source stuff is now handled by the WebDragSource (Cocoa) object, with messages proxied through the TabContentsViewCocoa object. The WebDragSource object carries a weak reference to the TCVC, owns the WebDropData, and keeps track of the drag pasteboard types/promises. Patch Set 3 improvements over Patch Set 2: It shouldn't crash anymore. Made drop_data_ reference counted, in anticipation of asynchronous file writing. TODO #1: Testing. Still need a unit test, maybe. Should make sure that dragging by file contents actually works. TODO #2 (in some other patch): Refactor some of the WebDropData extraction code out, e.g., file name extraction should be made common with other platforms. TODO #3 (in some other patch): We really should make WebDropData cheaper to copy around and retain. I'm not convinced it's a good idea to push out the entire thing over IPC, especially since the data pushed could be very big and may not even be used. BUG=15640 TEST=drag images to various applications Patch by viettrungluu@gmail.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22187 0039d316-1c4b-4281-b951-d872f2087c98
* Make spacing between "theme" buttons same as spacing between "browsing data"thakis@chromium.org2009-07-311-1/+1
| | | | | | | | | | | buttons. BUG=none TEST=Open Options->Personal Stuff and note that it looks better than before. Review URL: http://codereview.chromium.org/160467 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22182 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding r22155 (GTK Themes: Use theme colors in the text view in the ↵erg@google.com2009-07-312-21/+100
| | | | | | | | | | | | location bar.) Fixed build issues with Ben's help. Original Review URL: http://codereview.chromium.org/159671 Review URL: http://codereview.chromium.org/160466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22181 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash in bookmark menus. Specifically if you had a menusky@chromium.org2009-07-311-0/+77
| | | | | | | | | | | | | | | showing and brought up the context menu and clicked a separator we would do the wrong thing. We would try to show the first menu again, without cancelling out of the inner loop, which would most likely result in a crash. The right thing to do in this case is not close the context menu (this behavior can be seen in windows as well). BUG=17862 TEST=see bug, but also covered by ui test now. Review URL: http://codereview.chromium.org/160458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22180 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at Safari Import - Home Page & History Only.jeremy@chromium.org2009-07-315-3/+356
| | | | | | Review URL: http://codereview.chromium.org/159668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22179 0039d316-1c4b-4281-b951-d872f2087c98
* Revert a part of r22173 that caused a compile failure on Win dbg.jhawkins@chromium.org2009-07-311-1/+1
| | | | | | | TBR=rafaelw Review URL: http://codereview.chromium.org/160470 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22177 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Ctrl+shift+q for quitestade@chromium.org2009-07-311-1/+2
| | | | | | | | | | yay BUG=17819 Review URL: http://codereview.chromium.org/159722 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22175 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Get Themes" button to gtk options dialog.estade@chromium.org2009-07-313-12/+27
| | | | | | | | BUG=17641 Review URL: http://codereview.chromium.org/160416 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22174 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Check the return value of DictionaryValue::GetString.jhawkins@chromium.org2009-07-311-5/+5
| | | | | | | | | CID=4199,4685 BUG=none TEST=none Review URL: http://codereview.chromium.org/159677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22173 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Check the return value of ExecuteJavaScriptAndExtractString.jhawkins@chromium.org2009-07-311-8/+8
| | | | | | | | | CID=5133 BUG=none TEST=none Review URL: http://codereview.chromium.org/159676 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22172 0039d316-1c4b-4281-b951-d872f2087c98
* Implement FindBarGtk::StopAnimation().estade@chromium.org2009-07-314-3/+9
| | | | | | | | | | Not convinced it's 100% necessary but it can't hurt. BUG=11979 Review URL: http://codereview.chromium.org/159715 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22170 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Show shortcuts in title bar context menu and tab context menu.estade@chromium.org2009-07-314-52/+50
| | | | | | | | BUG=17936 Review URL: http://codereview.chromium.org/159721 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22169 0039d316-1c4b-4281-b951-d872f2087c98
* Make TOOLKIT_VIEWS port use views-based Autocomplete popup.ben@chromium.org2009-07-3119-1006/+245
| | | | | | | | | | | | The popups now interact with the edit via AutocompleteEditView rather than the platform-specific types. Note this also removes the old omnibox popup code. It hasn't been active for some time. BUG=none TEST=none Review URL: http://codereview.chromium.org/160378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22168 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in creating search terms where we weren't unescapingsky@chromium.org2009-07-312-1/+6
| | | | | | | | | | | correctly. BUG=17697 TEST=covered by unit tests Review URL: http://codereview.chromium.org/159707 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22167 0039d316-1c4b-4281-b951-d872f2087c98
* Use real KVO notification for the default browser text.avi@chromium.org2009-07-311-8/+3
| | | | | | | | | BUG=none TEST=make sure the default browser explanatory text stays working. Review URL: http://codereview.chromium.org/159708 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22164 0039d316-1c4b-4281-b951-d872f2087c98
* I give up. Reverting all attempts at fixing the gtk-view bustage.erg@google.com2009-07-312-77/+21
| | | | | | | | Reverts r22161,r22159,r22155 Review URL: http://codereview.chromium.org/159719 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22163 0039d316-1c4b-4281-b951-d872f2087c98
* Show an icon and the page title in the custom frame when it's antc@google.com2009-07-313-17/+185
| | | | | | | | | | | | | | app mode window or a popup window. The icon will become a clockwise spinning throbber when pages are loading. BUG=16049 TEST=Open a window using --app=http://google.com/ and click on a few links. Review URL: http://codereview.chromium.org/160427 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22157 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Use theme colors in the text view in the location bar.erg@google.com2009-07-312-21/+77
| | | | | | | | Tested with a bunch of light and dark themes. Review URL: http://codereview.chromium.org/159671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22155 0039d316-1c4b-4281-b951-d872f2087c98
* Add "Get themes" button to the prefs.avi@chromium.org2009-07-312-0/+19
| | | | | | | | | BUG=none TEST=you get a button "get themes" that takes you to the theme gallery. Review URL: http://codereview.chromium.org/160455 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22153 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-15 19:34:51 +0000