summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Implement GTK dropdown menus.estade@chromium.org2009-03-184-23/+108
| | | | | | | | These are used for <select> html items, for example. Review URL: http://codereview.chromium.org/48054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11991 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build break.estade@chromium.org2009-03-181-1/+0
| | | | | | | | tbr=avi Review URL: http://codereview.chromium.org/48139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11988 0039d316-1c4b-4281-b951-d872f2087c98
* Fix underflow that would cause either an access violation or an infinite ↵robertshield@google.com2009-03-181-2/+3
| | | | | | | | loop if we were ever to get a "chrome_config" node back in metrics response data. Review URL: http://codereview.chromium.org/42335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11983 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BrowserWindow::Init().estade@chromium.org2009-03-187-111/+99
| | | | | | | | This belongs as a private method of BrowserView. Neither mac nor linux uses it. Review URL: http://codereview.chromium.org/42298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11982 0039d316-1c4b-4281-b951-d872f2087c98
* Fix errors detected by coverity.paulg@google.com2009-03-181-6/+6
| | | | | | Review URL: http://codereview.chromium.org/48136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11981 0039d316-1c4b-4281-b951-d872f2087c98
* Adds Get(Root)WindowRect handlers for the Mac.avi@google.com2009-03-187-61/+113
| | | | | | | | Fixes http://crbug.com/8829 . Review URL: http://codereview.chromium.org/42336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11980 0039d316-1c4b-4281-b951-d872f2087c98
* Reland the changes to use command line switch to turn on worker feature.jianli@chromium.org2009-03-181-0/+1
| | | | | | Review URL: http://codereview.chromium.org/48106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11975 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of base/ref_counted.h.thestig@chromium.org2009-03-189-10/+0
| | | | | | Review URL: http://codereview.chromium.org/48105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11974 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dragging a Chrome window which has a single tab by the tab itself.idanan@chromium.org2009-03-181-7/+1
| | | | | | | | | | | | | | | | | | | A change in 9953 made a tab of a single chrome-window with a single tab part of the client area so that double-clicks on it are not treated as non-client double-clicks and that the tab context-menu appears instead of the system context menu (see issue 3787). That change also solved issue 2827 (which is not restructed to the close button of the right-most tab). Change 10929 reverted 9953 partially, keeping the sinle-tab of a single-window as part of the client area but removed the double-click swallowing code that was needed to fix 2827. In doing so, dragging a single-tabbed single chrome window by the tab (not the tabstrip) no longer worked. This small changes only fixes that behavior. It turns out that there was a use case where some users want double-clicks to be considered as two single-clicks (see issue 8287) and swallowing the double-click breaks this. Review URL: http://codereview.chromium.org/46033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11973 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an assertion I added in my DOM UI change. It looks like this happens inbrettw@chromium.org2009-03-181-5/+0
| | | | | | | some cases and doesn't represent an actual problem. Review URL: http://codereview.chromium.org/48134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11966 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a few minor issues found during static analysis of the Chromium codebase.finnur@chromium.org2009-03-182-3/+3
| | | | | | | | | | | | | | | | | | | | | | find_bar_controller.cc: Unused local variable created. hwnd_view.cc: The local definition of parent overshadows param passed in. google_update.cc: Uninitialized member variable. webframe_impl.cc: The if was overly constrained. At the top of the function there is an if (reset) { ... return; } so we don't need to check for !reset in the next if statement. This functionality is covered by a ui_test, which passes with this change. Review URL: http://codereview.chromium.org/42321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11964 0039d316-1c4b-4281-b951-d872f2087c98
* Port DirectoryWatcher to Linux using inotify.phajdan.jr@chromium.org2009-03-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11962 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11953.hbono@chromium.org2009-03-183-73/+1
| | | | | | Review URL: http://codereview.chromium.org/48121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11954 0039d316-1c4b-4281-b951-d872f2087c98
* A tricky fix for Issue 1845.hbono@chromium.org2009-03-183-1/+73
| | | | | | | | | | | | | | | | | This change is a very tricky fix for Issue 1845 in chromium: cant alignt text to the right using right shift and right ctrl.This change consists of two parts listed below. 1. Emulating the implementation of Safari that changes the text-direction of an input element. Safari uses context menus to change the text direction. This change adds an IPC message 'ViewMsg_SetTextDirection', which notifies the new text direction. Also, it adds two functions: RenderWidgetHost::UpdateTextDirection() and RenderWidgetHost::NotifyTextDirection(). They encapsulate the new IPC message so that we can use them both when we presses a set of keys and when we add context-menu items which change the text direction. 2. Calling the above interface when pressing right-shift and right-control keys, or when left-shift and left-control keys. This modifies the RenderWidgetHostViewWin::OnKeyEvent() function and call the above text-direction interfaces when a user finishes pressing the keys. As you can imagine, if we send an IPC message every time when we receive a WM_KEYDOWN event, we continue sending IPC messages while a user is pressing the keys. BUG=1845 Review URL: http://codereview.chromium.org/39252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11953 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bogus DCHECKabarth@chromium.org2009-03-181-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11938 0039d316-1c4b-4281-b951-d872f2087c98
* SSLPolicy Fix: Step 8.abarth@chromium.org2009-03-184-144/+267
| | | | | | | | | | | Cleanup the SSLPolicy API. This should be the last reorganization patch. The next step should be the substantive changes. R=jcampan BUG=8706 Review URL: http://codereview.chromium.org/48091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11937 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark work. jrg@chromium.org2009-03-1826-85/+689
| | | | | | | | | | | | | | | | | | | | | - The bookmark menu is populated dynamically with bookmarks, including subfolders --> submenus. E.g. star something --> shows up in menu. Menu items are disabled but always present and current. - Always Show Bookmarks" menu now live; reads from / writes to preference, and shows correct "toggle state". - Bookmark bar on each tab, present if requested. (Currently an empty box). - Random stuff; e.g. bookmark prefs init moved to a x-plat location. This CL does not contain Cole's views. Bried english description of the nib file changes: - add a new view for the bookmark bar in the tab; hook it up to the controller - Many tag sets (e.g. View-->Always Show Bookmarks Bar now 40009) - Remove dummy bookmark menu items Review URL: http://codereview.chromium.org/46078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11936 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of base/hash_tables.h.thestig@chromium.org2009-03-174-4/+0
| | | | | | Review URL: http://codereview.chromium.org/48098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11928 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where an extension toolstrip would sometimes get added twice to thempcomplete@google.com2009-03-171-3/+11
| | | | | | | | | bookmark bar. The problem was that sometimes the EXTENSIONS_LOADED notification would get sent before we initialized the bookmark view (which adds the initial extension toolstrips). Review URL: http://codereview.chromium.org/42252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11927 0039d316-1c4b-4281-b951-d872f2087c98
* Merge DOMUIContents into WebContents.brettw@chromium.org2009-03-1745-1216/+1153
| | | | | | | I did a lot of cleanup of the DOM UI system as part of this. Review URL: http://codereview.chromium.org/42227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11925 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash on showing info bubble.sky@google.com2009-03-171-6/+4
| | | | | | | | | BUG=8854 TEST=see bug Review URL: http://codereview.chromium.org/42302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11924 0039d316-1c4b-4281-b951-d872f2087c98
* Renames AccessibleWrapper to ViewAccessibilityWrapper for clarity. klink@chromium.org2009-03-171-2/+2
| | | | | | | | Reorders the functions in ViewAccessibility to match the order used in BrowserAccessibility, accessibility.h and in Glue/WebKit. Review URL: http://codereview.chromium.org/46011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11914 0039d316-1c4b-4281-b951-d872f2087c98
* Use anonymous shared memory for VisitedLinks.agl@chromium.org2009-03-172-20/+4
| | | | | | | | | | | | | | We already pass a handle to the shared memory via IPC but, when we create it, we create a named segment. These segments are not garbage collected on POSIX. Since nobody actually uses the name of the segment, use an anonymous segment instead and remove the functions. Review URL: http://codereview.chromium.org/48087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11900 0039d316-1c4b-4281-b951-d872f2087c98
* This test only passed if RLZTracker::InitRlz hadn't been called, levin@chromium.org2009-03-171-3/+11
| | | | | | | | | | so it failed when the test run order happened to change. This change fixes that. Review URL: http://codereview.chromium.org/42283 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11899 0039d316-1c4b-4281-b951-d872f2087c98
* First pass at Mac status bubble.avi@google.com2009-03-175-2/+300
| | | | | | Review URL: http://codereview.chromium.org/48070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11895 0039d316-1c4b-4281-b951-d872f2087c98
* SSLPolicy Fix: Step 7.abarth@chromium.org2009-03-172-263/+103
| | | | | | | | | | | Simplify SSLPolicy to prepare for changing its algorithm. This change should not change the SSLPolicy behavior at all. R=jcampan BUG=8706 Review URL: http://codereview.chromium.org/48060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11892 0039d316-1c4b-4281-b951-d872f2087c98
* SSLPolicy Fix: Step 6.abarth@chromium.org2009-03-173-17/+69
| | | | | | | | | | | | | Merge in changes to SSLHostState. We now can store whether a specific origin is "broken," which is the key new bit of state that we need to share between tabs. Currently, there is a naming inconsistency between the SSLManager names and the SSLHostState names. I'll clear this up when I merge in the new SSLManager. R=jcampan BUG=8706 Review URL: http://codereview.chromium.org/42274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11891 0039d316-1c4b-4281-b951-d872f2087c98
* Don't initialize members from themselves, especially when they're uninitialized.mark@chromium.org2009-03-171-1/+1
| | | | | | Review URL: http://codereview.chromium.org/42286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11880 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where favicons wouldn't always show up in history page. Thissky@google.com2009-03-171-1/+8
| | | | | | | | | | | | | | would happen for an URLs that contained parens. These need to be escaped when using in CSS. BUG=none TEST=Go to a page that has parens in it (such as http://en.wikipedia.org/wiki/The_Wire_(season_5) ). Then open up history and make sure you get a favicon for the site. Review URL: http://codereview.chromium.org/48043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11876 0039d316-1c4b-4281-b951-d872f2087c98
* Register more prefs on linux/mac.tc@google.com2009-03-171-6/+5
| | | | | | | Review URL: http://codereview.chromium.org/48052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11875 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup GTK toolbar tooltips. Move from GtkTooltips to GtkTooltip API.deanm@chromium.org2009-03-172-17/+6
| | | | | | | | | | | | | Move away from the deprecated GtkTooltips API, instead using the preferred methods on GtkWidget. Add missing tooltips to the back and forward buttons. This also fixes a memory leak of the old tooltips object which is no longer needed. BUG=8868 Review URL: http://codereview.chromium.org/48068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11873 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that MenuGtks are destroyed before their accelerator group.deanm@chromium.org2009-03-173-30/+26
| | | | | | | | | | | | | When a MenuGtk is created, it is passed a GtkAccelGroup. Previously the GtkMenu widgets were destroyed after the browser window, which was the owner of the GtkAccelGroup. Make the toolbar own a reference to the GtkAccelGroup, and teardown all GtkMenus that reference it beforehand. Some MenuGtk cleanup while debugging the problem. BUG=8866 Review URL: http://codereview.chromium.org/48065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11872 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Enable building worker and use command line switch to turn on ..."agl@chromium.org2009-03-171-1/+0
| | | | | | | This reverts commit 11870. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11871 0039d316-1c4b-4281-b951-d872f2087c98
* Enable building worker and use command line switch to turn on this feature.jianli@chromium.org2009-03-171-0/+1
| | | | | | Review URL: http://codereview.chromium.org/41029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11870 0039d316-1c4b-4281-b951-d872f2087c98
* Use devtool_ prefix instead of dev_tools_ to be consistent with the rest code.yurys@google.com2009-03-175-11/+11
| | | | | | Review URL: http://codereview.chromium.org/42281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11863 0039d316-1c4b-4281-b951-d872f2087c98
* Don't leak AutocompleteEditViewGtk objects. I meant reset() not release().deanm@chromium.org2009-03-171-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/48066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11859 0039d316-1c4b-4281-b951-d872f2087c98
* Initial unit tests implementation.yurys@google.com2009-03-175-13/+151
| | | | | | Review URL: http://codereview.chromium.org/42233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11855 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing file.abarth@chromium.org2009-03-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11854 0039d316-1c4b-4281-b951-d872f2087c98
* SSLPolicy Fix: Step 5.abarth@chromium.org2009-03-173-7/+7
| | | | | | | | | | | | Add a new notification type to notify other SSLManagers when a security origin becomes contaminated with mixed content. TBR=wtc BUG=8706 Review URL: http://codereview.chromium.org/48059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11853 0039d316-1c4b-4281-b951-d872f2087c98
* Porting unit tests in chrome/phajdan.jr@chromium.org2009-03-172-6/+8
| | | | | | | | | | | | | | | | | Enable following tests on Linux: browser/autocomplete/autocomplete_unittest.cc browser/navigation_controller_unittest.cc browser/search_engines/template_url_model_unittest.cc browser/sessions/session_backend_unittest.cc browser/tab_contents/web_contents_unittest.cc Remove not-existing file from remove list for Linux. Check for zero-size write in SessionBackend because it's an error in POSIX (but is ok from the session backend's perspective). Review URL: http://codereview.chromium.org/42223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11852 0039d316-1c4b-4281-b951-d872f2087c98
* SSLPolicy Fix: Step 3.abarth@chromium.org2009-03-178-35/+86
| | | | | | | | | | | Plumbing the security origin of the frame making the request to SSL land. R=wtc BUG=8706 Review URL: http://codereview.chromium.org/48038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11851 0039d316-1c4b-4281-b951-d872f2087c98
* SSL Fix: Step 4.abarth@chromium.org2009-03-176-9/+34
| | | | | | | | | | | | Plumb the security origin information for memory cache loads too. R=wtc BUG=8706 Review URL: http://codereview.chromium.org/42263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11850 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot these two files.ben@chromium.org2009-03-172-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11842 0039d316-1c4b-4281-b951-d872f2087c98
* Move controls into their own dir under chrome/views/controlsben@chromium.org2009-03-17129-267/+263
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/48058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11841 0039d316-1c4b-4281-b951-d872f2087c98
* Move focus related files into a new chrome/views/focus subdirben@chromium.org2009-03-1710-11/+11
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/48056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11837 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustage - file movedben@chromium.org2009-03-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11836 0039d316-1c4b-4281-b951-d872f2087c98
* bustage fix - moved fileben@chromium.org2009-03-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11831 0039d316-1c4b-4281-b951-d872f2087c98
* bustage fix - moved fileben@chromium.org2009-03-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11830 0039d316-1c4b-4281-b951-d872f2087c98
* bustage fix - moved fileben@chromium.org2009-03-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11829 0039d316-1c4b-4281-b951-d872f2087c98
* bustage fix - file movedben@chromium.org2009-03-175-5/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11828 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-12 11:52:31 +0000