| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
extensions that are loaded after EXTENSIONS_READY.
Review URL: http://codereview.chromium.org/140065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I noticed a Font dialog used the system locale (not the application locale) to display the localzed font name of a CJK font, i.e. we can retrieve this localized font name with a GetTextFace() call. This change just retrieves the localized font name of the given font with a GetTextFace() call before initializing a CHOOSEFONT object.
BUG=3803 <http://crbug.com/3803>
TEST=run Chrome on Simplified Chinese XP; open the "Fonts and Languages" dialog;click the "Change" for "Sans-Serif Font", and; verify its "font" editbox shows the localized font-name of "simsun".
Review URL: http://codereview.chromium.org/119416
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Rearranged the windows and mac ports to use the cross platform interfaces. Updated windows fonts and languages to use those interfaces. As well, created stubs for mac platform.
BUG=13524 (http://crbug.com/13524)
TEST=Open a webpage with a textfield, right click and choose Spell checker options > Language Settings. Tested this on windows as well.
Review URL: http://codereview.chromium.org/140043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none, just re-enabling some disabled tests.
Review URL: http://codereview.chromium.org/113789
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/14763
TEST=Enable themes; status bubble color should reflect changed theme. Otherwise, status bubble color should not change.
Review URL: http://codereview.chromium.org/140016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Following the same approach as the general tab page..
BUG=11507
TEST=The Personal stuff tab is fully functioning, the prefs save correctly.
Review URL: http://codereview.chromium.org/125105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=14783
TEST=Download more than one thing. Shelf shouldn't get bigger everytime an item is added.
Review URL: http://codereview.chromium.org/140041
Review URL: http://codereview.chromium.org/140041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben
Review URL: http://codereview.chromium.org/141013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[retry, fix windows compile failure]
* use a new ChannelHandle type when passing IPC channels over IPC
The current POSIX code assumes that one end of a channel is always a new
child process (a renderer). For plugins we need to be able to construct
channels between each of the browser, plugin, and renderer.
This change augments the messages related to creating channels to allow
passing in a base::FileDescriptor containing the socket. The intent is
that the browser process, as the initial interchange between plugin and
renderer, creates the socketpair() on their behalf and hands each their
respective end of the connection.
* register channel endpoint names in the global pipe map
The plugin code assumes it can map from a string to a channel endpoint
at basically any time. So whenever we get a channel endpoint over IPC,
we install it in a global map of channel endpoints.
Review URL: http://codereview.chromium.org/113157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Don't like that GTK only does app-modal rather than window modal, but otherwise you can just close the parent window and crash when you then click okay on the dialog.
BUG=11507
Review URL: http://codereview.chromium.org/141020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14774
TEST=no
Review URL: http://codereview.chromium.org/140032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Resuscitate the TOOLKIT_VIEWS build by disabling stuff we don't build yet.
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/141012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke the Windows build.
BUG=None
TEST=None
TBR=ben
Review URL: http://codereview.chromium.org/140023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
not subclassed anymore.The FocusManager is now created and owned by top-level WidgetWins.BUG=NoneTEST=Run the unit tests, UI tests, interactive UI tests. Fully test the focus behavior in the browser: activate/deactivate the browser windows, make sure focus is remembered. Switch tabs, make sure focus is remembered for each tab. make sure accelerators work as expected. Test focus traversal in a web page, in the option dialog.
Review URL: http://codereview.chromium.org/125148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18872 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Adds read-write to the client key of google_update
- Adds the logic to track experiment outcome
- Some new geric exitc codes (non error codes)
BUG= b/1484308
TEST= see the bug
Review URL: http://codereview.chromium.org/132058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/140020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/141006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18868 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the tab correctly.
BUG=14126
TEST=Use the "Create application shortcut..." menu to bring up the Gears dialog. Press tab, the focus should move around. Press ESC, the dialog should close.
Review URL: http://codereview.chromium.org/140001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Implements a ConstrainedWindowGtk which positions itself in the center of its corresponding TabContentsViewGtk.
- Implements LoginPromptGtk. HTTP Auth now works under Linux.
- Renames ConstrainedWindowImpl to ConstrainedWindowWin
http://crbug.com/11512
Review URL: http://codereview.chromium.org/132047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
more input and calling parent class forall.
http://crbug.com/14485
Review URL: http://codereview.chromium.org/141004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- SavePageTest.SaveHTMLOnly
- SavePageTest.SaveCompleteHTML
- DownloadTest.UnknownSize
- DownloadTest.IncognitoDownload
BUG=14746,14755
TEST=no
Review URL: http://codereview.chromium.org/139006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This reverts commit f2f30e9d0108f4a776672c6b29d25ed3a8ad19ad.
Review URL: http://codereview.chromium.org/140013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes us a better citizen in OSX text-editing land and is a first step in getting our text entry story to work more natively on OSX.
The selectors are added at runtime to the Cocoa class and invoking them causes the appropriate WebKit core command to be invoked on the currently focused WebFrame.
As a side-effect bug 10862 is fixed.
BUG=10862
TEST=Open a new tab and type some text into an input element, change to a Hebrew keyboard layout and hit command-a, all text should be selected.
Review URL: http://codereview.chromium.org/114070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
friendly when running in purify.
Review URL: http://codereview.chromium.org/139004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18852 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r18850, as it had a compile failure.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18851 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* use a new ChannelHandle type when passing IPC channels over IPC
The current POSIX code assumes that one end of a channel is always a new
child process (a renderer). For plugins we need to be able to construct
channels between each of the browser, plugin, and renderer.
This change augments the messages related to creating channels to allow
passing in a base::FileDescriptor containing the socket. The intent is
that the browser process, as the initial interchange between plugin and
renderer, creates the socketpair() on their behalf and hands each their
respective end of the connection.
* register channel endpoint names in the global pipe map
The plugin code assumes it can map from a string to a channel endpoint
at basically any time. So whenever we get a channel endpoint over IPC,
we install it in a global map of channel endpoints.
Review URL: http://codereview.chromium.org/113157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also notify other browser windows of changes to the order.
BUG=http://code.google.com/p/chromium/issues/detail?id=12123
TEST=browser_tests.exe --gtest_filter=ExtensionShelfModelTest.*
Review URL: http://codereview.chromium.org/131114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
catch the case when the user closes the last tab in a tabstrip. In this case, we add ourselves as a message loop observer and never get a chance to remove ourselves before the tabstrip is destroyed.
BUG=14648
TEST=Open a new window and press the close button on the tab. The browser should not crash.
Review URL: http://codereview.chromium.org/140006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18843 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
and stores it in user prefs, where it can be used by the new tab page.
BUG = http://crbug.com/13363
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=18766
Review URL: http://codereview.chromium.org/125052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18842 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
DownloadRequestManager is the object that manages the number of downloads
that can occur in a given tab. It throttles non-user initiated downloads
to prevent carpet-bombing download attacks.
Enabling this object for Mac fixes the issue where we can only download
one file in a given tab.
BUG=None (mac work).
TEST=Can now download more than one item in a tab.
Review URL: http://codereview.chromium.org/132039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18840 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
See: http://codereview.chromium.org/126098
Patch from Jerry Tang <tangjie@google.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It only passes on the build bots because they still have old directories, I
think? AbsolutePath() on POSIX will fail if the path doesn't exist. We let
the program march on in that case and the normal error handling (that would
handle the non-existent path) make the tests continue to pass.
Review URL: http://codereview.chromium.org/132054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18834 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=14665
TEST=Download something, check that "show all downloads" text is on
shelf, click it, check that the downloads tab opens.
Review URL: http://codereview.chromium.org/132073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Thanks to zhu.she.pi@gmail.com for finding the bug
BUG=14631
TEST=no test
Review URL: http://codereview.chromium.org/131066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests for it.
Not used quite yet, since the metadata database still needs to be integrated into PasswordStoreMac.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/131076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/131118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=fields in the middle of being editing should not save the value.
Review URL: http://codereview.chromium.org/131113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
automatically selecting a client certificate when an SSL server
requests client authentication.
This switch will be removed when we implement client certificate
selection UI.
Also fix some cpplint.py nits.
R=jcampan
BUG=http://crbug.com/318
TEST=none
Review URL: http://codereview.chromium.org/131090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/132071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make ImporterHost aware of the current parent window and use that
as parent for the warning dialog.
BUG=13481
TEST=Start Firefox, try to import profile in Chrome and make sure the warning dialog is modal.
Review URL: http://codereview.chromium.org/131080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this means that the printing is done async instead of the fully synchronous mode the normal full page printing is.
This means we create an in memory copy of the selected text for printing.
This is the next step to move to fully async printing with print frame support.
This change also removes the print on demand functionality that was no longer used.
BUG=http://crbug.com/1682
TEST=The print dialog on Windows now contains an option to print selection only. Test that with various pages and various selections.
Review URL: http://codereview.chromium.org/125082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also correctly handle crashes in task manager. The infobar allows user to restart the extension process.
TEST=Install buildbot extension, see its content in the shelf. Open task manager, kill extension process. Click "restart" in the infobar that should appear. The extension content in the shelf should re-appear after the crash.
http://crbug.com/14111
Review URL: http://codereview.chromium.org/126289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
handle the case of restoring when there are no browsers open by making window restore re-use a given browser if it has no tabs. Removed unit test that assumes it can pass a NULL Browser. Wrote a new UI test to cover the same area, but it's disabled until another bug is fixed, and I didn't want to hold up landing this feature. Added key shortcut for "open window in incognito mode".
BUG=13758
TEST=restoring closed tabs with visible windows and with no windows remaining open.
Review URL: http://codereview.chromium.org/125257
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18806 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, the Windows taskbar (put differently, work area) is not considered
in getting the last window bounds (while it is for the saved window bounds).
This causes new windows (CTRL-N) appear to the left/up of the existing window
instead of right/down, if the taskbar is on left or top.
TESTED=gcl try, manually
TEST=Place the taskbar on left or top of the screen and create new Chrome windows by CTRL-N and observe.
BUG=14131
Review URL: http://codereview.chromium.org/125179
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18795 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We already discard all stability info when we do an upgrade to a new
version, as there is less concern about stats from old versions. This
change just adds the list of "old logs" (gathered in previous sessions,
presumably with an old version) to the list of data that is discarded.
BUG=14657
r=evanm
Review URL: http://codereview.chromium.org/131089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
AutocompletePopupWin would be leaked when the browser view is closed.
BUG=None
TEST=Make sure Chrome can be opened/closed without crasher.
Review URL: http://codereview.chromium.org/132050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18791 0039d316-1c4b-4281-b951-d872f2087c98
|