summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Constrain the gtk menu popup to the bounds of the current monitor.jhawkins@chromium.org2009-05-051-4/+9
| | | | | | Review URL: http://codereview.chromium.org/106001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15262 0039d316-1c4b-4281-b951-d872f2087c98
* Add a RENDERER_PROCESS_CLOSED notification that gets sent when we close thempcomplete@google.com2009-05-054-12/+15
| | | | | | | | | | RenderProcessHost's process_. This is similar to RENDER_PROCESS_TERMINATED, but the latter is not always sent since the process could get reused. It also takes the place of RENDERER_PROCESS_CRASHED, where this one contains a boolean Details indicating whether the process crashed (true) or just exited (false). Review URL: http://codereview.chromium.org/100277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15261 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: enable omni box ui test and automation proxy ui test.estade@chromium.org2009-05-057-28/+37
| | | | | | | | Enable a lot of (already essentially working) automation code along the way. Review URL: http://codereview.chromium.org/100278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15258 0039d316-1c4b-4281-b951-d872f2087c98
* Port the folder selector portion of the BookmarkEditor to GTK.erg@google.com2009-05-059-97/+770
| | | | | | | | | | | | | | | Mirrors the BookmarkEditorView method, where the contents of BookmarkModel are copied to a temporary model so changes can be discarded if the user hits Cancel. In the GTK version, we copy not into another BookmarkModel, but into a GtkTreeStore, which serves as a model to the GtkTreeView on screen. Also ports the unit tests. http://crbug.com/11250 Review URL: http://codereview.chromium.org/99361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15257 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: show the correct cursor when the render view regains focus.estade@chromium.org2009-05-051-1/+2
| | | | | | | | BUG=11407 Review URL: http://codereview.chromium.org/105002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15256 0039d316-1c4b-4281-b951-d872f2087c98
* Highlight the next find result when the return key is pressed in the Linux ↵jhawkins@chromium.org2009-05-052-31/+34
| | | | | | | | find bar. Review URL: http://codereview.chromium.org/99376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15255 0039d316-1c4b-4281-b951-d872f2087c98
* Several minor visual fixes to toolstrips:aa@chromium.org2009-05-045-46/+57
| | | | | | | | | | | | | | | | | | | | | | | | | | | * Layout toolstrips on the left of the bookmark bar so that something always obviously happens when you install one. This is in response to some feedback I've gotten demoing toolstrips for various people. * Open the NTP on install if the bookmarkbar isn't visible. Again, I'm trying to make something happen when you install an extension. This won't be the permanent behavior but it seems like doing nothing if you have your bookmark bar detached is likely to confuse people. * Fix a bug where we kept trying to resize the toolstrip back to the width it had when it was first made visible. * Fix a bug where we didn't always repaint the bookmarkbar after the toolstrip preferred width changed. This also seems to fix the issue where the buildbot sample shows up overlayed on top of tab contents, though I didn't mean to fix that with this CL. Review URL: http://codereview.chromium.org/100310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15249 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 9812: Remove current RSS code in favor of new more generalizedfinnur@chromium.org2009-05-0414-196/+5
| | | | | | | | | | | | PageAction code that serves the same purpose (and more). BUG=9812 TEST=No test needed, this shouldn't result in any noticable difference since the RSS parsing was disabled. Review URL: http://codereview.chromium.org/100356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15247 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in search provider. It wasn't setting template_url andsky@chromium.org2009-05-042-0/+11
| | | | | | | | | | | correct fill_into_edit for keywords. BUG=11416 TEST=see bug Review URL: http://codereview.chromium.org/100350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15245 0039d316-1c4b-4281-b951-d872f2087c98
* Undo part of brettw's WebContents refactor that removed TabContentsDelegatempcomplete@google.com2009-05-043-7/+112
| | | | | | | | | code from HtmlDialogView. BUG=http://code.google.com/p/chromium/issues/detail?id=9884 Review URL: http://codereview.chromium.org/99305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15238 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of aesthetic nits about infobars that have been broken since I ↵ben@chromium.org2009-05-042-6/+30
| | | | | | | | | | | | redid them a few months back. - close button is properly centered horizontally - animation looks correct - layout no longer dependent on current frame height http://crbug.com/11389 Review URL: http://codereview.chromium.org/99332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15237 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux ui tests broken by r15112.estade@chromium.org2009-05-042-16/+8
| | | | | | | | | | also re-enable tests that I disabled in an attempt to green the bot TBR=tony Review URL: http://codereview.chromium.org/100351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15234 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable failing ui tests on linux.estade@chromium.org2009-05-041-0/+12
| | | | | | | | TBR=cpu Review URL: http://codereview.chromium.org/100348 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15229 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes focus issues when browsing on Mac.rohitrao@chromium.org2009-05-042-2/+8
| | | | | | | | | | http://crbug.com/10032 TEST=Open a new tab and browse to www.google.com. Type something and check that focus is correctly set to the text field. Review URL: http://codereview.chromium.org/99327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15226 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: tweak find bar.estade@chromium.org2009-05-048-27/+28
| | | | | | | | | - (attempt to) fix find bar z ordering in a simpler way - get "close without animation" right. Review URL: http://codereview.chromium.org/100286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15225 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate wstring version of PathService::Get() in unit tests.thestig@chromium.org2009-05-046-48/+44
| | | | | | Review URL: http://codereview.chromium.org/100292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15221 0039d316-1c4b-4281-b951-d872f2087c98
* Change in enable-spellcheck checkbox in Languages Options Tab should not be ↵sidchat@google.com2009-05-042-4/+6
| | | | | | | | | considered unless OK is clicked. Issue=11013 Review URL: http://codereview.chromium.org/99095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15219 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Linux find bar look a bit better.deanm@chromium.org2009-05-045-12/+27
| | | | | | | | | | - Fake some anti-aliasing so the text entry matches the next/prev images. - Match padding pixel perfect with Windows. Review URL: http://codereview.chromium.org/99275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15217 0039d316-1c4b-4281-b951-d872f2087c98
* Remove "output=chrome" as the Suggest team has deprecated it server-side.pkasting@chromium.org2009-05-041-3/+2
| | | | | | | BUG=1660988 Review URL: http://codereview.chromium.org/102024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15212 0039d316-1c4b-4281-b951-d872f2087c98
* Reset the omnibox contents when the user reloads the page. Patch by Yusuke ↵pkasting@chromium.org2009-05-048-0/+24
| | | | | | | | Sato (see http://codereview.chromium.org/100198 ), r=me. BUG=2985 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15211 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Wire existing shortcutto out of process devtools.pfeldman@chromium.org2009-05-041-16/+20
| | | | | | Review URL: http://codereview.chromium.org/99345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15210 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some recently small size / position regressions in Linux Omnibox.deanm@chromium.org2009-05-042-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/100343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15204 0039d316-1c4b-4281-b951-d872f2087c98
* Fix find in page. When fixing the conflict after updating, I accidentallybrettw@chromium.org2009-05-041-0/+5
| | | | | | | removed the code that updates the find in page commands. Review URL: http://codereview.chromium.org/100331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15202 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression that the sad tab favicon is not displayed when a tab crashes.brettw@chromium.org2009-05-042-2/+8
| | | | | | | | | | | | | | This regressed in my favicon/title updating change because the crashed state is not updated on the codepath, since it comes from the tab. The other approach would have been to make this call through the "update everything" codepath for tbe state changing, but that's executed on a timer, and it's nice to show the tab crash right away since the check is very inexpensive. BUG=http://crbug.com/10756 Review URL: http://codereview.chromium.org/99341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15201 0039d316-1c4b-4281-b951-d872f2087c98
* More linux build fixesbrettw@chromium.org2009-05-041-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15197 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux build.brettw@chromium.org2009-05-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/99339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15196 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the mac build from my WebContents rename.brettw@chromium.org2009-05-042-3/+2
| | | | | | Review URL: http://codereview.chromium.org/100329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15195 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-04174-1391/+1189
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* linux: set the window icon (used in alt-tab list, etc.)evan@chromium.org2009-05-042-0/+13
| | | | | | | | BUG=11354 Review URL: http://codereview.chromium.org/100303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15192 0039d316-1c4b-4281-b951-d872f2087c98
* roll back r15177ben@chromium.org2009-05-0416-16/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15191 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15180.ben@chromium.org2009-05-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/100323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15188 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15181.ben@chromium.org2009-05-041-2/+1
| | | | | | Review URL: http://codereview.chromium.org/100322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15187 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15182.ben@chromium.org2009-05-047-56/+56
| | | | | | Review URL: http://codereview.chromium.org/101024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15186 0039d316-1c4b-4281-b951-d872f2087c98
* Bustage fix:ben@chromium.org2009-05-047-56/+56
| | | | | | | | | | Add back these files which I removed earlier since Linux is using them. The resources are duplicate until I collapse them into src/app/ later this week. Review URL: http://codereview.chromium.org/100320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15182 0039d316-1c4b-4281-b951-d872f2087c98
* Make the header include of views_strings.h here windows-only, temporarily ↵ben@chromium.org2009-05-041-1/+2
| | | | | | (we duplicate the strings in generated_resources.h) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15181 0039d316-1c4b-4281-b951-d872f2087c98
* Bustage fix for mac and linux:ben@chromium.org2009-05-041-1/+1
| | | | | | | | | | Duplicate views strings and rename them to uniquify them to get mac and linux going again. TODO(beng): move these strings into the forthcoming app/ dependency so that mac linux and windows can rely on it. Review URL: http://codereview.chromium.org/99335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15180 0039d316-1c4b-4281-b951-d872f2087c98
* Extract all views resources into:ben@chromium.org2009-05-0416-2/+16
| | | | | | | | | | | | | views_strings.[grd,vcproj] views_resources.[grd,vcproj] Moves views images (.png files) from app/theme to views/resources dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15177 0039d316-1c4b-4281-b951-d872f2087c98
* Blind fix for ChromeBot crashes.mal@chromium.org2009-05-031-1/+3
| | | | | | | | | | | | | | | | | | | | | A ChromeBot run for 172.17 was very top heavy (77/103 crashes) with: [vector:703] std::vector<PasswordManagerTableModel::PasswordRow *,std::allocator<PasswordManagerTableModel::PasswordRow *> >::size() [browser_init.cc:140] `anonymous namespace'::NotifyNotDefaultBrowserTask::Run() [message_loop.cc:308] MessageLoop::RunTask(Task *) I'm going to try a null check on |tab| before we invoke tab->infobar_delegate_count(). This applies the change made to 172 to trunk. TBR= jcampan,ben BUG= 11388 Review URL: http://codereview.chromium.org/99331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15176 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two bugs in the omnibox2 popup:ben@chromium.org2009-05-031-11/+12
| | | | | | | | | - popup frequently flashes white after being updated. This was because rows weren't being laid out after being added so they had zero size after async changes to the model. - text ran off the right side because DrawStringFragment wasn't clamping the output width to the available width. Does this now, and so eliding works. Review URL: http://codereview.chromium.org/101023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15171 0039d316-1c4b-4281-b951-d872f2087c98
* Fix multiple instances of first run dialog appearing when Chrome is started ↵robertshield@google.com2009-05-035-23/+50
| | | | | | | | | | again while a first run dialog is visible. Also cause the original first run dialog to come to foreground. BUG=http://crbug.com/10765 Review URL: http://codereview.chromium.org/99281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15170 0039d316-1c4b-4281-b951-d872f2087c98
* Allowing the client to handle escape and keyup events.tommi@google.com2009-05-022-7/+15
| | | | | | Review URL: http://codereview.chromium.org/99293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15142 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the following CL (it was breaking the UI tests because ajcampan@chromium.org2009-05-025-3/+143
| | | | | | | | | | | | | | | | | | | | | | | | | NOTREACHED() would be triggered in that case). If Chrome is not the default browser, tell the user, unless: - it is the first run - the user already said not to warn him/her about it - an info-bar is already showing. BUG=9049 TEST=Run a new install of chrome, proceed through the first run flow, don't make Chrome your default browser. No info-bar warning about Chrome not being the default browser should be shown. Restart Chrome, such an info-bar should be shown. Click the x on the info-bar to close it. Restart Chrome. The info-bar should be shown. Select "Set as default". Restart Chrome, the info-bar should not be shown. Start IE, make it your default browser (Tools menu, 'Internet option', Programs tab). Restart Chrome, it should show the default browser info-bar. Select "Don't ask me again". Restart Chrome, the info-bar should not be shown. Review URL: http://codereview.chromium.org/100287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15137 0039d316-1c4b-4281-b951-d872f2087c98
* Yet more deprecation of the wstring version of PathService::Get() for UI tests.thestig@chromium.org2009-05-0212-44/+37
| | | | | | Review URL: http://codereview.chromium.org/99298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15127 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome/chromium icons as PNGs.ben@chromium.org2009-05-022-2/+6
| | | | | | | | | | | | Also, add support to NativeButton for rendering as default independently of behaving as default. This will be used by the default browser infobar. Adds methods to the infobar delegate interface to allow the delegate to specify that it wants its Accept button to appear as the default button. http://crbug.com/9049 Review URL: http://codereview.chromium.org/100288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15125 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15115, it sadly breaks the ui tests.jcampan@chromium.org2009-05-015-140/+3
| | | | | | | TBR=beng Review URL: http://codereview.chromium.org/100285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15122 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix inverted infobubble logic.evan@chromium.org2009-05-011-1/+1
| | | | | | Review URL: http://codereview.chromium.org/100282 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15118 0039d316-1c4b-4281-b951-d872f2087c98
* Don't try and install extensions when --enable-extensions isn'taa@chromium.org2009-05-011-12/+28
| | | | | | | | | | | on. Also, pop up a dialog telling the user they probably forgot to turn on the flag. Review URL: http://codereview.chromium.org/99295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15116 0039d316-1c4b-4281-b951-d872f2087c98
* If Chrome is not the default browser, tell the user, unless:jcampan@chromium.org2009-05-015-3/+140
| | | | | | | | | | | | | | | | | | | | | | - it is the first run - the user already said not to warn him/her about it - an info-bar is already showing. BUG=9049 TEST=Run a new install of chrome, proceed through the first run flow, don't make Chrome your default browser. No info-bar warning about Chrome not being the default browser should be shown. Restart Chrome, such an info-bar should be shown. Click the x on the info-bar to close it. Restart Chrome. The info-bar should be shown. Select "Set as default". Restart Chrome, the info-bar should not be shown. Start IE, make it your default browser (Tools menu, 'Internet option', Programs tab). Restart Chrome, it should show the default browser info-bar. Select "Don't ask me again". Restart Chrome, the info-bar should not be shown. Review URL: http://codereview.chromium.org/99301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15115 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the issue with Options menu fonts display bigger than size of fonts ↵sidchat@google.com2009-05-012-18/+43
| | | | | | | | actually set. This was happening because Windows Font Picker returns font size in points, whereas the corresponding pref members for serif, sans-serif and fixed-width fonts expect font size in pixels.Issue=7806TEST: Go to options > fonts and languages > fonts tab and change serif font to 16 and click OK. Then open a new Tab page - the corresponding fonts should be that size.NOTE: I don't know why the div element set to 16pt serif font is not the same height as that shown by the font picker. That is a separate issue I think. Review URL: http://codereview.chromium.org/100228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15114 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes Chrome on par with Firefox in terms of 'GetSuggestedFilename' ↵jungshik@google.com2009-05-0110-6/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | for file download via context-menu. For a download initiated with a click on a link in a web page, a webkit-side change is necessary, which will be done later. Add a field (referrer_charset) to URLRequestContext and DownloadCreateInfo. It's set to the character encoding of a document where the download request originates from when it's known (download initiated via "save as" in the context menu). If it's not known (a download initiated by clicking on a download link or typing a url directly to the omnibox), it's initialized to the default character encoding in the user's preference. I guess this is marginally better than leaving it empty (in that case, step 2b below will be skipped and step 2c will be taken) because a user has a better control over how raw 8bit characters in C-D are interpreted (especially on Windows where a reboot is required to change the OS default codepage). This is later passed to GetSuggestedFilename and used as one of fallback encodings (1. UTF-8, 2. origin_charset, 3. default OS codepage). With this change, we support the following: 1. RFC 2047 2. Raw-8bit-characters : a. UTF-8, b. origin_charset, c. default os codepage. 3. %-escaped UTF-8. In this CL, for #3, I didn't add a fallback similar to one used for #2. If necessary, it can be added easily. New entries are added to 3 existing tests. What's previously not covered (raw 8bit Content-Disposition header) is now covered in all 3 tests. BUG=1148 TEST=net unit test: NetUtilTest.GetFileNameFromCD NetUtilTest.GetSuggestedFilename unittest : DownloadManagerTest.TestDownloadFilename Review URL: http://codereview.chromium.org/83002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15113 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-10 07:20:09 +0000