| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
Issue 6477: Support modifier clicks on UI elements Mouse event flags transformed to WindoOpenDisposition so that browser commands can all inteterpert event modifiers. Implemented home, forward and backwards middle-click andshift middle click. Previously working on issue 358 which was market a duplicate and concerned with the home and tabstrip subset of this behavior: Can't open a new tab by middle-clicking home button. No functionality has been lost or altered, only the use ofmodifiers give access to increased functionality.
BUG=6477
TBR=maruel
Review URL: http://codereview.chromium.org/53020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Note that this only works if you are using a gnome or kde session. Support for other sessions will be added in the future.
Review URL: http://codereview.chromium.org/52034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also, don't alphabetize available spellchecker locale codes.
Review URL: http://codereview.chromium.org/42531
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=idanan
Review URL: http://codereview.chromium.org/42571
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mouse event flags transformed to WindoOpenDisposition so that
browser commands can all inteterpert event modifiers. Implemented
home, forward and backwards middle-click andshift middle click.
Previously working on issue 358 which was market a duplicate
and concerned with the home and tabstrip subset of this behavior:
Can't open a new tab by middle-clicking home button.
No functionality has been lost or altered, only the use ofmodifiers
give access to increased functionality.
BUG=6477
TBR=ben@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
close button.
Review URL: http://codereview.chromium.org/50079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
need the message and can just put an actual URL in the page.
BUG=8961
Review URL: http://codereview.chromium.org/49014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We now correctly reset the background color on tab switches, and navigations from a ssl to non-ssl page.
BUG=8236,9225
Review URL: http://codereview.chromium.org/49015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add the progress status text indicator code from the old history page.
Make 'cancel' visible when paused.
More RTL fixes.
BUG=8220,8334
Review URL: http://codereview.chromium.org/42550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
HistoryBackend::first_recorded_time_
BUG=8827
Review URL: http://codereview.chromium.org/42546
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
first.
BUG=8583
TEST=see bug
Review URL: http://codereview.chromium.org/42566
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/45033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- enable following tests on Linux:
browser/net/resolve_proxy_msg_helper_unittest.cc
browser/profile_manager_unittest.cc
browser/sessions/tab_restore_service_unittest.cc
common/time_format_unittest.cc
- sync chrome.gyp
- fix a bug in resolve_proxy_msg_helper_unittest that triggered
a DCHECK on POSIX.
It freed the WaitableEvent too early because Wait in dtor
was effectively a noop because the event was already in signaled
state from previous operations and a manual-reset flag was set.
The fix was to put the WaitableEvent in automatic reset mode.
- misc GCC-related cleanups
http://crbug.com/9227
Review URL: http://codereview.chromium.org/53007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flag):
- Add new devtools IPC message
- Expose WebView's hit target
- Refactor dom_agent interaction not to send information known to client
- Collect incoming messages on the client until frontend is loaded
- Add Inspect Element scenario into the devtools_host_stub
Review URL: http://codereview.chromium.org/45022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The function had confusing semantics, was marked to be removed,
and could induce flakiness in tests which used it.
WaitForWindowCountToBecome is much better replacement for it.
Review URL: http://codereview.chromium.org/49007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
results.
Review URL: http://codereview.chromium.org/42262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12347 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
There's a typo in resource_message_filter.cc that disallows
media request context being used for any requests. This
patch fixes it.
Review URL: http://codereview.chromium.org/42548
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the title in the task manager, and show an infobar when a page's workers die.
I also cleaned up the code in RenderView which creates a window and widget, since when I originally wrote it I wasn't aware of RenderViewHost::FromID.
Review URL: http://codereview.chromium.org/45025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8334
Review URL: http://codereview.chromium.org/42544
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
the css user script information to chrome-ui://extensions/
Review URL: http://codereview.chromium.org/49011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
be something that breaks our build.
TBR=aa
Review URL: http://codereview.chromium.org/52029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
messages to the extension process is supported.
Review URL: http://codereview.chromium.org/48090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Replace with renamed NativeButton2, Checkbox2, RadioButton2.
Review URL: http://codereview.chromium.org/50083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following are implemented:
* Keyboard shortcuts for next/prev/close tab.
* Tab layout and rendering.
The following need to be implemented:
* Mouse input handling.
* Animations.
* TabGtk, TabRendererGtk.
* Dragging.
* Fix a NOTREACHED in navigation_controller.cc.
Review URL: http://codereview.chromium.org/42457
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=6468
Review URL: http://codereview.chromium.org/46076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gfx::GetCleanStringFromUrl() got implemented for Mac at some point (I
suspect when fonts landed), so now all of this code should be
portable.
There is a slight difference in how ElideUrl() works, due to font
metric differences, but that should not be relevant to this code.
Review URL: http://codereview.chromium.org/42513
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42519
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetRequestContextForMedia() in ProfileImpl and OffTheRecordProfileImpl
now respect --disk-cache-dir. Since the snippet for getting the path
from --disk-cache-dir is very short, it's not necessary to keep it in
a separate method so I duplicated the snippet and used it in both
classes.
Review URL: http://codereview.chromium.org/42517
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=9082
Since I forwarded CreateOffTheRecordForMedia to
CreateOriginalForMedia, it triggers a DCHECK. Since the
implementation of off the record media cache is not going to be
implemented soon, I duplicated the implementation of
CreateOriginalForMedia.
Review URL: http://codereview.chromium.org/42467
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/52017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/52015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- enable following ui tests on Linux:
history_uitest.cc
inspector_controller_uitest.cc
browser/history/redirect_uitest.cc
browser/locale_tests_uitest.cc
browser/sanity_uitest.cc
- move information about Linux-specific splash page
to more generic location and enable more logic
about start page on Linux
- maintainability cleanups (DISABLED_ instead of #if 0)
- misc GCC-related cleanups
Review URL: http://codereview.chromium.org/49006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/47002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window and remote debugger connected over TCP(apavlov is working on it). To allow DevToolsManager coordinate both types of devtools uniformly their API is extracted into DevToolsClientHost interface.
Fix purify errors in DevToolsManager unit tests.
BUG=9150
Review URL: http://codereview.chromium.org/50009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
initializing values into Extension, outputting values to the extension_ui, and appropriate unit test changes
Review URL: http://codereview.chromium.org/42480
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This is also meant to exercise the field trial infrastructure.
r=mbelshe
Review URL: http://codereview.chromium.org/50084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
DownloadRequestManagerTest, URLFetcher*Test, TimeFormat, RenderWidgetTest
Review URL: http://codereview.chromium.org/50081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
in the purify unit test.
Review URL: http://codereview.chromium.org/45021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/45012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
At one point we changed the Clear Browsing Data dialog to remember
the values of the combobox and the checkboxes between runs. Like
with the Options dialog, changes you make take effect immediately
and as such having a Cancel button is misleading. Therefore, I am
proposing we rename it to Close.
BUG=6474
TEST=Open Clear Browsing Data dialog. The button should now say
Close.
Review URL: http://codereview.chromium.org/45019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test for extension user script load and inject.
This add a test that a user script actually gets injected into
pages and runs. Before we only had unit tests for the various
classes and weren't testing the system end-to-end.
Review URL: http://codereview.chromium.org/51003
Patch from Steve Krulewitz <skrulx@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/42439
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
implementation.
Review URL: http://codereview.chromium.org/45016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
deletes that suggestion from the DB.
BUG=6176
TEST=Bring up the autofill popup in a form. Select an item and press the Del key. The item should be removed from the popup and should not show on subsequent autofill popups.
Review URL: http://codereview.chromium.org/42258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This DCHECK occurs when we click Allow on the "This webpage is trying to download multiple files" dialog.
When...
DownloadRequestDialogDelegate
... and ...
DownloadRequestDialogDelegateWin
... were created, both classes by accident contained a host_ member.
This causes a DCHECK in...
DownloadRequestDialogDelegateWin::DeleteDelegate()
... because the host_ in the child class is never initialized. I
believe the intent is to check the host_ of the parent class, so
I deleted the definition of host from xxxDelegateWin.
Review URL: http://codereview.chromium.org/50072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/50073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
--bookmark-menu.
BUG=3206
TEST=Turn on the bookmark menu via --bookmark-menu and make sure it
works. Also make sure I didn't break anything on the bookmark bar.
Review URL: http://codereview.chromium.org/42460
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This consolidates the shutdown path. We used to have two paths depending
of whether the user hit the X on the window manager or used wrench -> exit.
Now both do the same thing: call BrowserWindowGtk::Close().
Review URL: http://codereview.chromium.org/42372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
- less things #ifdef-ed
- replaced Windows-specific functions with portable equivalents
Review URL: http://codereview.chromium.org/50059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12213 0039d316-1c4b-4281-b951-d872f2087c98
|