summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Test has failed a few times in the current waterfall display. The bug that ↵thomasvl@chromium.org2009-10-161-1/+2
| | | | | | | | | | enabled it is still open, so tagging it to that bug and just marking as flaky. TEST=none BUG=20809 Review URL: http://codereview.chromium.org/276060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29275 0039d316-1c4b-4281-b951-d872f2087c98
* Popup width and height are now dynamic.erikkay@chromium.org2009-10-1622-72/+161
| | | | | | | | | BUG=24471 TEST=none Review URL: http://codereview.chromium.org/273046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29274 0039d316-1c4b-4281-b951-d872f2087c98
* Flagging as flaky again, they like to fail with some frequency on Chromium ↵thomasvl@chromium.org2009-10-161-2/+2
| | | | | | | | | | | XP but not the testers. TBR=finnur@chromium.org TEST=none BUG=23686 Review URL: http://codereview.chromium.org/284011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29271 0039d316-1c4b-4281-b951-d872f2087c98
* Disable backspace until I have fixed it in IME mode.thakis@chromium.org2009-10-161-2/+0
| | | | | | | | | BUG=25000 TEST=hit opt-u backspace. Browser should not go back a page. Browser should in fact never go back when you hit backspace. Review URL: http://codereview.chromium.org/288002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29270 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac theme provider so it returns nil when there is no theme provided ↵avi@chromium.org2009-10-162-19/+29
| | | | | | | | | | | color. Partial revert of r28560. BUG=http://crbug.com/24551 TEST=as in bug Review URL: http://codereview.chromium.org/274069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29269 0039d316-1c4b-4281-b951-d872f2087c98
* Keep the "place bookmarks here" text vertically centered on the Mac.avi@chromium.org2009-10-162-0/+15
| | | | | | | | | | | | BUG=http://crbug.com/24934 TEST=the text should be vertically centered always: - confirm text is vertically centered when bookmark bar is visible - confirm text is vertically centered when bookmark bar is set to "not visible" but on the new tab page so it is floating Review URL: http://codereview.chromium.org/281009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29267 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1613-36/+63
| | | | | | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29258 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29263 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29258.akalin@chromium.org2009-10-1612-61/+34
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29259 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1612-34/+61
| | | | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29258 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in incognito mode when clicking the wrench menu.nick@chromium.org2009-10-161-0/+4
| | | | | | | | | | | | This was a regression recent sync UI changes. This fixes the regression to match the old incognito mode behavior. TBR=tim@chromium.org BUG=25014 TEST=See bug. It doesn't crash anymore. Review URL: http://codereview.chromium.org/283008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29257 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29255.akalin@chromium.org2009-10-1612-61/+34
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29256 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1612-34/+61
| | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29255 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29253.akalin@chromium.org2009-10-1611-60/+33
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29254 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1611-33/+60
| | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29253 0039d316-1c4b-4281-b951-d872f2087c98
* Move autofill related WebView{Delegate} methods into the WebKit API.darin@chromium.org2009-10-1610-105/+118
| | | | | | | | | | | | This CL also changes a bunch of autofill related wstring values to string16. R=jcampan BUG=24595 TEST=none Review URL: http://codereview.chromium.org/279001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29244 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 'Create an account' and 'Help' links on gaia login dialog.tim@chromium.org2009-10-161-4/+4
| | | | | | | BUG=19918,21509 Review URL: http://codereview.chromium.org/267135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29243 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: nick@chromium.orgakalin@chromium.org2009-10-1610-59/+32
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29240 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-1610-32/+59
| | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29239 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up ClientToServerResponse::THROTTLED to the client sync loop.tim@chromium.org2009-10-1613-36/+113
| | | | | | | | TEST=Added SyncerThreadWithSyncerTest.Throttling Review URL: http://codereview.chromium.org/269101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29236 0039d316-1c4b-4281-b951-d872f2087c98
* Removing a synchronous pause that reduces impact on the IO threadhclam@chromium.org2009-10-161-36/+63
| | | | | | | | | | | | | | | | Audio pause is implemented synchronously in the browser process. This can easily choke the IO thread when user does a series of pause of looping a very short audio / video. This change will make the pause action asynchronous. The drawback of this change is that we cannot stop audio playback immediately as we receive the pause request. This is still an improvement over chrome 3.0 as the "playback" period after pause is noticably shorter. Review URL: http://codereview.chromium.org/279010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29234 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an erroneous set of tab change notifications sent whenever closing a tab ↵pkasting@chromium.org2009-10-161-3/+3
| | | | | | | | | | before the current one. GetSelectedTabContents() was using the old |selected_index_|, which was no longer the selected tab, leading to bogus notifications, which in turn caused other problems. BUG=16753 TEST=Open Chrome. Hit ctrl-t twice. Type a few letters. Middle click the tab to the left of the current tab (the first "New Tab" you opened). Your typing should not disappear. Review URL: http://codereview.chromium.org/276052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29233 0039d316-1c4b-4281-b951-d872f2087c98
* Let cmd-` switch windows again.thakis@chromium.org2009-10-161-0/+25
| | | | | | | | | BUG=24817 TEST=Open three windows. Focus web contents. Cmd-` should cycle windows Cmd-shift-` should cycle in the other direction. Review URL: http://codereview.chromium.org/280005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29229 0039d316-1c4b-4281-b951-d872f2087c98
* Within libjingle, add an abstraction of winsock initialization.nick@chromium.org2009-10-161-0/+4
| | | | | | | | | | | | | | | | | | When building chrome, override the default implementation so that we share the winsock initialization singleton with net/base. Trigger the winsock initialization lazily in a few places. This is intended to fix a startup perf regression that appeared when sync (and libjingle) became linked into chrome.dll, rather than a separate delay-loaded sync dll. BUG=24448 TEST=Verified deferred winsock initialization via debugger. Measured before and after time of the StartupTest.PerfTest. Verified sync notification still work. Review URL: http://codereview.chromium.org/267089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29228 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the HTTP cache to use FilePath rather than wstring for thetony@chromium.org2009-10-151-3/+3
| | | | | | | | | | disk cache path. BUG=24672 Review URL: http://codereview.chromium.org/276048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29213 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add theme install bubble.estade@chromium.org2009-10-153-2/+201
| | | | | | | | | BUG=24360 TEST=load a theme Review URL: http://codereview.chromium.org/273074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29212 0039d316-1c4b-4281-b951-d872f2087c98
* Fix status area to use icognito mode background when in icognito mode.chocobo@google.com2009-10-152-10/+18
| | | | | | | | BUG=24970 TEST=none Review URL: http://codereview.chromium.org/274070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29208 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling failing ExternalCookieHandlerTest testsoshima@chromium.org2009-10-151-3/+3
| | | | | | Review URL: http://codereview.chromium.org/271111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29207 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] UMA histogram for uncaught NSExceptions.shess@chromium.org2009-10-153-0/+169
| | | | | | | | | | | | NSExceptions break C++ assumptions. This starts to track how often NSExceptions happen. http://crbug.com/24463 TEST=Brower continues to operate. Review URL: http://codereview.chromium.org/264061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29204 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Trim Omnibox hints as field shrinks.shess@chromium.org2009-10-1513-138/+434
| | | | | | | | | | | | | | | | | When user text doesn't fit with the full hint: "Type to search" hint goes away "Tab to search" condenses to "Tab" "Search Engine:" is truncated http://crbug.com/20285 TEST=Type a sentence. Resize window to see if type-hint goes away. TEST=Type "google". Resize window to see if tab-hint goes away. TEST=Type "google" then TAB, then sentence. Resize window to see if "Search Google:" is truncated. TEST=In all cases, text should not scroll before truncation (though it might move as part of truncation). Review URL: http://codereview.chromium.org/262034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29202 0039d316-1c4b-4281-b951-d872f2087c98
* Facelifts to sync UItim@chromium.org2009-10-1519-97/+352
| | | | | | | | BUG=23136,24858,21596 TEST=SyncSetupWizardTest Review URL: http://codereview.chromium.org/270081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29197 0039d316-1c4b-4281-b951-d872f2087c98
* Get the nexe name from NaCl and send the NaCl process handle and pid to the ↵gregoryd@google.com2009-10-154-29/+62
| | | | | | | | | | renderer TEST=none BUG=http://code.google.com/p/nativeclient/issues/detail?id=108 Review URL: http://codereview.chromium.org/273056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29195 0039d316-1c4b-4281-b951-d872f2087c98
* Fix another memory leak in my unit test.rogerta@chromium.org2009-10-151-2/+6
| | | | | | | | | TEST=none BUG=24769 Review URL: http://codereview.chromium.org/271109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29191 0039d316-1c4b-4281-b951-d872f2087c98
* Provides a certificate for SSL client authentication on NSS sockets.wtc@chromium.org2009-10-151-0/+9
| | | | | | | | | | | | | | | | | | | GUI is still missing, so certificates and private keys have to be stored manually, p.e.: $ pk12util -d sql:$HOME/.pki/nssdb -i PKCS12_file.p12 Adds --auto-ssl-client-auth command-line option to enable this feature. Patch contributed by Jaime Soriano <jsorianopastor@gmail.com>. Original review URL: http://codereview.chromium.org/220009 R=wtc BUG=16830 TEST=Try to connect to a web page that requires SSL authentication and confirm that it connects if and only if a valid certificate is stored in the ~/.pki/nssdb database. Review URL: http://codereview.chromium.org/276037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29188 0039d316-1c4b-4281-b951-d872f2087c98
* Add UI for changing timezones.chocobo@google.com2009-10-1511-268/+476
| | | | | | | | BUG=24876 TEST=none Review URL: http://codereview.chromium.org/267113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29183 0039d316-1c4b-4281-b951-d872f2087c98
* Remove flaky label from ParseFeed tests.finnur@chromium.org2009-10-151-21/+3
| | | | | | | | | | | | These tests have been running fine since my fix. Also removing the traces I added for debugging. TBR=jcampan BUG=23686 TEST=Change is enabling the test. Review URL: http://codereview.chromium.org/273069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29176 0039d316-1c4b-4281-b951-d872f2087c98
* Tracks the amount of memory SQLite is using in the browser processjamesr@chromium.org2009-10-155-0/+28
| | | | | | | | | | | | | This patch adds support for SQLite memory use tracking in the task manager and enables it for the browser process. SQLite can get into the 10s of MB of memory pretty easily and it is nice to see exactly how much of a 'fat' browser process it is responsible for. SQLite is also used in the renderer process for web databases, but since those are behind a flag and off by default I haven't added support for them yet. TEST=none BUG=none Review URL: http://codereview.chromium.org/276009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29173 0039d316-1c4b-4281-b951-d872f2087c98
* Add checkmark image to repository so that try servers can use it in testing ↵tim@chromium.org2009-10-151-0/+0
| | | | | | upcoming patch. TBR=nick git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29172 0039d316-1c4b-4281-b951-d872f2087c98
* didn't mean to add this file.ben@chromium.org2009-10-151-457/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29168 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2009-10-152-1/+458
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29167 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leaks in BlacklistManagerTest.phajdan.jr@chromium.org2009-10-151-17/+38
| | | | | | | | | BUG=21541 TEST=Covered by unit_tests. Review URL: http://codereview.chromium.org/276047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29166 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=http://crbug.com/24459jrg@chromium.org2009-10-158-126/+230
| | | | | | | | TEST=see bug report. Also play with entering and leaving fullscreen. Review URL: http://codereview.chromium.org/269070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29165 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a whole category of frame switching bugs relating to the window z-order ↵ben@chromium.org2009-10-152-10/+34
| | | | | | | | | | | | | | | | | | | | | | | | | being screwed up screwed up when DWM is toggled or themes are installed or reset. The first part of the fix was to remove the hack I put in to hide then show the window while the frame type change occurs. The hack was to work around the fact that upon returning to glass from non-glass, the area identified by BrowserFrameWin::OnNCCalcSize as client was filled with solid black vs. transparent black. I don't know why this fix works, but returning a client size for the opaque frame as 1 pixel different to the window rect causes the blackness bug to not occur, so that's what I did (in addition to removing the hack). I also had to put in a couple of fixes to accommodate the pixel turd we gain in the opaque frame. I renamed ChangeSize to LayoutRootView. When we're using the opaque frame, since the views system is rendering the entire content of the window all the time I always size the widget to the window rect rather than the client rect. http://crbug.com/15424 TEST=change the frame type by: - turning on/off aero glass - installing a theme, then resetting - running an app that forces the DWM off, e.g. the O3D plugin The frame should appear correct after the transition in either direction, and window z-order should be preserved. Review URL: http://codereview.chromium.org/266013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29164 0039d316-1c4b-4281-b951-d872f2087c98
* Default to using system background, text, and link colors on the NTP instead ↵pkasting@chromium.org2009-10-151-0/+10
| | | | | | | | | | of white, black, and blue (respectively). BUG=22967 TEST=Change system theme, start Chrome w/no theme, observe the NTP respects the system colors. Review URL: http://codereview.chromium.org/273043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29155 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: Make badge drawing code cross platform so linux (and eventually ↵estade@chromium.org2009-10-153-36/+55
| | | | | | | | | | | | | mac) can use it. I will switch Windows over to the common function in a follow-up patch. BUG=23882 TEST=gmail browser action sample extension Review URL: http://codereview.chromium.org/279008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29152 0039d316-1c4b-4281-b951-d872f2087c98
* The ParseFeed test was testing too much in one test, hitting the overall ↵finnur@chromium.org2009-10-151-29/+54
| | | | | | | | | | | | | limit for a single browser test. I have therefore split it into three and added a more descriptive error message for when we time out. I will remove the traces and the FLAKY_ label after a successful run or two on the bots. BUG=23686 TEST=Tested by automated test. Review URL: http://codereview.chromium.org/274066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29149 0039d316-1c4b-4281-b951-d872f2087c98
* Update search state when search text is updated through find pasteboard.thakis@chromium.org2009-10-152-4/+34
| | | | | | | | | | | | BUG=none TEST= *Search for something. Switch to textedit, search for something else. Switch back to chrome. The outdated "x of y" text should be invisble in the find bar, but the prev/next find result buttons should be enabled. Hit enter. Pages should be searched, "x of y " text should return. * Open a findbar, search for something. Open new chrome window, hit cmd-f. findbar in new window should contain the text you searched for in the last window. Review URL: http://codereview.chromium.org/267022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29146 0039d316-1c4b-4281-b951-d872f2087c98
* Add a ui test to verify that using the typical_history profiletony@chromium.org2009-10-151-0/+48
| | | | | | | | | | | | results in thumbnails. I could have added this directly to the new tab startup tests, but that would mean turning on DOM automation for the new tab tests. I was trying to avoid the extra code in the new tab startup tests. Review URL: http://codereview.chromium.org/269060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29145 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some debugging code in hopes of isolating a crasher. From thesky@chromium.org2009-10-152-1/+32
| | | | | | | | | | | | crash it appears that we're starting a drag for an index beyond that of the model. BUG=24132 TEST=none Review URL: http://codereview.chromium.org/275023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29144 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug: browser action button disappears when loading a new extension. This ↵sidchat@chromium.org2009-10-151-0/+10
| | | | | | | | | | was happenening because BrowserActionContainer, on receiving notification about an extension load/unload/change, deletes all BrowserAction views, re-adds all the views again, and asks the toolbar to SetBounds for the BrowserActionContainer. However, during deletion, it does not re-set the bounds. As a result, when SetBounds is called by the toolbar again, it does not see any changed in BrowserActionContainer, and does not layout again, causing all the browser actions to disappear. The solution lies in forcing Layout() after SetBounds() in ToolbarView. BUG=23593 TEST=none Review URL: http://codereview.chromium.org/276033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29143 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tab dragging when windows overlap. Bring window to front when dragging a ↵pinkerton@chromium.org2009-10-151-7/+14
| | | | | | | | | | tab into it (allowing drags to window whose tab strip is fully obscured). BUG=22283 TEST=all tab dragging between windows. Review URL: http://codereview.chromium.org/281001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29139 0039d316-1c4b-4281-b951-d872f2087c98