summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* [Mac] Magnifying glass in keyword-search bubble.shess@chromium.org2010-04-023-23/+69
| | | | | | | | | | | | | | | Abstract the image-in-attributed-string code into a helper function so everyone makes the same mistakes. The keyword-search string's baseline became wrong at some point, adjust it to match the rest of the field. BUG=37865 TEST=Type "google.com" until "press tab to search" appears, hit TAB. "Search Google:" bubble should have a magnifying glass on the LHS. TEST=Add a bunch of text to search. Resizing smaller should first remove the image, then change to shorter text ("Search Go..." or somesuch). Review URL: http://codereview.chromium.org/1581011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43540 0039d316-1c4b-4281-b951-d872f2087c98
* Include the appcache and database tracker databases into the sql diagnostics ↵michaeln@chromium.org2010-04-024-71/+69
| | | | | | | | | | | | fold. TEST=manual BUG=none Review URL: http://codereview.chromium.org/1508016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43534 0039d316-1c4b-4281-b951-d872f2087c98
* #include what you use: <Security/Security.h> for SecKeychainAddCallback andmark@chromium.org2010-04-021-0/+1
| | | | | | | | | | friends following r43492. BUG=none TEST=none Review URL: http://codereview.chromium.org/1570010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43532 0039d316-1c4b-4281-b951-d872f2087c98
* Behaving nice with AutoFill servers: Adjusting upload rate, processing 500, ↵georgey@chromium.org2010-04-029-42/+375
| | | | | | | | | | 502 and 503 responses, etc. TEST=Unit-tested + by setting up the response from AutoFill server. BUG=39921 Review URL: http://codereview.chromium.org/1535011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43531 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when an extension bg page calls alert(). Add regression tests thismpcomplete@chromium.org2010-04-022-3/+33
| | | | | | | | | | time. BUG=37567 Review URL: http://codereview.chromium.org/1602005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43530 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Add geolocation exceptions window.mattm@chromium.org2010-04-024-13/+290
| | | | | | | | | BUG=39820 TEST=manual Review URL: http://codereview.chromium.org/1518010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43529 0039d316-1c4b-4281-b951-d872f2087c98
* New tab perfbot didn't like this.jrg@chromium.org2010-04-021-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Reverting to confirm this was the cause. Even if proven the cause my plan is to re-land since this fixes a visible bug but fix perf in a different way. BUG=40225 Revert 43419 - Fix floating bookmark bar on windows. IsBookmarkBarVisible() continues to have a consistent meaning across platforms, but extra logic has been added to windows to be smarter about when to show the bar. Such extra logic also is consistent across platforms (e.g. see browser_window_gtk.cc and bookmark_bar_gtk.cc). Problem introduced with http://codereview.chromium.org/1461001 BUG=http://crbug.com/39559 Review URL: http://codereview.chromium.org/1594009 TBR=jrg@chromium.org Review URL: http://codereview.chromium.org/1539017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43528 0039d316-1c4b-4281-b951-d872f2087c98
* In-app installation when running from a disk image.mark@chromium.org2010-04-024-0/+463
| | | | | | | | | BUG=28986 TEST=Launch from a disk image without having a copy already installed in /Applications, and with permission to write to /Applications. Review URL: http://codereview.chromium.org/1599011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43527 0039d316-1c4b-4281-b951-d872f2087c98
* Add calling frame's source_url to extension and dom ui requests.rafaelw@chromium.org2010-04-0217-52/+120
| | | | | | | | Additionally, in the extension and tabs api, compute & report UMA histogram data for relative URL use in API calls so we can decide if it's possible to change the behavior of relative url resolution to use the calling frame's url rather than the extension's base url. Review URL: http://codereview.chromium.org/1605005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43523 0039d316-1c4b-4281-b951-d872f2087c98
* Insure that the bookmark bubble comes up properly aligned when the browser ↵mrossetti@chromium.org2010-04-026-16/+32
| | | | | | | | | | | | is in full-screen mode and the floating bar is not showing by having the floating bar come up. BUG=39428 TEST=1) Enter full-screen mode. Press Cmd-D and verify that the floating bar appears and that the bubble is properly aligned. Press 'Remove' and verify that the floating bar goes away. Repeat but this time press 'Done'. Repeat once again and this time press 'Edit' and verify that the bubble goes away but the floating bar remains until the bookmark editor is dismissed with the editor pane appearsing off the bottom of the floating bar. 2) Exit full-screen mode and perform the above exercises to insure that the bookmark bubble and bookmark edit window are still presented as expected: Press Cmd-D and verify that the bubble is properly aligned. Press 'Remove' and verify that the bubble goes away. Repeat but this time press 'Done'. Repeat once again and this time press 'Edit' and verify that the bubble goes and that the bookmark editor pane is presented off the bottom of the Chrome toolbar. Review URL: http://codereview.chromium.org/1539011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43519 0039d316-1c4b-4281-b951-d872f2087c98
* Make plugin descriptions, etc. in chrome://plugins display as LTR.viettrungluu@chromium.org2010-04-021-14/+9
| | | | | | | | | | | | | | Otherwise parentheses, periods, etc. look wrong with RTL languages. Note that for RTL languages, tables should still be layed out right-to-left (and cells should be aligned to the right). BUG=34306 TEST=Set your language to your favourite RTL language. Go to chrome://plugins/. Everything should look correct. Expand Details -- everything should look correct. Everything should still look correct in LTR languages as well. Review URL: http://codereview.chromium.org/1593010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43518 0039d316-1c4b-4281-b951-d872f2087c98
* GTK browser actions toolbar fiddling:estade@chromium.org2010-04-029-64/+148
| | | | | | | | | | | | - make the toolbar size restore properly when the toolbar is created before the model is loaded - allow the user to right click menu items in the overflow menu BUG=40068 (sorta) TEST=manual Review URL: http://codereview.chromium.org/1602003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43515 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the themeing from the folder menu background, text in the folder menu ↵mrossetti@chromium.org2010-04-0215-92/+188
| | | | | | | | | | | items, and no longer needed calls. Changed the menu button stroke color to a lighter shade of black. Did a bit of refactoring of how bookmark buttons are created. BUG=39428 TEST=Pop up a folder menu and insure that the background does not adopt any theme settings. Review URL: http://codereview.chromium.org/1589005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43511 0039d316-1c4b-4281-b951-d872f2087c98
* Fix copying/dragging of empty folders in BMM on macfeldstein@chromium.org2010-04-021-0/+4
| | | | | | | | | | | | | The code was assuming there was at least one url. There is still a js error in the BMM on all platforms that I've run into a couple of times, but I want to check this in while I look into that. BUG=39229 TEST=Copy or drag an empty bookmarks folder Review URL: http://codereview.chromium.org/1456003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43510 0039d316-1c4b-4281-b951-d872f2087c98
* Mac cleanup: avoid double-conversion of URL string.viettrungluu@chromium.org2010-04-021-6/+5
| | | | | | | | | BUG=none TEST=home page text field in prefs continues to work as before Review URL: http://codereview.chromium.org/1529011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43509 0039d316-1c4b-4281-b951-d872f2087c98
* Polish new user login screen:dpolukhin@chromium.org2010-04-022-35/+26
| | | | | | | | | | | | | - create new account should looks like link - removed username and password labels, they should be visible as background text in input fields if user hasn't typed anything yet. BUG=none TEST=Create new account should be link on Chromium OS login screen. Review URL: http://codereview.chromium.org/1593005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43508 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that we go to existing open bookmark manager when pressing ↵arv@chromium.org2010-04-022-1/+58
| | | | | | | | | | | Shift+Ctrl+B BUG=37354 TEST=ui_test.exe --gtest_filter=BookmarksUITest.* Review URL: http://codereview.chromium.org/1519015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43503 0039d316-1c4b-4281-b951-d872f2087c98
* Add extra views to the new net internals page. This adds tabs along the top ↵eroman@chromium.org2010-04-0211-241/+733
| | | | | | | | | for proxy, dns, sockets, requests, and http cache subsections. The actual subviews are placeholders. BUG=37421 Review URL: http://codereview.chromium.org/1593009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43502 0039d316-1c4b-4281-b951-d872f2087c98
* Upgrade fonts to receive MEDIUM request priority like scripts andtonyg@chromium.org2010-04-022-19/+53
| | | | | | | | | | | | | | | stylesheets. A detailed discussion can be found here: http://www.stevesouders.com/blog/2009/10/13/font-face-and-performance/ http://paulirish.com/2009/fighting-the-font-face-fout/ Also, factor out resource priorities and ensure that all types are considered. BUG=none TEST=none Review URL: http://codereview.chromium.org/1572013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43498 0039d316-1c4b-4281-b951-d872f2087c98
* Add a bunch of preferences to sync.skrul@chromium.org2010-04-029-43/+283
| | | | | | | | | | This includes a fix for not crashing when we encounter a preference that is not registered. BUG=39958 Review URL: http://codereview.chromium.org/1571006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43497 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Register for keychain notifications on the main thread.snej@chromium.org2010-04-021-0/+17
| | | | | | | | | | | Fixes issues where SSL doesn't notice changes made to keychains, like plugging in a crypto-card after Chrome launches. BUG=37766,34767 TEST=None (manual testing) Review URL: http://codereview.chromium.org/1575016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43492 0039d316-1c4b-4281-b951-d872f2087c98
* Mark OtherRedirectsDontForkProcess as FLAKY because it crashed at leastdmazzoni@chromium.org2010-04-021-1/+2
| | | | | | | | | | | | twice this morning - revisions 43472 and 43474. BUG=32799 TEST=greenify the tree TBR=rohitrao Review URL: http://codereview.chromium.org/1574011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43489 0039d316-1c4b-4281-b951-d872f2087c98
* Update routing info and nudge syncer in ConfigureDataTypes().skrul@chromium.org2010-04-0210-85/+125
| | | | | | | | | | | | | | Here is an incomplete change that will reconfigure the routing info when the DTM calls ConfigureDataTypes. Some open questions: - How will the SBH actually nudge the syncer? I can add a SyncManager::Nudge method if that makes sense. - Looking at the nudge code, it looks like it is possible for nudges to get dropped on the floor. This could be really bad since sync can't start until the syncer thread runs and downloads updates for new data types. Is there a better way to make sure the syncer thread runs at this point? Also, I changed the callback method used for the SBH to notify the DTM that downloads are ready by switching the raw CancelableTask instance with a RunnableMethod. The previous version has the DTM touching the CancelableTask pointer after it was handed over to the SBH which was bad. This should be better. Review URL: http://codereview.chromium.org/1484001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43487 0039d316-1c4b-4281-b951-d872f2087c98
* translate infobar: sort languages in menus by application localekuan@chromium.org2010-04-021-1/+25
| | | | | | | | | | | | - provide string16 sorting methods (there were only std::wstring sorting methods before) - problem is fixed on win, mac, linux and chromeos BUG=39850 TEST=verify per bug report. Review URL: http://codereview.chromium.org/1542009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43484 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug which causes proxy authentication requeststonyg@chromium.org2010-04-021-4/+4
| | | | | | | | | | to crash Debug builds. BUG=39329 TEST=Mocking a proxy isn't trivial. Ideas? Review URL: http://codereview.chromium.org/1355001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43483 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43475 - Adding "preload_engines" and "use_global_engine" preferences ↵rohitrao@chromium.org2010-04-023-69/+2
| | | | | | | | | | | | | | to Chrome side. BUG=crosbug.com/488 TEST=none Review URL: http://codereview.chromium.org/1546010 TBR=yusukes@chromium.org Review URL: http://codereview.chromium.org/1520012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43481 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43476 - Use "preload_engines" pref on Chrome side to save the list of ↵rohitrao@chromium.org2010-04-022-239/+124
| | | | | | | | | | | | | | | | active IMEs. This change depends on http://codereview.chromium.org/1546010. BUG=crosbug.com/488 TEST=manual Review URL: http://codereview.chromium.org/1576010 TBR=yusukes@chromium.org Review URL: http://codereview.chromium.org/1540012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43480 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43382 - Move fetching of fullfledged auth cookies to a time when we ↵jar@chromium.org2010-04-0225-1067/+330
| | | | | | | | | | | | | | | | | | have the user's real profile available. Also, enable the use of a localaccount on Chrome OS [Valgrind was red, per investigation by rohitrao] many of the changes here are just callsite fixes, because I changed the signature of a function. I also moved my code into the chromeos namespace, which accounts for several other files. The important stuff is in: 1) google_authenticator* 2) cookie_fetcher* 3) login_utils.cc Review URL: http://codereview.chromium.org/1515003 TBR=cmasone@google.com Review URL: http://codereview.chromium.org/1517015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43478 0039d316-1c4b-4281-b951-d872f2087c98
* Use "preload_engines" pref on Chrome side to save the list of active IMEs.yusukes@chromium.org2010-04-022-124/+239
| | | | | | | | | | | This change depends on http://codereview.chromium.org/1546010. BUG=crosbug.com/488 TEST=manual Review URL: http://codereview.chromium.org/1576010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43476 0039d316-1c4b-4281-b951-d872f2087c98
* Adding "preload_engines" and "use_global_engine" preferences to Chrome side.yusukes@chromium.org2010-04-023-2/+69
| | | | | | | | | BUG=crosbug.com/488 TEST=none Review URL: http://codereview.chromium.org/1546010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43475 0039d316-1c4b-4281-b951-d872f2087c98
* 1. Create a new sandbox type which allows access to Unix sockets in the Macmsneck@google.com2010-04-021-0/+39
| | | | | | | | | | | | | | | | | | | | | renderer sandbox to support running Native Client. 2. Put the Native Client sel_ldr (which contains the user's untrusted code) into a new Mac sandbox type. 3. Open /dev/random in SandboxWarmup(). 4. Remove the "--nosandbox" flag when running Mac tests. See http://codereview.chromium.org/1234003/show and http://codereview.chromium.org/1525005/show which were both reverted because of problems on Mac 10.6. This change is identical except for the ";NACL" lines in renderer.sb files and the corresponding lines in nacl-loader.sb. Unix socket support for the sandbox changed considerably from 10.5 to 10.6. BUG=http://code.google.com/p/nativeclient/issues/detail?id=327 TEST=nacl_ui_tests still pass while running in the sandbox. Review URL: http://codereview.chromium.org/1559012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43473 0039d316-1c4b-4281-b951-d872f2087c98
* Add remaining test cases for NetworkScreen.nkostylev@google.com2010-04-023-43/+116
| | | | | | | | | | | | Connecting Ethernet & Cellular network test cases. Fix language library mock warning for CrosInProcessBrowserTest (SetImeConfig). BUG=crosbug.com/2037 TEST=out/Debug/browser_tests --gtest_filter=NetworkScreenTest* Review URL: http://codereview.chromium.org/1604005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43465 0039d316-1c4b-4281-b951-d872f2087c98
* Repair DevTools in docked mode on Gtk. After ↵yurys@chromium.org2010-04-021-2/+12
| | | | | | | | | | http://codereview.chromium.org/1025005 browser hangs when switching between tabs with docked devtools or inspecting an element in a tab with docked devtools. BUG=39716,39883 Review URL: http://codereview.chromium.org/1539008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43464 0039d316-1c4b-4281-b951-d872f2087c98
* Add a folders_only and subtree api to bookmark managerfeldstein@chromium.org2010-04-028-92/+279
| | | | | | | | | | | | | | | | Adds a new API to the experimental.bookmarkManager namespace getSubtree(id, foldersOnly, callback) Which returns any subtree, and if foldersOnly is true, only returns the folders. At this point, only the bookmark tree is using the new call. BUG=39877 TEST=ExtensionBookmarksTest.* Review URL: http://codereview.chromium.org/1611001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43461 0039d316-1c4b-4281-b951-d872f2087c98
* Add --websocket-live-experiment-host flag to debug websocket live experiment.ukai@chromium.org2010-04-022-15/+45
| | | | | | | | | | | If --websocket-live-experiment-host is specified, it is used for host of websocket live experiment in debug build. BUG=none TEST=none Review URL: http://codereview.chromium.org/1524005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43460 0039d316-1c4b-4281-b951-d872f2087c98
* Add TableModel for geolocation settings.mattm@chromium.org2010-04-024-0/+213
| | | | | | | | | BUG=39817,39820 TEST=manual Review URL: http://codereview.chromium.org/1534013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43454 0039d316-1c4b-4281-b951-d872f2087c98
* Fix syncing deleted autofills and properly associate when an autofill is added.zork@chromium.org2010-04-023-23/+37
| | | | | | | | | BUG=39957 TEST=Manually test. Review URL: http://codereview.chromium.org/1546009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43445 0039d316-1c4b-4281-b951-d872f2087c98
* Add Flash EULA to about box on Mac (for branded builds).viettrungluu@chromium.org2010-04-021-2/+24
| | | | | | | | | BUG=none TEST=On Chromium, about box should be the same as before. On Google Chrome, about box should have "Adobe Flash Player License Agreement" below the Google Terms of Service, with "License Agreement" an appropriate link. Review URL: http://codereview.chromium.org/1610001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43443 0039d316-1c4b-4281-b951-d872f2087c98
* Move enable/disable storage to prefs.nick@chromium.org2010-04-0214-167/+240
| | | | | | | | | | | | | | | | | | | | | | | The ProfileSyncService will manage the enabled/disabled types. Remove CustomizeSyncWindowView's DataTypeManager dependency; it should really just be operating on the preferences via the ProfileSyncService. Clarify the difference between types being enabled (meaning the user wants to sync them) versus being advertisable (meaning we support the datatype, and advertise that the user has the option of syncing it). BUG=34209,38340 TEST=After syncing, open the options dialog and recustomize your options. Verify that the enabled types from the wizard match the initial state of the options window. After changing the options and hitting "accept", observe that a breakpoint in DTM::Configure gets triggered, with exactly the new configuration set. Verify that the preferences are preserved on restart, as well as across Stop Syncing / Start Syncing. Review URL: http://codereview.chromium.org/1556009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43440 0039d316-1c4b-4281-b951-d872f2087c98
* Fix AutoFillProfile leaks in WebDataService.tim@chromium.org2010-04-021-9/+14
| | | | | | | | TBR=akalin Review URL: http://codereview.chromium.org/1569016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43438 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed bugs related to the GPU process terminating unexpectedly.kbr@google.com2010-04-022-11/+4
| | | | | | | | | | BUG=40173 TEST=ran WebGL tests, killed GPU process, and reloaded page TBR=jam Review URL: http://codereview.chromium.org/1549013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43437 0039d316-1c4b-4281-b951-d872f2087c98
* Add generic "json dict" entry point for pyauto commands. Will preventjrg@chromium.org2010-04-024-0/+178
| | | | | | | | | | | | | | | | the need to modify the automation proxy anymore. New pyauto commands will only need to edit pyauto.py (to add a new SendJSONCommand() call) and browser_proxy.cc (to implement the other side). Contrast with the normal editing of ~8 files. Also added WaitForAllDownloadsToComplete using new JSON path. BUG=http://crbug.com/39274 Review URL: http://codereview.chromium.org/1547012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43436 0039d316-1c4b-4281-b951-d872f2087c98
* Mark SessionRestoreUITest.ShareProcessesOnRestore as flaky.rohitrao@chromium.org2010-04-021-1/+2
| | | | | | | | BUG=40181 TEST=None Review URL: http://codereview.chromium.org/1569015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43435 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFillDialogController leak fixed.dhollowa@chromium.org2010-04-022-8/+12
| | | | | | | | | | | | | | | | | The AutoFillDialogController was leaking view controllers when dynamically adding and removing AutoFillAddressViewController and AutoFillCreditCardViewController views. Ownership of the controllers was not getting relinquished to the NSArray containers correctly. New checks in the unit tests now explicitly check that the controllers have a single owner. BUG=39720 TEST=AutoFillDialogControllerTest.DeleteAddress, AutoFillDialogControllerTest.DeleteCreditCard TBR=avi@chromium.org Review URL: http://codereview.chromium.org/1551011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43432 0039d316-1c4b-4281-b951-d872f2087c98
* Disable most commands at startup.arv@chromium.org2010-04-022-1/+11
| | | | | | | | | | Make sure we do not show the menu on right mouse botton. BUG=40078 TEST=Open the bookmark manager and right click Review URL: http://codereview.chromium.org/1518011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43428 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to the Browser to support Database access from Workers.ericu@google.com2010-04-027-43/+123
| | | | | | | | | | | | This changelist should have no visible effect until the V8 bindings for the Database get added to the Worker context in WebKit. BUG=none TEST=webkit layout tests Review URL: http://codereview.chromium.org/1387001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43427 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to web database and autofill components requiredtim@chromium.org2010-04-029-57/+301
| | | | | | | | | | | | | | | | | | | | | to sync profiles / addresses. The main part here is adding Refresh to the PersonalDataManager. It changes the expectation that the PDM is the only thing modifying autofill, which is necessary as the sync engine connects directly to the WebDatabase on the DB thread. The tricky part is ID generation, which I spent a great deal of time harping over in my sync change to make sure that everything is in an eventually consistent state. Note that because of the way the autofill window takes an isolated copy of the data, there *are* extremely rare cases where an edit will get dropped - I cover this case in PersonalDataManagerTest.Refresh. TEST=WebDataServiceTest, PersonalDataManagerTest. Review URL: http://codereview.chromium.org/1550007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43426 0039d316-1c4b-4281-b951-d872f2087c98
* Keyboard events of any kind end bookmark bar folder menus.jrg@chromium.org2010-04-023-20/+41
| | | | | | | | BUG=http://crbug.com/38268 Review URL: http://codereview.chromium.org/1572018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43424 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for focus issues in the AutoFill windows dialog, including #37817georgey@chromium.org2010-04-022-22/+197
| | | | | | | | BUG=37817 TEST=You should be successfully able to navigate all controls and buttons with keyboard. + info in the bug. Review URL: http://codereview.chromium.org/1560006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43423 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bookmarks log message.dhollowa@chromium.org2010-04-021-2/+0
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/1524008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43421 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 10:02:12 +0000