summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Unfork some code who's dependency has landed on Mac.shess@chromium.org2009-04-271-6/+0
| | | | | | | | | I believe that this was originally commented out due to fonts not being quite wired in. Review URL: http://codereview.chromium.org/92142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14667 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send stats from Chromium builds.kuchhal@chromium.org2009-04-273-7/+21
| | | | | | | | | BUG=1435533 Review URL: http://codereview.chromium.org/93109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14665 0039d316-1c4b-4281-b951-d872f2087c98
* This patch adds a new kind of tests: browser tests.jcampan@chromium.org2009-04-272-4/+22
| | | | | | | | | | | | | | | | | | They are intended to provide an alternative to the UI tests, hopefully helping with flackiness. These tests are in-process browser test. There are 2 projects to build the tests: - the browser_test.dll that contains the tests, the gtest framework and the browser classes. - the browser_test_launcher.exe. The launcher loads the browser_test.dll for each test, run the test and then unloads the DLL. This insures the static initializers are run before each test and that any atexit handler is invoked properly. This is Windows only for now. BUG=9764 TEST=Run browser_test.exe Review URL: http://codereview.chromium.org/88066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14664 0039d316-1c4b-4281-b951-d872f2087c98
* Update selected line in model before accepting input when the user clicks in ↵shess@chromium.org2009-04-272-5/+6
| | | | | | | | | | the popup. BUG=10932 Review URL: http://codereview.chromium.org/93130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14659 0039d316-1c4b-4281-b951-d872f2087c98
* Add quarantine metadata to downloads on the Mac. Patch by Stuart Morganmark@chromium.org2009-04-274-1/+14
| | | | | | | | | | | <stuart.morgan@gmail.com>. BUG=10853 Code review URL: http://codereview.chromium.org/99005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14657 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this. jcampan@chromium.org2009-04-271-2/+5
| | | | | | | | | | | | | | | | | | | The Ole unitialization was failing on one of the Vista build-bot. It is not clear when the Ole initialization is balanced when a CRichEditCtrl is created/destructed. So I now turn it off explicitly. This CL makes sure we unregister our Windows window classes when shut-down. It also balances-out an OLE initialization performed by the CRichEditCTRL. This is necessary for allowing to reload chrome.dll in a process, which is what the browser tests will do. BUG=None TEST=None Review URL: http://codereview.chromium.org/101004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14649 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up construction of LocationBarViewMac objects.shess@chromium.org2009-04-277-49/+16
| | | | | | | | | | | This removes the need for SetField() accessors on AutocompleteEditViewMac and AutocompletePopupViewMac, and also removes the Init() wart on LocationBarViewMac. Now everything is wired up in the constructor. Review URL: http://codereview.chromium.org/92136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14641 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few crashes when trying to drag a closing tab.jhawkins@chromium.org2009-04-272-4/+32
| | | | | | Review URL: http://codereview.chromium.org/99065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14640 0039d316-1c4b-4281-b951-d872f2087c98
* Adds --no-audio, which replaces the audio IPC layer with a mock audio device.scherkus@chromium.org2009-04-271-1/+2
| | | | | | | | Useful for testing <audio> and <video> over remote desktop or on machines without sound cards. Should also let mac/linux playback videos without our audio layer being implemented on those platforms. Review URL: http://codereview.chromium.org/93132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14637 0039d316-1c4b-4281-b951-d872f2087c98
* Now that we have file dialogs, we might as well hook up "Open File" on the Mac.avi@google.com2009-04-272-6/+0
| | | | | | Review URL: http://codereview.chromium.org/93145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14625 0039d316-1c4b-4281-b951-d872f2087c98
* Speculatively roll back r14549 and r14508. The chrome browsertc@google.com2009-04-272-34/+11
| | | | | | | | | | | | process is pegged at 100% cpu after ui_tests has exited. Seeing if this is the cause. Will re-roll forward if it's not. TBR=estade Review URL: http://codereview.chromium.org/100047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14620 0039d316-1c4b-4281-b951-d872f2087c98
* Add keyboard accelerators for IDC_FIND_NEXT and IDC_FIND_PREVIOUS.willchan@chromium.org2009-04-271-3/+9
| | | | | | Review URL: http://codereview.chromium.org/101007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14619 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow the browser window to be resized so small that layout starts ↵pkasting@chromium.org2009-04-277-68/+193
| | | | | | | | | | | breaking horribly. When it _is_ small, draw the frame correctly. This is an incomplete fix; only non-Aero main/popup/app windows are handled so far, but this was becoming hairy enough I wanted to checkpoint it. BUG=9885 Review URL: http://codereview.chromium.org/100005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14618 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a memory leak in TaskManagerphajdan.jr@chromium.org2009-04-271-3/+7
| | | | | | | | http://crbug.com/11068 Review URL: http://codereview.chromium.org/99059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14615 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a gcc-4.3 warning in tab_strip_gtk.cc.jhawkins@chromium.org2009-04-272-19/+3
| | | | | | | | | | | | | | | | | | | Also factorizes some code in tab_strip.cc and tab_strip_gtk.cc. One of the inlined call to GenerateStartAndEndWidths with end_tab_count = start_tab_count - 1 caused line 164 to be rewritten as: if (start_tab_count < start_tab_count - 1 && which raised the following warning with gcc-4.3: tab_strip_gtk.cc:164: warning: assuming signed overflow does not occur when assuming that (X - c) > X is always false patch by vincent.zanotti@gmail.com <http://codereview.chromium.org/99031> R=me Review URL: http://codereview.chromium.org/100045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14613 0039d316-1c4b-4281-b951-d872f2087c98
* Add a way to checksum bookmark data to help determine if themunjal@chromium.org2009-04-273-23/+290
| | | | | | | | | | | | | | bookmarks file was changed by the user between two chrome runs. - BookmarkCodec now serializes a checksum of bookmark data along side bookmark data during encoding. - During decoding BookmarkCodec computes the checksum of deserialized data, and it also reads the checksum in the file. - BookmarkCodec exposes both the checksums via getters. - Add unit tests for BookmarkCodec, right now only checksum related. Review URL: http://codereview.chromium.org/69028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14612 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable and set svn:eol-style to LF.tc@google.com2009-04-274-0/+0
| | | | | | | TBR=dean Review URL: http://codereview.chromium.org/99060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14611 0039d316-1c4b-4281-b951-d872f2087c98
* Searching by keyword now generates a visit against the site with asky@chromium.org2009-04-2715-31/+205
| | | | | | | | | | | | | | | | transition type of TAB_TO_SEARCH. This visit increments the typed count and ensures if you use TAB_TO_SEARCH you still get autocompleted to the site. I'll add some tests for this, but want to make sure we're ok with it before I do that. BUG=3633 TEST=will be covered by unit tests. Review URL: http://codereview.chromium.org/93087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14609 0039d316-1c4b-4281-b951-d872f2087c98
* Linux Omnibox results improvements:deanm@chromium.org2009-04-272-92/+92
| | | | | | | | | | | | | - Honor the damage rect when painting result lines. - Move some code from GdkRectangle to gfx::Rect. - Drop GC creation and just use one from the widget's style. - Fix a bug in content/description width allocation. - Factor out the icon loading and switch into IconForMatch(). Review URL: http://codereview.chromium.org/99050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14605 0039d316-1c4b-4281-b951-d872f2087c98
* Massively improve the performance of dragging a window over our window.deanm@chromium.org2009-04-271-1/+3
| | | | | | | | | | | | | | | | | Our toolbar background is a 1 pixel wide image, which we tile by drawing a pixbuf over and over. The way the toolbar is laid out, everything shares the same window. The toolbar is painted first, then the buttons on top of it, etc. If the toolbar painting is slow, you can see gray trails when you drag a window over and the exposes are slow to come back to X. Honor the damage rect, so when we get tons of tiny exposes we aren't doing this really inefficient tiling over the entire toolbar. Improving the tiling performance needs to be done separately. Review URL: http://codereview.chromium.org/100036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14604 0039d316-1c4b-4281-b951-d872f2087c98
* Add a stub test for TabStripController. It doesn't fully work because of issuespinkerton@chromium.org2009-04-272-1/+131
| | | | | | creating WebContents objects. A bug has been filed to come back to it. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14601 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a NOTIMPLEMENTED() that's not necessary on Mac.pinkerton@chromium.org2009-04-271-1/+5
| | | | | | Review URL: http://codereview.chromium.org/97004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14600 0039d316-1c4b-4281-b951-d872f2087c98
* Add virtual dtor for TaskManager::ResourceProvider.phajdan.jr@chromium.org2009-04-271-0/+2
| | | | | | | | | It has virtual methods but no virtual dtor. This change may help fix memory leaks which appeared after adding unit tests for TaskManager. Review URL: http://codereview.chromium.org/100041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14599 0039d316-1c4b-4281-b951-d872f2087c98
* Use AutocompletePopupPositioner for the Linux Omnibox.deanm@chromium.org2009-04-278-39/+73
| | | | | | | | | | | Now a few less magic numbers in exchange for a lot more plumbing. BUG=10966 Review URL: http://codereview.chromium.org/92127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14592 0039d316-1c4b-4281-b951-d872f2087c98
* Linux Omnibox mouse support.deanm@chromium.org2009-04-272-4/+103
| | | | | | | | | | | | - Paint both concepts of hovered and selected lines. - Track mouse movements and button up/down. TEST=Select, drag, and click entries in the Omnibox results. Should behave just like Windows. Review URL: http://codereview.chromium.org/92124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14591 0039d316-1c4b-4281-b951-d872f2087c98
* Add basic unit tests for TaskManager.phajdan.jr@chromium.org2009-04-272-0/+84
| | | | | | | | | | | | | For now the tests are Windows-only, because the TaskManager isn't ported. But they should make porting effort a bit safer. TEST=Make sure that tests from unit_tests matching TaskManagerTest.* pass. http://crbug.com/10844 Review URL: http://codereview.chromium.org/92071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14590 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 14569abarth@chromium.org2009-04-262-43/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14573 0039d316-1c4b-4281-b951-d872f2087c98
* Add some histograms to see how often users click through blocking pages.abarth@chromium.org2009-04-262-1/+43
| | | | | | | | R=jar Review URL: http://codereview.chromium.org/99020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14569 0039d316-1c4b-4281-b951-d872f2087c98
* Monitor some sensitive UI actions for evidence of clickjacking.abarth@chromium.org2009-04-264-1/+28
| | | | | | | | | | Defending against clickjacking on these UI elements has a usability cost. We should measure to see if anyone is trying these attacks before inventing some crazy half-workaround. R=jar Review URL: http://codereview.chromium.org/99021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14568 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: implement automation for modal dialogs.agl@chromium.org2009-04-262-5/+18
| | | | | | | | | | | | | | | | | The Linux ui_tests are currently red because BrowserCloseBeforeUnloadOK and BrowserCloseBeforeUnloadCancel are failing. This is because we didn't implement several automation functions regarding modal dialogs and someone obviously wrote a test which needed them. So this is a TBR in order to green the tree. TBR=tony http://codereview.chromium.org/99032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14549 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash I introduced in r14053. It removed the setting of the controller inbrettw@chromium.org2009-04-251-6/+10
| | | | | | | | | one arm of an if statement. BUG=10930 Review URL: http://codereview.chromium.org/99003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14533 0039d316-1c4b-4281-b951-d872f2087c98
* Show icons in the new omnibox popup.ben@chromium.org2009-04-252-37/+107
| | | | | | | | Also fix some crashes. Review URL: http://codereview.chromium.org/98003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14518 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sudden termination after the latest WebKit merge.jam@chromium.org2009-04-2511-54/+99
| | | | | | | | BUG=10927 Review URL: http://codereview.chromium.org/93104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14517 0039d316-1c4b-4281-b951-d872f2087c98
* Port unload_uitest.cc and enable some of the tests on linux.estade@chromium.org2009-04-241-7/+17
| | | | | | | | Make WaitForSingleProcess respect base::kNoTimeout (which is equivalent to INFINITE on windows). Review URL: http://codereview.chromium.org/99008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14508 0039d316-1c4b-4281-b951-d872f2087c98
* Passing correct HWND to CreateChromeWindow(). The HWND of the toplevel windowestade@chromium.org2009-04-241-1/+5
| | | | | | | | | | | should be passed. BUG=9191 patch by yusukes@google.com <http://codereview.chromium.org/97011> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14505 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk file selection filters, first cut.estade@chromium.org2009-04-242-6/+78
| | | | | | Review URL: http://codereview.chromium.org/92153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14502 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "POSIX: Don't spawn zombies." (r14488)agl@chromium.org2009-04-241-13/+2
| | | | | | | | Something else is trying to reap children in the ui_tests and causing a mess. Reverting since it's a Friday night. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14499 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14489.jcampan@chromium.org2009-04-242-12/+2
| | | | | | Review URL: http://codereview.chromium.org/99004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14492 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes sure we unregister our Windows window classes when shut-down.jcampan@chromium.org2009-04-242-2/+12
| | | | | | | | | | | | It also balances-out an OLE initialization performed by the CRichEditCTRL. This is necessary for allowing to reload chrome.dll in a process, which is what the browser tests will do. BUG=None TEST=None Review URL: http://codereview.chromium.org/93026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14489 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: Don't spawn zombies.agl@chromium.org2009-04-241-2/+13
| | | | | | | | TEST=Navigate to several different sites and check that no Chrome zombies are roaming around. BUG=9401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14488 0039d316-1c4b-4281-b951-d872f2087c98
* No code change, just converting CRLF to LF to prevent changesfinnur@chromium.org2009-04-241-156/+156
| | | | | | | | | | to this file from messing up the try server. TBR=aa Review URL: http://codereview.chromium.org/93156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14486 0039d316-1c4b-4281-b951-d872f2087c98
* Fix word wrapping on the license label.erg@google.com2009-04-241-0/+11
| | | | | | | | | This uses the trick described here: http://blog.16software.com/dynamic-label-wrapping-in-gtk Review URL: http://codereview.chromium.org/93153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14485 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for minimum size checkevan@chromium.org2009-04-241-2/+5
| | | | | | | | cds->cbData is data length in bytes, and min_message_size is in characters. So it needs to be multiplied by sizeof(wchar_t) Review URL: http://codereview.chromium.org/93078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14482 0039d316-1c4b-4281-b951-d872f2087c98
* Pass the ExtensionID to the ExtensionFunctionDispatcher.finnur@chromium.org2009-04-246-8/+30
| | | | | | | | | | | | | | | | This is needed for PageActions that deal with IDs, so that we can check if one PageAction is trying to change another PageAction. This converts the object ExtensionFunctionDispatcher in RenderViewHost from a member to a scoped ptr so we can reset it on navigate. BUG=None TEST=Extensions should work as before (no visible change). Review URL: http://codereview.chromium.org/93125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14481 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Do not send stats from Chromium builds."kuchhal@chromium.org2009-04-243-17/+7
| | | | | | | | | | | | This reverts commit 4a0189db765fe94f5df360c0907a585e26c9f681. Revert "Fix build break." This reverts commit eada493cf28975e56395aa3e2d3a0dc267a7f2c7. Review URL: http://codereview.chromium.org/92162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14479 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break.kuchhal@chromium.org2009-04-241-1/+1
| | | | | | | | | BUG=1435533 Review URL: http://codereview.chromium.org/93154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14478 0039d316-1c4b-4281-b951-d872f2087c98
* Add a gcc warning if we don't check the results of ReadParam. Sometc@google.com2009-04-241-2/+2
| | | | | | | | | | | | of the buildbots noticed that we weren't checking the results when generating log output. AGL gets the credit for tracking this down. Review URL: http://codereview.chromium.org/93126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14475 0039d316-1c4b-4281-b951-d872f2087c98
* Do not send stats from Chromium builds.kuchhal@chromium.org2009-04-243-7/+17
| | | | | | | | | BUG=1435533 Review URL: http://codereview.chromium.org/93109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14474 0039d316-1c4b-4281-b951-d872f2087c98
* Make uninstall dialog handle keyboard events (TAB).kuchhal@chromium.org2009-04-241-1/+1
| | | | | | | | | BUG=10950 Review URL: http://codereview.chromium.org/93140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14473 0039d316-1c4b-4281-b951-d872f2087c98
* Implement HTML selects as native Cocoa controls for Chrome.paul@chromium.org2009-04-247-3/+87
| | | | | | | | BUG=8389 (http://crbug.com/8389) Review URL: http://codereview.chromium.org/57032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14471 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 19:49:19 +0000