summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Temporarily revert char* to std::string because Linux and Mac are throwing ↵glen@chromium.org2009-05-091-17/+17
| | | | | | | | | | | | 'defined but not used' errors (the strings are used by themes). TBR=beng Review URL: http://codereview.chromium.org/113184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15718 0039d316-1c4b-4281-b951-d872f2087c98
* Make 'reset theme' work.glen@chromium.org2009-05-091-31/+33
| | | | | | | | | GenerateFrameImages tweaking. Convert global std::strings to char* Review URL: http://codereview.chromium.org/115161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15717 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build in debug mode.jcampan@chromium.org2009-05-091-1/+2
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/115160 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15716 0039d316-1c4b-4281-b951-d872f2087c98
* There was a potential race when showing the default browser info-bar on star-up,jcampan@chromium.org2009-05-091-1/+24
| | | | | | | | | | | | | | | | | | | | between the info-bar showing and the first navigation. If the first navigation was committed after the bar had been shown, the bar would hide (as it is supposed to hide on navigation). This CL makes the bar linger for few seconds before it is hidden on the next navigation. BUG=11427 TEST=Have a test server that blocks for few seconds before serving a page. Make that your home page (or set "sessino restore" and make that page your last visited page). Make sure Chrome is not the default browser. Start Chrome, the info-bar should appear and stay around. After few seconds have elapsed, navigating to another page should cause the info-bar to disappear. TBR=ben Review URL: http://codereview.chromium.org/113177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15715 0039d316-1c4b-4281-b951-d872f2087c98
* Some unnecessary painting and initing was being done.glen@chromium.org2009-05-092-13/+8
| | | | | | | | TBR=beng Review URL: http://codereview.chromium.org/113182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15714 0039d316-1c4b-4281-b951-d872f2087c98
* Random cleanups and stubs to get cross platform build going.glen@chromium.org2009-05-091-1/+1
| | | | | | | | TBR=beng Review URL: http://codereview.chromium.org/115158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15712 0039d316-1c4b-4281-b951-d872f2087c98
* To get things green:glen@chromium.org2009-05-092-8/+13
| | | | | | | | | | | - Add ifdef for filepath init (there is probably a better way of doing this). - Make Linux UI use active/inactive tabs instead of hover/OTR. TBR=beng Review URL: http://codereview.chromium.org/113180 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15710 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser_theme_provider to GYP so that Mac and Linux can build.glen@chromium.org2009-05-091-18/+2
| | | | | | | | | | Temporarily remove theme resource validation to get unittests passing. TBR=beng Review URL: http://codereview.chromium.org/113178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15709 0039d316-1c4b-4281-b951-d872f2087c98
* Add stubs for UserChangedThemes to Mac and Linux.glen@chromium.org2009-05-094-0/+10
| | | | | | Review URL: http://codereview.chromium.org/115156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15708 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary win_util from dom_ui.glen@chromium.org2009-05-091-1/+0
| | | | | | | | TBR=beng Review URL: http://codereview.chromium.org/113175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15706 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first pass at themes.glen@chromium.org2009-05-0939-685/+1674
| | | | | | | | | | | | This CL is paired with http://codereview.chromium.org/67284 This CL (for commit purposes) includes http://codereview.chromium.org/67284 BUG=4463,11232,11233,11234,11235 Review URL: http://codereview.chromium.org/99030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15704 0039d316-1c4b-4281-b951-d872f2087c98
* Decrease the SafeBrowsing false positive rate.paulg@google.com2009-05-098-88/+245
| | | | | | | | | | | | | | | | | This CL replaces the weak hashing functions of the bloom filter for a more thorough mixing function. The bloom filter is modified to use and store random keys in the mixing function. This addresses the need for randomizing the contents of each user's bloom filter to prevent a false positive for a popular site causing a global spike in hash requests. BUG=10584 (http://crbug.com/10584) BUG=10634 (http://crbug.com/10634) Review URL: http://codereview.chromium.org/113064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15703 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the popup blocking whitelist pref. This makes the whitelist ↵pkasting@chromium.org2009-05-093-21/+66
| | | | | | | | actually function.BUG=11440 Review URL: http://codereview.chromium.org/115149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15702 0039d316-1c4b-4281-b951-d872f2087c98
* Add customized first run tabscpu@google.com2009-05-095-35/+122
| | | | | | | | | | | | | - More refactor of BrowserInit and LaunchWithProfile - hardcoded magic names : new_tab_page and welcome_page BUG=9706 TEST=see the bug for detailed instructions. Review URL: http://codereview.chromium.org/115139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15701 0039d316-1c4b-4281-b951-d872f2087c98
* Defer window.close(), resizeTo() and moveTo() actionsmbelshe@google.com2009-05-093-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | by posting a task back to the message loop before notifying the RenderWidgetHost to perform these operations. Otherwise the JS code races with the browser to use the modified window. BUG=http://crbug.com/6377 BUG=http://crbug.com/6192 Cache a pending_window_rect on the render_view (moved from prior CL where I had it on the chrome_client_impl). This is a short lived cache, and not a complete solution. It fixes this case, where a JS script makes multiple operations and expects the GetWindowSize() to be correct immedately after having called SetWindowSize(). BUG=http://crbug.com/835 Review URL: http://codereview.chromium.org/115030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15698 0039d316-1c4b-4281-b951-d872f2087c98
* Stop leaking RenderWidgetHostViewGtk.willchan@chromium.org2009-05-082-1/+1
| | | | | | | | | | | | | | | Don't bother calling gfx::RemoveAllChildren() in TabContentsViewGtk when creating a new RWHV, since any previously existing RWHV widget should already have been deleted. This also fixes interstitial pages crashing. Although instead we have two RWHV widgets in the same TabContentsView vbox :) I'll fix that in a later changelist. Also update the valgrind suppressions file. BUG=http://www.crbug.com/10747 BUG=http://www.crbug.com/8486 Review URL: http://codereview.chromium.org/115145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15695 0039d316-1c4b-4281-b951-d872f2087c98
* Move win_util.h from common to app.ben@chromium.org2009-05-0842-61/+51
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15694 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 9837 - RTL: "Pop-ups blocked" bar should be at left-bottom ↵xji@chromium.org2009-05-081-2/+12
| | | | | | | | | | | | | | for RTL Chrome. The fix is to position the 'pop-ups blocked' bar at the bottom left for RTL chrome. Test: 1. Launch Hebrew Chrome 2. load http://www.brg8.com/ 3. Observe the 'pop-up blocked' bar after the page load. Review URL: http://codereview.chromium.org/89004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15691 0039d316-1c4b-4281-b951-d872f2087c98
* move this to app/gfx, part of previous commitben@chromium.org2009-05-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15688 0039d316-1c4b-4281-b951-d872f2087c98
* Move color_utils, text_elider, drag_utils, accessibility_types, ↵ben@chromium.org2009-05-0859-361/+63
| | | | | | | | | standard_layout to new locations in app/ and views/ http://crbug.com/11387 Review URL: http://codereview.chromium.org/113143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15687 0039d316-1c4b-4281-b951-d872f2087c98
* Landing approved patch for Yuta Kitamura (yutak@google.com)mbelshe@google.com2009-05-082-26/+28
| | | | | | | | | | | | | This patch fixes an assertion failure that occurs when Windows is back from sleep. BUG=11141 Original changelist is http://codereview.chromium.org/109034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15685 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a potential crash in automation framework whenhuanr@chromium.org2009-05-081-2/+3
| | | | | | | | | | a browser window is closed. BUG=http://crbug.com/11659 Review URL: http://codereview.chromium.org/113155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15682 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Store/restore focus in tab contents during tab swithcing.estade@chromium.org2009-05-083-4/+33
| | | | | | | | BUG=8604 Review URL: http://codereview.chromium.org/113166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15681 0039d316-1c4b-4281-b951-d872f2087c98
* Add PreferredSizeChanged() to View to allow subviews to notify their parents ↵erikkay@google.com2009-05-086-17/+24
| | | | | | | | that they'd really like another layout.R=skyTEST=none Review URL: http://codereview.chromium.org/113133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15680 0039d316-1c4b-4281-b951-d872f2087c98
* Enable generation of da.pak, he,pak, and zh-TW.pak. Re-enabletc@google.com2009-05-081-1/+1
| | | | | | | | | | | | | | locale UI tests on windows and linux. Not sure if this will work on mac with resource bundles, so leaving this disabled for now. BUG=9758 Review URL: http://codereview.chromium.org/113158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15676 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ctrl-shift-L for app/popup windows and fix a crash. Patch by Yusuke ↵pkasting@chromium.org2009-05-087-20/+47
| | | | | | | | Sato (see http://codereview.chromium.org/115050 ), r=me. BUG=8071,11559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15671 0039d316-1c4b-4281-b951-d872f2087c98
* Various popup UI fixes:pkasting@chromium.org2009-05-0813-342/+304
| | | | | | | | | | | | | * Remove "show popup notification" option, pref, and all associated machinery. * Toggling whitelisting on for a site no longer hides the "manage" button. * Toggling whitelisting off for a site re-blocks (not closes) its popups, and does not hide the "manage" button. Also rips the whitelist hooks out of TabContents in preparation for getting the whitelist values directly from the BlockedPopupContainer, since there was no reason to plumb everything through TabContents. BUG=11440 Review URL: http://codereview.chromium.org/115112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15670 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for b/1837411 -- Interstitial title lines bleed together.mal@chromium.org2009-05-085-0/+5
| | | | | | | | | | | | | | | | | | | | The line height for titles in the warning interstitials is too small. In English, a second line starts to abut the line above it if the browser is narrow. In languages with ligatures above the line, a second line bleeds into the first, impairing readability. This is compounded in languages like Tamil and Marathi, where the title of the interstitial warning is quite long and likely to break on two lines. My solution is to set the line height to 140% in the .title. TEST= Navigate to ianfette.org with Chrome's lang set to ta or mr. The title lines in the anti-malware blocking page should not bleed together. BUG= 1837411 Review URL: http://codereview.chromium.org/113140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15667 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: clean up some focus issues.estade@chromium.org2009-05-087-24/+33
| | | | | | | | | | | - Set focus to render view after finishing find. - Make all custom buttons unfocusable. (matches windows chrome) - Let the GtkWindow's default keyhandler run when the child widget fails to handle the key press event. Previously I optimized this out, but it turns out to be necessary because when a tab is pressed while focus is at the boundary of a child widget (e.g. the last button in an infobar) the focus has to traverse to the next child widget (e.g. the render view), and this is handled by the GtkWindow's key handler (and not the infobar's key handler). BUG=8604,11560 Review URL: http://codereview.chromium.org/115113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15666 0039d316-1c4b-4281-b951-d872f2087c98
* Stub implementation of linux, mac icon loader/manager.estade@chromium.org2009-05-0812-114/+167
| | | | | | | Define a platform specific type IconGroupID which helps with caching multiple requests for the same icon. Previously we just used the file path (or the extension), but on POSIX we use mime types rather than extensions. Review URL: http://codereview.chromium.org/113120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15665 0039d316-1c4b-4281-b951-d872f2087c98
* Pass external tab handle when Chrome sends outgoing notifications through ↵stoyan@chromium.org2009-05-083-12/+22
| | | | | | | | automation interface. Review URL: http://codereview.chromium.org/115134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15663 0039d316-1c4b-4281-b951-d872f2087c98
* linux: new splash page.evan@chromium.org2009-05-081-31/+26
| | | | | | Review URL: http://codereview.chromium.org/113148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15651 0039d316-1c4b-4281-b951-d872f2087c98
* Update the instructional text's visibility on bookmark add/remove events.erg@google.com2009-05-082-1/+13
| | | | | | Review URL: http://codereview.chromium.org/114016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15650 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a comment that doesn't seem to be true anymore. Change to using an ↵tc@google.com2009-05-081-7/+3
| | | | | | | | | | | | | assert. I tried using a debugger to repro, but was unable to. BUG=9914 Review URL: http://codereview.chromium.org/115111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15649 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression introduced in r15560 where all bookmark buttons became folders.erg@google.com2009-05-082-4/+17
| | | | | | | | http://crbug.com/11628 Review URL: http://codereview.chromium.org/113134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15642 0039d316-1c4b-4281-b951-d872f2087c98
* Fix default browser info string to change text and color instead of ↵pinkerton@chromium.org2009-05-081-20/+50
| | | | | | | | hiding/showing. Record default browser metric. Review URL: http://codereview.chromium.org/115129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15638 0039d316-1c4b-4281-b951-d872f2087c98
* Converted BookmarkStorage to use ImportantFileWriterphajdan.jr@chromium.org2009-05-084-264/+242
| | | | | | | | | | | | | | | | | | Also made BookmarkStorage completely responsible for migration of bookmark data from history database. Previously the logic crossed file and class boundaries a few times. This made it a bit hard to follow. Now it should be a bit more clear. Made ImportantFileWriter also batch data serializations. TEST=Make sure that bookmarks still work. Also test migrating bookmarks from history database. http://crbug.com/10618 Review URL: http://codereview.chromium.org/99192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15635 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Style drive bypfeldman@chromium.org2009-05-081-1/+2
| | | | | | Review URL: http://codereview.chromium.org/115124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15633 0039d316-1c4b-4281-b951-d872f2087c98
* Try fixing session restore UI tests.huanr@chromium.org2009-05-081-29/+30
| | | | | | | | | - Change async ApplyAccelerator to sync RunCommand. - Renable disabled tests. Review URL: http://codereview.chromium.org/113129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15612 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r15607hclam@chromium.org2009-05-081-2/+0
| | | | | | | | r15607 broke the build TBR=brg, thestig git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15608 0039d316-1c4b-4281-b951-d872f2087c98
* Put test_user_data in a temp directory instead of using base::DIR_EXE.thestig@chromium.org2009-05-081-0/+2
| | | | | | | | | base::DIR_EXE could be a very long path, which causes socket creation to fail because socket paths have a limited length. Let's use a temp directory instead. We should also clean up the temp dir when we're done. Also abort if the socket path is too long. Review URL: http://codereview.chromium.org/115107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15607 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-08212-576/+571
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
* Add hung renderer dialog on linux. Pretty much just follow thetc@google.com2009-05-081-0/+215
| | | | | | | | | | | windows view code and do the same thing. BUG=11083 Review URL: http://codereview.chromium.org/115109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15602 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in SiteInstance::CreateSiteInstanceForURL.mpcomplete@google.com2009-05-071-1/+4
| | | | | | | TBR=creis Review URL: http://codereview.chromium.org/115110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15596 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor BrowserInit in preparation for customized first run tabscpu@google.com2009-05-073-83/+82
| | | | | | | | | | | | | | | - BrowserInit is now a instanciable class - The 'bag of static functions' part is mostly unchanged - unused members in the interface moved to the cc file TEST= no visible change. interactive UI tests sufice BUG=9706 Review URL: http://codereview.chromium.org/113113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15595 0039d316-1c4b-4281-b951-d872f2087c98
* Make background pages work more nicely with the tabs API.aa@chromium.org2009-05-076-35/+41
| | | | | | | | | | | | | | | Changed ExtensionHost so that it returns NULL if it doesn't have a browser, instead of getting the last active one. The problem is that if ExtensionHost returns the last active browser at the time it's constructed, it might be garbage by the time it is used. Changed tab functions to use more consistent logic to determine the 'current' browser to operate on. Review URL: http://codereview.chromium.org/115071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15587 0039d316-1c4b-4281-b951-d872f2087c98
* Move pgup/dn special casing to browser window gtk.estade@chromium.org2009-05-072-22/+33
| | | | | | Review URL: http://codereview.chromium.org/112006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15586 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the "(empty)" disabled item placed in empty bookmark menus.erg@google.com2009-05-072-16/+30
| | | | | | | | | (As a side effect, this patch also fixes disabled items in the rest of the bookmarks bar.) Review URL: http://codereview.chromium.org/113119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15582 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate notifiers used by different automationhuanr@chromium.org2009-05-071-24/+93
| | | | | | | | | IPC messages. Make OpenIncognito synchronuous. Review URL: http://codereview.chromium.org/115092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15579 0039d316-1c4b-4281-b951-d872f2087c98
* Windows icon loader refactor in preparation for port.estade@chromium.org2009-05-077-311/+145
| | | | | | Review URL: http://codereview.chromium.org/115056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15577 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-16 10:32:38 +0000