summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Revert change 6149 because it broke the unit tests on windows.nsylvain@chromium.org2008-12-0113-217/+47
| | | | | | Review URL: http://codereview.chromium.org/12834 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6155 0039d316-1c4b-4281-b951-d872f2087c98
* Landing http://codereview.chromium.org/12502 for sverrir:sky@google.com2008-12-011-8/+15
| | | | | | | | | | | Fix selection after deleting cookies. The selection was seemingly random because the model to view mapping changed when deleting items. BUG=3692 TEST=Try deleting items in cookies view and make sure selection doesn't jump around unexpectedly. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6150 0039d316-1c4b-4281-b951-d872f2087c98
* browser porting, part 2 - importeragl@chromium.org2008-12-0113-47/+217
| | | | | | | | Review URL: http://codereview.chromium.org/12688 Patch from Pawel Hajdan jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6149 0039d316-1c4b-4281-b951-d872f2087c98
* Changes filter used when importing in bookmark manager to includesky@google.com2008-12-011-1/+1
| | | | | | | | | | | | | *.htm. BUG=4388 TEST=Create a file name foo.htm. Go to bookmark manager, choose import, navigate to directory with foo.htm and make sure the the open dialog shows foo.htm. Review URL: http://codereview.chromium.org/12459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6144 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply 5971 which was reverted in 5974. The unit test wasn't unregistering ↵maruel@chromium.org2008-12-013-2/+139
| | | | | | | | the observer correctly. Review URL: http://codereview.chromium.org/12474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6142 0039d316-1c4b-4281-b951-d872f2087c98
* Rollbackmbelshe@google.com2008-12-0111-88/+152
| | | | | | Review URL: http://codereview.chromium.org/13009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6127 0039d316-1c4b-4281-b951-d872f2087c98
* A new copy of the old system monitor changelist.mbelshe@google.com2008-11-3011-152/+88
| | | | | | Review URL: http://codereview.chromium.org/12817 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6126 0039d316-1c4b-4281-b951-d872f2087c98
* Remove file_util::kPathSeparator from posix.estade@chromium.org2008-11-271-9/+9
| | | | | | Review URL: http://codereview.chromium.org/12489 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6099 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 5927 as John has a better fix for this issue.ananta@chromium.org2008-11-271-4/+0
| | | | | | | | | | | | | was as below:- R=jam Bug=4582 Review URL: http://codereview.chromium.org/12402 Review URL: http://codereview.chromium.org/10787 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6094 0039d316-1c4b-4281-b951-d872f2087c98
* Reenabling a DCHECK that was causing the ui tests to hang on the dbg build ↵jcampan@chromium.org2008-11-271-3/+1
| | | | | | | | | | | bots, which I could not reproduce locally. I'll try to investigate on the bots. TBR=nsylvain Review URL: http://codereview.chromium.org/10979 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6091 0039d316-1c4b-4281-b951-d872f2087c98
* * Don't do an idle check in StartLogTransmissionTimer(). This check makes ↵pkasting@chromium.org2008-11-271-71/+51
| | | | | | | | | | us never re-set timers after sending logs. The check in TryToStartTransmission() is sufficient to halt uploading and timers after a user has been idle. * Various small style fixes to comply with style guide, around args alignment and indentation. Review URL: http://codereview.chromium.org/11452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6083 0039d316-1c4b-4281-b951-d872f2087c98
* fix linux opt buildtc@google.com2008-11-261-2/+2
| | | | | | | | | | | Set initial values to 0. TBR=jar Review URL: http://codereview.chromium.org/12507 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6070 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding docus manager crasher work-around.jcampan@chromium.org2008-11-263-3/+22
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/12685 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6050 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed two simple compilations that stopped browser/net/referrer.cctc@google.com2008-11-263-10/+11
| | | | | | | | | | | | from compiling on linux. Patch by Kunal Thakar <kunalt@gmail.com>, original CL: http://codereview.chromium.org/10773 Review URL: http://codereview.chromium.org/12674 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6034 0039d316-1c4b-4281-b951-d872f2087c98
* Add client parameter to the RLZ pingcpu@google.com2008-11-261-3/+6
| | | | | | | | | | | | - Does nothing on regular chrome or chromium installs - up to google_update to put data in 'client' BUG=1503035 Review URL: http://codereview.chromium.org/12657 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6030 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting my previous commit, it seems to be breaking the UI tests in debug ↵jcampan@chromium.org2008-11-263-20/+3
| | | | | | | | mode. Review URL: http://codereview.chromium.org/12666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6020 0039d316-1c4b-4281-b951-d872f2087c98
* Changes keyword editor to map all input in the keyword field to lowersky@google.com2008-11-262-14/+17
| | | | | | | | | | | | case. BUG=4520 TEST=bring up the keyword editor, type some text and make sure it gets mapped to lower case. Review URL: http://codereview.chromium.org/12452 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6018 0039d316-1c4b-4281-b951-d872f2087c98
* Attempted fix for some wheel/touchpad scrolling errors.pkasting@chromium.org2008-11-261-1/+1
| | | | | | | | | | | The nTrackPos member of SCROLLINFO is not actually the scroll position, and can't be set by a SetScrollInfo() call. Thus the SetScrollInfo() calls were actually setting the scroll position of the fake scroll bars to the upper left corner. This change sets the scroll position to the center of each scrollbar, in the hopes that some mouse drivers were querying the scroll position or thumb position and not sending scroll left/up messages when they found the page was already scrolled all the way left/up. This change may not help, but it won't hurt, and the old code was definitely wrong. Review URL: http://codereview.chromium.org/12415 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6016 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on the new SafeBrowsing by default. To use the olderpaulg@google.com2008-11-263-6/+6
| | | | | | | | implemenation, use the command line flag: --old-safe-browsing Review URL: http://codereview.chromium.org/12448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6015 0039d316-1c4b-4281-b951-d872f2087c98
* Don't create separate SiteInstances for pages from the same domain and schemecreis@google.com2008-11-263-14/+32
| | | | | | | | | | | | | | | | but from different ports. (These pages can still access each other.) (This is copied from http://codereview.chromium.org/12443, which has already been reviewed by darin and abarth. Just had to commit from a different checked out codebase.) BUG=4792 R=darin,abarth Review URL: http://codereview.chromium.org/12451 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6014 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up paths now that test_file_util has moved.deanm@chromium.org2008-11-252-2/+2
| | | | | | Review URL: http://codereview.chromium.org/12453 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6008 0039d316-1c4b-4281-b951-d872f2087c98
* Port some files in chrome/browser/ - part 1.deanm@chromium.org2008-11-259-35/+60
| | | | | | | Review URL: http://codereview.chromium.org/11402 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6007 0039d316-1c4b-4281-b951-d872f2087c98
* Port base/watchdog to Linux.deanm@chromium.org2008-11-251-2/+2
| | | | | | | | | BUG=4632 Review URL: http://codereview.chromium.org/11326 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6004 0039d316-1c4b-4281-b951-d872f2087c98
* Changes tab restore service to handle restoring closed windows as asky@google.com2008-11-257-213/+340
| | | | | | | | | | | | | | single unit. Sadly I've written another ui test. Lets hope it isn't flakey. Glen is going to change the NTP to deal with this appropriately. BUG=4686 TEST=Try closing a window (with more than one window open), hitting control-shift-t, and make sure the window and all it's tabs comes back. Review URL: http://codereview.chromium.org/11377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6003 0039d316-1c4b-4281-b951-d872f2087c98
* Some crashes reported from the field seems to indicate that whenjcampan@chromium.org2008-11-253-3/+20
| | | | | | | | | | | | | | | | | storing/restoring the focused view on a tab, the focus manager or focused view is garbage. I have not been able to repro any of these crashers and was not able to discover much from the mini-dumps. This is a simple work-around that just prevents the storing/restoring of focus when closing a tab, to avoid the cases reported in the crasher. Note this is the equivalent of CL 12622 (which is on the release branck), which was reviewed by Ben. BUG=4633 Review URL: http://codereview.chromium.org/12652 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6000 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash in WebContents::ShowWidget. I suspect this issky@google.com2008-11-254-0/+30
| | | | | | | | | | | | | happening because the RenderWidgetHost is getting destroyed between the time it is created but before it it shown (perhaps the renderer went away). BUG=4629 TEST=none Review URL: http://codereview.chromium.org/12439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5998 0039d316-1c4b-4281-b951-d872f2087c98
* Changes table_view to get position for context menu from the currentsky@google.com2008-11-251-2/+4
| | | | | | | | | | | | | | position of the mose. I've no idea why, but it seems when RTL the position passed to OnContextMenu is wrong in weird inconsistent ways. I thought it was interted, but that isn't always the case. I'm also changing the anchor position to top_right when RTL. BUG=4750 TEST=see bug Review URL: http://codereview.chromium.org/12447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5996 0039d316-1c4b-4281-b951-d872f2087c98
* The first run sentinel does not get created for system installcpu@google.com2008-11-251-2/+11
| | | | | | | | | | | | - Vista case mostly if user has UAC enabled - The sentinel path is not writeable if you are not elevated so first run keeps happening every time. BUG=1503885 Review URL: http://codereview.chromium.org/12650 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5994 0039d316-1c4b-4281-b951-d872f2087c98
* Changelist for erg's readability review.erg@google.com2008-11-253-114/+180
| | | | | | | | | | | | | | | | I am submitting BlockedPopupContainer for my C++ windows readability review. It's original code reviews are: http://codereview.chromium.org/8782 http://codereview.chromium.org/9373 http://codereview.chromium.org/10606 In addition to the above reviews, the test cases have been (re)written in: http://codereview.chromium.org/10206 http://codereview.chromium.org/9709 http://codereview.chromium.org/10282 Review URL: http://codereview.chromium.org/10618 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5992 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for 1498134, possible crash when cancelling a url request. Thesky@google.com2008-11-252-2/+29
| | | | | | | | | | | | | | crash happened because OnReadCompleted would invoke CompleteRead which might invoke CancelRequest and delete the request. If this happened when control returned back to OnReadCompleted the request was deleted, yet ResourceDispatcherHost assumed it wasn't. BUG=1498134 TEST=none Review URL: http://codereview.chromium.org/12602 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5989 0039d316-1c4b-4281-b951-d872f2087c98
* Set the delegate on incoming TabContents in ↵erg@google.com2008-11-251-3/+5
| | | | | | | | BlockedPopupContainer::ReplaceContents. Review URL: http://codereview.chromium.org/12646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5988 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the encoding menu for javascript and css files. jungshik@google.com2008-11-251-1/+4
| | | | | | | | | | BUG=3565 TEST=Open a JS or CSS file by clicking a link to it in view-source and see if the encoding menu is enabled. Review URL: http://codereview.chromium.org/12619 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5982 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 5971.maruel@chromium.org2008-11-253-136/+2
| | | | | | Review URL: http://codereview.chromium.org/12637 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5974 0039d316-1c4b-4281-b951-d872f2087c98
* Add superficial unit test for PrintJob. That's a start.maruel@chromium.org2008-11-253-2/+136
| | | | | | | | Add more DCHECKs. Same as r5607 except that Thread.StopSoon is fixed. Review URL: http://codereview.chromium.org/11534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5971 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash with plugin installer infobar due to the infobardelegate not being ↵ben@chromium.org2008-11-258-18/+30
| | | | | | | | | | removed from the containing TabContents. http://crbug.com/4620 Review URL: http://codereview.chromium.org/12624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5957 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land 5929 (r5882) with crash fix and also this change:ben@chromium.org2008-11-2517-266/+331
| | | | | | | | | | | http://codereview.chromium.org/11392/show which fixes the remainder of the UI test issues apparently. http://crbug.com/4620 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5954 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of ISO-8859-9 in the character encoding menu because it's now ↵jungshik@google.com2008-11-253-6/+2
| | | | | | | | | | | | treated as an alias to its superset, windows-1254. BUG=4746 TEST=visit http://www.sabah.com.tr (ISO-8859-9 page) and make sure that 'Turkish' is checked in the encoding menu Review URL: http://codereview.chromium.org/11811 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5948 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up some net/ code. Change a number of wstrings to FilePaths.estade@chromium.org2008-11-243-4/+5
| | | | | | Review URL: http://codereview.chromium.org/12409 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5944 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a potential memory leak with a message creation.klink@chromium.org2008-11-241-4/+3
| | | | | | Review URL: http://codereview.chromium.org/11579 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5939 0039d316-1c4b-4281-b951-d872f2087c98
* rollbackben@chromium.org2008-11-247-90/+83
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5933 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r5882 with a crash fix.ben@chromium.org2008-11-247-83/+90
| | | | | | | http://codereview.chromium.org/11559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5929 0039d316-1c4b-4281-b951-d872f2087c98
* Don't reenter Webkit, while it waits for outgoing sync calls to complete. Thisananta@chromium.org2008-11-241-0/+4
| | | | | | | | | | | | | | fixes bug http://code.google.com/p/chromium/issues/detail?id=4582, which is a crash in the renderer process, which occurs when the renderer receives a sync message requesting accessibility information from the browser, while it waits for the PluginDestroyed sync call to unwind. The ViewMsg_GetAccessibilityInfo has a timeout associated with it, which indicates that it is ok for the call to fail. We now turn off the unblock flag on the sync message which will ensure that it does not reenter Webkit in this scenario. R=jcampan Bug=4582 Review URL: http://codereview.chromium.org/12402 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5927 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 5882. It broke LoginPromptTest.TestBasicAuth and .TestTwoAuths.maruel@chromium.org2008-11-247-84/+76
| | | | | | Review URL: http://codereview.chromium.org/11399 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5922 0039d316-1c4b-4281-b951-d872f2087c98
* Remove base versions of the graphics headers, which previously just ↵brettw@google.com2008-11-225-5/+4
| | | | | | | | forwarded to the skia ones. Review URL: http://codereview.chromium.org/11588 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5894 0039d316-1c4b-4281-b951-d872f2087c98
* Add new infobar files to SCons build.sgk@google.com2008-11-222-0/+3
| | | | | | Review URL: http://codereview.chromium.org/11380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5892 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix 2.evanm@google.com2008-11-221-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5886 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix.evanm@google.com2008-11-221-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5885 0039d316-1c4b-4281-b951-d872f2087c98
* This change makes the following infobars use the new system:ben@chromium.org2008-11-227-76/+84
| | | | | | | | - save password Review URL: http://codereview.chromium.org/11559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5882 0039d316-1c4b-4281-b951-d872f2087c98
* Back out r5252 temporarily to see if it is related to thewtc@google.com2008-11-221-10/+1
| | | | | | | | | | crash in ResourceDispatcherHost::OnReadCompleted. R=eroman BUG=b/1498134 Review URL: http://codereview.chromium.org/11584 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5881 0039d316-1c4b-4281-b951-d872f2087c98
* Remove use of wide characters in stats table identifiers.evanm@google.com2008-11-226-60/+56
| | | | | | | Review URL: http://codereview.chromium.org/11544 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5880 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 18:39:36 +0000