summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Move functions required by the rest of the browser from RenderProcessHost to ↵brettw@chromium.org2009-01-1640-630/+729
| | | | | | | | an interface and move the implementation to BrowserRenderProcessHost. This will allow me to write render view unit tests without using the actual renderer, but there are no tests yet. Review URL: http://codereview.chromium.org/18132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8188 0039d316-1c4b-4281-b951-d872f2087c98
* mac bootstrapping of browser main and app startup bitspinkerton@google.com2009-01-167-54/+192
| | | | | | Review URL: http://codereview.chromium.org/18112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8185 0039d316-1c4b-4281-b951-d872f2087c98
* Make GetSignonRealm a global function as opposed towtc@google.com2009-01-163-17/+13
| | | | | | | | | | | a static method of the LoginHandler class, which should remain an interface with only pure virtual methods. R=eroman Review URL: http://codereview.chromium.org/18106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8183 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when handling close tab accelerators. The class would still bebrettw@chromium.org2009-01-161-1/+11
| | | | | | | | | | accessed after the accelerator was handled, and close tab accelerators will cause the view to be deleted out from under us. BUG=6321 Review URL: http://codereview.chromium.org/18151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8182 0039d316-1c4b-4281-b951-d872f2087c98
* Removed a stray string.maruel@chromium.org2009-01-161-1/+1
| | | | | | Review URL: http://codereview.chromium.org/18317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8179 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the test SavePageTest.CleanFilenameFromPageTitle due to bug 6514.maruel@chromium.org2009-01-161-2/+3
| | | | | | Review URL: http://codereview.chromium.org/18154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8178 0039d316-1c4b-4281-b951-d872f2087c98
* Update the command line JavaScript debugger to support the changed debugger ↵sgjesse@chromium.org2009-01-161-64/+141
| | | | | | | | protocol in V8 0.4.8. All the debugger tests now pass. Review URL: http://codereview.chromium.org/18149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8174 0039d316-1c4b-4281-b951-d872f2087c98
* This change list fix issue 3233: RTL: Wrong URL showing on Javascript pop up ↵xji@chromium.org2009-01-161-1/+4
| | | | | | | | | | | | | | | | | | | | | window ( http://crbug.com/3233) The fix put LTR-PDF pair around URL to force URL to be LTR always. test step: 1. open RTL Chrome 2. open http://www.w3.org/International/tests/test-rtl-chrome-4 3. click any "click me" button without the fix, the ending "/" in the URL appears at left-most in the alert window title. with the fix, the ending "/" in the URL appears correctly. Review URL: http://codereview.chromium.org/18088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8170 0039d316-1c4b-4281-b951-d872f2087c98
* Run ShellExecute on the file thread instead of the IO thread. ShellExecute candarin@chromium.org2009-01-162-4/+6
| | | | | | | | | | | | be janky so we don't want to be calling it on the IO thread. The file thread is really the "blocking io" thread, and it's where we call ShellExecute for other things. R=nsylvain Review URL: http://codereview.chromium.org/18120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8166 0039d316-1c4b-4281-b951-d872f2087c98
* Move all the SSL stuff into its own subdirben@chromium.org2009-01-1618-55/+131
| | | | | | Review URL: http://codereview.chromium.org/18137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8165 0039d316-1c4b-4281-b951-d872f2087c98
* Remove timeout constants from ui_tests. All tests will nowpaulg@google.com2009-01-169-36/+36
| | | | | | | | | use accessors for various timeouts which can be set (via command line parameters) to values appropriate to the test environment, such as longer timeouts when running under purify. Review URL: http://codereview.chromium.org/18109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8164 0039d316-1c4b-4281-b951-d872f2087c98
* Move metrics files into a subdirben@chromium.org2009-01-1645-77/+83
| | | | | | Review URL: http://codereview.chromium.org/18302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8156 0039d316-1c4b-4281-b951-d872f2087c98
* Fix windows scons build.ben@chromium.org2009-01-161-4/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8149 0039d316-1c4b-4281-b951-d872f2087c98
* Move search code to a subdirben@chromium.org2009-01-1653-119/+222
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8148 0039d316-1c4b-4281-b951-d872f2087c98
* WaitableEvent is the replacement for Windows events. Previously in the code, ↵agl@chromium.org2009-01-1516-39/+69
| | | | | | | | | | | | | | | | | | | | | | | | | | | | a HANDLE from CreateEvent was used for signaling, both within a process and across processes. WaitableEvent is the cross platform replacement for this. To convert: * HANDLE -> base::WaitableEvent* * ScopedHandle -> scoped_ptr<base::WaitableEvent> * CreateEvent -> new base::WaitableEvent * SetEvent -> base::WaitableEvent::Signal * ResetEvent -> base::WaitableEvent::Reset * ObjectWatcher -> base::WaitableEventWatcher * WaitForMultipleObjects -> static base::WaitableEvent::WaitMany ObjectWatcher remains for Windows specific code. WaitableEventWatcher has an identical interface save, * It uses WaitableEvents, not HANDLEs * It returns void from StartWatching and StopWatcher, rather than errors. System internal errors are fatal to the address space IMPORTANT: There are semantic differences between the different platforms. WaitableEvents on Windows are implemented on top of events. Windows events work across process and this is used mostly for modal dialog support. Windows events can be duplicated with DuplicateHandle. On other platforms, WaitableEvent works only within a single process. In the future we shall have to replace the current uses of cross-process events with IPCs. BEWARE: HANDLE, on Windows, is a void *. Since any pointer type coerces to void *, you can pass a WaitableEvent * where a HANDLE is expected without any build-time errors. Review URL: http://codereview.chromium.org/16554 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8126 0039d316-1c4b-4281-b951-d872f2087c98
* Fie.ben@chromium.org2009-01-1567-202/+7707
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8111 0039d316-1c4b-4281-b951-d872f2087c98
* Part of previous move that seems to have gotten botched.ben@chromium.org2009-01-1514-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8110 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for Issue 3258: Tabs created when tabstrip is compressed pending resizeben@chromium.org2009-01-152-3/+12
| | | | | | | | | | | | | | | | relayout should not force resize relayout. This is proposed solution one from the comment#5 which is to create new tabs without resizing existing tabs unless there is no room for the new tab. BUG=3258 Change from Itai Danan (idanan@google.com) Code review: http://codereview.chromium.org/14050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8109 0039d316-1c4b-4281-b951-d872f2087c98
* Move search engines files into subdirben@chromium.org2009-01-1551-7704/+190
| | | | | | Review URL: http://codereview.chromium.org/18263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8108 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 8081 because it breaks the unit testsnsylvain@chromium.org2009-01-151-7/+4
| | | | | | Review URL: http://codereview.chromium.org/18274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8091 0039d316-1c4b-4281-b951-d872f2087c98
* post-winhttp cleanup: refactor net/base/auth_cache into net/ftp/ftp_auth_cache.ericroman@google.com2009-01-153-6/+80
| | | | | | | | Also moves AuthCache::HttpKey() --> GetSignonRealmKey(). Review URL: http://codereview.chromium.org/18218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8085 0039d316-1c4b-4281-b951-d872f2087c98
* This test only passed if RLZTracker::InitRlz hadn't been called, levin@chromium.org2009-01-151-4/+7
| | | | | | | | | | so it failed when the test run order happened to change. This change fixes that. Review URL: http://codereview.chromium.org/18222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8081 0039d316-1c4b-4281-b951-d872f2087c98
* Remove non-existant files that should have been removedpaulg@google.com2009-01-151-8/+0
| | | | | | | in this CL: http://codereview.chromium.org/18259 Review URL: http://codereview.chromium.org/18083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8076 0039d316-1c4b-4281-b951-d872f2087c98
* fix bustageben@chromium.org2009-01-151-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8067 0039d316-1c4b-4281-b951-d872f2087c98
* Move password manager files into a subdirben@chromium.org2009-01-1519-24/+51
| | | | | | Review URL: http://codereview.chromium.org/18259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8066 0039d316-1c4b-4281-b951-d872f2087c98
* Render maximized mode better when using nonstandard border widths.pkasting@chromium.org2009-01-152-69/+68
| | | | | | | | | | | This change is a bit gross. It calls out to GetSystemMetrics() all over this code, which just shows how many places are sizing themselves from the window edge instead of from the window border edge. When cleaning this file up to be more sane, I intend to make most of these functions position themselves based on the border edge, which should cut down the number of these calls to just a couple (and perhaps collapse some of the constants together too). BUG=5054 TEST=In both Classic and Luna, use the Display control panel to set your active/inactive border widths to something nonstandard (try 20, that's real noticeable) and maximize a Chrome window. Make sure the window controls appear where you expect instead of partly or totally off the screen edges. Review URL: http://codereview.chromium.org/18255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8060 0039d316-1c4b-4281-b951-d872f2087c98
* Fix status bubble positioning with custom border widths by positioning the ↵pkasting@chromium.org2009-01-151-9/+12
| | | | | | | | | | | | | bubble relative to the client area and then converting to parent coordinates instead of trying to position it absolutely with hardcoded constants. Also changes an Offset() call to ConvertPointToView(), which is functionally the same but I think clearer in intent. BUG=5054 TEST=In both Classic and Luna, use the Display control panel to set your active/inactive border widths to something nonstandard (try 20, that's real noticeable) and maximize a Chrome window. Make sure when hovering a link that the status bubble appears aligned with the screen corner instead of partly offscreen. Review URL: http://codereview.chromium.org/18253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8059 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of TabContents related files into a tab_contents subdirben@chromium.org2009-01-15170-494/+649
| | | | | | Review URL: http://codereview.chromium.org/18250 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8058 0039d316-1c4b-4281-b951-d872f2087c98
* More ui_test purify changes.paulg@google.com2009-01-152-21/+22
| | | | | | Review URL: http://codereview.chromium.org/18069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8052 0039d316-1c4b-4281-b951-d872f2087c98
* When opening a new tab by pressing CTRL-T in app mode, the location bar ↵jcampan@chromium.org2009-01-141-0/+5
| | | | | | | | | | | | would not get focused. This is because when the tab was shown its browser window is not yet active. BUG=6380 TEST=Open an app (ex: gmail), press CTRL-T, this opens a new browser with a new tab. Navigate to google.com in the new tab. Go back to the app, press CTRL-T again, a new tab should be opened and the location bar should have focus. Review URL: http://codereview.chromium.org/18017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8040 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix: altbase.h inclusion in hang_monitoragl@chromium.org2009-01-141-0/+1
| | | | | | | | | | r8020 tickled an issue by removing altbase.h from a header file where it shouldn't have been needed. Review URL: http://codereview.chromium.org/18228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8022 0039d316-1c4b-4281-b951-d872f2087c98
* Provides the infrastructure for Browser unit tests that create asky@google.com2009-01-149-102/+125
| | | | | | | | | | | | | BrowserWindow with only a TabStrip. I also converted two ui tests over to unit tests to make sure it all worked. I had to add a bunch of null checks to Browser and a couple of other places. BUG=none TEST=none Review URL: http://codereview.chromium.org/17386 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8007 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux build of unittests.levin@chromium.org2009-01-141-0/+7
| | | | | | | TBR=evan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8002 0039d316-1c4b-4281-b951-d872f2087c98
* Fix UrlFetcher unittest.levin@chromium.org2009-01-142-0/+13
| | | | | | | | TBR=joshia,iyengar Review URL: http://codereview.chromium.org/18220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8001 0039d316-1c4b-4281-b951-d872f2087c98
* Temp fix for windows unit tests.levin@chromium.org2009-01-141-2/+2
| | | | | | | TBR=dimich git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7998 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the release build by including <vector>darin@chromium.org2009-01-141-0/+1
| | | | | | | | TBR=zork Review URL: http://codereview.chromium.org/18032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7990 0039d316-1c4b-4281-b951-d872f2087c98
* After playing around with a modified image from Glen, I concluded that a ↵pkasting@chromium.org2009-01-141-4/+2
| | | | | | | | comment I wrote saying something should be changed was wrong. So fix the comment. Review URL: http://codereview.chromium.org/18028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7989 0039d316-1c4b-4281-b951-d872f2087c98
* Updating so that Gears can spawn file selectors when running in the renderer ↵zork@google.com2009-01-139-13/+159
| | | | | | | | process Review URL: http://codereview.chromium.org/14907 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7986 0039d316-1c4b-4281-b951-d872f2087c98
* Pixel perfection on tabstrip for non-Aero frame. This gets both ends of the ↵pkasting@chromium.org2009-01-135-36/+42
| | | | | | | | tabstrip positioned correctly for normal and incognito windows, in both restored and maximized modes.The chief change was to correctly transform the bounds returned by the non-client view into the BrowserView's coordinate system, as the Views system expected. To make this not break the world I then had to actually return the right coordinates in the non-client view :). Updated comments on function declarations to hopefully match reality.For convenience this also introduces a function to get the horizontal border size and cleans up existing code to use it.BUG=5054 Review URL: http://codereview.chromium.org/18019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7976 0039d316-1c4b-4281-b951-d872f2087c98
* Remove HttpTransactionWinHttp and the --winhttp command-linewtc@google.com2009-01-131-9/+2
| | | | | | | | | | | | | | | switch. Remove WinHttpThrottle and CertStatusCache, which are only used by HttpTransactionWinHttp. Fix nits reported by cpplint.py. R=eroman,darin BUG=6323 Review URL: http://codereview.chromium.org/17635 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7970 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a std::string static constructor in the new history dom ui.deanm@chromium.org2009-01-131-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/17361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7932 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a static initializer for a TimeDelta constant.deanm@chromium.org2009-01-133-8/+5
| | | | | | | Review URL: http://codereview.chromium.org/17631 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7927 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a static initializer while reducing a bit of casting.deanm@chromium.org2009-01-131-7/+4
| | | | | | | Review URL: http://codereview.chromium.org/17628 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7925 0039d316-1c4b-4281-b951-d872f2087c98
* Add hover cards to the recently closed windows on the new tab page.ojan@google.com2009-01-131-10/+172
| | | | | | Review URL: http://codereview.chromium.org/17226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7913 0039d316-1c4b-4281-b951-d872f2087c98
* Regression for importer. Updated the code to reflect the coding standards ↵brg@chromium.com2009-01-133-228/+221
| | | | | | | | of the chrome team. Review URL: http://codereview.chromium.org/10272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7909 0039d316-1c4b-4281-b951-d872f2087c98
* Pixel perfection on OTR icon. The tabstrip is still positioned/sized wrong ↵pkasting@chromium.org2009-01-132-40/+63
| | | | | | | | | | | | | | | | | relative to the OTR icon, sadly. Much of the issue here is because the OTR image was a child view in the old code and isn't in the new. As a result, we have to: * Change the drawing order to draw the OTR image after the tabstrip (like a child view would normally have been drawn), so the tabstrip's semi-transparent pixels don't overlay it * Change the bounds calculation and drawing code to clip the image properly in maximized mode (where a child view would have been clipped naturally) Since I changed the calling order of the OTR functions, I also changed their declaration/definition order to follow suit. This also tries to rename a few constants to be more consistent. I can't figure out how to make any of these read nicely :( BUG=5054 Review URL: http://codereview.chromium.org/17362 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7908 0039d316-1c4b-4281-b951-d872f2087c98
* Fix layout test failures. Looks like keying the plugins based on ↵jam@chromium.org2009-01-131-1/+2
| | | | | | | | OriginalFileName didn't work, since different filenames might still have the same value (i.e. QuickTime). Instead I did what Firefox does, which is collect the list of directories in one pass, then crawl them in another. Review URL: http://codereview.chromium.org/17367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7907 0039d316-1c4b-4281-b951-d872f2087c98
* Check if the delegate in WebContents::CanTerminate is validjoshia@google.com2009-01-131-1/+5
| | | | | | | | | | | before invoking on it. not doing this causes a UT test 'VisibleBrowserTest.WindowOpenClose' to crash frequently. Review URL: http://codereview.chromium.org/17366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7905 0039d316-1c4b-4281-b951-d872f2087c98
* On exit do not terminate renderers hosted in external tabsjoshia@google.com2009-01-128-2/+24
| | | | | | | | | | | | | | | When a browser window is closed, we just terminate all existing renderers for fast shutdown. If we have any renderers hosted externally using automation they are also killed during this process. The fix is to prevent fast termination if any of the tabs are hosted by automation. Review URL: http://codereview.chromium.org/17453 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7901 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds a way to block resource requests in the ResourceDispatcherHost ↵jcampan@chromium.org2009-01-125-38/+435
| | | | | | | | | | | | | | | for specific RenderViewHosts. This is used by the interstitial code to prevent the original page from making network requests while the interstitial is showing. Several UI tests are still required to test this. Because of the inherent complexity of the scenarios to test this, I'm afraid these tests are going to be flakey and soon after disabled (like many of the interstitial UI tests at this point). This will be done next as part of my next effort to mock some of the WebContents stuff. TEST=Run the unit tests. Create a page that does XMLHttpRequests and log when the requests complete with the time it did. While that page is shown, switch to a malware/bad SSL page. Come back to the page, ensure no requests were processed while the interstitial was showing. BUG=None Review URL: http://codereview.chromium.org/16546 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7898 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 22:10:53 +0000