summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Make our distributor logo light on XP (and leave it dark on Vista).glen@google.com2008-08-021-2/+2
| | | | | | Also conveniently fixes accessibility test 'failures' introduced by the last distributor logo change. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272 0039d316-1c4b-4281-b951-d872f2087c98
* Add a non-interactive distributor logo to the window frame. This logo ↵glen@google.com2008-08-014-21/+70
| | | | | | disappears in maximized view to avoid taking away from the tab strip. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270 0039d316-1c4b-4281-b951-d872f2087c98
* Let the logo display correctly on the History and Downloads pages in RTL. ↵glen@google.com2008-08-012-17/+35
| | | | | | | | This really should be using our GridLayout, but GridLayout had trouble both handling our row-spanned images, and cropping the image correctly when the column got too small (it center-cropped it). In the interests of not adding complication for Beta, I just modified the existing code. BUG=1304459 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267 0039d316-1c4b-4281-b951-d872f2087c98
* SCons build:sgk@google.com2008-08-011-0/+3
| | | | | | | | | | | | * Add base\object{,_watcher}.cc. * Add chrome\browser\bookmark_{codec,storage}.cc. * Add chrome\views\frame\browser_window_factory.cc. * Split of app\main.cc into app\chrome_{dll,exe}_main.cc, with added CPPDEFINES for {BROWSER,RENDERER,PLUGIN}_DLL. * Move $CSCRIPT, $PLATFORMSDK* and $VISUAL_STUDIO variables to the win32-specific construction environment. * Remove unnecessary comments. TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261 0039d316-1c4b-4281-b951-d872f2087c98
* Automation provider should send real windows messages to the window when ↵beng@google.com2008-08-011-8/+33
| | | | | | | | simulating drags, rather than ChromeViews events. Sending ChromeViews events directly to the RootView means that capture isn't set up properly and some state relating to dragging isn't saved on the frame. B=1303306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258 0039d316-1c4b-4281-b951-d872f2087c98
* Make closetabsopenedby walk the whole tabstrip instead of just all the tabs ↵ojan@google.com2008-08-011-1/+1
| | | | | | to the right of the tab whose context menu was used. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK in history_backend by ensuring we clear redirect tracking state ↵timsteele@google.com2008-08-011-1/+61
| | | | | | | | | | | | | whenever the RenderView is told that a provisional load has started for the main frame. The DCHECK(params->referrer == params->redirects[0]) was firing because: a) page A was loaded, triggered WillPerformClientRedirect b) after the provisional load started for the destination page of A's client redirect, but before this load was committed, the browser makes a Navigation request for page B. c) When page B's load is committed, the RenderView's completed_client_redirect_src_ was still set, resulting in a CLIENT_REDIRECT transition type and forwarding the src value through params->referrer -- but params->redirects was now completely unrelated. Kaboom. This fix should be general enough to handle cases (that are relatively likely in the wild) where WebKit legitimately cancels the redirect, instead of just the browser doing so. Note we can't depend on dispatchDidCancelClientRedirect because we get that callback on both completion and cancellation of a client redirect. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ability to dynamically generate keywords. Mark the Google engine as ↵pkasting@google.com2008-08-0110-160/+277
| | | | | | | | needing this. This ensures that users in countries where the Google base URL is not "google.com" will see the appropriate keyword for their local country (and can trigger it for tab-to-search, etc.). BUG=1301290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a backend for the bookmarks bar that reads/writes to a JSONsky@google.com2008-08-016-0/+640
| | | | | | | | | | | | file. These files aren't being built or used yet (though a test case exists that is ifdef'd out). BUG=1256202 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the BrowserView to the XPFrame/VistaFrame, and moves the ↵beng@google.com2008-08-0112-148/+257
| | | | | | | | | | | | | | | | | | | | BrowserToolbarView and StatusBubble into it. Also restructures the creation of the Frame. This is significant! The Browser now constructs a frame via a new static BrowserWindow::CreateBrowserWindow method (see browser_window_factory.cc). Recall the diagram in the architectural overview doc - the BrowserView object is the one that implements the interface that the Browser object uses to communicate with the UI. The Browser object communicates to the BrowserView directly through this interface, but not directly to the frame. What actually happens right now in CreateBrowserWindow is that an XP/VistaFrame is constructed, but this is _not_ the object returned to the Browser, rather when the XP/VistaFrame is init'ed, it constructs a BrowserView that also implements BrowserWindow. This is the object that's returned to the Browser. Since both BrowserView and XP/VistaFrame implement BrowserWindow, I am now able to gradually migrate functionality from the frames to BrowserView. During this process BrowserWindow functions not handled yet by BrowserView will be forwarded to the appropriate frame. Modifies the Accessibility UI tests to account for this extra level of indirection (should only be temporary while I'm moving things around). This does actually pass the UI tests. See the whiteboard in my office for a diagram. This is a bit confusing right now since there's so much going on. Sadly the only way to get where we need to go incrementally is to make a mess on the way. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245 0039d316-1c4b-4281-b951-d872f2087c98
* Forward declare Task in ssl_manager.h. Cleanup some uses of ↵deanm@google.com2008-08-014-4/+3
| | | | | | | | notification_service.h. TBR=maruel git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug introduced with the locking changes to login_prompt.cc :\deanm@google.com2008-08-011-1/+1
| | | | | | TBR=maruel git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236 0039d316-1c4b-4281-b951-d872f2087c98
* Remove atomic operations from login_prompt.cc. Removes an atomic tess and ↵deanm@google.com2008-08-011-12/+18
| | | | | | set, and replaces it with a lock. Rename confusing GotAuth test and set method to was WasAuthHandled, which will optionally marked as handled. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235 0039d316-1c4b-4281-b951-d872f2087c98
* Pick the most commonly used search engine as the default when we have ↵pkasting@google.com2008-08-011-3/+6
| | | | | | | | competing can-be-default choices with the same host and path. Previously we would end up picking the least commonly used engine in this case. BUG=1303406 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218 0039d316-1c4b-4281-b951-d872f2087c98
* Allow trailing commas in JSON responses from suggestion services. Various ↵pkasting@google.com2008-08-011-0/+1
| | | | | | | | real-world servers return responses like this and there's no obvious reason to disallow it, even though technically it violates the JSON spec. BUG=1295216 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217 0039d316-1c4b-4281-b951-d872f2087c98
* Have CommandCloseTabsOpenedBy iterate through the tabs in reverse order to ↵ojan@google.com2008-08-011-6/+5
| | | | | | | | avoid race conditions with tab closing now that it's async. BUG=1303289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216 0039d316-1c4b-4281-b951-d872f2087c98
* Make BrowserView implement the BrowserWindow interface so we can start ↵beng@google.com2008-08-012-1/+201
| | | | | | | | moving frame functionality into it. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214 0039d316-1c4b-4281-b951-d872f2087c98
* Move the BookmarkBarView into the frames.beng@google.com2008-08-017-46/+69
| | | | | | | | Yes this causes duplicate code, but only for a brief while until I can bring up BrowserView at which point this code will move from the frames to that object. "It gets worse before it gets better". B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate the infinite read loop that can occasionally allowpaulg@google.com2008-08-011-8/+20
| | | | | | | | | | | | | | | | | | | | a large, fast network request to monopolize the IO thread. This particular bug was tickled by an FTP download where pause tasks posted to the IO thread from the UI thread were blocked from running until the FTP transfer was completed, leading to user noticeable jankiness. I added histograms to the previous read loop and noticed that during regular browsing and downloading sessions, the number of times the loop was traversed was 1 for something like 99.5% of the time. This leads me to believe that eliminating the read loop in favor of asynchronous tasks will not impact performance. BUG=1270179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212 0039d316-1c4b-4281-b951-d872f2087c98
* Minor alignment tweaks to simple XP frame.glen@google.com2008-07-311-3/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210 0039d316-1c4b-4281-b951-d872f2087c98
* Stop the new tab page fading in if it's not your startup tab.glen@google.com2008-07-313-40/+28
| | | | | | BUG=1295355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209 0039d316-1c4b-4281-b951-d872f2087c98
* Command-line flag to allow the debugger UI to be loaded from the filesystem ↵erikkay@google.com2008-07-311-2/+20
| | | | | | rather than the DLL. Very useful for rapid development. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208 0039d316-1c4b-4281-b951-d872f2087c98
* Move BrowserToolbarView to the frames (XPFrame/VistaFrame).beng@google.com2008-07-3111-44/+117
| | | | | | | | | | This causes some temporary duplication of code in xp/vista frames but it will be temporary. My goal is to move all the top level browser level views into the frames. From there, I will move them from the frames into their new home - BrowserView (chrome/browser/views/frames/browser_view.cc), and each frame will host a BrowserView. This will reduce duplication of code. To make this change I had to add a bunch of methods to the BrowserWindow (nee ChromeFrame) interface to provide access to some of the toolbar's contents. Excuse the ugly API, we will be improving this incrementally. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205 0039d316-1c4b-4281-b951-d872f2087c98
* Updated the SSL UI test with the common name from the new cert.jcampan@google.com2008-07-311-4/+2
| | | | | | | BUG=1293555 TEST=Run the ssl ui tests. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where debugger wasn't showing its contents.beng@google.com2008-07-314-3/+20
| | | | | | | | | | Since the debugger window hosts a HWND, it should be initialized when the DebuggerView is inserted into the hierarchy, such that it gets sized properly. Also the DebuggerView needed to propagate changes to its own bounds into the inner view. Also fixes a DCHECK in NavigationController that wasn't handling the existence of the debugger. B=1302810 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SCons breakage, plus latest updates:sgk@google.com2008-07-312-1/+7
| | | | | | | | | | | | | * Update src/DEPS to latest icu38 rev. * Add new browser/views/frame/*.cc files. * Add new browser/debugger/debugger_contents.cc file. * Add new views/dialog_client_view.cc file. * Build new browser/debugger/resources/debugger_resources.rc file. * Add a new ChromeVersionRC() builder to the environment to provide a simpler, abstract interface for the four *version.rc files we build, with fixed definitions of $VERSION_BAT and $CHROME_SRC_DIR. * Fix the definition of $HTML_INLINE. R=deanm,bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 1303177: Homepage field left enabled even though Reset to Default sets ↵finnur@google.com2008-07-312-7/+9
| | | | | | | | | | | | homepage to New Tab page. The fix is to enable the textfield when the NewTabPageIsHomePage setting is changed. I also left out a change to the header guard from my last checkin (no code change). That's included in this changelist. BUG=1303177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193 0039d316-1c4b-4281-b951-d872f2087c98
* Move more net classes into the net namespace. Also remove the net_util ↵darin@google.com2008-07-3148-144/+149
| | | | | | | | namespace in favor of the net namespace. This is a purely mechanical change. There should be no logic changes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192 0039d316-1c4b-4281-b951-d872f2087c98
* We were reporting Google Update errors as error:0, due to the fact that we ↵finnur@google.com2008-07-312-0/+6
| | | | | | | | | | were not catching the failure code from Google Update and reporting it. This is now fixed. This is mentioned on the side in this bug (although this check-in does not fix this bug) BUG=1302580 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191 0039d316-1c4b-4281-b951-d872f2087c98
* Simplifies the project configuration by setting the lib dependency in the ↵maruel@google.com2008-07-311-2/+6
| | | | | | | | source file. BUG=1211534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181 0039d316-1c4b-4281-b951-d872f2087c98
* Initial cleanup and refactoring to make debugger UI use DHTML and get rid of ↵erikkay@google.com2008-07-3121-80/+580
| | | | | | | | | | | | | | the last of its native UI. This is done using a DOMUIHost subclass and a new TabContents type. This checkin also fixes a few minor issues: * hitting the keyboard accelerator brings the current debugger window to front * text is grayed out when in "running" mode rather than "paused" * up/down arrows have command-line history (transient) * some text used to get eaten when you first bring up the window ("attached to <tabname>"), this is now handled git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180 0039d316-1c4b-4281-b951-d872f2087c98
* Initial cleanups en route to coalescing the get-it-built cut-and-paste from ↵sgk@google.com2008-07-312-76/+70
| | | | | | | | | | | | | | | | | | various SConscripts into readable and maintainable shape. To wit: * Put the near-universal settings of /DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS, /DWIN32_LEAN_AND_MEAN, /wd4503 and /wd4819 in the base construction environment. * Sort various unsorted source file lists. * Fix indentation and quoting for consistency in a couple SConscript files that escaped previous dragnets. * Eliminate two left-over uses of Split() for input file lists. * Give the devenv invocation to build v8_shell.exe the full path to the relevant .vcproj file. * Add /nologo to the base LINKFLAGS setting. * Remove various CPPPATH and other settings that have been hanging around commented out from the Visual Studio build (in case we needed them, which we evidently don't). * Get rid of unnecessary env.File() and env.Dir() calls in various settings (esp. CPPPATH) and source file lists. * Add copyright notice to an overlooked SConscript file. * Clean up version.bat invocation. TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174 0039d316-1c4b-4281-b951-d872f2087c98
* Stub out the files to be used for the new browser frame.beng@google.com2008-07-3112-0/+677
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168 0039d316-1c4b-4281-b951-d872f2087c98
* Move dialog-specific aspects of ClientView into a new subclass DialogClientView.beng@google.com2008-07-3110-56/+40
| | | | | | | | | | | | | | ClientView becomes a generic representation of the View that occupies the "client area" of a window. All Windows now require a Client View (though they can use the default). Adjust WindowDelegate to provide a method for constructing the ClientView for a Window. The DialogDelegate overrides this to construct the DialogClientView. In the future, other specialized delegates will construct ClientViews specific to them, e.g. WizardDelegate would construct WizardClientView. Adjust the Window Init method to set up this new required Client View, and make some tweaks to CustomFrameWindow to make all this work. Remove all traces of dialog specific handling in Window into DialogClientView. B=1280060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153 0039d316-1c4b-4281-b951-d872f2087c98
* Adds exitcodes for the TerminateProcess calls on hung renderers. There are ↵ojan@google.com2008-07-313-3/+5
| | | | | | still plenty of TerminateProcess(..., 0) calls, but these are the ones I know. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152 0039d316-1c4b-4281-b951-d872f2087c98
* I looked at the full dump from the previous crashes and it looks like a ↵brettw@google.com2008-07-301-1/+2
| | | | | | testing issue. Hopefully it will be magically unbroken. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151 0039d316-1c4b-4281-b951-d872f2087c98
* At the first run use Omaha usagestats key to determine whether to collect ↵rahulk@google.com2008-07-303-2/+4
| | | | | | | | | | | user metrics. BUG=1299579 TEST=With clean profile and no "first run" file, start Chrome and make sure that Under the Hood->Help make Chrome better... option is checked or unchecked depending on whether the value of HKEY_CURRENT_USER\Software\Google\Update\ClientState\{8A69D345-D564-463c-AFF1-A69D9E530F96}\usagestats key is 1 or 0. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149 0039d316-1c4b-4281-b951-d872f2087c98
* Removes a method never implemented in HistoryDB.sky@google.com2008-07-301-3/+0
| | | | | | | | | BUG=none TEST=none; this is just cleanup git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144 0039d316-1c4b-4281-b951-d872f2087c98
* Make the download arrow show and hide correctly in response to shelf ↵glen@google.com2008-07-305-9/+10
| | | | | | | | visibility. This was caused by both the shelf_visible_ bool not being set by the download shelf correctly, and the tab renderer not being aware of the new state. BUG=1300997 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143 0039d316-1c4b-4281-b951-d872f2087c98
* Simple change to make the "New [incognito] window" commands work like you'd ↵pkasting@google.com2008-07-302-6/+5
| | | | | | | | | | | | expect. The old behavior disabled "New incognito window" when in incognito windows, created a new incognito tab instead of a new window when you already had an incognito window open, and gave you no way to get a non-incognito window from an incognito one. Now, both commands are always enabled, and both do exactly what they say they'll do no matter what type of window you're currently in. BUG=1190035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142 0039d316-1c4b-4281-b951-d872f2087c98
* Make NonClientView an interface independent of CustomFrameWindow (i.e. move ↵beng@google.com2008-07-301-58/+17
| | | | | | | | | | | | it into its own file). Rename NonClientView's HitTest method to NonClientHitTest, so it doesn't collide with View's HitTest method. Also, consolidate some duplicated code between CustomFrameWindow and ConstrainedWindow's non-client view impl. B=1300864 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141 0039d316-1c4b-4281-b951-d872f2087c98
* Made changes to display tooltip window when user navigates through the icons ↵stanguturi@google.com2008-07-301-0/+12
| | | | | | | | in the toolbar using keyboard arrow keys. I have already fixed this issue. (Issue:801). I have got LGTM also. But, I have checked in the code when tree was closed. So, all my changes were reverted. So, this new issue is created to upload the same changes. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139 0039d316-1c4b-4281-b951-d872f2087c98
* Update SCons build for recent changes:sgk@google.com2008-07-301-1/+1
| | | | | | | | | | Delete chrome_frame.cc, add frame_util.cc. url_request_http_cache_job.cc => url_request_http_job.cc. Rename sandbox *tests.exe to sbox_*.exe per upstream. Define ENABLE_CROSS_DOCUMENT_MESSAGING when generating V8 bindings. TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135 0039d316-1c4b-4281-b951-d872f2087c98
* Insert a commasidchat@google.com2008-07-301-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we remove info-bars on reload.jcampan@google.com2008-07-301-1/+3
| | | | | | | BUG=1296826 TEST=See bug git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more classes from net/base into the net:: namespace.darin@google.com2008-07-3015-42/+45
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116 0039d316-1c4b-4281-b951-d872f2087c98
* Send the "shutdown didn't get to finish" metric to UMA.evanm@google.com2008-07-301-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 1295677: REGRESSION: Import SETS startup page to imported home page.finnur@google.com2008-07-308-28/+65
| | | | | | | | | We had only kHomePage pref before, which if blank/set to chrome-internal: meant that the New Tab page should be shown when Home is pressed. Now we add a pref called kHomePageIsNewTabPage for this purpose, which allows us to set the kHomePage value during import without actually using it as the HomePage (effectively importing home page becomes importing a default suggestion for when the users want a home page instead of the New Tab page). BUG=1295677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107 0039d316-1c4b-4281-b951-d872f2087c98
* Make HWNDViewContainer set up its contents view separately from its Init method.beng@google.com2008-07-3010-11/+16
| | | | | | | | | This is needed as a first step in further adjustments I'm going to be making to Window, ClientView, etc. B=1280060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeFrame->BrowserWindowbeng@google.com2008-07-3024-172/+224
| | | | | | | | | Move static utility functions to FrameUtil class. B=1294302 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 13:07:40 +0000