summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Port some more parts of browser/evanm@google.com2008-10-2310-84/+122
| | | | | | | | | | | | This first needs http://codereview.chromium.org/6492 (porting base/process_util). BUG=2333 Review URL: http://codereview.chromium.org/6268 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3858 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes http://code.google.com/p/chromium/issues/detail?id=2529, which isananta@chromium.org2008-10-234-4/+16
| | | | | | | | | | | | | tabs displaying Loading/Untitled in Chrome. We should display the page URL if the title of the page is blank. Fix on these lines. R=beng Review URL: http://codereview.chromium.org/7905 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3852 0039d316-1c4b-4281-b951-d872f2087c98
* Set |contents_mime_type| early enough so that the encoding menu is enabled ↵jungshik@google.com2008-10-231-3/+7
| | | | | | | | | | | | | | on the first load of a page in a tab. BUG=2929 TEST=Launch Chrome, go to www.google.com and make sure that the encoding menu is enabled. Review URL: http://codereview.chromium.org/7894 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3844 0039d316-1c4b-4281-b951-d872f2087c98
* Add a separate string for showing that chrome updated withouttc@google.com2008-10-231-9/+9
| | | | | | | | | | a version number. This makes it easier for translators to handle both cases. BUG=2656 Review URL: http://codereview.chromium.org/7900 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3821 0039d316-1c4b-4281-b951-d872f2087c98
* Adds models needed by the bookmark manager. Specifically asky@google.com2008-10-239-5/+1204
| | | | | | | | | | | | | BookmarkTableModel, which will be used to show one of the following: the children of a folder, recently bookmarked or the results of a search. And the tree model implementation that shows the folders. BUG=674 TEST=covered by unit tests Review URL: http://codereview.chromium.org/8063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3814 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 in Chromium and fix compilation errors kasperl@google.com2008-10-232-2/+2
| | | | | | | | | | | resulting from API changes. NOTE: I'll probably submit this with a slightly later V8; I'm still waiting for the try-finally issue to be resolved. Review URL: http://codereview.chromium.org/7913 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3811 0039d316-1c4b-4281-b951-d872f2087c98
* Disable link doctor when in off the record/incognito mode.tc@google.com2008-10-231-0/+4
| | | | | | | BUG=3493 Review URL: http://codereview.chromium.org/8088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3805 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash due to NULL deref.ben@chromium.org2008-10-231-1/+4
| | | | | | | http://crbug.com/3183 Review URL: http://codereview.chromium.org/8069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3803 0039d316-1c4b-4281-b951-d872f2087c98
* Change a dependency from clipboard_util.h to the more cross-platform clipboard.hestade@chromium.org2008-10-221-2/+2
| | | | | | Review URL: http://codereview.chromium.org/7884 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3797 0039d316-1c4b-4281-b951-d872f2087c98
* Change the default http stack for chrome.exe from winhttp to the new one.ericroman@google.com2008-10-221-3/+2
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=2645 Review URL: http://codereview.chromium.org/7876 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3776 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies.evanm@google.com2008-10-224-0/+4
| | | | | | | | | Random files in V8Bindings were getting rebuilt when I touched process_util.h. I tracked it down to stats_table.h and shared_memory.h. This change cuts down some dependencies there; more could be removed if we made some of our FooHandle typedefs into abstract data types instead. Review URL: http://codereview.chromium.org/7307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3770 0039d316-1c4b-4281-b951-d872f2087c98
* Make the character encoding override work again. There are two other bugs ↵jungshik@google.com2008-10-227-22/+37
| | | | | | | | | | with character encoding override, but it seems that it's better to fix them separately. BUG=3315 Review URL: http://codereview.chromium.org/7647 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3759 0039d316-1c4b-4281-b951-d872f2087c98
* Apply the already-reviewed <http://codereview.chromium.org/2936> by ↵glen@google.com2008-10-222-0/+7
| | | | | | | | | | | | | developer0420. I updated it to always have reload enabled, as you sometimes want to reload while a page is loading. BUG=204 TBR=ben Review URL: http://codereview.chromium.org/8016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3754 0039d316-1c4b-4281-b951-d872f2087c98
* Switching hash/ to $CHROME_SRC_DIR/chrome down in chrome.bradnelson@google.com2008-10-222-2/+2
| | | | | | Review URL: http://codereview.chromium.org/7856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3727 0039d316-1c4b-4281-b951-d872f2087c98
* Using $CHROME_SRC_DIR in place of hash/..bradnelson@google.com2008-10-223-3/+3
| | | | | | | | This will facilitate changing where the main sconstruct lives. Review URL: http://codereview.chromium.org/7847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3725 0039d316-1c4b-4281-b951-d872f2087c98
* forgot this file tooben@chromium.org2008-10-221-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3724 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the bug with the minimize/restore buttons getting stuck hot when the ↵ben@chromium.org2008-10-225-0/+20
| | | | | | | | | | | window is restored. Turns out the messages we receive prior to becoming restored/minimized etc are not sufficient to restore the button to its appropriate state. Since this is specific to the implementation of these controls, I have provided a solution specific to them. http://crbug.com/3559 Review URL: http://codereview.chromium.org/7803 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3721 0039d316-1c4b-4281-b951-d872f2087c98
* Change the detection of the list name from parsing a URLpaulg@google.com2008-10-223-13/+3
| | | | | | | | to storing it from the update in order to avoid breaking due to changes in the format. Review URL: http://codereview.chromium.org/7851 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3717 0039d316-1c4b-4281-b951-d872f2087c98
* Correct typo in histogram name (I left out the word trial)jar@google.com2008-10-221-2/+4
| | | | | | | r=mbelshe Review URL: http://codereview.chromium.org/8045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3714 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback r3693 as it caused a 7% startup test slowdown.ericroman@google.com2008-10-221-2/+3
| | | | | | | | BUG=3639 Review URL: http://codereview.chromium.org/8044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3711 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing various layout issues with the download shelf:finnur@google.com2008-10-213-27/+31
| | | | | | | | | | | | 1) Bug 3424: If you download an EXE which takes a while to start and you switch tabs before it does, then when you come back to the tab it would truncate the dangerous download on the right because we have never cached the size of the label. We now perform a SizeLabelToMinWidth() in the constructor of DownloadItem for dangerous downloads to make sure the calculation has taken place when needed. 2) Bug 3424: Once I fixed the problem above, I also noticed that the Save and Discard buttons would not show since the cached button sizes are 0 because the view animation took place while the shelf was hidden (while the shelf had no parent). By triggering a Layout of the shelf after setting the bounds, this triggers the buttons to draw appropriately. 3) Bug 3459: The remaining work was to fix the truncation on the bottom of the dangerous download view by taking the size of the progress icon for non-dangerous downloads into account. Ideally, we should increase the size of a non-dangerous download view if the warning icon or the buttons on the dangerous download view cause the size to increase, but I find that unlikely and it should be easy to fix if we come across that. Review URL: http://codereview.chromium.org/7843 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3705 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary disabling accessibility in the renderer to work-around bug 1432077 ↵jcampan@chromium.org2008-10-212-0/+11
| | | | | | | | | | | | which causes a crasher on tablet PCs (which for some reason issue WM_GETOBJECT messages). Once that bug is fixed (John is currently working on it), then we can reenable it. BUG=1432077 Review URL: http://codereview.chromium.org/7823 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3697 0039d316-1c4b-4281-b951-d872f2087c98
* Create memory histograms that also depend on the memory-model experimentjar@google.com2008-10-211-10/+36
| | | | | | | | | | | The experiment was set up to measure tab switch time impact, and this mod will allow us to see the impact on user memory (and user perception of memory). r=mbelshe Review URL: http://codereview.chromium.org/8027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3696 0039d316-1c4b-4281-b951-d872f2087c98
* Change the default http stack for chrome.exe from winhttp to the new one.ericroman@google.com2008-10-211-3/+2
| | | | | | | | http://code.google.com/p/chromium/issues/detail?id=2645 Review URL: http://codereview.chromium.org/7668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3693 0039d316-1c4b-4281-b951-d872f2087c98
* Remove WebKeyboardEvent::key_data because we don't actually use ittc@google.com2008-10-211-1/+1
| | | | | | | | anymore. This makes WebKeyboardEvent easier to port to other platforms. Review URL: http://codereview.chromium.org/8026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3692 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use UuidCreate as a source of randomness, and it's not portable. This ↵deanm@chromium.org2008-10-211-21/+5
| | | | | | | | removes chrome.dll's dependence on rpcrt4.dll (although it will still likely be loaded later). If the change is fine, I will also remove it from the depends list and the build configuration files. Review URL: http://codereview.chromium.org/7818 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3687 0039d316-1c4b-4281-b951-d872f2087c98
* Run MetricsResponseTest on the Mac. This test depended onmark@chromium.org2008-10-215-55/+63
| | | | | | | | | | | url_fetcher_protect.h, which contained a ProtectEntry class, but this name conflicts with the ProtectEntry function in QuickDraw, and apparently QuickDraw headers were being brought in by some other system header we use. Rename our ProtectEntry to URLFetcherProtectEntry, and change ProtectManager for consistency. Review URL: http://codereview.chromium.org/7834 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3684 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a timing problem that caused the find bar's coordinates to be incorrect.brettw@google.com2008-10-212-7/+2
| | | | | | | | The visible flag was getting set twice from two different sources, one of which was wrong. Review URL: http://codereview.chromium.org/7820 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3666 0039d316-1c4b-4281-b951-d872f2087c98
* Add a sleep to temporarily fix the find in page test.brettw@google.com2008-10-211-0/+5
| | | | | | Review URL: http://codereview.chromium.org/7819 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3663 0039d316-1c4b-4281-b951-d872f2087c98
* Fix include path from last checkin.brettw@google.com2008-10-211-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7815 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3655 0039d316-1c4b-4281-b951-d872f2087c98
* Factor find in page out of WebContents and into the view, since it is almostbrettw@google.com2008-10-2123-462/+486
| | | | | | | | | | | | | | | all view specific. Rename find in page controller to be "FindBarWin", and find in page view to be "findBarView" (since this is not Windows specific, but "Views" specific). I did lots of simplification and moving around of the find in page API. I coalesced several of the show functions into one master function on the view. I removed some other sizing and window updating code from WebContents and moved it to the view. Review URL: http://codereview.chromium.org/7667 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3654 0039d316-1c4b-4281-b951-d872f2087c98
* try rolling this back to see if it helpsben@chromium.org2008-10-211-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3645 0039d316-1c4b-4281-b951-d872f2087c98
* Fix breakage from r3643.aa@chromium.org2008-10-211-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3644 0039d316-1c4b-4281-b951-d872f2087c98
* Show the path to the Greasemonkey script that caused an erroraa@chromium.org2008-10-212-12/+16
| | | | | | | | in the console. Review URL: http://codereview.chromium.org/7533 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3643 0039d316-1c4b-4281-b951-d872f2087c98
* To go with the retardation of recently closed tabs, remove the yellow from ↵glen@google.com2008-10-201-4/+1
| | | | | | | | the style. Review URL: http://codereview.chromium.org/7624 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3630 0039d316-1c4b-4281-b951-d872f2087c98
* Restore field trial for memory modeljar@google.com2008-10-202-6/+0
| | | | | | | | | | | | Rollback was not needed to correct distributed test regression. This reverts changes in 3608, which were done to try to repair the regression. r=huanr Review URL: http://codereview.chromium.org/7522 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3627 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ctrl-k not working.pkasting@chromium.org2008-10-201-1/+1
| | | | | | | | | This was just an artifact of how I changed my mind a number of times during the AutocompleteEdit model/view split and failed to ultimately do the right thing here. BUG=2901 Review URL: http://codereview.chromium.org/7672 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3621 0039d316-1c4b-4281-b951-d872f2087c98
* More Windows-is-a-crack-baby mitigation.beng@google.com2008-10-201-1/+1
| | | | | | | | | | | | | | | | | I think I've finally fixed this. Knock on wood. Turns out that these two additional places do non-client rendering: - DefWindowProc for WM_NCLBUTTONDOWN - the function EnableMenuItem (called from CustomFrameWindow::OnInitMenu) For the first case, we also need to unlock updating when we begin to receive mouse move events during modal size/move loops, otherwise the feedback won't be visually continuous. http://crbug.com/3264 Review URL: http://codereview.chromium.org/7662 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3620 0039d316-1c4b-4281-b951-d872f2087c98
* Disable FieldTrial code to repair UI reliability test regressionjar@google.com2008-10-202-0/+6
| | | | | | | r=mbelshe Review URL: http://codereview.chromium.org/7520 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3608 0039d316-1c4b-4281-b951-d872f2087c98
* Construct a field trial to see if HIGH or MEDIUM memory model "works better"jar@google.com2008-10-196-10/+77
| | | | | | | | | | | | | | Includes definition of a FieldTrial class to support this. I have thoughts in my head about how this will eventually extend to be controllable via UMA (as well as being able to run tests defined at compile time, as was done in this example. r=mbelshe, mmentovai Review URL: http://codereview.chromium.org/7638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3604 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 3487: We now set the bounds for the links in the About box as soon as ↵finnur@google.com2008-10-191-19/+18
| | | | | | | | we know where they should be placed, instead of waiting until the Layout call to do so. This fixes an issue of the links not appearing at all -- something, that I can't reproduce myself, but Darin could on his Vista machine (until he tried this fix). Review URL: http://codereview.chromium.org/7513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3603 0039d316-1c4b-4281-b951-d872f2087c98
* Move more platform-specific stuff from WebContents to the view.brettw@google.com2008-10-187-187/+189
| | | | | | | | | | | I refactored the way title setting is done since there were two parts that duplicated the logic and did so slightly differently. I removed some old code in RendererGone whose premise is no longer valid and had the effect of creating a bug with no benefit. I moved the sad tab view from WebContents to the view. Amusingly, the view was the only one using this, but it would go poke inside of the WebContents to get it. Review URL: http://codereview.chromium.org/7650 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3601 0039d316-1c4b-4281-b951-d872f2087c98
* Support shortcut show styles for "run maximized", "run minimized" etc.ben@chromium.org2008-10-172-1/+3
| | | | | | | http://crbug.com/3278 Review URL: http://codereview.chromium.org/7504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3579 0039d316-1c4b-4281-b951-d872f2087c98
* Changes BookmarkDragData to allow for multiple nodes. I'm going tosky@google.com2008-10-175-150/+306
| | | | | | | | | | | | | | | | | need this for the bookmark manager, which will let you drag multiple nodes around. I didn't make the bookmark bar deal with multiple nodes though (it won't allow a drop of multiple nodes). I may add support for this at some point, but not in this patch. BUG=674 TEST=covered by unit tests, but make sure the aren't problems dragging around bookmarks on the bookmark bar, especially with folders. Review URL: http://codereview.chromium.org/7498 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3575 0039d316-1c4b-4281-b951-d872f2087c98
* We were still warning about a dangerous download when the user has picked ↵jcampan@chromium.org2008-10-171-2/+8
| | | | | | | | | | the option to always ask for download. BUG=3539 TEST=Select the option "always ask for download". Download an exe. You should not see a dangerous download warning. Review URL: http://codereview.chromium.org/7634 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3570 0039d316-1c4b-4281-b951-d872f2087c98
* Straighten out the way the system menu works a bit. We no longer create the ↵ben@chromium.org2008-10-177-41/+32
| | | | | | | | | menu every time it is shown (or reset it). Resetting it caused some system-wide system menu items to be voted off the island (e.g. nView desktop manager, and some other third party addins). Resetting also caused some of the NC overpainting issues to be worse. This simplifies things a bit by creating the menu at frame creation time, then when the menu is run doing enabling only. Review URL: http://codereview.chromium.org/7497 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3569 0039d316-1c4b-4281-b951-d872f2087c98
* Remove throttling code from the Browser process and implement throttling in ↵erg@google.com2008-10-177-9/+74
| | | | | | | | | | | | | the Renderer. The previous way of doing throttling was just calling CloseContents() on a window to reject it. But since the Browser is notified about a window opening asynchronously, by the time the CloseContents() sends a message back to the Renderer, a bunch more windows have been opened, leading to memory exhaustion. Instead, make all RenderViews created from a parent RenderView share a counter and start refusing to create RenderViews if too many RV have been created. Every RenderView (except for the first one) is assumed to be an unrequested popup, until notified by the Browser process by either a ViewMsg_DisassociateFromPopupCount message (this RenderView is a new top level page) or a ViewMsg_DisassociatePopup message (this RenderView is a requested popup and therefore shouldn't count against the count.) BUG=3382, 2632 Review URL: http://codereview.chromium.org/7388 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3568 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem where "text/xml" responses get buffered past 512 bytes, causing ↵ericroman@google.com2008-10-171-0/+1
| | | | | | | | | | the response to be truncated. BUG=3521 Review URL: http://codereview.chromium.org/7610 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3567 0039d316-1c4b-4281-b951-d872f2087c98
* Make ChromeThreadTest and TextDatabaseTest inherit from PlatformTest formark@chromium.org2008-10-172-3/+8
| | | | | | | autorelease pool management on the Mac. Review URL: http://codereview.chromium.org/7640 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3563 0039d316-1c4b-4281-b951-d872f2087c98
* more bustage fixesben@chromium.org2008-10-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3556 0039d316-1c4b-4281-b951-d872f2087c98