summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Only have middle click lower the window if we hit the titlebar ortc@google.com2009-08-101-1/+3
| | | | | | | | | | | | window edge. Middle clicking a link on the page shouldn't do this. BUG=15430 Review URL: http://codereview.chromium.org/164257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22924 0039d316-1c4b-4281-b951-d872f2087c98
* Changes SessionService to make sure a Pickle is deleted before thesky@chromium.org2009-08-101-5/+10
| | | | | | | | | | | | | | memory the pickle was created from is deleted. I don't think the current code actually causes a problem as Pickle's destructor won't attempt to delete the memory in this case, but I'm adding this to make it clear the Pickle should be deleted and prevent any future problems. BUG=none TEST=none Review URL: http://codereview.chromium.org/165241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22921 0039d316-1c4b-4281-b951-d872f2087c98
* Rework visited link updating mechanism to be more robust.dglazkov@chromium.org2009-08-103-24/+69
| | | | | | | | | | | | | | | | | | This is a follow-up to http://src.chromium.org/viewvc/chrome?view=rev&revision=22540, which eliminated one crash, but still left behind another, this time due to racing between history backend and WebView creation. The solution is to make sure no visited-link-related messages are sent to the rendering process until we know for sure it is created. BUG=17555 TEST=VisitedLinkeRelayTest.WebViewReadiness R=darin Review URL: http://codereview.chromium.org/165210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22917 0039d316-1c4b-4281-b951-d872f2087c98
* A blind fix for Issue 18837 (and a build fix for VS2008)hbono@chromium.org2009-08-101-7/+10
| | | | | | | | | | | | | To read this crash dump, this issue is caused by my mistake that this jumplist.cc calls "icon_urls_.front()" for an empty list. This change added some checks that verifies a std::list has one or more items. This change also fixes linker errors because of conflicted symbols: CLSID_DestinationList and CLSID_EnumerableObjectCollection, which is caused by my mistake that I forgot removing "EXTERN_C" keywords when I moved them into an anonymous namespace. This change removes the "EXTERN_C" keywords for VS2008. BUG=18837 "Crash - JumpList::OnFavIconDataAvailable(int,bool,scoped_refptr<RefCountedVector<unsigned char> >,bool,GURL)" TEST=Show JumpList on Windows 7. TEST=Build Chromium with VS2008. Review URL: http://codereview.chromium.org/159853 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22907 0039d316-1c4b-4281-b951-d872f2087c98
* Renaming the class ShelfItemDialog to URLPicker, and ShelfItemDialogDelegate ↵thakis@chromium.org2009-08-106-451/+454
| | | | | | | | | | | to URLPickerDelegate. BUG=None TEST=None Review URL: http://codereview.chromium.org/164149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22895 0039d316-1c4b-4281-b951-d872f2087c98
* Modified the browser controller so that it can revert the location bar when ↵yusukes@google.com2009-08-101-0/+17
| | | | | | | | | | | | | | | | a user pressed RELOAD, FORWARD, or BACK buttons. Note that this change does not revert the bar when Command+r is pressed. That's intentional. Please see the comment #7 by pkasting in http://crbug.com/15464 . Windows change: http://codereview.chromium.org/155908 Linux change: http://codereview.chromium.org/164137 BUG=18710 TEST=The same as http://codereview.chromium.org/155908 (except the F5 stuff since Chromium Mac seems not to support F5 reload?) Review URL: http://codereview.chromium.org/164145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22894 0039d316-1c4b-4281-b951-d872f2087c98
* add "remove" to download item context menu on macthakis@chromium.org2009-08-102-0/+8
| | | | | | | | | BUG=60 TEST=Download something, open context menu, click "remove" -- item should be removed from shelf. It leaves a hole behind right now (bug 17831), will fix that later. Review URL: http://codereview.chromium.org/160444 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22893 0039d316-1c4b-4281-b951-d872f2087c98
* vector.end() is out of range, need to erase (end() - 1)jnd@chromium.org2009-08-091-24/+15
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22886 0039d316-1c4b-4281-b951-d872f2087c98
* On GTK, middle-click on the title bar (and the window frame in general) willevan@chromium.org2009-08-091-2/+5
| | | | | | | | | | | | lower the window. This is Chromium's custom titlebar, not the one provided by the window manager. BUG=15430 Review URL: http://codereview.chromium.org/165123 Patch from Nigel Tao <nigeltao@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22885 0039d316-1c4b-4281-b951-d872f2087c98
* When importing bookmarks from Firefox, filter out the default bookmarks.evan@chromium.org2009-08-091-6/+3
| | | | | | | | | | | The existing code attempted to do this but it had a bug. BUG=18530 Review URL: http://codereview.chromium.org/165094 Patch from Doug Muir <dmuir@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22884 0039d316-1c4b-4281-b951-d872f2087c98
* Completely disable DOM Storage UI test until ↵jorlow@chromium.org2009-08-081-0/+6
| | | | | | | | | | | | https://bugs.webkit.org/show_bug.cgi?id=28094 is in. Until then, this will be flaky and crash the browser. TBR=jam BUG=none TEST=none Review URL: http://codereview.chromium.org/165211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22870 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the ui test based layout tests for DOM Storage.jorlow@chromium.org2009-08-081-8/+3
| | | | | | | | | | TBR=jam TEST=none BUG=none Review URL: http://codereview.chromium.org/164227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22868 0039d316-1c4b-4281-b951-d872f2087c98
* Committing for Siggi based on review:mad@google.com2009-08-086-24/+82
| | | | | | | | http://codereview.chromium.org/165134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22858 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use stock icons for bookmark folder and default favicon.estade@chromium.org2009-08-087-31/+69
| | | | | | | | | | | | In the main window, in the default theme, we still use the chrome icons. There are still several more places that need updating: the tab strip, the task manager, etc. I will deal with that later. BUG=13320 Review URL: http://codereview.chromium.org/165194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22855 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bookmark bar text not being correct in subsequent Windows. I believe ↵glen@chromium.org2009-08-081-5/+12
| | | | | | | | | | | this bug was masked by how long bookmarks take to create in the primary window (as the bookmark system is loaded late) BUG=18550 TEST=Install a theme with custom colors for bookmark bar text, then open a new window and verify that the bookmark bar text is themed correctly. Review URL: http://codereview.chromium.org/165172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22840 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Theme: Use Glen's new non-bordererg@google.com2009-08-084-33/+55
| | | | | | | | | | | | Imports Glen's new icons, and creates centered versions of all of them. Then use these icons in the GTK theme interface. Also selects the button tinting color to be a lighter color on some very dark backgrounds. Review URL: http://codereview.chromium.org/164202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22839 0039d316-1c4b-4281-b951-d872f2087c98
* Revert accidental change that snuck into my last patch.estade@chromium.org2009-08-071-1/+2
| | | | | | | | TBR=senorblanco Review URL: http://codereview.chromium.org/164204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22824 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Make the bookmark bar folder menus dismiss properly.estade@chromium.org2009-08-071-2/+37
| | | | | | | | | | | - They will not dismiss when you show and then hide a context menu (unless that context menu initiates certain actions such as "Edit"). - They will dismiss when you click away from them. BUG=18523 Review URL: http://codereview.chromium.org/164183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22820 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the message which appears when the user is asked to re-login when the ↵idana@chromium.org2009-08-073-11/+14
| | | | | | | | login credentials expire. Review URL: http://codereview.chromium.org/164161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22817 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for an "update in progress" DCHECK.paul@chromium.org2009-08-072-1/+32
| | | | | | | | | | | | | | | | | | | | A DCHECK in SafeBrowsingService::UpdateStarted can potentially be triggered if there is an error opening the database for reading, or if there is no response from the server for a update request. Both of these cases can cause our 'update_in_progress_' flag to not be reset properly before the next update. This CL adds: - a timeout for update responses - better handling for database errors that properly resets the update state. BUG=12835 (http://crbug.com/12835) TEST=None. Review URL: http://codereview.chromium.org/165008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22814 0039d316-1c4b-4281-b951-d872f2087c98
* Set up a interposing library for Carbon calls made by plugins.stuartmorgan@google.com2009-08-072-1/+125
| | | | | | | | | | | | | This gives us a library that's inserted into plugin process via DYLD_INSERT_LIBRARIES to intercept Carbon calls, and moves the window/process activation handling into that library (based on Carbon window activation/deactivation calls, rather than polling the front window). Over time we'll interpose more, but this gives us the foundation. This fixes both the "window loses focus when loading a page with plugins" and "can't click on YouTube controls" bugs. BUG=18203,18553 TEST=Clicking on Flash plugins should work much more reliably, opening a page with a plugin shouldn't cause the window to lose focus. Review URL: http://codereview.chromium.org/164100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22799 0039d316-1c4b-4281-b951-d872f2087c98
* Check the bookmark bar state when updating the title of the page.tc@google.com2009-08-071-0/+6
| | | | | | | | | | | Windows does this too, it's just not an explicit call. BUG=18602 Review URL: http://codereview.chromium.org/165158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22792 0039d316-1c4b-4281-b951-d872f2087c98
* Use the inactive window overlay when the window is inactive.tc@google.com2009-08-071-1/+2
| | | | | | | | | | TEST=Install the Zen Spring theme and activate a different window. The tree overlay should be lighter. Review URL: http://codereview.chromium.org/164186 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22791 0039d316-1c4b-4281-b951-d872f2087c98
* The UrlRequestAutomationJob::GetResponseInfo function needs to return a ↵ananta@chromium.org2009-08-071-1/+16
| | | | | | | | | | | | | | | | valid X509Certificate in the HttpResponseInfo structure passed in if the current URL scheme is https Not returning this certificate causes a number of DCHECKS to fire in the network stack implementation and in the renderer process, which eventually causes the navigation to fail. Fix is to return a dummy X509Certificate on the same lines as Gears. This fixes bug http://b/issue?id=2039699 Bug=2039699 Review URL: http://codereview.chromium.org/164110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22784 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that popups windows are not themed.mirandac@chromium.org2009-08-072-14/+48
| | | | | | | | | BUG= http://crbug.com/18093 TEST= While running Chrome with a theme installed, and force a popup. Note that the popup window is not themed. Review URL: http://codereview.chromium.org/159871 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22783 0039d316-1c4b-4281-b951-d872f2087c98
* Mark a layout tests as crash/pass; disable two crashing UI tests.senorblanco@chromium.org2009-08-071-2/+4
| | | | | | | | | BUG=http://crbug.com/18784,http://crbug.com/18786 TEST=less redness == more goodness TBR=tim git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22768 0039d316-1c4b-4281-b951-d872f2087c98
* Move some Mac l10n helpers out into app/l10n so they are closer to the ↵thomasvl@chromium.org2009-08-074-82/+6
| | | | | | | | | | | | | generic ones. Complete the apis points so the ones folks might need are all there already. Switch the code using the old calls over to the new helpers. TEST=no l10n stuff broke BUG=none Review URL: http://codereview.chromium.org/165132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22753 0039d316-1c4b-4281-b951-d872f2087c98
* In app windows, fallback to the product icon if there's no site favicon.tc@google.com2009-08-071-2/+6
| | | | | | | | | | TEST=Open the web inspector. When it finishes loading, it should show the chromium icon instead of the last frame of the throbber. Review URL: http://codereview.chromium.org/164159 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22747 0039d316-1c4b-4281-b951-d872f2087c98
* Add module-level permissions to extensions.mpcomplete@chromium.org2009-08-074-3/+19
| | | | | | | | | | | | | | This first pass is fairly simple. If a permission is not specified in the manifest, the corresponding module will not be exposed to script. For example, without specifying the "tabs" permission, chrome.tabs and chrome.windows will not be available. BUG=12140 TEST=no Review URL: http://codereview.chromium.org/164039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22745 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some issues with bookmark bar folder menu.estade@chromium.org2009-08-071-11/+32
| | | | | | | | | | | | Without this patch, you have to click repeatedly on a folder to get the context menu to pop up, because the first few clicks dismiss whatever submenus you may have open. This patch fixes that. There is another problem present with and without this patch where a bookmark bar folder menu that has shown a context menu will not regain the application/X grabs. This makes it possible to use the rest of the browser while the menu is showing, and clicking away from the menu won't dismiss the menu. In the interests of keeping this patch easy to review I will look into that issue separately. BUG=18275 Review URL: http://codereview.chromium.org/165138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22743 0039d316-1c4b-4281-b951-d872f2087c98
* Move the sync options group from "user Data" tab to "Personal Stuff" tab and ↵munjal@chromium.org2009-08-077-291/+191
| | | | | | | | | | | remove the "User Data" tab. BUG=none TEST=none Review URL: http://codereview.chromium.org/165105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22742 0039d316-1c4b-4281-b951-d872f2087c98
* Implement back/forward toolbar menus on Mac (bug 13203).avi@chromium.org2009-08-0711-5/+511
| | | | | | | | | | | | | | | | | | | | Note: The drop-down menu is actually a drag-down (activating on click-hold or on drag), working much like Safari's (and other Apple apps, such as Dictionary). This can be changed to a pop-down if that's what's desired. TODO: Show keyboard shortcut for "Show Full History". Patch by viettrungluu. BUG=http://crbug.com/13203 TEST=Navigate around, check out and use the menus; do so in multiple tabs and windows. Review URL: http://codereview.chromium.org/160496 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22740 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we don't maximize on titlebar double click in KWin.tc@google.com2009-08-072-4/+39
| | | | | | | | | | | | | | | | | | | GTK+ sends the following events on double click: GDK_BUTTON_PRESS GDK_BUTTON_RELEASE GDK_BUTTON_PRESS GDK_2BUTTON_PRESS GDK_BUTTON_RELEASE If we start a gtk_window_begin_move_drag on the second GDK_BUTTON_PRESS, the call to gtk_window_maximize fails. To work around this, we keep track of the last click and if it's going to be a double click, we don't call gtk_window_begin_move_drag. BUG=18401 Review URL: http://codereview.chromium.org/165102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22736 0039d316-1c4b-4281-b951-d872f2087c98
* Support cntrl-tab to switch tabs on OS X.jeremy@chromium.org2009-08-071-0/+2
| | | | | | | | | BUG=13299 TEST=Cntrl-Tab should switch to the next tab, cntrl-shift-tab should switch to the previous tab. Review URL: http://codereview.chromium.org/164133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22731 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts the revert of 22517.rohitrao@chromium.org2009-08-0722-429/+487
| | | | | | | | | | | | | | | | | | | | Rewrites the Mac view resizing logic to have the BrowserWindowController directly resize and relayout its children views. Now when a view needs to be resized, it asks its resize delegate (typically its controller's parent) to perform the resize. BUG=http://crbug.com/17619 TEST=Make sure that views are laid out correctly, even when they change size. Open and close the bookmark bar. Trigger an infobar and then close it. Trigger the download shelf and then close it. Trigger a download shelf with the infobar open, or with the bookmark bar open. Switch to and from fullscreen with various bars open. Resize the browser window with various bars open. Start the browser with and without the bookmark bar open. Try all of the above in a popup window. Review URL: http://codereview.chromium.org/165014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22721 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk Cookie Manager polish.mattm@chromium.org2009-08-071-1/+7
| | | | | | | | | | Make dialog wider, set first column width to fixed (but resizable), set initial sort order. BUG=17919 Review URL: http://codereview.chromium.org/164125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22713 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash on fullscreening of popup.jrg@chromium.org2009-08-073-0/+22
| | | | | | | | | | | | | BUG=http://crbug.com/18551 TEST=Create a pop-up window. Fullscreen it (Cmd-Shift-F). Go back (Cmd-Shift-F again). Repeat a few times across different launches of Chromium. Review URL: http://codereview.chromium.org/164024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22712 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few bugs with the theme infobar:aa@chromium.org2009-08-075-16/+77
| | | | | | | | | | | | | | * Don't animate the infobar closing and opening when switching between themes. * Don't show multiple infobars when intalling themes in rapid succession. BUG=18213 Review URL: http://codereview.chromium.org/165029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22711 0039d316-1c4b-4281-b951-d872f2087c98
* Porting POINT to gfx::Point.thestig@chromium.org2009-08-072-8/+12
| | | | | | | | | | | Patch from thiago.farnia at gmail.com. Original review url: http://codereview.chromium.org/155888 BUG=none TEST=none Review URL: http://codereview.chromium.org/164121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22710 0039d316-1c4b-4281-b951-d872f2087c98
* Restore right click on bookmark bar.estade@chromium.org2009-08-071-1/+1
| | | | | | | | it stopped working after r22660 Review URL: http://codereview.chromium.org/165108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22708 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Add a menu item that allows the user to restore all blacklistedarv@google.com2009-08-073-22/+51
| | | | | | | | | | | | | | thumbnails BUG=15247 TEST=Blacklist (remove) a few thumbnails (hit the x on the thumbnail toolbar). Then go to the options menu and "Restore all removed thumbnails". The removed thumbnails should be back. Review URL: http://codereview.chromium.org/165107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22704 0039d316-1c4b-4281-b951-d872f2087c98
* Set the dangerous download text to the bookmark bar texttc@google.com2009-08-071-0/+3
| | | | | | | | | | color since we already set the shelf to the toolbar background color. Review URL: http://codereview.chromium.org/164116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22703 0039d316-1c4b-4281-b951-d872f2087c98
* Changelist for mattm readability review.mattm@chromium.org2009-08-073-157/+187
| | | | | | Review URL: http://codereview.chromium.org/160037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22697 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Change the way to calculate the position of the tab title text.estade@chromium.org2009-08-061-4/+8
| | | | | | | | | | On my machine this doesn't actually change the position, but at least it gets rid of the magic -1. BUG=18555 Review URL: http://codereview.chromium.org/165024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22696 0039d316-1c4b-4281-b951-d872f2087c98
* Add a temporary extension error message box on linux.tc@google.com2009-08-061-2/+4
| | | | | | | | | The NOTREACHED() crashed my debug build. Review URL: http://codereview.chromium.org/164088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22695 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding r22644, "GTK: Rounded corner on status bubble."erg@google.com2009-08-062-28/+128
| | | | | | | | | | | | | | The previous patch made ui_tests red because we don't always have a GdkWindow when a widget's size-allocate signal is called. Move all responsibility into the expose-event handler. http://crbug.com/18309 Original Review URL: http://codereview.chromium.org/164010 Review URL: http://codereview.chromium.org/164104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22692 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Remove tips and downloads and introduce a recently closed bar instead.arv@google.com2009-08-065-330/+160
| | | | | | | | | | | | | | Make the list mode only show one column and make the items look like links. BUG=None TEST= On the new tab page try opening and closing tabs and windows. The closed tabs and windows should appear in the recently closed bar at the bottom. Review URL: http://codereview.chromium.org/165095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22691 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up copy pasta hotkeys in gtk bookmark manager.estade@chromium.org2009-08-062-4/+32
| | | | | | | | | | | Also change the display hotkey for tab reload from f5 (windowsy) to ctrl+r (linuxy). BUG=none TEST=use the new hotkeys Review URL: http://codereview.chromium.org/164097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22685 0039d316-1c4b-4281-b951-d872f2087c98
* Don't pack an empty label into bookmarks with empty titles.estade@chromium.org2009-08-061-9/+16
| | | | | | | | BUG=18348 Review URL: http://codereview.chromium.org/164101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22684 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Pass font settings through to interstitial renderers.derat@chromium.org2009-08-063-46/+15
| | | | | | | | | BUG=18483 TESTED=restarted and visited a page with a broken SSL cert a few times while changing font settings via gnome-appearance-properties Review URL: http://codereview.chromium.org/164094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22679 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-10 21:46:26 +0000