summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Adding a SIGTERM handler for OS_POSIX builds. This is needed so that Chrome ↵cmasone@google.com2009-10-072-3/+74
| | | | | | | | | | | | | can shut down gracefully when many posix-based system halt or reboot while Chrome is open. SIGTERM may come in on any thread, so the handler creates a Task object that wraps up a call to BrowserList::CloseAllBrowsers(true) and Posts it to the message loop of the UI thread. Thus, we both get out of the signal handler quickly and can deal with the signal on any thread. BUG=23551 TEST=covered by BrowserTest.PosixSessionEnd Review URL: http://codereview.chromium.org/255036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28225 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Show the page info window after clicking the security icon in the URL barrsesek@chromium.org2009-10-079-15/+99
| | | | | | | | | BUG=22922 TEST=Go to https://twitter.com, click the lock icon, see page info window. Review URL: http://codereview.chromium.org/222020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28221 0039d316-1c4b-4281-b951-d872f2087c98
* Copy the relevant parts of ICU to a new file base/third_party/icu/icu_utf.*brettw@chromium.org2009-10-071-1/+17
| | | | | | | | | | | | | | so we can do basic UTF8/16/32 conversions without linking all of ICU. Change callers who used to call SysUTF8ToWide/SysWideToUTF8 in base to using these new functions. I will remove the Sys versions of these functions in a later patch. TEST=none BUG=none Review URL: http://codereview.chromium.org/243102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28219 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix focus issues in bookmark bubble.derat@chromium.org2009-10-074-27/+70
| | | | | | | | | | | | | | | | I wasn't aware of it in my initial change that made us use override-redirect windows for InfoBubbleGtk, but clicking on the bookmark bubble's folder combobox steals InfoBubbleGtk's pointer and keyboard grabs, resulting in the other widgets in the window behaving as if they're inactive after the combobox's popup is closed. This somewhat hacky change makes us reinstall the bubble's grabs after the popup closes. TEST=clicked in and out of bookmark bubble's combobox and checked that text entry still behaves normally Review URL: http://codereview.chromium.org/260019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28218 0039d316-1c4b-4281-b951-d872f2087c98
* Reap renderer processes following fast termination.estade@chromium.org2009-10-071-1/+14
| | | | | | | | | | | I'm still seeing some defunct processes, but not one for every tab, and they don't appear to be former renderer processes, so that's probably a separate bug. BUG=23778 TEST=after closing a tab ps shows that the renderer is gone (not just defunct) Review URL: http://codereview.chromium.org/242155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28217 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Draw bottom-aligned ntp themes on floating bookmark bar.estade@chromium.org2009-10-073-35/+136
| | | | | | | | | | | | | This is a simplified version of the windows code. There will be a follow-up patch to switch windows over to using this as well. I ran into some trouble calculating the correct size of the tab contents. Punting on that for now, filed http://crbug.com/23907 BUG=22836 TEST=Tested on klassen, candies, karim rashid, tiesto, ratchet and clank, and jeff coons themes. Review URL: http://codereview.chromium.org/255086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28215 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix minor slide animation bugs.estade@chromium.org2009-10-071-6/+6
| | | | | | | | | | | Following r27934, we might hit the code path for initial positioning *after* the AnimationProgressed positioning, causing the child widget not to show. BUG=23902 TEST=when you switch away from a tab that has an infobar, then switch back, you can see the infobar. Review URL: http://codereview.chromium.org/258038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28214 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: make sure to delete any remaining dialogs when the SelectFileDialogImpl ↵estade@chromium.org2009-10-071-0/+11
| | | | | | | | | | | | | | | | | | | | | | object goes out of scope. The control flow was as follows: 1. user initiates a save page command 2. user initiates a second save page command 3. tab contents creates a SavePackage, shows dialog 4. tab contents gets second OnSavePage, deletes old SavePackage, which deletes its SelectFileDialogImpl 5. At this point two dialogs are visible. 6. User dismisses second dialog. 7. User dismisses first dialog, and calls us back with pointer to freed SelectFileDialogImpl. 8. Bad stuff. BUG=23817 TEST=I put a sleep in Browser::SavePage, then hit ctrl+s twice quickly. Only one dialog appeared. Review URL: http://codereview.chromium.org/243117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28213 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add startup tests that log start script, domcontentloaded, and onload."mattm@chromium.org2009-10-076-99/+5
| | | | | | | | | | | | which failed on XP Perf (single). This reverts commit r28199. TBR=tony Review URL: http://codereview.chromium.org/265002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28209 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 28198 - Remove pthreads from syncable.chron@google.com2009-10-072-10/+34
| | | | | | | | | | | | | | | Remove unused kernel scoped unlock. BUG=19895 TEST=Existing unit tests Review URL: http://codereview.chromium.org/246097 TBR=chron@chromium.org Review URL: http://codereview.chromium.org/265001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28208 0039d316-1c4b-4281-b951-d872f2087c98
* Add NULL-checks to render_view_host->view() to fix startup test crash.mpcomplete@chromium.org2009-10-073-3/+3
| | | | | | | | TBR=erikkay Review URL: http://codereview.chromium.org/258040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28202 0039d316-1c4b-4281-b951-d872f2087c98
* Add startup tests that log start script, domcontentloaded, and onload.tony@chromium.org2009-10-076-5/+99
| | | | | | | | | | | | | | | | TabContents sends a notification which is picked up by the browser automation controller which keeps a map of events and times. Add an automation IPC so that tests can get these values from the browser automation controller. Finally, add a feature startup test to collect these values. This is just to get some consistent timings from the buildbot. BUG=23120 Review URL: http://codereview.chromium.org/246105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28199 0039d316-1c4b-4281-b951-d872f2087c98
* Remove pthreads from syncable.chron@chromium.org2009-10-072-34/+10
| | | | | | | | | | | Remove unused kernel scoped unlock. BUG=19895 TEST=Existing unit tests Review URL: http://codereview.chromium.org/246097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28198 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tips in OS X to respect system language settings instead of locale.mirandac@chromium.org2009-10-073-8/+26
| | | | | | | | | | | | BUG= http://crbug.com/22727 TEST= Set preferred language to a different setting from the locale in the OS X system settings. Make sure that the language of the tips matches the language setting (which should be the same as that of the Chrome UI). If tips are not available in the Chrome UI language, no tips should be shown. Review URL: http://codereview.chromium.org/258037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28193 0039d316-1c4b-4281-b951-d872f2087c98
* Make browser actions appear to the left of the bookmark menu.finnur@chromium.org2009-10-061-4/+4
| | | | | | | | | | | Also fixed min size of the browser to take into account the browser actions. BUG-23924 TESTS=Open Chrome with --bookmark-menu and make sure browser actions you install appear to the left. Also, resize the browser horizontally and make sure it always shows all the controls in the chrome (from Back to App menu). Review URL: http://codereview.chromium.org/246102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28191 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for BrowserActions UNLOAD not changing Omnibox length. ↵sidchat@chromium.org2009-10-061-1/+4
| | | | | | | | | | | BrowserActionsContainer is the child view of ToolBarView. When BrowserActionsContainer gets notification for LOAD/UNLOAD, it needs to re-layout ToolBarView, its parent. BUG=23381 TEST=none Review URL: http://codereview.chromium.org/246107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28190 0039d316-1c4b-4281-b951-d872f2087c98
* Add an BubbleBorder to BrowserAction popups and fix positioning of theerikkay@chromium.org2009-10-067-29/+99
| | | | | | | | | | | popup. BUG=23833,23835 TEST=none Review URL: http://codereview.chromium.org/259065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28187 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression with setting the toolstrip background.mpcomplete@chromium.org2009-10-067-9/+58
| | | | | | | | | BUG=23458 TEST=Load an extension with a toolstrip. The toolstrip's background should match the shelf's background for your theme. Review URL: http://codereview.chromium.org/243114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28177 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r28050 and put the paint observer timeout back to 2 sec.tony@chromium.org2009-10-061-1/+1
| | | | | | | | | The new tab times didn't change on linux/mac so that's probably not the problem. This will speed up the new tab tests. Review URL: http://codereview.chromium.org/256083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28175 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when a plugin file picker window is dismissed. This is aamanda@chromium.org2009-10-062-4/+13
| | | | | | | | | | | spot fix--a comprehensive fix will require http://code.google.com/p/chromium/issues/detail?id=23571 BUG=23774 TEST=upload a file via Flash (example: Gmail, YouTube). The browser should not crash after you click "OK" to dismiss the file picker. Review URL: http://codereview.chromium.org/242161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28158 0039d316-1c4b-4281-b951-d872f2087c98
* External protocol dialog support for the Mac.avi@chromium.org2009-10-064-4/+193
| | | | | | | | | BUG=http://crbug.com/15546 TEST=try to use an external protocol; it should put up a dialog Review URL: http://codereview.chromium.org/256065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28145 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Check the return value of CryptDestroyHash and CryptReleaseContext.jhawkins@chromium.org2009-10-061-4/+10
| | | | | | | | | CID=6309 BUG=none TEST=none Review URL: http://codereview.chromium.org/243103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28144 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Assert that socket() returned a successful value.jhawkins@chromium.org2009-10-061-0/+1
| | | | | | | | | CID=6384 BUG=none TEST=none Review URL: http://codereview.chromium.org/260010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28143 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: disable TestProfilerTab test due to flakiness.mnaganov@chromium.org2009-10-061-1/+3
| | | | | | | | | | | To fix it, a change needs to be made in V8. BUG=23768 TEST=none Review URL: http://codereview.chromium.org/256082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28140 0039d316-1c4b-4281-b951-d872f2087c98
* Make EditSearchEngineCocoaController adhere to NSWindowDelegatemark@chromium.org2009-10-061-1/+3
| | | | | | Review URL: http://codereview.chromium.org/242157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28139 0039d316-1c4b-4281-b951-d872f2087c98
* Implement browserAction.setIcon(ImageData) for extensions.mpcomplete@chromium.org2009-10-062-4/+21
| | | | | | | | | BUG=23269 TEST=load the test_browser_action sample extension, and click the browser action. Watch it dynamically update. Review URL: http://codereview.chromium.org/242150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28136 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup some rotten references to old command line switches.nick@chromium.org2009-10-062-4/+2
| | | | | | Review URL: http://codereview.chromium.org/243105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28131 0039d316-1c4b-4281-b951-d872f2087c98
* Modify extension request IPC messages to pass a ListValue instead of a string.mpcomplete@chromium.org2009-10-0617-46/+47
| | | | | | | | | | | | This allows us to pass binary values through extension requests. I use this in my next CL to pass SkBitmaps. BUG=23269 TEST=no Review URL: http://codereview.chromium.org/251093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28130 0039d316-1c4b-4281-b951-d872f2087c98
* DOMView: avoid double-detaching.nick@chromium.org2009-10-061-1/+1
| | | | | | | | | | | | | I'm seeing ~DOMView happen after NativeViewHost::Detach has already been done as part of WM_DESTROY. BUG=20339 TEST=cancel the sync login dialog and create app shortcuts dialogs. Review URL: http://codereview.chromium.org/258028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28129 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show popup browser actions in the wrench menu.erikkay@chromium.org2009-10-066-19/+31
| | | | | | | | | BUG=23834 TEST=none Review URL: http://codereview.chromium.org/257048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28119 0039d316-1c4b-4281-b951-d872f2087c98
* (please review thoroughly since this touches many moving parts).jeremy@chromium.org2009-10-0620-478/+673
| | | | | | | | | | | | | | | | | | | | | | | Refactor ImporterHost as preparation for OOPprofile import. ImporterHost currently requires substantial infrastructure in order to run which we don't need or can't have in a utility process. This change splits ImporterHost into a couple of subclasses so that the profile import process can remain light weight and doesn't need to initialize Profile, etc. ImporterList: Manages the list of importers, this class will allow the utility process to locate and instantiate an importer without initializing the world. ImprterBridge/InProcessImporterBridge: Provides an abstract interface for the importers to interact with the rest of the App. The idea is to stick the IPC boundary in using this interface. There may still be some rough spots in the separation (e.g. Firefox locking and surrounding UI) but I'll sort those out in a followup CL that makes the OOP stuff work. For now I'm trying to keep these CLs as small as I can. BUG=14458 TEST=Profile import should continue to work on Windows/Linux & Mac. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27996 Review URL: http://codereview.chromium.org/242091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28117 0039d316-1c4b-4281-b951-d872f2087c98
* Turns out a cleanup change I made a while ago was wrong. This could result ↵pkasting@chromium.org2009-10-061-1/+5
| | | | | | | | | | in odd text colors in the Omnibox when typing. BUG=none TEST=Visit m/, then type a letter into the omnibox and make sure it's black. Review URL: http://codereview.chromium.org/259054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28116 0039d316-1c4b-4281-b951-d872f2087c98
* Resubmit http://codereview.chromium.org/243096 with gcc compile error fixed.erikkay@chromium.org2009-10-063-3/+33
| | | | | | | | | BUG=23832 TBR=mpcomplete Review URL: http://codereview.chromium.org/257056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28115 0039d316-1c4b-4281-b951-d872f2087c98
* Change the Windows build to statically link the sync library.nick@chromium.org2009-10-062-34/+7
| | | | | | | | | | | Update installer files so that they don't reference syncapi.dll. Add a reference to iphlpapi, and make it and pthreads lazy-loaded. BUG=23609 TEST=interactive testing of two sync clients with notifications. Review URL: http://codereview.chromium.org/242118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28112 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the url of the main menu.sky@chromium.org2009-10-061-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/255088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28111 0039d316-1c4b-4281-b951-d872f2087c98
* Prevents a duplicate beforeunload dialog after window.close().creis@google.com2009-10-062-1/+26
| | | | | | | | | | | | | If the renderer tells the browser to close a window, we no longer run the unload events, because the renderer already has. BUG=11647 TEST=BrowserTest.SingleBeforeUnloadAfterWindowClose Review URL: http://codereview.chromium.org/246080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28110 0039d316-1c4b-4281-b951-d872f2087c98
* Removed omnibox images from the bundle.thomasvl@chromium.org2009-10-061-5/+20
| | | | | | | | | | Update the code to pull the omnibox images from the pak files instead. TEST=Omnibox still has all the right images next to the things it lists BUG=20230 Review URL: http://codereview.chromium.org/246101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28104 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: bring devtools tests back.pfeldman@chromium.org2009-10-061-17/+17
| | | | | | Review URL: http://codereview.chromium.org/243107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28099 0039d316-1c4b-4281-b951-d872f2087c98
* Revert.jorlow@chromium.org2009-10-061-2/+9
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28098 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable the DOM Storage ui tests that worked orginally.jorlow@chromium.org2009-10-061-9/+2
| | | | | | | | | | | Next step: enable ones that should work, but (for some reason) don't. TEST=It runs. BUG=none Review URL: http://codereview.chromium.org/256070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28097 0039d316-1c4b-4281-b951-d872f2087c98
* Generate IDs for --load-extension by hashing the path insteadaa@chromium.org2009-10-067-43/+32
| | | | | | | | | | | | | of incrementing a static counter. BUG=21281 TEST=Load an unpacked extension from chrome://extensions/ that does not have an ID in its manifest. The resulting ID should be random-looking, not something like "aaaaaa". Review URL: http://codereview.chromium.org/256049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28095 0039d316-1c4b-4281-b951-d872f2087c98
* Implement --enable-web-sockets flag.ukai@chromium.org2009-10-062-0/+3
| | | | | | | | | BUG=12497 TEST=none Review URL: http://codereview.chromium.org/255075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28093 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly activeIgnoringOtherApps from IDC_NEW{,_INCOGNITO}_WINDOWsgk@google.com2009-10-062-3/+11
| | | | | | | | | | | in app_controller_mac.mm, under the assumption we're either already the foreground app or should become the foreground mac (when created from the dock menu). BUG=22595 TEST="New Window" or "New Incognito Window" from dock menu with other app in foreground Review URL: http://codereview.chromium.org/256054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28091 0039d316-1c4b-4281-b951-d872f2087c98
* Initial CL for fixing some of the proxy auth issues.chron@chromium.org2009-10-066-32/+87
| | | | | | | | | | | | | | Auth_cache is contained in the http session. We need to share the http session with the parent profile request context in order to retain http authentication. Weirdly enough, Profile::GetDefaultRequestContext() is not the same as profile_->GetRequestContext(), It does NOT yet pop up a dialog if the user hasn't done so already. BUG=19581 TEST=Included. Review URL: http://codereview.chromium.org/241001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28086 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for specifying the BrowserFlags DWORD value when we register ↵ananta@chromium.org2009-10-062-0/+29
| | | | | | | | | | | | | | | | | | | | | | the ChromeFrame Active Document server. This allows the document server to receive a number of menu events like Find, View->Text Size, etc. Thanks to Stoyan for helping me debug this :) Clicking on Edit->Find in the menu in IE with this causes IEFrame to call our Active document's Exec implementation with the IDM_FIND command. The handling here is to invoke our default Find handling. Added support for honoring user text size selections. The next thing to be done is to honor the current text size setting while launching Chrome. I also fixed the rgs files to have LF as the terminating character. This fixes Bug http://code.google.com/p/chromium/issues/detail?id=23667 Bug=23667 Review URL: http://codereview.chromium.org/243082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28085 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize message_loop_ in gaia authenticator.timsteele@google.com2009-10-061-1/+2
| | | | | | | | BUG=23906 Review URL: http://codereview.chromium.org/257058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28084 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: check module for NULL before calling GetProcAddress.mattm@chromium.org2009-10-061-1/+3
| | | | | | | | | | CID=5168,5169 TEST=none BUG=none Review URL: http://codereview.chromium.org/257043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28082 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build.erg@google.com2009-10-061-1/+1
| | | | | | | | TBR=nsylvain Review URL: http://codereview.chromium.org/246100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28077 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix crash while dragging a tab alone in a window.viettrungluu@chromium.org2009-10-062-1/+13
| | | | | | | | | | | | | Specifically, the crash could be repro'ed as follows (it also occurred under other circumstances as well): Have a window with one or more tabs in it. Create a new window with a single tab. Drag the tab in the new window, and while dragging right-click (and release). This patch also prevents right-clicks while dragging from stopping the drag. BUG=23591 TEST=See above. Review URL: http://codereview.chromium.org/242139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28075 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Implements the special bookmark bar on NTP.erg@chromium.org2009-10-0623-208/+575
| | | | | | | | | | | | | Based mostly on Ben's patch, but made it compile, work, and descoped moving the bookmark bar around the view heiarchy. XIB modification: The root view is now a BookmarkBarToolbarView instead of an NSView and is [BookmarkBarController view]. BUG=17625 Review URL: http://codereview.chromium.org/246034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28074 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 08:41:55 +0000