summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* GTK: Move chrome/common/gtk_signal.h to app/ so views-gtk can use it.erg@google.com2010-03-1118-18/+18
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/856003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41341 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "drag cancel" semantics.jrg@chromium.org2010-03-111-9/+7
| | | | | | | | | | | | | | BUG=37967 TEST=\ 1) make sure bookmark buttons still work (click to open) 2) make sure basic DnD of bookmark buttons still works 3) In Debug build, drag a bookmark button. ESC to cancel. Then mouse up. Make sure no crash. Review URL: http://codereview.chromium.org/871002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41340 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Improve window look from "completely broken" to "pretty broken" when RI ↵thakis@chromium.org2010-03-111-1/+2
| | | | | | | | | | | | | | | | | is enabled. From http://developer.apple.com/mac/library/DOCUMENTATION/UserExperience/Conceptual/HiDPIOverview/HiDPISupport/HiDPISupport.html: "Because of scaling, the coordinates of the window frame and its top-level view (the frame view) are not always the same. [...] These methods provide the means to transform geometry to and from a base coordinate space that is pixel-aligned with the backing store into which the view is being drawn." Stuff is still pretty broken with this patch (it used to be better), but it's a low-hanging fruit. BUG=19476 TEST=Open QuartzDebug, set scale factor to e.g. 1.5. Reopen Chrome. Tabs should be visible. Review URL: http://codereview.chromium.org/893001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41336 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement translate toolbar. Tested on spiegel.de, www.lemonde.fr and ↵erg@google.com2010-03-1110-22/+568
| | | | | | | | | | | mainichi.jp (from an English profile). BUG=36714,37528 TEST=Open up a page that's not in your current language. You should be presented with a toolbar offering to apply Google Translate to the page. Review URL: http://codereview.chromium.org/830005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41332 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill field parser fixes.dhollowa@chromium.org2010-03-118-30/+500
| | | | | | | | | | | This fixes a number of form field parsing issues. Ecml field name matching. Adds country field parsing. Adds state field parsing. Multi-line address parsing. Fixes issue with empty field names confusing the parser. Fixes issue with phone field parsing. Adds unit tests in form_structure_unittest.cc to verify parsing order issues. Adds new unit tests address_field_unittest.cc that cover parsing of each address component as well as Ecml variants. BUG=37776 TEST=FormStructureTest.Heuristics:AddressFieldTest.*, as well as manual steps described in bug report. Review URL: http://codereview.chromium.org/867003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41331 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41230 - gtk: Notify the TabContents when the browser window has been ↵chase@chromium.org2010-03-111-6/+0
| | | | | | | | | | | moved or resized. This is used to close the AutoFill popup in the renderer. BUG=31865 TEST=none TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/878003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41329 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41316 - gtk: Only notify the TabContents that the browser window has ↵chase@chromium.org2010-03-111-10/+5
| | | | | | | | | | | moved or resized if the window has actually moved or resized. This fixes a ~20ms startup performance regression. BUG=37975 TEST=none TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/868002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41328 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Do not hide the menubar if going fullscreen on a secondary monitor.rohitrao@chromium.org2010-03-112-11/+20
| | | | | | | | BUG=37989 TEST=Go fullscreen on a secondary monitor. Should not hide the menubar. Review URL: http://codereview.chromium.org/872003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41327 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix an infobar crash.rohitrao@chromium.org2010-03-113-6/+21
| | | | | | | | BUG=37797 TEST=See test cases in bug. Review URL: http://codereview.chromium.org/801008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41317 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Only notify the TabContents that the browser window has moved or ↵jhawkins@chromium.org2010-03-111-5/+10
| | | | | | | | | | resized if the window has actually moved or resized. This fixes a ~20ms startup performance regression. BUG=37975 TEST=none Review URL: http://codereview.chromium.org/844004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41316 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in wm_ipc where we were passing ints to XChangeProperty whensky@chromium.org2010-03-111-1/+6
| | | | | | | | | | | we should have been passing longs. BUG=none TEST=none Review URL: http://codereview.chromium.org/879002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41315 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fix crash because of wrong prototype.erg@google.com2010-03-112-2/+4
| | | | | | | | | BUG=37950 TEST=none Review URL: http://codereview.chromium.org/837006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41314 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the first half of gtk/options/* to use the new signal handler macros.estade@chromium.org2010-03-1116-384/+243
| | | | | | | | | BUG=NONE TEST=trybots Review URL: http://codereview.chromium.org/859003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41311 0039d316-1c4b-4281-b951-d872f2087c98
* Move all the PrefObserverBridges into namespaces (like is already done with ↵avi@chromium.org2010-03-114-15/+35
| | | | | | | | | | | ToolbarController's) so we stop violating the ODR and things start working properly. BUG=http://crbug.com/37898 TEST=as in bug Review URL: http://codereview.chromium.org/887002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41306 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: make browser actions container resizable.estade@chromium.org2010-03-118-60/+269
| | | | | | | | | | | | TODO: persist the size of the browser actions container to the profile. TODO: implement the overflow menu. BUG=32101 TEST=manual Review URL: http://codereview.chromium.org/800003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41305 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes navigation issues with interstitial pages.creis@chromium.org2010-03-116-12/+150
| | | | | | | | | | | | | | | | Updates NavigationController so that the back and forward menus can be used while an interstitial page is showing. Also fixes tab cloning while an interstitial page is showing, so that the cloned tab does not have the interstitial navigation entry. BUG=37215 BUG=37894 TEST=SSLUITest.TestHTTPSExpiredCertAndGo{Back,Forward} TEST=NavigationControllerTest.CloneOmitsInterstitials Review URL: http://codereview.chromium.org/861001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41304 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux perf compile:estade@chromium.org2010-03-111-0/+1
| | | | | | | | | | | | fix "may be used uninitialized" error BUG=NONE TEST=buildbot compiles TBR=finnur Review URL: http://codereview.chromium.org/880002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41299 0039d316-1c4b-4281-b951-d872f2087c98
* Pick up a GTM roll and update the apis that changed in this roll.thomasvl@chromium.org2010-03-1111-11/+25
| | | | | | | | BUG=none TEST=everything still works Review URL: http://codereview.chromium.org/793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41295 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RenderViewHostDelegate::FormFieldHistory to Autocomplete.jhawkins@chromium.org2010-03-117-45/+42
| | | | | | | | BUG=33032 TEST=none Review URL: http://codereview.chromium.org/815004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41294 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Update the top section to have same positions and spacing ↵arv@chromium.org2010-03-111-10/+20
| | | | | | | | | | | as downloads and history. BUG=37371,4890 TEST=Open three tabs, History, Downloads and Bookmarks. Ctrl+tab between them and notice how the section icon, input and button all stay in the same position. Review URL: http://codereview.chromium.org/837003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41293 0039d316-1c4b-4281-b951-d872f2087c98
* win: string_util.h -> utf_string_conversions.h fix.jhawkins@google.com2010-03-1123-20/+23
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/830002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
* Allow users to close the find session and activate the current link via ↵estade@chromium.org2010-03-1112-39/+126
| | | | | | | | | | | | | | | | | | ctrl-enter. this only hooks up ctrl-enter on gtk for now, but adding it on windows/mac should be trivial webkit side, which needs to land first, is here: https://bugs.webkit.org/show_bug.cgi?id=35407 This also enables the FindInPageControllerTest tests on linux/gtk. BUG=29500 TEST=FindInPageControllerTest.ActivateLinkNavigatesPage Review URL: http://codereview.chromium.org/660137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41291 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41274 - Unit Tests for OS X Translte infobars.thomasvl@chromium.org2010-03-118-326/+39
| | | | | | | | | | | | | | This has had a few tests crash on the bots, so its starting out flaky/bad. BUG=None TEST=New unit tests, tree should stay green after this checkin. Review URL: http://codereview.chromium.org/669276 TBR=jeremy@chromium.org Review URL: http://codereview.chromium.org/885001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41284 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling browser test that is crashing on the Mac bots.finnur@chromium.org2010-03-111-2/+9
| | | | | | | | | | BUG=29424 TEST=Disabling JavascriptAlertActivatesTab. TBR=pamg Review URL: http://codereview.chromium.org/866004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41282 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor synchronous error handlingskrul@chromium.org2010-03-1119-296/+262
| | | | | | | | | | This is the first of hopefully only two changes to improve our error handling situation. This change changes the way we use OnUnrecoverableError -- previously this was called whenever there was some kind of error in the MA or CP, but now it is only used for asynchronous errors. It has been removed from synchronous methods in favor of boolean return values to report errors. This simplifies some of the error handling. The next step is to make sure asynchronous usage of OnUnrecoverableError actually works as it should. Review URL: http://codereview.chromium.org/778002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41278 0039d316-1c4b-4281-b951-d872f2087c98
* Unit Tests for OS X Translte infobars.jeremy@chromium.org2010-03-118-39/+326
| | | | | | | | | BUG=None TEST=New unit tests, tree should stay green after this checkin. Review URL: http://codereview.chromium.org/669276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41274 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add more NULL-checks to UI tests that were lacking them to avoid ↵phajdan.jr@chromium.org2010-03-1111-31/+72
| | | | | | | | | | | crashiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/841002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41273 0039d316-1c4b-4281-b951-d872f2087c98
* Long string continuation lines require an 'L' on each continuation.mrossetti@chromium.org2010-03-111-1/+1
| | | | | | | | | | | Build broke by commit for http://codereview.chromium.org/790001. Revision 41252. BUG=None Test=None Review URL: http://codereview.chromium.org/869001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41255 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bookmark_bar_view_unittest's BookmarkButtonDragAndDrop test by adding ↵mrossetti@chromium.org2010-03-111-0/+4
| | | | | | | | | | | | | | the missing draggingSourceOperationMask method to the FakeBookmarkDraggingInfo class. Broke by commit for http://codereview.chromium.org/790001. Revision 41252. BUG=None TEST=None Review URL: http://codereview.chromium.org/860002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41253 0039d316-1c4b-4281-b951-d872f2087c98
* Add bookmark copying while dragging by holding down the <option> key.mrossetti@chromium.org2010-03-1114-17/+205
| | | | | | | | | BUG=35969 TEST=Hold down the <option> key while dragging a bookmark to a new location. Repeat with the following: 1) From bookmark bar to bookmark bar, 2) from bookmark bar into a folder, 3) from within a folder to a different place within the same folder, 4) from within a folder to the bookmark bar, 5) from within a folder to a different folder. Check to insure that the original bookmark (and its contents if it was a folder) are in both the original location and the new location. Review URL: http://codereview.chromium.org/790001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41252 0039d316-1c4b-4281-b951-d872f2087c98
* Add a table for the preferred languages to the languages settings dialog.satorux@chromium.org2010-03-112-8/+91
| | | | | | | | | | | | For now, it does nothing, but we'll add code for the table in the subsequent changes. TEST=manually BUG=none Review URL: http://codereview.chromium.org/807002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41251 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: make the URL field lighter.arv@chromium.org2010-03-112-2/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/850001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41250 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41245 - [Mac] Allow the overlay to animate out when a bookmarkbar ↵rohitrao@chromium.org2010-03-111-2/+2
| | | | | | | | | | | | | folder closes. This matches the effect when finishing dragging a button. BUG=None TEST=Go fullscreen. Omnibox should not have focus. Open a folder on the bookmarkbar and hover over one of its subentries. Overlay should not scroll back up. Dismiss the overlay. Overlay should animate out, not disappear instantly. Review URL: http://codereview.chromium.org/803002 TBR=rohitrao@chromium.org Review URL: http://codereview.chromium.org/854002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41249 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Save window position into the SessionService, so we can restore it ↵rohitrao@chromium.org2010-03-111-0/+4
| | | | | | | | | | after a crash. BUG=20909 TEST=Start chrome, load some pages/tabs, move the window somewhere else. Click away and back to the window (to trigger saving window position). Kill chrome (you may have to use kill -9 to actually kill it uncleanly). Restart, click to restore pages. Window should jump to where it was before the crash. Review URL: http://codereview.chromium.org/660395 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41248 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Allow the overlay to animate out when a bookmarkbar folder closes. ↵rohitrao@chromium.org2010-03-111-2/+2
| | | | | | | | | | This matches the effect when finishing dragging a button. BUG=None TEST=Go fullscreen. Omnibox should not have focus. Open a folder on the bookmarkbar and hover over one of its subentries. Overlay should not scroll back up. Dismiss the overlay. Overlay should animate out, not disappear instantly. Review URL: http://codereview.chromium.org/803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41245 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Notify the TabContents when the browser window has been moved or ↵jhawkins@chromium.org2010-03-111-0/+6
| | | | | | | | | | resized. This is used to close the AutoFill popup in the renderer. BUG=31865 TEST=none Review URL: http://codereview.chromium.org/805006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41230 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] If an info bubble window is open when the app is terminating, cancel ↵andybons@chromium.org2010-03-111-2/+34
| | | | | | | | | | the fadeout animation to prevent the window object from leaking. BUG=37717 TEST=none Review URL: http://codereview.chromium.org/822007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41229 0039d316-1c4b-4281-b951-d872f2087c98
* Code got moved out from under me, and when I merged, I missed a line. ↵cmasone@google.com2010-03-111-1/+3
| | | | | | | | People not using my new code will be unaffected, but this change makes it so the new stuff works again. Review URL: http://codereview.chromium.org/826003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41227 0039d316-1c4b-4281-b951-d872f2087c98
* Enable chrome to mount cryptohomes on its own as a part of auth, as well as ↵cmasone@google.com2010-03-1110-29/+493
| | | | | | | | | | handle offline login. TEST=Unittests, and also run on chromium OS device with --in-chrome-auth Review URL: http://codereview.chromium.org/822006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41223 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors the login manager code to have two windows:sky@chromium.org2010-03-1010-306/+436
| | | | | | | | | | | | | | | | | . background window containing the status and visual background. . WizardController creates it's own window for showing the various wizard dialogs. I needed to separate these two out as if you have logged in once I still want the background, and may end up showing the wizardcontrollers later. BUG=none TEST=none Review URL: http://codereview.chromium.org/832002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41219 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to continuous reporting of uptimejar@chromium.org2010-03-103-28/+33
| | | | | | | | | | | | | | | | | | | Uptime was being reported only at startup, and then, for the previous session. This meant that folks with a long uptime would be very slow to report. This change moves the reporting to an incremental reporting, done as often as we report pageloads etc. (i.e., in each UMA upload). This also fixes several bugs relating to uptime calculation, by using TimeTicks (which show process time) rather than Time (which shows wall clock time, and is subject to corruption if the user changes the will clock time on the computer). It also resolves a bug that may have caused negative uptimes to be reported. BUG=37630 r=hunar Review URL: http://codereview.chromium.org/675001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41216 0039d316-1c4b-4281-b951-d872f2087c98
* Added monochrome status icons for the mac.atwilson@chromium.org2010-03-106-0/+22
| | | | | | | | | | | Added support for setting an alternate "pressed" image for status icons. BUG=37375 TEST=updated unit tests Review URL: http://codereview.chromium.org/752002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41211 0039d316-1c4b-4281-b951-d872f2087c98
* Ripped out talk/p2p directory from third_party/libjingle.akalin@chromium.org2010-03-105-5/+5
| | | | | | | | | | | Fixed a few compile errors as a result. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/790002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41210 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use new macros to hide thunk declaration and cleanup callback declaration.erg@chromium.org2010-03-1014-424/+291
| | | | | | | | | | | | | | | | We have two conventions for declaring GTK+ callbacks in our code: We either declare a bunch of static thunks in the header that redirect to the correct object (and bloat up the header) OR we declare the callback methods static and pass the object as the final parameter (and litter the implementation with "context->"). The two styles are now about half/half...including mixing these two styles in the same files. This madness must end! BUG=none TEST=none Review URL: http://codereview.chromium.org/661010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41202 0039d316-1c4b-4281-b951-d872f2087c98
* Add comment about flaky test.pam@chromium.org2010-03-101-0/+1
| | | | | | | | | BUG=27039 TEST=none TBR=phajdan.jr Review URL: http://codereview.chromium.org/778006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41199 0039d316-1c4b-4281-b951-d872f2087c98
* Implement missing method and re-enable three browser_tests on Mac.pam@chromium.org2010-03-102-25/+6
| | | | | | | | BUG=29424 TEST=covered by browser_tests Review URL: http://codereview.chromium.org/669133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41198 0039d316-1c4b-4281-b951-d872f2087c98
* Use more theming methods on gray frame.avi@chromium.org2010-03-101-4/+12
| | | | | | | | | BUG=none TEST=no appearance change Review URL: http://codereview.chromium.org/823001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41197 0039d316-1c4b-4281-b951-d872f2087c98
* Implement the CoreAnimation drawing model for plug-ins, sharing IPC and some ↵pinkerton@chromium.org2010-03-101-1/+6
| | | | | | | | | rendering code with the GPU Plug-in. The drawing model negotiation is currently disabled so this should have no visible impact to plug-ins. BUG=32012 TEST=make sure the pepper GPU plug-ins still work. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41194 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Open in incognito window.arv@chromium.org2010-03-1011-32/+41
| | | | | | | | | | | Make IsIncognitoEnabled take an Extension* as an argument as well and use that where possible. BUG=4890 TEST=Select one more bookmarks and right click/tools and select "Open in incognito". The bookmarks should open in an incognito window. Review URL: http://codereview.chromium.org/750001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41193 0039d316-1c4b-4281-b951-d872f2087c98
* Adding initial version of the mediaplayer. This only hooks into the system ↵dhg@chromium.org2010-03-109-2/+1387
| | | | | | | | | | if the user selects a file via the filebrowser. BUG=none TEST=none Review URL: http://codereview.chromium.org/749001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41191 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 21:45:40 +0000