| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Realize our fake window in the GtkThemeProvider so we can access the style
properties.
- Make sure we don't generate the markup for a GtkChromeLinkButton until
after it is realized.
- Make sure GtkChromeLinkButton responds to system wide style theme changes.
BUG=43850
TEST=Open up chrome to the NTP with an empty bookmark bar in GTK+ theme mode. The links on the NTP should match the GTK+ link color, and so should the import bookmark link in the bookmark bar. Change your GTK+ theme to one with a different link color. The NTP and import bookmark link should change to the new color.
Review URL: http://codereview.chromium.org/2067007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Temporarily disable DevToolsSanityTest.TestResourceContentLength which started to fail on Linux after WebKit roll.
BUG=44202
Review URL: http://codereview.chromium.org/2084004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18774
TEST=import works exactly the same as before.
Review URL: http://codereview.chromium.org/2136002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43192
TEST=none
Review URL: http://codereview.chromium.org/2033010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, make sure we don't "hang" when the chrome url override failed.
BUG=43448
TEST=Manually
Review URL: http://codereview.chromium.org/2108001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
sem_init(), sem_destroy(), sem_wait(), etc.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=471
TEST=nacl_ui_tests still pass
Review URL: http://codereview.chromium.org/2091002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
show the updates about the download until the user presses allow. (much like the standard UI)
BUG=chromium-os:2773
TEST=none
Review URL: http://codereview.chromium.org/2130001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
clicking the edit button would crash.
BUG=none
TEST=clear the selection in the keyword editor (on windows), make sure
the edit button is disabled.
Review URL: http://codereview.chromium.org/2078006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42412
TEST=Unit tests in chrome/browser/value_tree_policy_decoder.cc and base/values_unittest.cc
Review URL: http://codereview.chromium.org/2027010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rest of IndexedDB) will be done in subsequent patches. Included in this patch
is a lot of other infrastructure for making IndexedDB work. Included is a
conversion from the DOMStorageDispatcherHost into a dispatcher host for all APIs
that have a backend in WebKit.
I named it WebKitAPIDispatcherHost. Since it's in browser/in_process_webkit and
it is for APIs that connect up to the WebKit API and it's used for APIs whose
backend is implemented in WebKit I thought the name was decent and not _too_
confusing, but if you have better ideas, please let me know.
This includes some code that you've already reviewed (darin), but a lot has
changed so please take a look at all of it.
TEST=Not much to test yet + behind a flag.
BUG=none
Review URL: http://codereview.chromium.org/1599009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/1853
TEST=Try to login with wrong password, see error message in bubble, start typing new password, bubble should close on typing.
Review URL: http://codereview.chromium.org/2074004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tyoshino@chromium.org
Review URL: http://codereview.chromium.org/2080003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit ffa6827263fb5e6b4017a5f1655b683c806498fd.
TBR=dpolukhin@chromium.org
Review URL: http://codereview.chromium.org/2126002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/1992005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=44147
TEST=valgrind bot should stay gree.
TBR=tyoshino@chromium.org,rvargas@chromium.org
Review URL: http://codereview.chromium.org/2071006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Add a search engine provider for which no keyword can be generated
Review URL: http://codereview.chromium.org/2008017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=crosbug.com/1853
TEST=Type wrong password and press Enter.
Review URL: http://codereview.chromium.org/2086001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
rkc@chromium.org.
This change hooks issue report dialog with Google Feedback backend for ChromeOS.
The dialog is going to be used only for Chrome OS at the moment, the previous mechanism is kept intact for other operating systems.
Image and System Info reporting is disabled at the moment; for image, we need
feedback to get their changes in production, for reporting, the system scripts
need to be added (basic Chrome and OS version info is being sent with the report)
BUG=chromium-os:2761
TEST=none, work in progress
TBR=zelidrag
Review URL: http://codereview.chromium.org/2068004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Command line looks like this:
chrome.exe --register-pepper-plugins="c:\foo\bar.dll;application/x-bar"
This causes the registered plugins to be loaded on startup before the sandbox
is engaged. As a result, registered plugins can function within the sandbox.
R=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2104002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is to make Chinese characters more readable.
BUG=chromium-os:2904
TEST=manually
Review URL: http://codereview.chromium.org/2070002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This field is unnecessary since it can be inferred from the list of log entries.
Review URL: http://codereview.chromium.org/2129001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for Chromium OS. Currently disabled by default behind a command line
switch, and containing a non-real URL for now, this code is at
prototype level. It works (when enabled and pointed at a functioning
cloud print service URL), has the beginnings of some unit tests, and
has the beginnings of deeper communication with the dialog contents,
and it shuts off the DOM UI access from the dialog contents.
Patch contributed by Scott Byer
Review URL: http://codereview.chromium.org/1769006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is to pass the file handle with magic FileDescriptor over IPC for POSIX.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2123001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
passing a URLRow across IPC for out of process import.
BUG=18774
TEST=NONE
Review URL: http://codereview.chromium.org/2127002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:59
TEST=none
Review URL: http://codereview.chromium.org/2085004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Added ScreenLockerLibrary and its mock class.
* Call NotifyScreenLockCompleted when screen locker is shown
* Call NotifyScreenUnlocked when authentication is sucessful.
* Replace includes in cros_in_process_browser_test.cc with forward declarations.
* Added ScreenLockerTester for testing
* Added new browser test ScreenLockerTest.TestBasic
BUG=2914
TEST=added ScreenLockerTest.TestBasic browser test.
Review URL: http://codereview.chromium.org/2025009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeOS.
BUG=chromium-os:2671
TEST=Verify fix for chromius-os:2671.
Review URL: http://codereview.chromium.org/2085003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=44119,44005
TEST=FirefoxProxySettingsTest.TestParseAutoConfigUrl
Review URL: http://codereview.chromium.org/2089004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=TopSitesTest
Original review=http://codereview.chromium.org/2057008
Patch by Nik Shkrob
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/23106
TEST=as in bug
Review URL: http://codereview.chromium.org/1992006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SideTabStrip. I still have a bunch of cleanup to do, but this is a
good checkpoint.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2037012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
from sprewell
Review URL: http://codereview.chromium.org/2058004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=js unit tests as well as manually ensuring the menu button in the bookmarks manager flips side when the window gets small.
Review URL: http://codereview.chromium.org/2042017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/2064002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When running under GNOME, read the gconf key that defines the button placement
and lay the close, minimize and maximize buttons out. This can even handle
bizarre combinations like putting the close button on the left and the
minimize/maximize buttons on the right.
When running under anything else, use the default button ordering.
BUG=39406
TEST=none
Review URL: http://codereview.chromium.org/2095001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=43816
TEST=none
Review URL: http://codereview.chromium.org/1981014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
(The "extra" was redundant. And "params" is a well understood abbreviation of "parameters").
Review URL: http://codereview.chromium.org/2110001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/44076
TEST=Open an extensio app and make sure that the bookmark bar never becomes visible.
Review URL: http://codereview.chromium.org/2090002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use InitMockCryptohomeLibrary in LoginManagerViewTest
BUG=none
TEST=LoginManagerView test should pass.
Review URL: http://codereview.chromium.org/2027011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and other misc. cleanup.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2100001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2098001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mitsuru landed CL http://codereview.chromium.org/2032006 that always creates
GoogleAuthenticator if --login_manager switch is enabled. GoogleAuthenticator
constructor has check for croslib that fails if croslib version doesn't match
or you are debugging login manager on Linux. So it broke previous behavior that
missing croslib was not a fatal error and user was able to see error message on
login screen (now user can't - only black screen after several Chrome restarts).
BUG=none
TEST=Run Chrome built for Chrome OS on Linux with --login_manager command line switch, it shouldn't crash with CHECK fail about croslib.
Review URL: http://codereview.chromium.org/2082001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=dict indicies indices
Review URL: http://codereview.chromium.org/2065001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2072002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This includes info like version string, executable name, path, and so on.
Review URL: http://codereview.chromium.org/2009013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=3231
(chromium-os)
http://code.google.com/p/chromium-os/issues/detail?id=3231
Review URL: http://codereview.chromium.org/2058006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
chrome/service/cloud_print
BUG=None.
TEST=None.
Review URL: http://codereview.chromium.org/2007012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A few sub options dialog has wrong size because OnCheckResize always applys
Gtk's default size regardless of what we set. Fix the problem by only do
auto resize when we are asked to (i.e. requested size_'s height is 0).
Also make sure that auto resize repects the given minimum size.
BUG=none
TEST=Verify sub options dialogs such as autofill, search engine manager etc has the right size.
Review URL: http://codereview.chromium.org/2053006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG= http://crosbug.com/3247
TEST=Use debug version of Chrome on the device. It should not crash on login.
Review URL: http://codereview.chromium.org/2087001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47141 0039d316-1c4b-4281-b951-d872f2087c98
|