summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Touch PSS as an experiment, to see what the builder recompiles.nick@chromium.org2009-08-151-1/+1
| | | | | | | | No-op code change. Review URL: http://codereview.chromium.org/172016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23504 0039d316-1c4b-4281-b951-d872f2087c98
* Import passwords from Firefox 3.1 and above.kuchhal@chromium.org2009-08-156-55/+169
| | | | | | | | BUG=9103 Review URL: http://codereview.chromium.org/165352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23503 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure we don't load plugins on the IO thread.jam@chromium.org2009-08-1511-143/+207
| | | | | | | | | | I had to move the locks from PluginService to PluginList, so that a lock (which can block other threads) isn't held while loading the plugins. BUG=17938 TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them Review URL: http://codereview.chromium.org/164305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23501 0039d316-1c4b-4281-b951-d872f2087c98
* Convert parts of errorpage_uitest.cc to be not flaky.phajdan.jr@chromium.org2009-08-154-10/+152
| | | | | | | | | TEST=Covered by browser_tests. http://crbug.com/19361, http://crbug.com/19395 Review URL: http://codereview.chromium.org/169002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23500 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a copyright header to extension_browsertest.cc and fixes lint error.mpcomplete@chromium.org2009-08-142-3/+9
| | | | | | Review URL: http://codereview.chromium.org/171005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23499 0039d316-1c4b-4281-b951-d872f2087c98
* Add new certificate error codewtc@chromium.org2009-08-143-8/+28
| | | | | | | | | | | | | | | | | | ERR_CERT_WEAK_SIGNATURE_ALGORITHM and certificate status flag CERT_STATUS_WEAK_SIGNATURE_ALGORITHM. Note that I didn't add new load flag LOAD_IGNORE_CERT_WEAK_SIGNATURE_ALGORITHM. Allow users to accept MD2 certificates as certificates signed using a weak signature algorithm. MD4 certificates are still treated as invalid certificates. R=jar,jcampan BUG=http://crbug.com/18725 TEST=none Review URL: http://codereview.chromium.org/165504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23497 0039d316-1c4b-4281-b951-d872f2087c98
* Do not delete default browser entries for other users when uninstalling it ↵kuchhal@chromium.org2009-08-141-10/+10
| | | | | | | | | | | for one user. BUG=19222 TEST=Install and set Chrome as default for two different users on the same machine. Uninstall for one user and make sure the default browser still works for the second user. Review URL: http://codereview.chromium.org/164454 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23496 0039d316-1c4b-4281-b951-d872f2087c98
* Fix TabDraggingTest.Tab2OutOfTabStrip, which I broke by changing ↵estade@chromium.org2009-08-142-4/+4
| | | | | | | | | | | | | | browser_tracker_ to window_tracker_ Verified working on my windows box. I'd like to go on the record as disliking "handle" as a variable name. BUG=19368 Review URL: http://codereview.chromium.org/172001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23493 0039d316-1c4b-4281-b951-d872f2087c98
* Disable UpdatePermissions until I can figure out why it's failing.mpcomplete@chromium.org2009-08-141-0/+3
| | | | | | | | | | BUG=no TEST=no TBR=aa Review URL: http://codereview.chromium.org/171002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23492 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for spell check toggle checkbox not getting selected after reset to ↵sidchat@google.com2009-08-141-0/+1
| | | | | | | | | default button is clicked. Patch by tfarina (original patch: http://codereview.chromium.org/165524) BUG=www.crbug.com/4602 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23490 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Change file chooser dialogs to prefer the suggested path (somewhatly ↵estade@chromium.org2009-08-141-18/+28
| | | | | | | | | | | | erroneously known as "default_path") over the last selected path. Also respect default_path for file save dialogs. This fixes a DCHECK we could hit from <upload> elements (as it turns out, there was no Release-mode crash). BUG=19267 Review URL: http://codereview.chromium.org/170014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23485 0039d316-1c4b-4281-b951-d872f2087c98
* Added support in the ExternalTabContainer for handling the ↵ananta@chromium.org2009-08-144-17/+83
| | | | | | | | | | | | NEW_FOREGROUND_TAB and NEW_BACKGROUND_TAB dispositions in its implementation of TabContents::AddNewContents. These dispositions are handled by creating a new ExternalTabContainer instance, attaching it to the automation provider and sending off the AutomationMsg_AttachExternalTab IPC to the automation client requesting it to attach to the newly created tab. This fixes bug http://b/issue?id=2050347 Bug=2050347 Review URL: http://codereview.chromium.org/164530 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23483 0039d316-1c4b-4281-b951-d872f2087c98
* Split short-circuited assertions in session_restore_uitest.cc to make morephajdan.jr@chromium.org2009-08-141-19/+20
| | | | | | | | | | | | | meaningful errors appear in the logs. This will help fight the test flakiness. TEST=none BUG=none Review URL: http://codereview.chromium.org/164564 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23482 0039d316-1c4b-4281-b951-d872f2087c98
* Disable an extension when it is upgraded to a version that requires morempcomplete@chromium.org2009-08-1415-71/+422
| | | | | | | | | | | | | permissions then before, and prompt the user to re-enable. Incidentally, this required adding support for disabling extensions. BUG=12140 TEST=covered by unit tests Review URL: http://codereview.chromium.org/165414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23480 0039d316-1c4b-4281-b951-d872f2087c98
* Implement chrome.tabs.getVisibleTabCapture() on Macrafaelw@chromium.org2009-08-141-1/+4
| | | | | | Review URL: http://codereview.chromium.org/165429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23479 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we can sometimes incorrectly decide a downloadaa@chromium.org2009-08-141-1/+1
| | | | | | | | | | | is not an extension. BUG=19340 TEST=See bug for details. Review URL: http://codereview.chromium.org/170007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23474 0039d316-1c4b-4281-b951-d872f2087c98
* Another attempt at tree fix.sidchat@google.com2009-08-141-2/+2
| | | | | | | | TBR=pkasting BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23468 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build.sidchat@google.com2009-08-141-1/+1
| | | | | | | | TBR=pkasting BUG=none TEST=none. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23465 0039d316-1c4b-4281-b951-d872f2087c98
* Make Spellchecker save the dictionary file in the file thread.sidchat@google.com2009-08-142-35/+151
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23464 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Theme: Theme the find bar.erg@chromium.org2009-08-142-49/+139
| | | | | | | | | | | | | | | Modify the find bar so that in GTK theme mode we: - ...set the dialog shape to a series of points instead of an image. - ...use the global border color. - ...use GTK icons. This does not draw the GtkEntry border around the GtkEntry though. That will be a follow up patch. http://crbug.com/17962 Review URL: http://codereview.chromium.org/165497 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23459 0039d316-1c4b-4281-b951-d872f2087c98
* remove some unneeded DCHECKs (from an earlier review comment you made)erikkay@chromium.org2009-08-141-5/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165545 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23456 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent mouse down events on the toolbar view from moving the parent window.paul@chromium.org2009-08-143-3/+28
| | | | | | | | | BUG=19305 (http://crbug.com/19305) TEST=Click and drag on the toolbar background and ensure that the window isn't moved. Review URL: http://codereview.chromium.org/164528 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23453 0039d316-1c4b-4281-b951-d872f2087c98
* Only call gtk_window_present on an alert dialog if thetony@chromium.org2009-08-141-7/+10
| | | | | | | | | | | | | | | | | | activation state of the window is changing to active. The signal gets sent even when windows are going inactive (to make the frame light blue), but we only want to do anything if the window is trying to become active. This seems fvwm specific in that gtk_window_present actually changes focus in fvwm (in compiz/metacity, it just causes the window to throb in the taskbar). BUG=19292 Review URL: http://codereview.chromium.org/165502 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23452 0039d316-1c4b-4281-b951-d872f2087c98
* Match Windows and GtkEntry move cursor with selection behavior.deanm@chromium.org2009-08-141-7/+18
| | | | | | | Review URL: http://codereview.chromium.org/170002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23451 0039d316-1c4b-4281-b951-d872f2087c98
* re-disable Tab2OutOfTabStrip to make the bot greenestade@chromium.org2009-08-141-1/+2
| | | | | | | | TBR=maruel Review URL: http://codereview.chromium.org/165547 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23447 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 23408 in the hope to fix linux webkit_tests regressions.maruel@chromium.org2009-08-141-2/+1
| | | | | | | | | | | | | According to http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux/builds/8895 and http://build.chromium.org/buildbot/waterfall/builders/Webkit%20Linux/builds/8896 The culprit is either 23407 or 23408. I'm trying 23408 first. TBR=estage TEST=webkit linux webkit_tests BUG=none Review URL: http://codereview.chromium.org/165534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23438 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23420. It caused a reliability regression.maruel@chromium.org2009-08-1411-207/+143
| | | | | | | | | TBR=jam BUG=none TEST=reliability Review URL: http://codereview.chromium.org/165532 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23437 0039d316-1c4b-4281-b951-d872f2087c98
* Another fix for my new unit-test "SpellCheckTest.SpellCheckTest".hbono@chromium.org2009-08-141-5/+16
| | | | | | | | | | | Sorry I forgot removing a fprint() call used for debug. TBR=brettw BUG=18184 TEST=run unit_test on Mac Review URL: http://codereview.chromium.org/164554 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23432 0039d316-1c4b-4281-b951-d872f2087c98
* A fix for a unit-test break on Mac.hbono@chromium.org2009-08-141-7/+14
| | | | | | | | | | | | | | | | | | This change fixes my new unit-test "SpellCheckTest.SpellCheckTest" breaks on Mac. The system dictionaries of Mac spellchecker don't have the following words included in hunspell: * en-AU (Australia): "organize" (which is a typo of "organise"); * en-GB (United Kingdom): "organize" (which is a typo of "organise"); * pt-BT (Brazil): "Google"; * pt-PT (Portugal): "Google". This change removed "Google" from a couple of texts and fixed a couple of typos. Also, this change adds a language for Spanish (Spain), which I forgot adding. TBR=brettw BUG=18184 TEST=run unit_tests on Mac Review URL: http://codereview.chromium.org/164553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23431 0039d316-1c4b-4281-b951-d872f2087c98
* Added a unit test "SpellCheckTest.SpellCheckText".hbono@chromium.org2009-08-141-0/+239
| | | | | | | | | | This change adds a new unit test "SpllCheckTest.SpellCheckText" for testing our spellchecker with all available dictionaries. BUG=18184 "Add more spellcheck tests with languages other than en-US" TEST=run unit_test.exe Review URL: http://codereview.chromium.org/159906 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23430 0039d316-1c4b-4281-b951-d872f2087c98
* Make ClientSocketPool/ClientSocketPoolBase/ClientSocketHandle more generic.willchan@chromium.org2009-08-141-1/+1
| | | | | | | | | | | | | | | This is in preparation for creating an SSLClientSocketPool. ClientSocketPoolBase is now templated. Most of the implementation has moved to ClientSocketPoolBaseHelper which is not templated. In order to make this possible, ClientSocketPoolBaseHelper's internal data structures do not use the full concrete Request type, but rather use a pointer to Request. ClientSocketPoolBase takes a SocketParams as a template argument, primarily to allow RequestSocket to take a templated parameter that contains all the information necessary to connect the socket (be it TCP or SSL or whatever). ClientSocketPool::RequestSocket() and ClientSocketHandle::Init() have been templated as well to handle this case. I've left adding run-time type safety checks as a TODO. TEST=net_unittests BUG=http://crbug.com/13289 Review URL: http://codereview.chromium.org/160621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23427 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable ExtensionBrowserTest.Toolstrip while the levin@chromium.org2009-08-141-1/+2
| | | | | | | | | | | | crash is being investigated. BUG=http://crbug.com/19335 TEST=None Review URL: http://codereview.chromium.org/164549 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23426 0039d316-1c4b-4281-b951-d872f2087c98
* The change has the followings:lzheng@chromium.org2009-08-149-101/+670
| | | | | | | | | | | | | | | 1. Auto-updating of extension blacklist. 2. Handle extensions in the blacklist. If an extension is in the blacklist, a. browser will not load the extension at start time; b. browser will unload the extension at running time; c. browser will not install the extension; BUG=12118 TEST=Verify behavior described above works (they should be covered in the unittests in this change). Review URL: http://codereview.chromium.org/165164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23423 0039d316-1c4b-4281-b951-d872f2087c98
* Implementation of getBackgroundPage(), getToolstrips(), andaa@chromium.org2009-08-1412-11/+118
| | | | | | | | | | | | | | | getTabContentses(). This lands http://codereview.chromium.org/159067. Raf, the only thing you need to look at is the changes to extensions_process_bindings.js and extension_api.json. BUG=13577 TEST=Browser tests added Review URL: http://codereview.chromium.org/164458 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23422 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure we don't load plugins on the IO thread.jam@chromium.org2009-08-1411-143/+207
| | | | | | | | | | I had to move the locks from PluginService to PluginList, so that a lock (which can block other threads) isn't held while loading the plugins. BUG=17938 TEST=added asserts which crash if plugins loaded on IO thread, current UI tests exercise them Review URL: http://codereview.chromium.org/164305 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23420 0039d316-1c4b-4281-b951-d872f2087c98
* LoadLog is used as an output parameter, reorder it to the last parameter.willchan@chromium.org2009-08-142-2/+2
| | | | | | Review URL: http://codereview.chromium.org/164531 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23419 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SyncSetupWizard test again; the order of operations when the HtmlDialogViewtim@chromium.org2009-08-141-27/+46
| | | | | | | | | | | | | infrastructure closes a dialog is a bit different from what I was simulating in this test. It goes 1) obtain handlers from delegate. 2) delete delegate. 3) delete handlers. Also add a virtual dtor to TestBrowserWindow. BUG=19002 TEST=SyncSetupWizardTest Review URL: http://codereview.chromium.org/164494 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23414 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23406.levin@chromium.org2009-08-141-1/+1
| | | | | | | | | | | | It seems that Tab2OutOfTabStrip is failing consistently after this change. BUG=None TEST=None TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/164543 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23411 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent mouse down events in the bookmark bar and download shelf from movingpaul@chromium.org2009-08-145-0/+88
| | | | | | | | | | | | the parent window around. BUG=19305 (http://crbug.com/19305) TEST=Make the download shelf and/or bookmark bar visible. Clicking and dragging on either one should not move the window around. Review URL: http://codereview.chromium.org/165500 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23409 0039d316-1c4b-4281-b951-d872f2087c98
* Check for enter as well as return in the find barestade@chromium.org2009-08-141-1/+2
| | | | | | | | BUG=19312 Review URL: http://codereview.chromium.org/165511 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23408 0039d316-1c4b-4281-b951-d872f2087c98
* Change PluginInstallImpl to use base::WindowImpl instead of CWindowImpl to ↵jhawkins@chromium.org2009-08-141-1/+1
| | | | | | | | | | reduce a dependency on ATL. BUG=5023 TEST=Uninstall flash. Visit hulu.com and install the flash plugin. Review URL: http://codereview.chromium.org/165469 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23406 0039d316-1c4b-4281-b951-d872f2087c98
* Revert some of my automation provider changes. Maybe it's possible that ↵estade@chromium.org2009-08-142-10/+9
| | | | | | | | GetResource() returns NULL when ContainsHandle() returns true? I can't repro locally and there is no try server for this. Review URL: http://codereview.chromium.org/165510 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23404 0039d316-1c4b-4281-b951-d872f2087c98
* Disable TabDraggingTest.Tab2OutOfTabStrip temporarily.sidchat@google.com2009-08-141-1/+2
| | | | | | | | | TBR=estade BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23401 0039d316-1c4b-4281-b951-d872f2087c98
* Show favicon in panel title, highlight focused panel, fix breakagedavemoore@chromium.org2009-08-134-74/+122
| | | | | | | recent search box changes Review URL: http://codereview.chromium.org/164425 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23395 0039d316-1c4b-4281-b951-d872f2087c98
* I changed an OS_WIN to TOOLKIT_VIEWS. The buildbot doesn't like it. Why ↵estade@chromium.org2009-08-131-2/+1
| | | | | | | | | | don't we have a trybot for linux views. TBR=tony Review URL: http://codereview.chromium.org/165505 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23393 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add view ids to our widgets. These will be used for testing.estade@chromium.org2009-08-1312-5/+210
| | | | | | | | | | Also add unit test to test test infrastructure. BUG=19214 Review URL: http://codereview.chromium.org/164519 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23392 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression caused by CL 16142suzhe@chromium.org2009-08-132-11/+123
| | | | | | | | | | | | | This CL fixes regression caused by CL 16142: Improve key event handling of AutocompleteEditViewGtk. BUG=19193: omnibox blocks ctrl-* commands BUG=19199: omnibox ignores history, automatically searchs TEST=Open chrome, move cursor into omnibox then press ctrl-t to see if a new tab is opened. TEST=Open chrome, input something in omnibox and make sure an url is matched and some text is highlighted in omnibox, then press Enter to see if the url is opened. Review URL: http://codereview.chromium.org/165457 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23388 0039d316-1c4b-4281-b951-d872f2087c98
* linux: More automation porting.estade@chromium.org2009-08-138-44/+102
| | | | | | | | | | I have verified that this is working on Linux, but still have yet to enable any new automated tests. Baby steps. BUG=19076 Review URL: http://codereview.chromium.org/164446 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23386 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r23358 with a fix for linux unit_tests:tony@chromium.org2009-08-133-25/+19
| | | | | | | | | | | | | | | | | | Better location for setting the size of tab contents. This should catch all code paths. I noticed that middle clicking a bookmark wasn't working, so I found a single place to do this. This code is always run when a tab is added and it sizes the contents when it's loading in the background. BUG=619 TBR=japhet Review URL: http://codereview.chromium.org/164526 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23384 0039d316-1c4b-4281-b951-d872f2087c98
* coverity: Pass strings by reference.jhawkins@chromium.org2009-08-131-1/+2
| | | | | | | | | CID=5738 BUG=none TEST=none Review URL: http://codereview.chromium.org/165486 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23381 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-14 04:56:22 +0000