| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
temp file once we are done with it.
We observe ResourceHandle::OnRequestClosed as a signal of when we should delete
the temp file. This corresponds to the WebURLLoader being closed (or
canceled).
This patch also includes some helpers:
base/scoped_callback_factory.h
This class makes it easy to allocate Callbacks that hold a weak reference
back to the owning class. It works just like ScopedRunnableMethodFactory
but for Callbacks instead of RunnableMethods.
base/platform_file.h
Added a PassPlatformFile class that is useful for cases where a callback may
decide not to take ownership of a PlatformFile (as can happen when using
ScopedCallbackFactory).
chrome/file_system_proxy.{h,cc}
This class provides static methods for executing file system commands on the
FILE thread. It routes callbacks back to the originating thread to deliver
results (file handles, etc.). Note: this file declares a few functions that
are not yet used. I anticipate that we'll make use of these and add more
functions here to support the Pepper and OWP FileSystem APIs.
chrome/chrome_thread_relay.{h,cc}
This class is a helper class for proxying calls over to a background
ChromeThread and then returning results to the originating ChromeThread.
R=brettw
BUG=49789
TEST=(more to be added in third_party/ppapi/tests)
Review URL: http://codereview.chromium.org/2878062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Cleaned up the final few callers, punting the remaining harder ones
to TODOs.
Review URL: http://codereview.chromium.org/3043033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There was a bug in the export code for exporting properties since it was just doing a simple [[Get]] which breaks cr.doc as well as the option to have singletons created lazily by the getter.
BUG=None
TEST=Options and Bookmarks should still work.
Review URL: http://codereview.chromium.org/3031035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This removes all switch-related wstring APIs from ui_test.cc, and
fixes all the callers.
Review URL: http://codereview.chromium.org/3066026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flip the compile-time enable switch for speech input to on and add a
command-line switch to put the functionality behind. The command-line
flag will be used both on the Chromium side and in WebKit via
WebRuntimeFeatures.
This CL depends on the webkit patch https://bugs.webkit.org/show_bug.cgi?id=43146
BUG=none
TEST=browser_tests --gtest_filter=SpeechInputEnableSwitchTest.*
Originally Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54235, but reverted due to tests failure.
Review URL: http://codereview.chromium.org/3064017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32148
TEST=Open task manager. It should immediately look like it did if you opened it and then resized it by 1px previously.
Review URL: http://codereview.chromium.org/3056036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
During install it is possible to display (or layout) the action before
the images have come in. Provide a default image for this case.
BUG=50771
TEST=See bug.
Review URL: http://codereview.chromium.org/3047031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Broke AutocompleteEditViewTest.DesiredTLD and AutocompleteEditView.EscapeToDefaultMatch on Linux.
TBR=mrossetti
Review URL: http://codereview.chromium.org/3052031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Preventative maintenance for abstract classes that do not declare virtual
destructors. Base classes that do not declare their destructors as virtual
could potentially lead to memory leaks.
These files were discovered using the -Wnon-virtual-dtor flag in g++.
r=jar
BUG=47469
Review URL: http://codereview.chromium.org/3072010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Everything now needs to be changed to avoid the deprecated wstring methods; this
includes the unit tests.
BUG=23581
TEST=all our tests still pass
Review URL: http://codereview.chromium.org/3075010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3025014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use the base namespace in the new file. Update callers.
I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling.
TEST=included unit tests
BUG=none
Review URL: http://codereview.chromium.org/3056029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for the replacement of the current history_url_provider. This step refactors the history provider code a bit, introduces the replacement class (history-quick_provider), and adds a unittest template. Note that the 'quick' provider will only support the fast, synchronous autocomplete pass. Once the quick provider has been completed the current history_url_provider will be replaced. In the meantime, the latter will remain in operation in order to provide the slower history results.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3017008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:1078
TEST=none
Review URL: http://codereview.chromium.org/3018029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=make sure options still work
Review URL: http://codereview.chromium.org/3027003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The window doesn't have any contents yet, which makes its appearance look a bit janky for now.
BUG=50307
TEST=
* All the following happens only if --enable-expose-for-tabs is passed in, else all of it should be disabled.
* In a browser window, hit cmd-f10 or three-finger-swipe down. A grey overlay with a gradient at the top should appear.
* The overlay should cover tab contents, eventual info bars, the bookmarks bar if it's detached (but not the bookmarks bar if it's not detached), and eventual attached inspector windows. It should not cover the download shelf if it's open.
* The window should block clicks on the tab strip and the download shelf for now.
* The overlay should close on three-finger-swipe up, click, esc, enter, and space.
* Every open browser window should have its own overlay, and they should be independent of each other.
* If a browser window with an overlay window is active, most menu items should be greyed out, and all browser-related keyboard shortcuts should be disabled.
* In particular, hitting cmd-f10 twice should open only one overlay per browser window
* The overlay should have the correct size with a UI scale factor > 1
Review URL: http://codereview.chromium.org/2819070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54349 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We've seen some flaky flips July 19th, but it still
might be caused by more recent changes like my download
cleanup or other changes that have landed recently.
More data in the bug.
TBR=jcivelli,suzhe,oshima
TEST=BrowserFocusTest.TabInitialFocus
BUG=50763
Review URL: http://codereview.chromium.org/3017046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
branded builds.
BUG=50537
TEST=unit_tests should pass in branded builds.
Review URL: http://codereview.chromium.org/3068013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54340 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Removes a few needless conversions.
Review URL: http://codereview.chromium.org/3075012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Removes some wstrings.
BUG=24672
Review URL: http://codereview.chromium.org/2819080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3010040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous code was comparing the window size to the screen
size, but that doesn't work properly for twinview or other cases
where there are multiple monitors that make up a single screen.
Instead, compare the window size against all monitors (since we
don't know which monitor the window is going to be placed on)
and resize if it matches any monitor size.
Also fix a bug in BoundsMatchMonitorSize where we should just be
comparing sizes, not rectangle positions.
BUG=32347
Review URL: http://codereview.chromium.org/3060032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux programs are expected to notify their launcher when they finish loading.
GTK+ does this automatically when the first GtkWindow is opened. When acting as
a remote, no window is opened, so we should manually send the notification.
This could perhaps be more thorough and pass DESKTOP_LAUNCH_ID to the remote to
call with gdk_notify_startup_complete_with_id, but a quick survey on codesearch
suggests that no one bothers anyway.
(This is reproducible in KDE. The bug report suggests some configurations of
GNOME need this as well, but not yet reproducible.)
R=estade
BUG=45392
TEST=throbber disappears on second Chrome launch in KDE
Review URL: http://codereview.chromium.org/3051023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The sandbox can not allow file access to paths that contain reparse points. Chrome tries to find a reparse point free path to the directory which will be sandboxed for extension unpacking. However, there are cases where there is no such path. See the bug for an example. In this case, give a decent error message.
BUG=49530
TEST=Manually created a partition mounted in C:/mnt, mounted as drive letter, and mounted only under /Devices/HardDisk3/, tried unpacking extensions in each.
Review URL: http://codereview.chromium.org/3060026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
view which provides an image based button that changes on hover and press.
Refer to the bug for screenshots of the current and desired UI.
Screenshot of what results from this patch is visible at http://www.corp.google.com/~johnnyg/49490patch.png
XIB change: change height of title bar, change bindings of buttons.
BUG=49190
TEST=notifications on the mac
Review URL: http://codereview.chromium.org/3014004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=www.popuptest.com, click a page to cause popups. Animation should go to where the blocked-popup content-setting decoration is in the omnibox.
Review URL: http://codereview.chromium.org/3014029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
--issue35198-crxdir-browser
--issue35198-permission
They were used to understand issue 35198. They are no longer needed. There is one more switch, --issue35198-logging, that is not being removed in this CL. The logging it adds may still be useful.
BUG=50604
TEST=manual
Review URL: http://codereview.chromium.org/3052023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=50599
TEST=Open a window and let its webpage load. Move the window left or right, without allowing the mouse to pass over the web area. Then type in a new url and load it, again without letting the mouse pass over the web area. Status bubble should appear in the proper place.
Review URL: http://codereview.chromium.org/3041028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixing CustomizationDocument to return full path to the pages being queried.
BUG=chromium:3178
TEST=none
Review URL: http://codereview.chromium.org/2878051
TBR=glotov@chromium.org
Review URL: http://codereview.chromium.org/3051026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Just a first step. I can't remove GetTempDir yet though.)
BUG=none
TEST=unit tests
http://codereview.chromium.org/3075008/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixing CustomizationDocument to return full path to the pages being queried.
BUG=chromium:3178
TEST=none
Review URL: http://codereview.chromium.org/2878051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
hackery.
BUG=49206
TEST=Unit tests pass regularly.
Review URL: http://codereview.chromium.org/3017044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use AppendASCII from FilePath API instead of the deprecated AppendToPath
function.
BUG=24672
TEST=trybots
Signed-off-by: Thiago Farina <tfarina@chromium.org>
Review URL: http://codereview.chromium.org/3046020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Create user account and verify that images login screen is shown and
the new user logs in.
Review URL: http://codereview.chromium.org/3057020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=unit_tests of mac
BUG=50083
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/3051025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The XIB change re-introduces the cookie tab view item with the "ask" setting
as additinoal tab view item. The controller deletes the one not required
according to the command line flag.
BUG=50083
TEST=none
Review URL: http://codereview.chromium.org/3075013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2808083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add test shortcut for register screen.
BUG= http://crosbug.com/4483 http://crosbug.com/4003 http://crosbug.com/4002
TEST=Manual - update during OOBE should work and reboot if update has been installed.
Review URL: http://codereview.chromium.org/2832088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50724
TEST=manual
Review URL: http://codereview.chromium.org/2819081
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
than polling.
BUG=50587
Review URL: http://codereview.chromium.org/3078009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3037034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
For this patch, I skipped over any instance where it wasn't a nearly trivial
change.
Review URL: http://codereview.chromium.org/3069014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
maintained GURL members holding the url and
referrer. We can stuff this information into the ChromeFrameLaunchParams member maintained by the client. This
reduces the complexity in the code related to detecting whether we can navigate up front or after chrome initialization.
The ChromeFrame ActiveX now launches the automation server in its implementation of IPersistPropertyBag::Load. This avoids
race conditions between launching the automation server and navigating to it via put_src.
Review URL: http://codereview.chromium.org/3038038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
appropriate CC icon.
BUG=50080
TEST=none
Review URL: http://codereview.chromium.org/3010041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark gets deleted.
BUG=50381
TEST=1) Bring up a bookmark folder which can be scrolled. 2) Scroll it a bit. 3) Cut or delete a bookmark using the contextual menu. 4) Scroll using the mouse scroll wheel. If there is no crash at this point then the bug has been fixed.
Review URL: http://codereview.chromium.org/3030029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50705
TEST=Snippets.FAILS_ThaiUTF8
Review URL: http://codereview.chromium.org/3079010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 893e3e083fe8d77949860cdb1af7fc14a371651e.
It was reverted due to a LINK failure, but reverting didn't fixed either, so I'm relanding it again.
BUG=39102
TEST=trybots
Review URL: http://codereview.chromium.org/2805096/
TBR=mirandac@chromium.org
Review URL: http://codereview.chromium.org/3057018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It didn't wait for things to finish, which was clearly broken.
TBR=xji
TEST=interactive_ui_tests:BrowserFocusTest.* on Linux, no crashes
BUG=50696
Review URL: http://codereview.chromium.org/3005038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r54235.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Flip the compile-time enable switch for speech input to on and add a
command-line switch to put the functionality behind. The command-line
flag will be used both on the Chromium side and in WebKit via
WebRuntimeFeatures.
This CL depends on the webkit patch https://bugs.webkit.org/show_bug.cgi?id=43146
BUG=none
TEST=browser_tests --gtest_filter=SpeechInputEnableSwitchTest.*
Review URL: http://codereview.chromium.org/3064017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54235 0039d316-1c4b-4281-b951-d872f2087c98
|