summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Linux: fix SELinux support.agl@chromium.org2010-03-171-9/+15
| | | | | | | | (First of a series to improve our SELinux support) http://codereview.chromium.org/1000008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41867 0039d316-1c4b-4281-b951-d872f2087c98
* Removed auth_task.* and talk_auth_task.* (dead code)akalin@chromium.org2010-03-1721-1435/+21
| | | | | | | | | | | | | | | Removed GaiaAuth class. Gtalk login will now fail immediately instead of trying (in vain) to gaia-auth. Removed now-unneeded parameters. BUG=38034 TEST=manual with and without --invalidate-sync-xmpp-login Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41790 Review URL: http://codereview.chromium.org/885008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41865 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing Unload UI test until fixed.creis@chromium.org2010-03-171-1/+4
| | | | | | | | | | TBR=stuartmorgan BUG=34827 TEST=UnloadTest.CrossSiteInfiniteUnloadAsyncInputEvent Review URL: http://codereview.chromium.org/1000009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41859 0039d316-1c4b-4281-b951-d872f2087c98
* Change observer expectationsskrul@chromium.org2010-03-172-24/+44
| | | | | | | | This should prevent some test flakyness we saw on vista. Review URL: http://codereview.chromium.org/977003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41857 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix menu display logic for people with top/down xinerama setups.thestig@chromium.org2010-03-171-7/+9
| | | | | | | | BUG=14184 TEST=see bug Review URL: http://codereview.chromium.org/1026006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41855 0039d316-1c4b-4281-b951-d872f2087c98
* Initial support for inspecting extension popups.rafaelw@chromium.org2010-03-1722-555/+455
| | | | | | | | | | | | | | | | | | The primary change in this CL is a refactor which makes ExtensionPopup a bit more self-contained WRT its clients. It adds the ability to specify an "inspect_with_devtools" flag to its Show() method which will cause the popup to remain open regardless of losing focus and to focus a devtools window on the popup's render view host. This CL also pulls apart some aspects of the extension_popup_api from ExtensionFunctionDispatcher and ExtensionHost. Still remaining to be done are: 1) Also the popup to stay open when the host window drags (it current closes) 2) Support for GTK 3) Support for Mac BUG=24477 Review URL: http://codereview.chromium.org/1001002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41854 0039d316-1c4b-4281-b951-d872f2087c98
* Adding debugging switches to Worker process startup on POSIX systems.dimich@chromium.org2010-03-171-5/+21
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1023005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41852 0039d316-1c4b-4281-b951-d872f2087c98
* Add chromium-side support for history.{push,replace}State.darin@chromium.org2010-03-173-9/+41
| | | | | | | | | | | | | | | | | | | | | | Enables the feature so that all but 2 of the related layout tests pass. Modifies TestShell to correctly update its location bar as navigations occur. It was incorrectly showing firstPartyForCookies for some crazy reason. Modifies glue_serialize.cc to store the state object associated with a session history entry. Modifies navigation_controller.cc to always replace the current navigation entry when observing an in-page navigation. This is required since the page ID isn't changing for an in-page navigation. BUG=29393 R=brettw TEST=covered by layout tests Review URL: http://codereview.chromium.org/1036003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41850 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Match popup contents to page zoom size.thakis@chromium.org2010-03-175-1/+7
| | | | | | | | | | | | | | | | | | Fix the size of the font used in popups presented by the browser UI thread. WebKit was modified to add a field containing the font size, the font size is then propagated in the message sent to the browser, and the web menu runner sets that font size on the popup button resonsible for running the popup menu. Requires WebKit release >= 55897. See WebKit bug https://bugs.webkit.org/show_bug.cgi?id=35990 BUG=14010 TEST=none Review URL: http://codereview.chromium.org/996001 Patch from scottbyer@chromium.org. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41845 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a timeout issue in RenderWidgetHost.creis@chromium.org2010-03-173-12/+97
| | | | | | | | | | | | | | | Before, each call to StartHangMonitorTimeout would reset the timer, possibly postponing it indefinitely. BUG=11007 BUG=16535 TEST=RenderWidgetHostTest.DontPostponeHangMonitorTimeout TEST=RenderWidgetHostTest.StopAndStartHangMonitorTimeout TEST=UnloadTest.CrossSiteInfiniteUnloadAsyncInputEvent Review URL: http://codereview.chromium.org/1034001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41844 0039d316-1c4b-4281-b951-d872f2087c98
* Add a lock to read |state_| in UIModelWorker::DoWorkAndWait. We don'ttim@chromium.org2010-03-172-8/+8
| | | | | | | | | | | | | | | strictly need to acquire the lock here because this can only get called while !syncapi_has_shutdown_ and STOPPED could only get set after that bool is false (and that bool is protected by locks), the purpose of this DCHECK/return is for catching developer error in extraordinary cases, so in a way, adding ANNOTATE_UNPROTECTED_READ would seem hypocritical. BUG=32892 TEST=UIModelWorkerTest Review URL: http://codereview.chromium.org/965002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41840 0039d316-1c4b-4281-b951-d872f2087c98
* Drop a comment that's no longer valid.avi@chromium.org2010-03-171-4/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1002005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41836 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Remove the internal timeout of extension browser tests.phajdan.jr@chromium.org2010-03-171-26/+5
| | | | | | | | | | | | | | | Now we have a global timeout for browser tests enforced by out of process test launcher. Having too many different timeouts all over the place makes debugging issues harder. TEST=browser_tests BUG=none Review URL: http://codereview.chromium.org/1046001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41823 0039d316-1c4b-4281-b951-d872f2087c98
* Add more sync calls to try to make the FileWatcher test nottony@chromium.org2010-03-171-2/+2
| | | | | | | | | | flaky on OSX. BUG=38188 Review URL: http://codereview.chromium.org/1045004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41819 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor WebSocket throttling feature.ukai@chromium.org2010-03-171-1/+0
| | | | | | | | | Protocol specific handling should be done in SocketStreamJob subclasss, so websocket throttling should be handled in WebSocketJob. Review URL: http://codereview.chromium.org/669157 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41818 0039d316-1c4b-4281-b951-d872f2087c98
* fixing bustage... file was movedben@chromium.org2010-03-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41814 0039d316-1c4b-4281-b951-d872f2087c98
* forgot a couple of files... moved gfx stuff to toplevel dirben@chromium.org2010-03-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41813 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-17142-152/+150
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41790 - Removed auth_task.* and talk_auth_task.* (dead code) because ↵hbono@google.com2010-03-1721-18/+1436
| | | | | | | | | | | | | | | | | | Windows XP doesn't have inet_pton and it crashes XP bots. Removed GaiaAuth class. Gtalk login will now fail immediately instead of trying (in vain) to gaiaauth. Removed nowunneeded parameters. BUG=38034 TEST=manual with and without invalidatesyncxmpplogin Review URL: http://codereview.chromium.org/885008 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/983005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41808 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at adding Extension Infobars to the experimental API.finnur@chromium.org2010-03-1718-21/+527
| | | | | | | | | | | | | | | | | | | | | | | | | | | Originally described here: http://code.google.com/p/chromium/wiki/InfoBarExtensionAPI The API is simple: chrome.experimental.infoBar.show( {"htmlPath": "infobar.html"}, function(window) { // |window| is where the infobar was shown. }); To close it, you can simply call window.close() from within the InfoBar (infoBar.hide is not provided). The api is privileged (not available to content scripts directly). The minimum height for the infobar is regular height for our infobars (32 pixels), maximum is twice that and the actual size is determined by the content (within these constraints mentioned). See screenshot in bug. The icon on the far left is an extension icon with a dropdown menu showing the menu that shows when you right-click on the extension icon in the Omnibox/browser action container. BUG=26463 TEST=None (for now). Review URL: http://codereview.chromium.org/1049001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41806 0039d316-1c4b-4281-b951-d872f2087c98
* Don't keep a pointer to NaClBrokerHost in NaClBrokerService - use ↵gregoryd@google.com2010-03-175-64/+29
| | | | | | | | | | | | ChildProcessHost::Iterator instead. This change fixes the crash that occured if the browser was closed while the NaCl module was still running (found by nacl_ui_tests). Also make nacl_ui_tests depend on nacl win64 binary (required to run the tests on Win64) BUG=none TEST=nacl_ui_tests Review URL: http://codereview.chromium.org/875005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41804 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromeos buildestade@chromium.org2010-03-172-2/+9
| | | | | | | | | BUG=none TEST=build works again Review URL: http://codereview.chromium.org/1051002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41803 0039d316-1c4b-4281-b951-d872f2087c98
* * Moved sticky/controls frag to chromeos::BalloonViewImploshima@chromium.org2010-03-1729-233/+491
| | | | | | | | | | | | | | * Added AddSystemNotification to add system notification and UpdateNotification to update a notification. * refactored NotificationObjectProxy and added NotificationDelegate class. * Added notification_browser.cc. BUG=33306 TEST=added notification_browser.cc with minimal test. I'll add more in next step. Review URL: http://codereview.chromium.org/1013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41801 0039d316-1c4b-4281-b951-d872f2087c98
* Add a pref for the number of showing icons in the browser actions toolbar.estade@chromium.org2010-03-178-31/+66
| | | | | | | | | | | | | | | Also fix some issues on GTK concerning the proper behavior when adding/removing browser actions (container sizing + chevron visibility). Windows uses a different pref (kBrowserActionContainerWidth), which is measured in pixels; it should be migrated to the new pref. Also, register extension prefs during startup. BUG=32101 TEST=manual Review URL: http://codereview.chromium.org/841007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41800 0039d316-1c4b-4281-b951-d872f2087c98
* Basic DragImage implementation.estade@chromium.org2010-03-1719-24/+108
| | | | | | | | | | | | | | | Only the chromium part is for review. The webkit part shows how that will look when I create the patch for webkit later. This can be landed without the change to webkit. TODO later: - use the image on windows, mac - implement the other DragImageRef functions TEST=drag an image from the render view in GTK BUG=11457 Review URL: http://codereview.chromium.org/668125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41799 0039d316-1c4b-4281-b951-d872f2087c98
* More AutoFill heuristics fixes.jhawkins@chromium.org2010-03-171-37/+29
| | | | | | | | | | | | * Match addr1, addr2 for Address Line 1/2. * Match pcode for postal/zip code. * Fix the termination condition for the address matching loop. BUG=none TEST=none Review URL: http://codereview.chromium.org/1006004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41798 0039d316-1c4b-4281-b951-d872f2087c98
* Add a DOMUI datasource that will handle the net-internals page.eroman@chromium.org2010-03-175-0/+401
| | | | | | | | | | | | | | | Right now it is bound to the temporary URL "chrome://net2", since the frontend is under construction. (Loading this page right now just shows a dummy HTML page.) This change is a first step to transitioning the about:net-internals / about:network pages from C++ to javascript. Note that the network stuff needs to run on the IO thread, however the DOMUI infrastructure is all set up to run on the UI thread. I work around this by proxying things back and forth through the IO thread. Hopefully in subsequent iterations this overhead can be removed, by exposing a sort of "IO thread DOMUI". BUG=37421 Review URL: http://codereview.chromium.org/1036001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41791 0039d316-1c4b-4281-b951-d872f2087c98
* Removed auth_task.* and talk_auth_task.* (dead code)akalin@chromium.org2010-03-1721-1436/+18
| | | | | | | | | | | | | Removed GaiaAuth class. Gtalk login will now fail immediately instead of trying (in vain) to gaia-auth. Removed now-unneeded parameters. BUG=38034 TEST=manual with and without --invalidate-sync-xmpp-login Review URL: http://codereview.chromium.org/885008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41790 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when a moust observer got a mouse event on a wnidow that has ↵oshima@chromium.org2010-03-171-2/+3
| | | | | | | | | | | | already been destroyed. BUG=chromium-os:1697 TEST=manual: switch to compact nav bar mode (ctrl-shift-c), move mouse to a tab to open compact location bar, then open app launcher. Type in something in the address bar and select from suggestion list. Review URL: http://codereview.chromium.org/1048003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41788 0039d316-1c4b-4281-b951-d872f2087c98
* Spruced up the warning dialog for when you enable an extension in incognito.mpcomplete@chromium.org2010-03-178-85/+128
| | | | | | | | | | | I hijacked the extension install/uninstall dialog, and added another type that it can transmogrify into. BUG=32365 Review URL: http://codereview.chromium.org/1041002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41787 0039d316-1c4b-4281-b951-d872f2087c98
* Finish porting FindInPageControllerTest to linux.estade@chromium.org2010-03-165-50/+62
| | | | | | | | | BUG=37809,268629 TEST=test passes Review URL: http://codereview.chromium.org/997004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41782 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes first and third points in the bug "Autofill profile dialog box polish ↵georgey@chromium.org2010-03-169-77/+124
| | | | | | | | | | | | | items". Adds correct expand icons to the AutoFill dialog. The icons were added in a separate CL. Moves asynchronous access to the database inside the dialog (it now shows "Loading..." while db is being connected) Also fixes memory leak. BUG=36601 TEST=in the bug Review URL: http://codereview.chromium.org/669076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41780 0039d316-1c4b-4281-b951-d872f2087c98
* Remove eval/new Function from file browser.arv@chromium.org2010-03-161-27/+63
| | | | | | Review URL: http://codereview.chromium.org/969005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41779 0039d316-1c4b-4281-b951-d872f2087c98
* This patch strips out the http auth credentials before storing it in History DB.inferno@chromium.org2010-03-164-6/+32
| | | | | | | | BUG=20318 TEST=Visit a url having auth credentials. Check history db to see url stored without credentials. Review URL: http://codereview.chromium.org/1012001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41773 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple more drop targets to the render view.estade@chromium.org2010-03-161-0/+16
| | | | | | | | | BUG=35063 TEST=see bug Review URL: http://codereview.chromium.org/1030001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41772 0039d316-1c4b-4281-b951-d872f2087c98
* Changing filebrowse html to delete pause when file is finished.dhg@chromium.org2010-03-162-3/+11
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/845003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41770 0039d316-1c4b-4281-b951-d872f2087c98
* Move over another legacy "LoadLog-style" event generator to routing its ↵eroman@chromium.org2010-03-165-5/+68
| | | | | | | | | | messages through the NetLog. BUG=37421 Review URL: http://codereview.chromium.org/1052002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41768 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes changing the size of the icon on hover, and instead changessky@chromium.org2010-03-161-13/+10
| | | | | | | | | | | | the size of the icon when the tab is in the background and the title changes. BUG=37333 TEST=none Review URL: http://codereview.chromium.org/974003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41767 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Load the imported form data into the AutoFill dialog when the user ↵jhawkins@chromium.org2010-03-166-11/+77
| | | | | | | | | | accepts the AutoFill InfoBar. Save a one-time initial profile to the WebDB if the user dismisses the InfoBar or the InfoBar closes. BUG=38104,38096 TEST=AutoFillInfoBarDelegateTest Review URL: http://codereview.chromium.org/974004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41765 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 2 issues with incognito extensions on linux:mpcomplete@chromium.org2010-03-162-4/+9
| | | | | | | | | | - Drag and drop of browser actions wouldn't work properly from an incognito window. - Installing an extension from an incognito window raised a DCHECK. Review URL: http://codereview.chromium.org/983004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41764 0039d316-1c4b-4281-b951-d872f2087c98
* Split up PreXmppAuth and SaslHandler.akalin@chromium.org2010-03-165-72/+55
| | | | | | | | | | | Created a X-GOOGLE-TOKEN-only SaslHandler class for use by sync. BUG=38034 TEST=manual Review URL: http://codereview.chromium.org/904006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41761 0039d316-1c4b-4281-b951-d872f2087c98
* Unify LocalStrings.arv@chromium.org2010-03-165-35/+54
| | | | | | | | | | | The main difference is that we are now using $1 - $9 instead of %s. This is more consistent with the C++ code as well. BUG=None TEST=None Review URL: http://codereview.chromium.org/1045003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41760 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] First run dialog cleanupthomasvl@chromium.org2010-03-162-20/+148
| | | | | | | | | | | | | | | | - coding style fixes for ivars - fixed some 10.6 toolchain warnings from the xib - provide custom getters for two properties to always return false when the matching controls are hidden. - Autosize the window to handle any possible l10n now - Make headers, buttons, and all by the stats/breakpad checkbox force the window to grow as needed. - Wrap the stats/breakpad checkbox to the resulting width (it will never fit otherwise). - Layout/shuffling things based on the views that get hidden (no other browsers to import from, not stats pref). BUG=37743 TEST=text isn't clipped in any language Review URL: http://codereview.chromium.org/995002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41758 0039d316-1c4b-4281-b951-d872f2087c98
* Obj-C readability review for thakis.thakis@chromium.org2010-03-163-19/+23
| | | | | | Review URL: http://codereview.chromium.org/790006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41753 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Use the default favicon until chrome://favicon/ works for ↵arv@chromium.org2010-03-161-2/+6
| | | | | | | | | | | extensions. BUG=None TEST=None Review URL: http://codereview.chromium.org/898004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41749 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bubbles (bookmark, status, blocked content, both extension ones) in ↵avi@chromium.org2010-03-167-36/+51
| | | | | | | | | | | resolution independence. BUG=http://crbug.com/19476, http://crbug.com/36366 TEST=click the star in RI and the bubble should position itself correctly; status bubble should have adequate height for text Review URL: http://codereview.chromium.org/851009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41748 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 41739 - Factoring duplicate code from platformspecific LoginHandlers ↵erg@chromium.org2010-03-165-305/+618
| | | | | | | | | | | | | | | | | | | | into a base LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Contributed by tonyg@chromium.org BUG=14909 TEST=ui_tests gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/834001 Patch from tonyg@chromium.org. TBR=erg@chromium.org Review URL: http://codereview.chromium.org/989004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41746 0039d316-1c4b-4281-b951-d872f2087c98
* [accessibility] Bookmarks bar is missing some MSAA informationctguil@chromium.org2010-03-166-34/+65
| | | | | | | | | | | | | | | | | | | | | | | Return the link role for the Link view. Return the grouping role for BookmarkBarInstructionsView. Support the link role in views accessibility types. Updated browser views accessibility tests. - Verify BrowserRootView accessibility info. - Verify BrowserView accessibility info. - Verify BookmarkBarView accessibility info. - In TestViewAccessibilityObject don't SetAccessible name, we should be testing that this name is correctly set. Set the accessible name for the application in BrowserRootView instead of OpaqueBrowserFrameView BUG=36281 TEST=Verify bookmarks bar tree in AccExplorer32.exe Review URL: http://codereview.chromium.org/652156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41744 0039d316-1c4b-4281-b951-d872f2087c98
* Refine IPv6 probe to require that the client has an IPv6 address on an interfacejar@chromium.org2010-03-161-28/+33
| | | | | | | | | | | | | | | | | | | | This currently only works on Posix, not windows. Network changes are monitored, and the test is repeated each time interfaces change (which is a subset of any IP addresses changing). The test performed is performed on a worker thread, so latency should not be an issue (even if we created much slower tests). The current test appears to takes in the raneg of 50-100ms, and probably (under the covers) does some reading from files). BUG=25680 BUG=12754 r=wtc,eroman Review URL: http://codereview.chromium.org/1006001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41743 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring duplicate code from platform-specific LoginHandlers into a baseerg@chromium.org2010-03-165-618/+305
| | | | | | | | | | | | | | | LoginHandler class. As pointed out by erg, it would be cleaner to use a separate controller class, but this simple refactor should make that easier. Contributed by tonyg@chromium.org BUG=14909 TEST=ui_tests --gtest_filter=LoginPromptTest* Review URL: http://codereview.chromium.org/834001 Patch from tonyg@chromium.org. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41739 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 12:10:46 +0000