summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Refactor extension bindings to share code, avoid exposing hidden variablesmpcomplete@chromium.org2009-06-301-4/+4
| | | | | | | | | | | | | | | | | globally, and avoid using the DOM load/unload events. - moved callback handling into event_bindings.js (ports will use it). - added chromeHidden, a V8 hidden value, to keep all internal variables that need to be accessible to native code. - changed context registration to occur always at extension load, instead of DOM load. - added an internal unload event that doesn't disable SuddenTermination. This is a rework of my earlier CL http://codereview.chromium.org/125280 which was reverted because of a perf regression. I believe the perf problem was caused by the call into javascript I did on page load to handle context registration - this CL avoids that. Review URL: http://codereview.chromium.org/147033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19634 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for shared memory when retrieving the backing store as a SkBitmap.brettw@chromium.org2009-06-301-13/+71
| | | | | | | | In my testing, this speeds it up 2-3x. Review URL: http://codereview.chromium.org/150032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19633 0039d316-1c4b-4281-b951-d872f2087c98
* Update the browser window's shape on state change.estade@chromium.org2009-06-302-3/+15
| | | | | | | | | | | | | When launching the browser we restore the maximized state. However, the maximize call is asynchronous, so we don't actually observe the change to |state_| until later. So we need to update the shape on that later state-changed signal. Usually if the user maximizes the window, it will change sizes. To avoid setting the window's shape more often than necessary, cache its current state (custom shape or no custom shape). BUG=none TEST=maximize the window, close chrome, re open chrome. It should not have a custom shape. Review URL: http://codereview.chromium.org/150081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19625 0039d316-1c4b-4281-b951-d872f2087c98
* Add a skeleton UI for the gtk task manager.jhawkins@chromium.org2009-06-304-15/+186
| | | | | | | | BUG=11392 TEST=Right-click on the tabstrip and select 'Task Manager'. Review URL: http://codereview.chromium.org/150082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19619 0039d316-1c4b-4281-b951-d872f2087c98
* This CL removes the last (major) Windows specific part out of the focus ↵jcampan@chromium.org2009-06-3028-104/+92
| | | | | | | | | | | | | | | | | | | | | | | manager. It was previously landed and reverted because it broke the reliability tests. http://codereview.chromium.org/125148 The breakage was caused by constrained windows not getting a hold of the FocusManager when in unparented tabs. The fix is to ensure unparented tab still have a way to access their FocusManager for proper closure. Files changed from the previous patch that need reviewing: native_tab_contents_container_win.cc tab_contents_view_win.h tab_contents_view_win.cc BUG=None TEST=Run all tests (unit, ui, interactive). Extensively test the focus in Chrome. Review URL: http://codereview.chromium.org/146093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19617 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity was complaining about the result of getenv not being null checked, ↵finnur@chromium.org2009-06-301-40/+25
| | | | | | | | | | | but when I look at the code and confer with mal it looks like the offending code can just be removed (and some de-linting applied). BUG=None TEST=None (report a bug dialog should work as before). Review URL: http://codereview.chromium.org/151069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19612 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity nit. Enums lacking name...finnur@chromium.org2009-06-301-2/+2
| | | | | | | | | BUG=None TEST=No need for one. Review URL: http://codereview.chromium.org/151056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19611 0039d316-1c4b-4281-b951-d872f2087c98
* Fix potential memleak in AddPagesWithDetails. Not a biggie finnur@chromium.org2009-06-301-4/+4
| | | | | | | | | | | | | | | since this is used only during testing, if the comment is correct. The reason this leaks is due to potential returns before Broadcast is reached. BUG=None TEST=None Review URL: http://codereview.chromium.org/151047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19610 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memleak in GetNodeDictionary.finnur@chromium.org2009-06-301-19/+18
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/151041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19609 0039d316-1c4b-4281-b951-d872f2087c98
* Disable new test DevToolsSanityTest.TestEnableResourcesTab until Yuri fixes itdkegel@google.com2009-06-301-1/+1
| | | | | | | | | BUG=http://crbug.com/15677 TEST=none Review URL: http://codereview.chromium.org/150115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19606 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 19593.glen@chromium.org2009-06-302-32/+33
| | | | | | Review URL: http://codereview.chromium.org/150112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19603 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at fixing BrowserThemeProvider memory leaks.tc@google.com2009-06-302-16/+11
| | | | | | | | | This time, don't delete images in generated_images_ since we're now going to delete them in image_cache_. Review URL: http://codereview.chromium.org/151048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19601 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we were getting a resize cursor near the top of the webtc@google.com2009-06-301-2/+9
| | | | | | | | | | | | | contents area. Fix a bug where the background color was not updated on theme change. BUG=14956 Review URL: http://codereview.chromium.org/151063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19599 0039d316-1c4b-4281-b951-d872f2087c98
* Disable new test DevToolsSanityTest.TestEnableScriptsTab until Yuri fixes itdkegel@google.com2009-06-301-1/+1
| | | | | | | | BUG=http://crbug.com/15677 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19597 0039d316-1c4b-4281-b951-d872f2087c98
* Create A/B test of SDCHjar@chromium.org2009-06-305-17/+41
| | | | | | | | | | | | | | | | | | | | | To do this, I needed to add the feature that ALL FieldTrials that are established in the browser process are forwarded and established in the corresponding renderer processes. This then allows both DNS impact, as well as SDCH inmpact (and any other field tests) to be studied at the same time in a single binary. This checkin also establishes a pattern that when we're doing A/B tests via a histogram such as RequestToFinish, that we produce names for all groups, rather than leaving one group as the "default" or "empty postfix" group. This is critical for naming various sub-groups when a multitude of tests are taking place at the same time. BUG=15479 r=mbelshe Review URL: http://codereview.chromium.org/150087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19595 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes issue where dragging a .crx to a chrome:// TabContents, and then ↵rafaelw@chromium.org2009-06-304-6/+62
| | | | | | | | | | | navigating to another chrome:// url, the destination DOMUI won't be able to retrieve the data it needs (and thus not function) BUG=14505 R=brettw Review URL: http://codereview.chromium.org/132009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19594 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the NNTP by default.arv@google.com2009-06-302-33/+32
| | | | | | | | | | | | | | | | | This renames the command line flags a bit. --new-tab-page=path/to/file.html --old-new-tab-page BUG=13362 TEST=Launch chrome and you should see the new new tab page. Review URL: http://codereview.chromium.org/151054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19593 0039d316-1c4b-4281-b951-d872f2087c98
* Reland of r19131, this time with real Math:glen@chromium.org2009-06-301-6/+14
| | | | | | | | | | | | | | | PNGDecoder wasn't multiplying the alpha like PNGEncoder was. This lead to color overflow. This intermediate fix makes everything correct, but will make alphaed pixels slightly darker until the user's cache is flushed (I have screenshots of the effect). BUG=13360 TEST=Run base_unittests.exe --gtest_filter=*PNG* Review URL: http://codereview.chromium.org/150107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19589 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for pressing escape during a drag and drop operation.arv@google.com2009-06-302-0/+9
| | | | | | | BUG=12018 Review URL: http://codereview.chromium.org/149038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19588 0039d316-1c4b-4281-b951-d872f2087c98
* Add some limits to incoming audio stream requests to avoid allocating massivecevans@chromium.org2009-06-301-0/+12
| | | | | | | | | | | buffers. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/147236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19586 0039d316-1c4b-4281-b951-d872f2087c98
* Enable support for the Mac OS X spellchecking service in chromium.pinkerton@chromium.org2009-06-308-36/+679
| | | | | | | | | | | | | | | | | | | | spellchecker_platform_engine.h provides a basic interface for platform specific spellcheckers to follow. spellchecker_mac.mm implements these functions for the OS X spellchecking service. spellchecker_win.cc and spellchecker_linux.cc provide a space for future developments on these platforms. spellchecker_common.h contains a few shared variables and typedefs that are useful across all spellchecking code. spellchecker.cc has been modified to call the SpellCheckerPlatform::SpellCheckerAvailable() and use either hunspell or the platform spellchecker based on that call. Many new test cases have been added to one of the unit tests as well. chrome.gyp has been edited to reflect the added files. patch from pwicks86@gmail.com (paul wicks) BUG=13206 TEST=spellchecking works in web pages git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19585 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: add tests that opens Scripts panel and checks that it's populated ↵yurys@google.com2009-06-301-0/+6
| | | | | | | | with two inspected scripts. Review URL: http://codereview.chromium.org/151076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19583 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Linux location bar SSL icon padding match Windows.deanm@chromium.org2009-06-301-2/+2
| | | | | | | | | The EV padding might also need adjustment later. Review URL: http://codereview.chromium.org/151073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19580 0039d316-1c4b-4281-b951-d872f2087c98
* GTK custom frame: Don't show the border when maximized. Enlarge the close ↵estade@chromium.org2009-06-304-9/+33
| | | | | | | | | | | button's clickable area when maximized. BUG= http://crbug.com/14646 and http://crbug.com/15628 TEST=maximize, turn on custom frame. The top right most pixel on the screen should be clickable and should close the window. There should be no border around the web contents. Review URL: http://codereview.chromium.org/150078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19567 0039d316-1c4b-4281-b951-d872f2087c98
* Enable "Save As" on Mac.paul@chromium.org2009-06-302-6/+0
| | | | | | | | | TEST=Right clicking an image and choosing "Save As" now works. BUG=15638 Review URL: http://codereview.chromium.org/151042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19565 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: build fix for release builder.agl@chromium.org2009-06-301-2/+1
| | | | | | | | r19500 triggered an error in the crash dumping code because of a duplicate \#define. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19562 0039d316-1c4b-4281-b951-d872f2087c98
* Mac fullscreen mode (with pkasting).jrg@chromium.org2009-06-2912-52/+320
| | | | | | | | | | | | | | | | | | | | | | | TEST=Launch Chrome. Create a 2nd tab. Close bookmark bar. Cmd-F11 to enter fullscreen; make sure content is centered and both bookmark bar and toolbar are gone. Make sure menubar gone. Cmd-Opt-arrows to switch tabs; make sure still OK. Cmd-F11 to go back; make sure things look normal. Open bookmark bar. Cmd-F11; make sure gone. Cmd-F11 again; make sure it comes back. Confirm View-->Fullscreen menu item works. While in fullscreen, Cmd-T to create new tab and click on a fav tile. Make sure page loads. While in fullscreen, try window hotkeys (Cmd-N and Cmd-W) to make sure they work. Cmd-` to switch windows; switch back, then Cmd-F11 to undo fullscreen. Move the mouse to to the top of the screen; make sure menubar appears. Move the mouse down; make sure menubar goes away. Review URL: http://codereview.chromium.org/126294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19559 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in delayed tab resizing. If the Resize Relayout code is called ↵ben@chromium.org2009-06-291-0/+6
| | | | | | | | | | | after the last tab has been closed but before the window is destroyed (this whole process is very async) there are zero tabs in the layout and as a result GetTabAt(0) will crash. http://crbug.com/14603 TEST=none Review URL: http://codereview.chromium.org/150064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19557 0039d316-1c4b-4281-b951-d872f2087c98
* Take two for http://codereview.chromium.org/131094tim@chromium.org2009-06-2920-165/+217
| | | | | | | | This time without browser_tests timeout that caused the revert. The problem was BrowsingHistoryHandler trying to use a dom_ui_ before being attached. Review URL: http://codereview.chromium.org/149117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19556 0039d316-1c4b-4281-b951-d872f2087c98
* More web contents dragging.estade@chromium.org2009-06-2913-128/+224
| | | | | | | | TEST=drag an image (such as the google logo from google.com) into gimp or onto the desktop. BUG=http://crbug.com/15429 Review URL: http://codereview.chromium.org/151033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19553 0039d316-1c4b-4281-b951-d872f2087c98
* Make tabstrip flush with top of titlebar when custom frame is enabled and ↵estade@chromium.org2009-06-292-4/+21
| | | | | | | | | | | browser is maximized. TEST=maximize and enable custom frame BUG=http://crbug.com/15431 Review URL: http://codereview.chromium.org/150072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19551 0039d316-1c4b-4281-b951-d872f2087c98
* a few minor tweaks the bookmarks API:erikkay@google.com2009-06-294-11/+35
| | | | | | | | | | | | | | | | * change name "childrenIds" to "children" * add dateAdded and dateGroupModified properties * add id to onRemoved BUG=13994 BUG=14581 BUG=12217 TEST=load sample bookmarks extension and play around with Dump Bookmarks Review URL: http://codereview.chromium.org/151032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19536 0039d316-1c4b-4281-b951-d872f2087c98
* Corrects RWHVCocoa to convert from flipped to unflippedrohitrao@chromium.org2009-06-291-11/+34
| | | | | | | | | | coordinates before whiting out unpainted areas. BUG=None TEST=Resize newly-created window, check for black areas. Review URL: http://codereview.chromium.org/147232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19535 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory leak in tips handler.finnur@chromium.org2009-06-291-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/150052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19533 0039d316-1c4b-4281-b951-d872f2087c98
* Deletes now-unused growbox code.rohitrao@chromium.org2009-06-293-162/+0
| | | | | | | BUG=None TEST=None. No visible impact. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19531 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo in a comment.ericroman@google.com2009-06-291-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/151037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19524 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extension extensions to be case-insensitive.avi@chromium.org2009-06-291-22/+5
| | | | | | | | | BUG=none TEST=try to load an extension with a capital letter or two in the extension's extension. It should load. Review URL: http://codereview.chromium.org/147017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19520 0039d316-1c4b-4281-b951-d872f2087c98
* Don't shutdown non-popup render views on clicks outside their bounds.estade@chromium.org2009-06-291-1/+5
| | | | | | Review URL: http://codereview.chromium.org/151031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19514 0039d316-1c4b-4281-b951-d872f2087c98
* Add three basic test items to RenderViewHostManagerTest:brettw@chromium.org2009-06-291-0/+134
| | | | | | | | | | | - Init - Navigate - DOMUI Original review: http://codereview.chromium.org/126060 Patch by tyoshino@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19513 0039d316-1c4b-4281-b951-d872f2087c98
* Remove --enable-web-workers command-line switch.dimich@google.com2009-06-291-1/+0
| | | | | | | | BUG=4361 TEST=many ui/layout tests. Review URL: http://codereview.chromium.org/149114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19512 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where all clicks in app mode windows would result in a window move.tc@google.com2009-06-291-4/+10
| | | | | | | | | | | Also update the comment to properly describe the code. It was referring to the tab strip, but the code was using the toolbar. BUG=15576 Review URL: http://codereview.chromium.org/150037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19511 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Drags from bookmark menus to the bookmark bar.erg@google.com2009-06-296-130/+244
| | | | | | Review URL: http://codereview.chromium.org/147241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19505 0039d316-1c4b-4281-b951-d872f2087c98
* update dnd registry enum to work properly with bitmaskestade@chromium.org2009-06-291-4/+4
| | | | | | | | TBR=erg Review URL: http://codereview.chromium.org/150033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19503 0039d316-1c4b-4281-b951-d872f2087c98
* Removes our homespun grow box and replaces it with therohitrao@chromium.org2009-06-296-72/+32
| | | | | | | | | | | standard widget. This may also fix some of our resizing issues. BUG=http://crbug.com/14663 TEST=The resizer widget should still work as expected. Review URL: http://codereview.chromium.org/149094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19501 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member view_ to NULL in constructor.finnur@chromium.org2009-06-291-1/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/150028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19499 0039d316-1c4b-4281-b951-d872f2087c98
* Two fixes for tab dragging in gtk:jhawkins@chromium.org2009-06-292-2/+10
| | | | | | | | | | | * Check that backing_store_ is non-NULL before using it. A drag can be initiated before the backing store has been created. * Don't read a size greater than the size of the backing store image. BUG=15387 TEST=Hard to reproduce. Quickly initiate a tab drag after opening a new tab. Review URL: http://codereview.chromium.org/150008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19496 0039d316-1c4b-4281-b951-d872f2087c98
* GTK DND:estade@chromium.org2009-06-299-79/+146
| | | | | | | | | | | | | | - Rearrange DND constants, create convenience functions - (partially) implement drag onto home button Note that the homepage is still hard-wired to the dev build splash page, so that it seems like this isn't working, but via debugging I ascertained that dragging a random file from the desktop onto the home button should successfully set that file as the homepage. TEST=drag a lot of stuff all over the place (tabs, bookmarks, what have you), make sure nothing crashes BUG=none Review URL: http://codereview.chromium.org/147256 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19495 0039d316-1c4b-4281-b951-d872f2087c98
* Let RenderProcessHost provide a method HasConnection() instead of exposingbrettw@chromium.org2009-06-2912-17/+41
| | | | | | | | | | | | | | | | | | | | | | | | channel(). Motivation: Currently, components that are using RenderProcessHost are checking its liveness by null testing on channel(). I'd like to write unittests for those components, but to mock out RenderProcessHost instances, I have to also mock out the instance returned by RenderProcessHost::channel(), but there's no interface class prepared. SyncChannel is directly used in RenderProcessHost. Instead of dependency injection, I can let mock objects return invalid pointer such as 0x1, but its bad test design. Rather than that, I'd like to introduce HasConnection() method and override it to return true. In fact, most of those components are not accessing channel()'s methods directry. They're just checking channel() is null or not, and to issue IPCs, they are calling Send method. So, it's OK to hide channel pointer from users, I think. Original review: http://codereview.chromium.org/147077 Patch by tyoshino@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19493 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up the create browser window.sky@chromium.org2009-06-293-4/+8
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/151026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19492 0039d316-1c4b-4281-b951-d872f2087c98
* Replace DeleteSoon with PostTask(DeleteTask) in browser_window_gtk for ↵pfeldman@chromium.org2009-06-291-1/+5
| | | | | | | | | | | | browser to be closed while in ui tests. DevToolsSanityTests are running various scenarios including the ones that are waiting for browser to be closed. Tests are closing all the tabs in the browser and are running nested message loop until the BROWSER_CLOSE message arrives. The browser close logic on Linux was using DeleteSoon on the window object, but DeleteSoon was never executed since the task was non-nestable. This change simply posts DeleteTask instead of DeleteSoon and hence browser close logic is working fine on a nested loop. Review URL: http://codereview.chromium.org/151020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19487 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 06:33:58 +0000