| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
BUG=55918
Review URL: http://codereview.chromium.org/3595004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Split the arbitrator into a class that handles the threading and a class that handles location provider arbitration. Changed unit tests and MockLocationProvider to work with this new model.
BUG=None
TEST= --gtest_filter=*Geolo*
Review URL: http://codereview.chromium.org/3548008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3582005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
AccessibilityEventRouterGtk::RemoveRootWidget via reference counting,
which stops ExtensionApiTest, FLAKY_Tabs from crashing on chromeos.
BUG=56479
TEST=ExtensionApiTest.FLAKY_Tabs no longer crashes, and added new AccessibilityEventRouterGtkTest.
Review URL: http://codereview.chromium.org/3382025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
squished.
The progress animation was showing up squished vertically to about 10 pixels on linux, and to
fix that we now create bitmaps with the proper colour depth ourselves and draw the animation
frames onto it instead of using the built-in method.
BUG=53598
TEST=manual, test that the speech recognition progress animation shows up as expected and not squished.
Review URL: http://codereview.chromium.org/3576006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crosbug.com/7010 http://crosbug.com/3062
TEST=Manual
Review URL: http://codereview.chromium.org/3610001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7100
TEST=Boot device. On "Select network" screen click on the network
selection combo box. The networks menu that will appear has the same
width as combo box itself.
Review URL: http://codereview.chromium.org/3586005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=michaeln
BUG=46601
TEST=ExtensionApiTest.FLAKY_Popup no longer runs
Review URL: http://codereview.chromium.org/3603003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3432033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The operator<< for url_parse::Component needs to be declared
in the same namespace as its parameter type, in this case url_parse.
Otherwise Clang fails to compile this because it is more strict on the Standard.
See http://clang.llvm.org/compatibility.html#dep_lookup for more info.
BUG=none
TEST=unit_tests
Review URL: http://codereview.chromium.org/3575002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The operator<< for webkit_glue::FormData needs to be declared
in the same namespace as its parameter type, in this case webkit_glue.
Otherwise Clang fails to compile this because it is more strict on the Standard.
See http://clang.llvm.org/compatibility.html#dep_lookup for more info.
BUG=none
TEST=unit_tests
Review URL: http://codereview.chromium.org/3583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The operator<< for AutocompleteResult::const_iterator needs to be declared
in the same namespace as its parameter type, in this case the global namespace.
Otherwise Clang fails to compile this because it is more strict on the Standard.
See http://clang.llvm.org/compatibility.html#dep_lookup for more info.
BUG=none
TEST=unit_tests
Review URL: http://codereview.chromium.org/3591001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3598002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3524006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57064
TEST=manual
Review URL: http://codereview.chromium.org/3452028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
rest of Chrome. Allows plugins to have different zoom ranges, and also to update zoom on its own.
Review URL: http://codereview.chromium.org/3419023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the indicator up to the OS updater on Chrome OS.
BUG=chromium-os:6526
TEST=Connect to a dev server with a newer version, and check that the display appears.
Review URL: http://codereview.chromium.org/3607001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It seems AutomationProxyTest.AppModalDialogTest crashes because Singleton<AppModalDialogQueue>()->active_dialog() call in this function returns NULL since r60785. This change just adds a NULL check to avoid this crash.
BUG=25039,57385
TEST=make the "Linux Tests (valgrind)(1)" bot green.
Review URL: http://codereview.chromium.org/3522007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=6789
TEST=none
Review URL: http://codereview.chromium.org/3521005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61148 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
miniview correctly. Refactored to use shared routine that
is used for the other sections.
BUG=54901
TEST=Open a bunch of NTP, then a bunch of tabs to different
sites. Close all the site tabs. NTP should never show clipped
words.
TBR=arv@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
renable the check against loading the plugins on the UI/IO thread.
Review URL: http://codereview.chromium.org/3569008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The default behaviour of GtkTextView on ctrl+backspace is a little counter
intuitive. If there is selected text and the cursor is on the left edge of
the selection, then instead of removing the selected text, it removes the
word prior to the selection. So in cases where ctrl+backspace is pressed
and text is selected, treat it as a normal backspace.
BUG=18224
TEST=Type in 'goo' in the omnibox. That should autocomplete to 'google.com'.
Pressing ctrl+backspace should remove the suggested 'gle.com'.
Review URL: http://codereview.chromium.org/3446021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
this and I don't feel comfortable leaving it on trunk while
they are ironed out.
The terminology in the code is a bit schizophrenic at the
moment, so for clarity:
open = big icons showing
closed = small icons showing
hidden = no icons showing (button in bottom of tab)
1. If the apps section is hidden and an app is installed, the
apps section comes back weirdly. The content is visible, but
the header is not and the menu along the bottom of the tab
is still there.
2. Sections' open state not persisted. If you click on a
header to make a section open, then refresh, that section is
closed again.
3. If you open the most visited section, then refresh, the
most visited section will look closed. But if you hover in
the empty area in the bottom of the tab, you will get
cursor changes and status bubbles. This is probably related
to 2, above.
These aren't that hard to fix probably, but there are a few
other high priority minor fixes I need to get in for m7,
and I'm afraid of this change conflicting with them for
merges. So I'm pulling this out until one of us has time to
get back to it.
TBR=thakis@chromium.org
BUG=55148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
See image here: http://imgur.com/XdxX6
BUG=55148
TEST=Close one or more sections in NTP. Font on collapsed menus
should be the same as section headers.
Review URL: http://codereview.chromium.org/3526009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
before sending an accessibility notification.
BUG=46209
TEST=interative_ui_tests:AccessibilityWinBrowserTest.TestNotificationChildrenChanged2
Review URL: http://codereview.chromium.org/3506004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
data structure that all the different contexts have a handle to.
BUG=56558
TEST=no functional change
Review URL: http://codereview.chromium.org/3439017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WARN_UNUSED_RESULT to make it less likely that callers ignore failures.
BUG=57216
TEST=tests should still run
Review URL: http://codereview.chromium.org/3569005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderWidgetHostViewViews class to replace RenderWidgetHostViewGtk in
the case of TOUCH_UI. This change shouldn't affect non-TOUCH_UI builds
and is not yet complete for a number of event types and corner cases,
but is sufficient to get in so that work on the touch keyboard and touch
events can proceed in parallel with GTK removal.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3415005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NPAPI implementation.
These include window.open requests, hrefs with target _blank, etc.
The ChromeFrame NPAPI plugin needs to set the renderer pref which indicates that the host browser
can handle top level requests.
We also pass an additional flag in the CreateExternal tab IPC which indicates whether the host
browser supports full tab mode browsing or not. This defaults to true for IE, as the activex
implementation relies on being able to launch a new window with the attach external tab prefix.
which assumes support for full tab mode for IE being available. If the host browser does not
support full tab browsing the window.open request which comes into the ExternalTabContainer
instance creates a dummy ExternalTabContainer instance which is destroyed when the top level
navigation info is sent back to the host browser.
This CL is a short term fix for the issues with the NPAPI ChromeFrame plugin. Will do some
investigation into a better approach.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=57319
Test=Covered by existing ChromeFrame widget mode tests WidgetModeIE_SrcProperty and
WidgetModeFF_SrcProperty
Fixed incorrect assumptions in the test files used by these tests.
Bug=57319
Review URL: http://codereview.chromium.org/3549006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
closed in the case where no apps are installed.
BUG=56867
TEST=Have no apps installed. Open NTP. Hide MV section. Open
another NTP. MV section should be hidden.
Review URL: http://codereview.chromium.org/3609002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=sky
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
should request a compositing run, and timeout-wait on resize-acks as is done
in software mode.
BUG=53274
TEST=On a non-composited desktop, open a composited page, then ensure windows
put on top of the page do not leave permanent damage on the screen.
Review URL: http://codereview.chromium.org/3431023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-POD structs.
Cuts ~2MB off our .a files (Debug, Linux). Also added the "virtual" keyword on
a whole bunch of virtual dtors that were missing it.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3522004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the plugins on the UI/IO thread. Add a way for PluginList to indirectly ensure it doesn't load the plugins on the wrong thread.
BUG=57425
Review URL: http://codereview.chromium.org/3599004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61096 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements http://folder/glen/chrome/spec/101_ntp/8_wish&sidebar mocks 2, 5, 6
It's a bit lame to use a bit in the "sections" bitmask to serialize the "should show?" information, but the damage here was done when someone decided to that "THUBMS bit missing" should mean "show a list instead" (instead of adding another bit for that).
BUG=55148
TEST=Hover "Most Visited" bar. Close button should appear. Clicking it should hide "Most Visited" area and add a button at the window edge. That button should have a menu that makes it possible to make the "Most Visited" area visible again. Also do this while multiple NTPs are open; the changes made in the front NTP should be synced to the background NTPs.
Review URL: http://codereview.chromium.org/3455007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Windows screenreaders.
BUG=none
TEST=manual testing with and without JAWS and NVDA screenreaders.
Review URL: http://codereview.chromium.org/3598003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The important part is that it comes after the EXTENSION_UNLOADED
notification is sent. This makes it easier on the listeners, as they
can assume that extension notifications other than EXTENSION_UNINSTALLED
are sent for currently-installed extensions.
BUG=54415
TEST=BackgroundModeManagerTest
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60834
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60848
Review URL: http://codereview.chromium.org/3461025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
controlled by the browser.
BUG=53616
TEST=none
Review URL: http://codereview.chromium.org/3534003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
eliminates two coverity issues.
CID=12683,12686
BUG=none
TEST=Test 'under the hood' panel displays correctly when extension controls proxy prefs.
Review URL: http://codereview.chromium.org/3535001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61082 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7160
TEST=Verify fix for chromium-os:7160
Review URL: http://codereview.chromium.org/3575004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52430,52916
TEST=Enable Page Info Bubble in about:labs and click on the lock icon.
Review URL: http://codereview.chromium.org/3461016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Map it to .sh, also mark it as executable. Either one of these fixes alone would take care of this bug, but 2 fixes are better than 1!
BUG=56855
TEST=manual (see bug)
Review URL: http://codereview.chromium.org/3557003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We still append extensions to extensionless downloads, and do some extension rewriting around dangerous extensions, but don't try to be smart about renaming, e.g., .txt to .zip
BUG=57080
TEST=download_util_unittest
Review URL: http://codereview.chromium.org/3453027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tab.
Added two new filter types: "type" and "id". "Type"
specifies source type, and "id" specifies source ID.
Both only allow exact matches, and multiple values of both
can be specified ("id:5 id:6" will match source IDs 5 and
6).
Added links to the #dns/#sockets tabs to link to filters to
display all outstanding DNS requests/live sockets. The
idle and connecting socket counts also now link to source
id filters, using ids which are now passed to Javascript
along with the rest of the socket pool information.
As socket pools do not seem to maintain a list of active
sockets, the same is not yet done for active
sockets.
Also fixes a bug that resulted in handed out/connecting
socket counts being reversed in the primary socket pool
table.
BUG=56437
TEST=manual
Review URL: http://codereview.chromium.org/3436033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes Guest mode for test images.
BUG=chromium-os:6626
TEST=On test image "Skip sign-in ang go incognito" opens proper Guest mode.
Review URL: http://codereview.chromium.org/3525007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=57378
TEST=none
TBR=skerner@chromium.org
Review URL: http://codereview.chromium.org/3541006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
privilege increase checks, unique ignoring the RCD, so example.com + example.co.uk is treated as a single host. If an extension adds more international versions to its permission list it's not treated as a privilege increase. When the extension is installed initially, a smaller list of hostnames can be showed even if it's matching a large list of international domain variants.
BUG=57042
TEST=ExtensionTest.IsPrivilegeIncrease,ExtensionTest.GetDistinctHosts
Review URL: http://codereview.chromium.org/3598001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
events.
BUG=none
TEST=Added new unittest: WizardAccessibilityHandlerTest
Review URL: http://codereview.chromium.org/3223011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61062 0039d316-1c4b-4281-b951-d872f2087c98
|