| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Tie the lifetime of the GtkFloatingContainer to TabContentsContainerGtk.
Working theory is that we're leaking that reference, which is causing
the crash.
http://crbug.com/14485
Review URL: http://codereview.chromium.org/147163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderWidgetHostView[Mac] is hidden.
BUG=14178
TEST=Get a tooltip to display (hover the Inbox link in Gmail) and then pop
a new tab without using the mouse (press command-T). The tooltip should
disappear.
Review URL: http://codereview.chromium.org/149017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/146118
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in EnsureDnsPrefetchShutdown().
This is necessary because although CleanupRequestContext() is strictly before EnsureDnsPrefetchShutdown(), the URLRequestContext instances are refcounted. Therefore they may survive CleanupRequestContext(), and continue accessing the HostResolver after dns prefetcher has done teardown.
BUG=14664
Review URL: http://codereview.chromium.org/146139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=nsylvain
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/147156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
skia/ext/skia_utils_mac.h and removed chrome/browser/cocoa/cocoa_utils.h.
Patch by rsesek.
BUG=13565
http://codereview.chromium.org/131018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the prefs file, but instead reads a preferences file
(a json file called external_extensions.json).
This file specifies what external extensions we
installed (shipped with Chrome) and the extension
system takes care of installing them.
Having this in a separate file makes the upgrade
scenario easier, since we can during upgrade simply
blow away this file and replace it (and not have
to worry about merging/loosing user specified data).
The extension system will read the file, and figure
out whether any extension needs to be upgraded based
on the information provided.
Now, all external providers fetch data on the file
thread instead of reading and copying preferences on
the UI thread and posting them to the file thread.
BUG=http://crbug.com/14201
TEST=Covered by unit test.
Review URL: http://codereview.chromium.org/144018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This was causing the browser tests to create browser tests instead of a renderer processes.
Also the SSL tests now pass on Linux and have been enabled.
BUG=None
TEST=Run the browser tests on Linux.
Review URL: http://codereview.chromium.org/146057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/6781
TEST=See bug
Review URL: http://codereview.chromium.org/149010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=try loading a failing extension on the Mac; you should get some UI
Review URL: http://codereview.chromium.org/147098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13763
TEST=none
Review URL: http://codereview.chromium.org/146095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
OtherRedirectsDontForkProcess InEmptyFrame TestLifetimeOfDomAutomationController
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
skia/ext/skia_utils_mac.h and removed chrome/browser/cocoa/cocoa_utils.h.
Patch by rsesek.
BUG=13565
Review URL: http://codereview.chromium.org/131018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change is an updated version of <http://codereview.chromium.org/126118> that I reverted because of issue 15024 <http://crbug.com/15024>. This issue 15024 is caused by my bonehead mistake that I forgot handling the case that gtk_im_context_filter_keypress() returns false. (The GtkIMContext usually returns false when we type control keys, such as return, page up, page down, etc.) To handle this case, this change added code that manually creates a Char
event and send it to the renderer in RenderWidgetHostViewGtkWidget::KeyPressReleaseEvent(). Except this code, it is exactly the same as <http://codereview.chromium.org/126118>.
Unfortunately, this change still uses std::wstring, I'm going to send another change which replace std::wstring with string16.
(The following message is copied from <http://codereview.chromium.org/126118>.)
This change implements signal handers of the GtkIMContext object to support IMEs anddead-keys. Also, to improve compatibility with Windows Chrome, this changeemulates IPC messages sent on Windows when we input characters and fixes
Issue13604 as well as Issue 10953 and 11226. Even though I notice we need more workfor fixing edge cases (e.g. disabling IMEs on a password input) on Linux, Ithink this is the good starting point. (Supporting edge-cases requirescomplicated code and it makes hard to review.)
BUG=10953 "IME support"
BUG=11226 "Dead keys and accents input not working"
BUG=13604 "Hotkeys not working in non-us keyboard layout"
BUG=13711 "Alt-D does not work when in editbox"
TEST=Open a web page which contains an <input> form, type a '[{' key and an 'A' key on a Canadian-French keyboard, and see a Latin character "U+00E2" is displayed in the <input> form.
TEST=Open a web page which contains an <input> form, enable an Chinese Pinyin IME, type a 'W' key, type an 'O' key, and see a Chinese character is displayed in the <input> form.
TEST=Change the keyboard layout to Hebrew (or Russian), open a web page which contains an <input> form, input some characters in the <input> form, type control+a, and see the text in the <input> form is selected.
TEST=Open a web page which contains a <textarea> form, type a return key, and see a new line is inserted.
Review URL: http://codereview.chromium.org/147011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
had not been updated with the test disabled name.
Disabling 2 browser tests that fail on the build-bot:
ExtensionShelfModelTest.Basic
WebCacheManagerBrowserTest.CrashOnceOnly
BUG=None
TEST=None
TBR=erikkay,jam
Review URL: http://codereview.chromium.org/147140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This breaks the build, incrediblously.
TEST=None
BUG=None
TBR=jam
Review URL: http://codereview.chromium.org/146141
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionShelfModelTest.Basic
WebCacheManagerBrowserTest.CrashOnceOnly
BUG=None
TEST=None
TBR=erikkay,jam
Review URL: http://codereview.chromium.org/147137
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
after clicking down arrow on download shelf instead of drawing a context menu
After changing the download items in download shelf to be RTL in RTL UI, need to change the computation of x coordinate of drop down button.
BUG=http://crbug.com/14481
TEST=
1. Run Hebrew Chrome
2. Download an exe file
>> Dangerous file warning should show up now
3. Click "Save" button
4. Click the down arrow on the download shelf
5. Chrome should draw a context menu after clicking down arrow (not trying to open the exe file)
Review URL: http://codereview.chromium.org/131091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
--isolated-world command line argument to let us iterate on this feature.R=aaBUG=12218TEST=None :( (I have a testing plan we can put in place once the upstream half of this CL lands.)
Review URL: http://codereview.chromium.org/118188
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use hbox to pack location entry, security icons and EV cert info text.
Change ToolbarModel::GetInfoText not return SkColor.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/126117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This facilitates easy QA for browser crash reporting.
Review URL: http://codereview.chromium.org/147126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and display LTR for RTL locales.
r19162 | jhawkins@chromium.org | 2009-06-24 13:15:04 -0700 (Wed, 24 Jun 2009) | 5 lines
Add support for RTL languages in the gtk toolbar layout.
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The toolbar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/147102
r19179 | jhawkins@chromium.org | 2009-06-24 14:38:25 -0700 (Wed, 24 Jun 2009) | 5 lines
Add support for RTL languages in the gtk bookmark bar.
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The bookmark bar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/146105
See http://i139.photobucket.com/albums/q315/failfast/revertrtl.png
Review URL: http://codereview.chromium.org/147130
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=go incognito, toggle custom frame drawing
Review URL: http://codereview.chromium.org/146122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/147131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/146127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
stuff going on here, I can't begin to unravel it on more than one platform at a time.
TBR=sky
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/146125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Correct row index calculation in bookmark manager drag receive.
- Support multiple target dnd
also see http://crbug.com/15240
BUG=none
TEST=multi dragging in bookmark manager/bookmark bar. See cited bug for explanation of how to multi-drag.
Review URL: http://codereview.chromium.org/147107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hidden.
Also, update the height of the lower section so that content does not
get clipped.
BUG=15234, 15106
TEST=Hide the thumbnails on the new new tab page. There should be no
way that clicking on some empty space would activate a hidden
.thumbnail For the second part of this bug close 5+ tabs and check that
the Recently closed section does not get clipped.
Review URL: http://codereview.chromium.org/146120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
accessed after the views have been removed.
This was causing a crasher in the browser tests (as a deleted object was accessed).
BUG=None
TEST=Run the browser tests.
Review URL: http://codereview.chromium.org/147110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(case-sensitive file system).
BUG=8647
TEST=Pass ui test on Linux
TBR=tony
Review URL: http://codereview.chromium.org/146117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
edit link.
BUG=14958, 15073
TEST=On the new new tab page. No "edit" link should show up after a
long hover of a thumbnail. The pin/unpin, remove, show/hide thumbnails,
show/hide list should all show tooltips.
Review URL: http://codereview.chromium.org/146108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My last patch (http://src.chromium.org/viewvc/chrome?view=rev&revision=18584) should have been for chrome/browser/views/tab_contents/tab_contents_view_win.cc, not for chrome/browser/tab_contents/tab_contents_view_win.cc since the latter had been deleted (http://src.chromium.org/viewvc/chrome?view=rev&revision=18368).
I've confirmed that no patch other than mine is submitted to the old file:
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_view_win.cc?view=log
BUG=12290
TEST=See http://codereview.chromium.org/125111
Review URL: http://codereview.chromium.org/147074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/15226
TEST=see bug
Review URL: http://codereview.chromium.org/147112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Added timer to clean unpopular thumbnails from the cache/disk every hour.
Still need to implement removal of blacklisted urls.
Review URL: http://codereview.chromium.org/126237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
hadn't expired (5 seconds), even if there was no backing store. We now use the
stashed one no matter what if there is no backing store to create a new one.
Review URL: http://codereview.chromium.org/147087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
figure these perf regressions out.
TEST=graphs
BUG=15232
Review URL: http://codereview.chromium.org/147113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Change the locale param to be std::string because they're always ASCII and change call-sites accordingly.
2. Add GetStringFUTF16 to l10n_util. On Windows, they're inline helpers calling the correspondingGetStringF returning wstring while on Mac/Linux, they just return the result of |string16 GetStringF|without converting to wstring.
This is part 1 of the fix for issue 8647. Some of newly introduced conversions are temporary and will be removed later (e.g. ASCIIToWide applied to the result of GetApplicationLocale in a few places).
Note : this CL will be landed after http://codereview.chromium.org/147038 is landed.
BUG=8647 (http://crbug.com/8647)
TEST=Pass l10n_util_unittest and other unit tests
Review URL: http://codereview.chromium.org/126223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
definitions file for installation.)
Review URL: http://codereview.chromium.org/146109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Add a unittest that pretends to be the UtilityProcessHost and launches a chrome utility process for unpacking a theme.
Review URL: http://codereview.chromium.org/147001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Open a browser window in a RTL language (--lang=he). The bookmark bar layout should correctly be in RTL layout.
Review URL: http://codereview.chromium.org/146105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For users with AFS home directories, we cannot create UNIX domain
sockets for ProcessSingleton. Before this patch we would spin because
the socket would be constantly 'readable' for accept.
http://codereview.chromium.org/139008
BUG=14237
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a regression introduced by a recent change that fixed another bug.
The problem was that we were not dealing with the empty selection case in the password table.
BUG=http://crbug.com/15215
TEST=Open the "show saved password" dialog in the options. Move the selection around. Delete a password. Show a password, then move the selection, the password should not be shown anymore.
Review URL: http://codereview.chromium.org/147104
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
r=erikkay,mark
Review URL: http://codereview.chromium.org/145026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
installation."
This reverts commit r19170.
Review URL: http://codereview.chromium.org/146106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=14201
Review URL: http://codereview.chromium.org/147092
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
revision 18898 (when WebKit revision 44901 was merged in).
BUG=14491
TEST=That's what this is all about.
Review URL: http://codereview.chromium.org/146102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15232
TEST=watch perf graphs
Review URL: http://codereview.chromium.org/147103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=14959
TEST=The option menu on the new new tab page should react to keyboard
and mouse events.
Review URL: http://codereview.chromium.org/147097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19166 0039d316-1c4b-4281-b951-d872f2087c98
|