| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=33091
TEST=none
Review URL: http://codereview.chromium.org/552162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(Xib change: move left/right edges of outer splitview out 1 pixel.)
BUG=33119
TEST=none (visual appearance only)
Review URL: http://codereview.chromium.org/556048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an accessibility API for events raised outside of the web content.
BUG=none
TEST=none
patch by Dominic Mazzoni <dmazzoni [at] google>
review url: http://codereview.chromium.org/402099/show
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
patch by Dominic Mazzoni <dmazzoni [at] google>
review url: http://codereview.chromium.org/402099/show
Review URL: http://codereview.chromium.org/549182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
font size bug
that snuck in with a recent webkit roll.
BUG= 33291
TEST= run a Mac build with a new profile. See the extension / sync promo line and the puzzle piece on the NTP.
Review URL: http://codereview.chromium.org/552193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Don't recreate AppMenuModel in ToolbarView as it now supports updating label dynamically.
BUG=none
TEST=manual: enabling/disabling bookmark sync will update the bookmark sync label correcty.
Review URL: http://codereview.chromium.org/551171
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37333 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The notification behavir is same as one in windows/linux_gtk and no integration with panels yet.
BUG=33306
TEST=enabled two tests in desktop_notification_unittests for linux view config.
manual test: goto http://www.corp.google.com/~johnnyg/notify_demo.html and
confirm text/html notification works.
Review URL: http://codereview.chromium.org/552196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
consistently on the BuildBot systems.
BUG=32804
TEST=None.
Review URL: http://codereview.chromium.org/557020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We weren't detecting whether we were in OTR mode like we were in
opaque_browser_frame_view.cc.
BUG=21046
TEST=none
Review URL: http://codereview.chromium.org/553125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-enable socket late binding. The mac valgrind errors happened due to threading bugs in test_shell_tests. The ui thread would TearDown() the test object, which deleted the TestURLRequestContext, which eventually deletes the TCPClientSocketPool, which deletes its ConnectJobs. However, those ConnectJobs might be running simultaneously on the io thread. Therefore, we have a race condition. This change fixes that.
Histograms for the 4.0.266.0 dev channel release indicate the following changes for late binding:
(a) Net.TCPSocketType shows a decrease (from 41.85% to 39.29%) in used of newly connected sockets. Part of this decrease is due to using previously used sockets more often (increase from 58.15% to 58.53%), but is primarily due to being able to use sockets that were connected, but not immediately handed over to a socket request (increased from 0 [not supported without late binding] to 2.18%).
(b) Net.SocketIdleTimeBeforeNextUse_ReusedSocket indicates that reused sockets are getting used more quickly than before, with a decrease of mean idle time from 11.65 seconds to 11.34 seconds.
(c) Net.Transaction_Connected_Under_10 indicates shows that the mean for time until the first byte of the transaction response decreased from 1585ms to 1481ms.
The code change deletes the old non socket late binding code paths, cleaning up the code significantly. It also deletes duplicated tests in ClientSocketPoolBase which covered both pathways. A TCPClientSocketPool test had to be updated as well.
BUG=http://crbug.com/30354.
Review URL: http://codereview.chromium.org/549093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
----------------------------------------
Views: use ExtensionToolbarModel for ordering of browser action buttons.
This doesn't implement drag and drop reording, but the order is stored on shutdown and restored on startup.
BUG=26990
Review URL: http://codereview.chromium.org/553084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We already do this when copying text; I forgot to do
the same for cutting.
BUG=33230
TEST=checked that both PRIMARY and CLIPBOARD get updated on Ctrl-X and Ctrl-C now (and cut via context menu)
Review URL: http://codereview.chromium.org/555135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the delegate, making using 'this' in the member intializer list for
creating a menu problematic. I've changed it to a scoped_ptr and
created as needed.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/552187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/549180
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/546107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
fullscreen settings. Prereq for fullscreen mode.
BUG=31638
TEST=No visible changes.
Review URL: http://codereview.chromium.org/555133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/546132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Note that this isn't intended to introduce behavior that
diverges from other platforms -- rather, some of the existing
function key scancodes are being used by new keys.)
BUG=chromium-os:101
TEST=tried it
Review URL: http://codereview.chromium.org/543220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note: this is a *slight* rework of CL 555082, which accidentally broke the
build. That CL was reviewed and LGTM'd byt sehr@ and bsy@.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/551172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
imports bookmarks.
Based on this patch: http://codereview.chromium.org/440029
BUG=28754
TEST=manually
Review URL: http://codereview.chromium.org/549001
Patch from thiago.farina@gmail.com.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension_popup_apitest.cc unit test.
I also removed the flaky designator from this test, as I was able to run the test (under stress conditions of 10 concurrent instances) without failure.
BUG=27271
TEST=extension_popup_apitest.cc (ExtensionApiTest.Popup)
Review URL: http://codereview.chromium.org/548157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=32871
Review URL: http://codereview.chromium.org/548156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=31719
TEST=none
Review URL: http://codereview.chromium.org/552174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change is a prerequisite to change 545068.
BUG=27526
TEST=Added unit tests, manual testing on mac, linux, windows.
Review URL: http://codereview.chromium.org/543176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: This uses some assembly that is NOT SECURE. This CL is for development
ONLY.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/555082
TBR=dspringer@google.com
Review URL: http://codereview.chromium.org/548163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: This uses some assembly that is NOT SECURE. This CL is for development
ONLY.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/555082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark-only columns. Add getters and setters for BookmarkSpecifics to
syncapi as well as syncable entries. Make the datatype be a required
property when creating a syncapi node. Add a datatype for the 'google
chrome' top level folder. Add database migrations from version 67 to
the new schema. Add infrastructure to support migrations generically.
Add unit tests for the migrations.
Pull a new version of the protobuf library to pick up a fix for a
bug that this change exposed (I upstreamed the fix).
Fix some example code in the sql helpers so that it would actually
compile.
BUG=29899,30041
TEST=New unit tests for migrations: unit tests are based on actual
database dumps. Additionally, I manually tested 2-client sync using
combos of old-protocol servers, new-protocol servers, and initial
database versions v67, v68, and v0 (new client). I manually verified
that add/edit/delete works in these combination cases. Afterwards I
verified (by inspecting the sync databases) that the ModelTypes are
consistent across the various migration/protocol paths.
Review URL: http://codereview.chromium.org/554066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
cookies by origin.
BUG=none
TEST=Mac Valgrind unit_tests
Review URL: http://codereview.chromium.org/555124
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=33197
TEST=Verified that Chrome builds.
Review URL: http://codereview.chromium.org/549163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
was passed to it or not. In the latter case 'Configure IME' menu is not
shown.
BUG=33197
TEST=Could be tested on login manager screen later. Right now browser can be set
to NULL in debugger manually.
Review URL: http://codereview.chromium.org/553096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prior to this change images where copied inline in IPC messages on non-Windows platforms. Copying an oversized image would cause the IPC system to bork and crash the renderer.
Changes in this CL:
* All platforms use a unified mechanism to copy images using shared memory.
* Introduced a new IPC message so the renderer can allocated a shared memory segment on OS X.
* On OS X tried to keep as few copies of the image data in memory as possible.
BUG=26822
TEST=1)On all platforms: navigate to a webpage, right click on an image and copy. Then try pasting into an image editor. 2)Repro steps in bug should no longer crash the Renderer on Mac/Linux
Review URL: http://codereview.chromium.org/552129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
rel="updates alternate". Now it is.
BUG=None
TEST=Covered by automated browser test (included).
Review URL: http://codereview.chromium.org/555127
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/16447
TEST=Covered by automated tests.
Review URL: http://codereview.chromium.org/549168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
supporting resize for the container).
Also improved RTL support a bit (the divider wasn't drawn on
the right side of the container and resizing was reversed).
BUG=32101
TEST=Overflow menu for browser action container should now work.
Make sure to test also right-clicking on a menu item in the overflow
menu to bring up a context menu for that item. And resizing the
container in RTL locales should work.
Review URL: http://codereview.chromium.org/557006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Cut/Copy/Paste items in page menu should work in both omnibox and web content.
Review URL: http://codereview.chromium.org/556016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
accordingly.
Bug=16447
TBR=finnur
Review URL: http://codereview.chromium.org/543223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See bug for more details.
BUG=33120
TEST=Put sleep(15) before post of on_work_done_task, made sure OnAuthDone doesn't get called on shutdown.
Review URL: http://codereview.chromium.org/548147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Made mac_util.mm and chrome_paths_mac.mm use GetUserDirectory().
Made firefox_importer_utils_mac.mm use PathService.
Added unittests for GetUserDirectory().
BUG=22045
TEST=trybots
Review URL: http://codereview.chromium.org/548123
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18063
TEST=Installer an update while Chrome is running. Log out of machine without closing Chrome first and make sure sure Chrome gets updated cleanly whenever it is launched next.
Review URL: http://codereview.chromium.org/553079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This matches Mozilla, which uses ~/.mozilla/plugins.
BUG=22261
TEST=watch an strace, see that it hits the appropriate dir when loading plugins
Review URL: http://codereview.chromium.org/553102
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- This fixes the crash in compact navigation bar without a adjustment.
- I didn't remove the adjustment because ths is necessary to make the compact navigation bar transparent. (currently, the clipping code assumes that the fixed widget and the actual opaque child have the same side, which is not the case for AutocompleteEditView.
BUG=chromium-os:1010
TEST=manual: compact nav bar does not crash.
Review URL: http://codereview.chromium.org/548151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame. This was because
the ExternalTabContainer would close the underlying tab contents in its OnDestroy handler without invoking
unload handlers on the page if any. In Chrome the TabStripModel invokes the RunUnloadListenerBeforeClosing
on the delegate which is implemented by the browser. We need to mimic this in the external tab container.
To achieve this we now have a static helper function RunUnloadListenerBeforeClosingHelper in the browser
class which is called by the ExternalTabContainer and the Browser::RunUnloadListenerBeforeClosing function.
The ExternalTabContainer also needs to wait for the unload handlers on the page to return before it returns
control back to the host browser. To achieve this we enter a nested modal loop which is exited when the
underlying tab is closed.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=31853
Bug=31853
Test=Covered by ChromeFrame unit test.
Review URL: http://codereview.chromium.org/543183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=rsesek
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/556033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
side of patch]
BUG=25831
TEST=none
Review URL: http://codereview.chromium.org/554004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This cleans up the interface for BrowserCreateForApp() which now longer takes a final argument of is_popup. The code has changed so that it is no caller is ever passing in true, so the code has been simplified.
BUG=5739
TEST=Ensure steps in bug report still no longer produce the bug.
Review URL: http://codereview.chromium.org/556024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in incognito mode.
BUG=27945
Review URL: http://codereview.chromium.org/543155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
in HungRendererController.
BUG=33160
TEST=None. (No repro case. Hopefully crashes will go away.)
Review URL: http://codereview.chromium.org/556022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
this is potentially temporary
BUG=27635
TEST=search for something that doesn't exist in the page
Review URL: http://codereview.chromium.org/548154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the same Extension object and then crash (or are killed by the Task manager). Since the first ExtensionHost RenderViewGone will cause the Extension to be unloaded, the subsequent call will try and unload a dirty pointer. This is prevented by NULLing out the Extension pointer in the host and checking it upon RenderViewGone before sending a notification to have it unloaded (again).
TEST=none
BUG=32613,32653
Review URL: http://codereview.chromium.org/555103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/548152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37155 0039d316-1c4b-4281-b951-d872f2087c98
|