| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159645
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/11598
TEST=Visit an HTTPS page, click the lock icon, the page info should show.
Review URL: http://codereview.chromium.org/159521
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
they are sent.
A good portion of this CL is to support the new UI test.
The IPC to notify the renderer of a redirect now includes a ResponseInfo struct
allowing WebURLLoaderImpl to provide detailed response info (including response
headers) to WebKit. This isn't strictly necessary, but I thought I'd include
this to make the code more future proof.
A cross origin restriction is added to SyncResourceHandler::OnRequestRedirected
that mimics the code in WebCore/platform/network/cf/ResourceHandleCFNet.cpp.
This is most unfortunate, and I filed a bug at bugs.webkit.org about the
similar duplication of logic in WebCore.
There seemed to be enough code paths leading to request cancellation at the
ResourceDispatcher level that I couldn't easily ensure that a request only gets
cancelled once. So, I added an is_cancelled flag to record if it is not
necessary to send a ViewHostMsg_CancelRequest IPC. This avoids some warnings
in the ResourceDispatcherHost.
To support my UI test, I needed to change URLRequestMockHttpJob to know how to
serve redirects. I moved URLRequestHttpJob::IsRedirectResponse to its base
class, URLRequestJob so that the implementation could be shared. This revealed
a minor bug in URLRequest. We were never resetting response_info_ upon
following a redirect. I added this code consolidated similar code from
URLRequest::Redirect and URLRequest::RestartWithJob into a new PrepareToRestart
method.
To support my UI test, I added a "hit count" field to URLRequestFilter, and I
added an associated automation IPC to query the value. The test was a bit
challenging to write because there is no way to tell the difference from JS.
Before and after, it appears to JS as though the cross-origin redirect failed.
However, the server can see the extra redirect request. So, I simply record
the number of hits against URLs of the form http://mock.http/foo, and use that
to observe if any extra requests were made. I implemented the new IPC message
by extending the AutomationResourceMessageFilter. This allowed me to trap the
IPC message on the IO thread where it is safe to probe the URLRequestFilter. I
then changed the implementation of AutomationMsg_SetFilteredInet to work
similarly.
I revised URLRequestMockHTTPJob::GetOnDiskPath to support ports. This actually
allowed me to reuse URLRequestMockHTTPJob to service URLs in different security
origins. My test redirects from http://mock.http/ to http://mock.http:4000/.
Please see the comments in cross-origin-redirect-blocked.html for details about
how the test functions.
R=brettw,wtc
BUG=16413
TEST=covered by resource_dispatcher_host_uitest.cc
Review URL: http://codereview.chromium.org/159370
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=4928
TEST=Open about:memory page a see if the browser name of Google is what is expected.
Review URL: http://codereview.chromium.org/159385
Patch from Thiago Farina <thiago.farina@gmail.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=avi
BUG=18079
TEST=none
Review URL: http://codereview.chromium.org/160400
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
tab strip before creating the tab strip controller.
BUG=none
TEST=initial incognito tab layout should exactly match normal tab layout (including new tab button).
Review URL: http://codereview.chromium.org/160397
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/12970
TEST=as in bug
Review URL: http://codereview.chromium.org/160353
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to use them too.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/160366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to MSDN, this avoids signed/unsigned issues that can
lead to problems on systems with multiple monitors.
Credit goes to Yoav Zilberberg for catching this!
R=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160372
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CrxInstaller is a new stateful object that encapsulates a
single installation from unpack through notification.
It currently contains the UI bits, but I suspect in the next
CL (where I will finally implement the install UI) these
will come out and CrxInstaller will become
SilentCrxInstaller, and only used for updates and external
installs.
Also in this change, I removed the concept of install callbacks that ExtensionUpdater was using. This was only used to delete the temp crx file as far as I can tell, and we can easily keep state about that in CrxInstaller.
With this CL, ExtensionsServiceBackend is almost completely
dead, with only a few zombie methods left like
LoadAllExtensions(). These should all become little objects
like CrxInstaller that hold a reference to ExtensionsService
over their lifetime and then kill themselves.
I'll get to that eventually.
Review URL: http://codereview.chromium.org/160311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160371
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=17851
TEST=Open the task manager. Click on the 'Stats for nerds' link. Browser should navigate to about:memory.
Review URL: http://codereview.chromium.org/159616
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem with GetCursorPos is that it queries the mouse position right now,
which means that the values may not be consistent with the values reported via
windows messages. GetMessagePos on the other hand returns the mouse position
as last reported via the message loop.
With this change, I'm unable to reproduce unwanted detached tabs even under
heavy system load.
R=ben
BUG=2993
TEST=While your system is heavily loaded, click on a tab, release the mouse
button and then move the mouse downward. Do this as quickly as you can, and
the tab should stay put.
Review URL: http://codereview.chromium.org/160364
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
CL cleans this up.BUG=NoneTEST=Accelerator should work in Chrome and in the first run window.
Review URL: http://codereview.chromium.org/160301
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160356
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put the star and go/stop buttons inside the location bar drawing. Reverts my changes to
location_bar_view_gtk.cc in the previous patch. (Showed mocks of this to Ben and Glen.)
Also fixes rendering of the location bar background under Crux and other themes that
draw an entry_bg.
Review URL: http://codereview.chromium.org/159610
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
1. SelectAll
2. Cut/Copy/Paste
3. Reload :- Added an asynchronous version of this IPC
4. Stop.
Review URL: http://codereview.chromium.org/159609
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=619
BUG=15960
TEST=none
Review URL: http://codereview.chromium.org/126290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This matches native gtk behavior.
BUG=17869
TEST=Open multiple tabs. Scroll the tabs using the scroll wheel. The scroll should not wrap around.
Review URL: http://codereview.chromium.org/160362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15875
Review URL: http://codereview.chromium.org/160350
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
download request manager.
We weren't reporting Cancel on page navigation, which meant the download request manager had a stale pointer that it later tried to dereference.
BUG=18021
Review URL: http://codereview.chromium.org/160361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To test, did the following under Metacity/GNOME:
- remove window_placement prefs from "Local State" file
- start chrome
- open bookmark manager with Ctrl-Shift-B
- resize window to be small and close it
- reopen bookmark manager and confirm that its window is the same
size as when closed
- maximize bookmark manager and close it
- reopen bookmark manager and confirm that it's still small
- minimize bookmark manager before closing it; confirm that the
size remains the same
- restart chrome and confirm that the window size is still saved
- repeat the above tests with the task manager (which is a bit
quicker, since it doesn't allow maximizing or minimizing)
BUG=15488
TEST=see above
Review URL: http://codereview.chromium.org/160330
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It still passes, and provides coverage for situation where there are
lots of DNS requests at the same time.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/159601
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160354
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Known limitations:
* Runs in browser process, should run in a separate process.
* No UI.
* No FF password import.
BUG=15455
TEST=Check that firefox settings are correctly imported on first run, firefox password importing and Safari importing still don't work.
Review URL: http://codereview.chromium.org/160341
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=8205
Review URL: http://codereview.chromium.org/159603
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
As with the rest of our shadow drawing, we don't overlap 1 pixel, we
just draw the area around.
BUG=15505
Review URL: http://codereview.chromium.org/160306
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
matches up with Windows.
BUG=17915
Review URL: http://codereview.chromium.org/160281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
See http://codereview.chromium.org/159186
Renaming GetNormalBounds to GetRestoredBounds from browser_window.h.
BUG=None
TEST=None
TBR=tfarina
Review URL: http://codereview.chromium.org/160337
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
inserted for LTR systems
To avoid empty square displayed around tooltip when system does not have RTL support, only add Unicode marks when element's directionality is not the same as UI's directionality.
Note:
1. tooltip will be displayed using its element's directionality.
2. in system without RTL support, tooltip will only be displayed correctly (in its element's directionality and without empty square around) when both UI and element's directionality is LTR.
BUG=http://crbug.com/17468
TEST=
1. Uninstall the right-to-left script and east Asian script through the Control Panel and restart system.
2. Run English Chrome.
3. given the following HTML, the displayed tooltip should not have empty square around.
<html>
<head>
<META HTTP-EQUIV="CONTENT-TYPE" CONTENT="TEXT/HTML; CHARSET=utf-8">
</head>
<body>
<span style="background-color:Blue" title="Hi!">And now here!</span>
</body></html>
Review URL: http://codereview.chromium.org/160262
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21975 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8205
TEST=go to wrench->options->personal stuff->show saved passwords, it works
Review URL: http://codereview.chromium.org/159522
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21973 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
multiple files. Do you want to allow this?" dialog on linux.
BUG=12757
TEST=Download several files from the same domain. After the first download, you should be prompted for every additional file you want to download from that domain (try for example http://amnoid.de/ddsview/download.html , click on the "download" link twice).
Review URL: http://codereview.chromium.org/159528
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21966 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The combined star/location bar/go construct doesn't look native. In
GTK mode, make the star and go buttons act like toolbar buttons, and
draw a GTK text entry widget onto the toolbar. The omnibox popup
is just the size of the entry when in GTK theme mode.
There's still a lot of work to be done on this; I want to properly
draw focus rings, have the rest of the location box use theme colors, et cetera, but this is less broken then what's currently
there.
Review URL: http://codereview.chromium.org/159532
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
accelerators to be broken.
This CL also makes sure to keep the focus on the location bar when reloading the NTP.
BUG=http://crbug.com/14954
TEST=See bug.
Review URL: http://codereview.chromium.org/160206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=17822
TEST=Use multiple monitors. Start Chrome, move the window to a non-primary
monitor, and exit Chrome. Disconnect or disable the monitor and start Chrome
again. Chrome should appear at the origin of a remaining monitor. Also try
chaning the resolution of the non-primary monitor. As far as the window fits
within the monitor, it should be shown as-is. If not, it is moved to the origin
and resized, if necessary.
Review URL: http://codereview.chromium.org/160246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Broke valgrind ui_tests
Review URL: http://codereview.chromium.org/160320
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It seems NXClient sends GDK_Tab not only when we press control+tab keys but also when we press control+shift+tab keys.
To emulate Firefox, this change checks if |modifier| is control+shift when |keyval| is either GDK_Tab, GDK_ISO_Left_Tab, or GDK_KP_Tab.
BUG=13443 "Shift+Ctrl+Tab should cycle tabs backwards"
TEST=Execute Chromium on an NX Client, press control+shift+tab keys, and verify tabs cycle backwards.
Review URL: http://codereview.chromium.org/155564
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch contributed by suzhe@google.com (http://codereview.chromium.org/155772)
BUG=http://crbug.com/12343
TEST=In one terminal, launch chrome and stop the process by pressing ctrl-z,
then launch chrome again in another terminal. The second chrome shall be started
in 5 seconds, and the first one shall be killed.
Review URL: http://codereview.chromium.org/159577
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
exist, and some newly added code handled that poorly, leading to crashes.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/160312
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
a NULL IOBuffer:data_.
BUG=http://crbug.com/16371
Review URL: http://codereview.chromium.org/159561
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=17475
TEST=obvious
Review URL: http://codereview.chromium.org/159570
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11507
Review URL: http://codereview.chromium.org/160307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
AutomationMsg_RequestStart.
Review URL: http://codereview.chromium.org/159228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionsServiceBackend into a set of utility functions.
The intent of this is:
a) make extensions_service.cc smaller
b) have smaller pieces hanging around that we can more easily
reconfigure to implement new features.
c) improve testability.
Review URL: http://codereview.chromium.org/159400
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also update the section background so that it looks the same on white, but is actually transparent.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159549
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Install two themes without closing the infobar - make sure only one infobar is visible.
Review URL: http://codereview.chromium.org/160296
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tweaks for the list view mode.
This also fixes an issue where the thumbnails were not positioned
correctly at startup in RTL
BUG=17810, 17811, 17751
TEST=Hide the recent activities and make sure that the right border of
even more is shown. Switch to list mode. Make sure that the filler are
hidden. Try dragging the items in the list view. The text should not
dissappear.
Review URL: http://codereview.chromium.org/160291
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now when an extension is loaded, you will see its entry in the task manager.
However, on the shelf there is still only a placeholder label (I have to
work on setting proper size for the render widget).
TEST=none
http://crbug.com/16759
Review URL: http://codereview.chromium.org/159527
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=awong
Review URL: http://codereview.chromium.org/159550
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- ctrl+e = ctrl+k
- alt + e and alt + f to open the page and wrench menus respectively (emulating menu bar _File and _Edit)
BUG=none
TEST=use the new hotkeys
Review URL: http://codereview.chromium.org/160292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21905 0039d316-1c4b-4281-b951-d872f2087c98
|