summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Made changes to the JavaScript debugger in preparing for an upcomingsgjesse@google.com2008-08-298-68/+142
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | change in V8 where the implicit breaks currently issued when receiving a command while running will be removed. To get in contact with the V8 debugging interface and send messages V8 needs to be in the break state. Getting V8 into the break state will be the responsebility of the debugger using the V8 debugging interface. Changed the messages between the renderer and the debugger. There are now explicit messages for break and detach. Alse renamed the SendToDebugger message to DebugCommand. There is now messages DebugAttach, DebugBreak, DebugCommand and DebugDetach. The message DebugBreak has a force flag to indicate whether the renderer should issue some JavaScript to help the break along or whether it should just schedule a break to happen whenever JavaScript executes. Removed the artificial attach JSON response send by the renderer and replaced that with an on debug attach call to the debugger shell. This call is reouted to the on_attach function in the debugger JavScript code. Changed the debugger to issue break requests whenever a suitable command, e.g. setting a break point, is issued. In this case a flag is used to track whether execution should be automatically resumed after the command have been send to the V8 debugger interface. Changed the handling of the plain break event to not force a break by executing additional JavaScript. Thereby a plain break does not break JavaScript execution until code on the tab beeing debugged is actually executed. Set the command name explicitly on all commands. Removed parseSimpleCommand as it was just used for the the continue command for which an explicit parseContinueCommand has been added. Removed the last_command field from DebugShell as it was not used. Updated the debugger protocol test to reflect the removed attach event. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1526 0039d316-1c4b-4281-b951-d872f2087c98
* Remove navigation_performance_viewer.{cc,h} from the SCons build,sgk@google.com2008-08-293-112/+1
| | | | | | | and for real. TBR: brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1521 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in ClearBrowsingDataView that can only occur during thesky@google.com2008-08-282-6/+19
| | | | | | | | | | | | | | automated tests. If the window is closed while a removal is in progress the BrowsingDataRemover would be left with a reference to a deleted object. This can only happen during automated testing as while clearing is in progress we don't allow the user to close the dialog. BUG=1138705 TEST=covered by automated test bot git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1512 0039d316-1c4b-4281-b951-d872f2087c98
* We should not EXPECT to get a browser object or a window object, we should ↵finnur@google.com2008-08-283-13/+18
| | | | | | ASSERT that we got it (which ends the test on NULL pointers). Otherwise we continue on and crash when we try to use these pointers, such as when passing it into GetBrowserForWindow. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1508 0039d316-1c4b-4281-b951-d872f2087c98
* Forgotten unit test chanes.brettw@google.com2008-08-284-9/+17
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1507 0039d316-1c4b-4281-b951-d872f2087c98
* Make a step on refactoring navigation. The eventual plan is to have the ↵brettw@google.com2008-08-2811-255/+296
| | | | | | | | | | | | | NavigationController create and commit the new NavigationEntries (currently WebContents does a bunch of the details of this which is hard to understand and not easily testable). This tries to consolidate the logic that I want to move to the NavigationController without actually moving it there yet. I removed all of the "PreCommit" functions in WebContents, since when the NavigationController does all of the committing, there won't be a phase where the NavigationEntry exists but isn't committed. Most of the logic could be moved to the PostCommit functions without any problem, which is an indication that the current design was busted anyway. I had to precompute some data and pass it to the *PostCommit function to work around some of the components that required old data. I had to change InfoBars around since it relied on having both the committed and uncommitted entries, but I think the new design is much better anyway. BUG=1343593,1343146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1506 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify OneShotTimer and RepeatingTimer. Fix up all consumers.darin@google.com2008-08-2810-29/+41
| | | | | | | | | | | | | | | | | | | | | | | | Major changes: OneShotTimer and RepeatingTimer become template classes that no longer require a Task or a Timer object. They just use PostDelayedTask. Under the hood that still uses a Timer object. The API is much simpler for consumers as they now no longer need to worry about allocating a Task or managing the lifetime of the object pointer held by the Task. I added some new unit tests to timer_unittest.cc to cover the API. I preserved the old TimerManager / Timer API for now, but I plan to soon kill it. R=brettw BUG=1346553 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1502 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash in TaskManager. I'm skeptical this is it, butsky@google.com2008-08-281-2/+2
| | | | | | | | | | it's worth a shot. BUG=1345092 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1501 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the redness in the interactive test. We were using GetActiveWindow ↵finnur@google.com2008-08-281-6/+5
| | | | | | to get the Browser window, which internally uses ::GetForegroundWindow(). This means that when other application windows are on top we fail to get the Browser window. By switching to GetLastActiveWindow() we avoid that. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1498 0039d316-1c4b-4281-b951-d872f2087c98
* The GetWindowRect must return the rect of the container HWND; not the actual ↵erg@google.com2008-08-282-6/+10
| | | | | | | | | | window rect. The usage of GetWindowRect in the ChromeClientImpl::windowRect() function is erroneous, and my modification of GetWindowRect to return the HWND's root ancestor rect broke drop down combo boxes and other embeded controls. So instead, add a GetRootWindowRect which gets the root anncestor of the HWND's rect and use it in ChromeClientImpl::windowRect(). BUG=1344367,1186573,1334505 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1496 0039d316-1c4b-4281-b951-d872f2087c98
* Split the AutocompletePopup into model and view classes, step 1.pkasting@google.com2008-08-285-821/+791
| | | | | | | | | | | | The just adds "Model" and "View" to the end of the current classname, leaves everything in the same files, and doesn't really change or remove any functionality, creation order, ownership semantics, etc. In other words, it's basically just moving some code around to get things split into two classes, and the harder work comes later. Also removes/trims some overly long comments, fixes a couple comment errors I noticed, and trims one or two bits of logic to be shorter. What really needs review the most is the high-level decisions about how to split data and functionality between the two classes. BUG=1343512 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1492 0039d316-1c4b-4281-b951-d872f2087c98
* No code change, just changing a comment (a nit from my previous review). ↵finnur@google.com2008-08-281-3/+3
| | | | | | | | | This fixes that. TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1491 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a test to catch regressions where the Find box moves when you open ↵finnur@google.com2008-08-287-65/+184
| | | | | | | | | | | and close a tab. Test is disabled until we fix the bug. Also made the error message for when tests fails because crash_service isn't running a bit explicit (unrelated to the rest of this change). BUG=1343052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1488 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression where we were no longer deleting TabContents whensky@google.com2008-08-282-11/+21
| | | | | | | | | | navigating to a new TabContents. BUG=1349274 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1487 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problem of safebrowsing database removing an add for a hostname when it ↵jabdelmalek@google.com2008-08-282-2/+31
| | | | | | | | got a sub for some prefixes. BUG=1315628 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1481 0039d316-1c4b-4281-b951-d872f2087c98
* Add region-specific suggest URLs for Yahoo_xx search engines where suggest ↵jungshik@google.com2008-08-281-45/+86
| | | | | | | | | | | | | | | | | | | | | | service is available. Add utf8 output flag to Naver (#1 engine in Korea) so that JSON comes back in UTF-8. meta.ua (Ukraine search engine) was changed similarly. Change the url for Yahoo_sg to sg.yahoo.com (from tw.yahoo.com) and that for Yahoo_nz to nz.yahoo.com (from sg.yahoo.com) Disable the suggestion service for Daum because it returns the result in EUC-KR and currently we assume it's in UTF-8 (issue 1293145). Also disable Yahoo_xx's that do not offer suggestion/ac services. We can do some mappings (e.g. at, ch => de, qc => ca or fr, hk => tw or en and nl,no,dk, fi => en, the rational for the last being that English proficiency of general public in those countries is rather good.), but disable it for now. BUG=1342120 TEST=Install various language versions of Chrome and set the default search engines to a regional Yahoo variant and see if suggest works in the omnibar. Install Korean Chrome and set the default search engine to Naver and see if suggesst works. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1480 0039d316-1c4b-4281-b951-d872f2087c98
* Change Chrome references to Chromium on about:memory page. rahulk@google.com2008-08-282-4/+4
| | | | | | | BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1474 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Google Chrome specific strings from common resources file and use ↵rahulk@google.com2008-08-2737-5/+56
| | | | | | | | | them from new resources file that is specific to only Google Chrome. BUG=1110882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1473 0039d316-1c4b-4281-b951-d872f2087c98
* Changes saving of prefs/bookmarks to try move a second time if firstsky@google.com2008-08-271-2/+9
| | | | | | | | | | time fails. BUG=1347276 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1458 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a test to make sure Find restarts properly after a timeout.finnur@google.com2008-08-271-0/+21
| | | | | | | BUG=1155639 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1456 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup navigation_entry.h. I made the accessors consistent and in Google ↵brettw@google.com2008-08-2731-425/+491
| | | | | | style, and organized and commented all the entries. Hopefully it will be much easier to find things and deal with this class. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1449 0039d316-1c4b-4281-b951-d872f2087c98
* The positioning of detached dragged tabs was wrong with the new frames, ↵beng@google.com2008-08-271-1/+1
| | | | | | | | because I wasn't initializing the value I was passing to RestoreWindowPosition with the specified initial bounds. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1448 0039d316-1c4b-4281-b951-d872f2087c98
* Fix header guardnsylvain@google.com2008-08-271-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1444 0039d316-1c4b-4281-b951-d872f2087c98
* Fix header guardnsylvain@google.com2008-08-271-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1440 0039d316-1c4b-4281-b951-d872f2087c98
* Again, call RunAllPending to flush out the pending tasks. This is done to makedarin@google.com2008-08-271-0/+3
| | | | | | | | | | | Purify happy. "wack a mole" TBR=erikkay git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1432 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly call RunAllPending in the Teardown phase a few more unit tests todarin@google.com2008-08-272-0/+6
| | | | | | | | | prevent Purify from complaining about these pending tasks as MLKs. TBR=erikkay git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1431 0039d316-1c4b-4281-b951-d872f2087c98
* Flush the message loop in the Teardown phase of these tests. This helps Purifydarin@google.com2008-08-271-0/+3
| | | | | | | | | | not complain about transient memory leaks related to queued up tasks that never run otherwise. TBR=erikkay git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1430 0039d316-1c4b-4281-b951-d872f2087c98
* No code change. Just adding some comments explaining why we need to keep ↵finnur@google.com2008-08-271-3/+7
| | | | | | track of whether or not we are importing when Cancel is called. It was non-obvious and it wasn't until I had attempted to remove it that the reason became clear (Cancel is called again when ImportEnded calls Window::Close and we must return true in this case). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1426 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a UI test to catch the crash described in issue 1341577.This test is ↵finnur@google.com2008-08-273-30/+65
| | | | | | disabled, and will be turned on once we fix the issue.I added to TabProxy the ability to do FindNext, which was necessary to reproduce the crash, and changed the automation IPC to take a FindInPageRequest struct, which makes it identical to the IPC we pass to render_view.BUG=1341577 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1425 0039d316-1c4b-4281-b951-d872f2087c98
* Makes deleting history no longer delete starred urls. Thiseffectively ↵sky@google.com2008-08-2728-478/+1029
| | | | | | reenables the code in ExpireHistoryBackend. I also madethe code consistent so that when we delete visits as the result ofhistory deletion we don't change the typed/visit count of theunderlying url.BUG=1214201 1256202TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1423 0039d316-1c4b-4281-b951-d872f2087c98
* Position the find box correctly with the new frames.beng@google.com2008-08-271-1/+4
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1416 0039d316-1c4b-4281-b951-d872f2087c98
* Make the system menu for frames have submenus for encoding and text zoombeng@google.com2008-08-262-11/+40
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1413 0039d316-1c4b-4281-b951-d872f2087c98
* Bumping up the default hung plugin timeout to 30 seconds. This matches withiyengar@google.com2008-08-262-9/+9
| | | | | | | | | | the hung webpage timeout. The other change is to take out the IsHungAppWindow call as this is redundant when combined with SendMessageTimeout. Bug=1308327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1411 0039d316-1c4b-4281-b951-d872f2087c98
* Extends the toolbar keyboard support. Adds skipping of unavailable elements ↵klink@google.com2008-08-261-7/+24
| | | | | | of the toolbar, to accomodate for quicker keyboard traversal. Fixes tooltip display on initial focusing of the toolbar. Also fixes the support for VK_SPACE and VK_ENTER. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1388 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the interceptor DCHECK that we are only called from a single thread.darin@google.com2008-08-261-1/+6
| | | | | | | | | | | | | Given recent changes, the unit tests now make URLRequest calls from multiple threads but not simultaneously. See TestServer::MakeGETRequest. I think the interceptor list needs to be stored on the URLRequestContext or it needs to be made thread safe. TBR=mpcomplete git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1373 0039d316-1c4b-4281-b951-d872f2087c98
* fix unit testsdarin@google.com2008-08-262-1/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1371 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome changes corresponding to my message_loop_type CL.darin@google.com2008-08-2667-122/+199
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1363 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break caused by some functions not ifdef CHROME_PERSONALIZATION'd out.ericcheng@google.com2008-08-262-10/+12
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1360 0039d316-1c4b-4281-b951-d872f2087c98
* Some more glue code for the personalization module.ericcheng@google.com2008-08-262-1/+12
| | | | | | | | Added ability to invoke a method on an NPObject wrapped in a CppVariant. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1359 0039d316-1c4b-4281-b951-d872f2087c98
* Sets the visibility bool of the Home button.klink@google.com2008-08-251-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1342 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the profiling system. This wasn't being used and complicated some ↵brettw@google.com2008-08-2514-1530/+8
| | | | | | parts of the code (I'm trying to clean up WebContents). We can ressurect this if we have a better plan for doing profiling that needs to live in the browser. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1341 0039d316-1c4b-4281-b951-d872f2087c98
* Make the AeroGlassFrame better:beng@google.com2008-08-259-175/+253
| | | | | | | | | | | - client edge rendering is now pixel-perfect for all BrowserTypes. - fix NCCALCSIZE handling that was making our top-right corner less than perfectly round - make system menu work - remove some unnecessary functions B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1340 0039d316-1c4b-4281-b951-d872f2087c98
* Create a unit test for making sure constrined popup windows close when their ↵erg@google.com2008-08-251-2/+56
| | | | | | | | X is clicked. Currently this unit test fails. It should. BUGS=1341975 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1338 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug in constrained windows where the close box was detaching instead of ↵beng@google.com2008-08-251-1/+2
| | | | | | | | closing. We weren't considering HTCLOSE in the test of acceptable hittest components that might cause detaching. B=1341975 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1335 0039d316-1c4b-4281-b951-d872f2087c98
* Second attempt at fixing task manager crash. Provide a protected ↵beng@google.com2008-08-251-0/+2
| | | | | | | | | ReleaseWindow methods that recycled delegates can use to release the window ptr they use. Currently only one delegate uses this (TaskManager). It'd be nice if TaskManager wasn't a singleton... B=1333829 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1328 0039d316-1c4b-4281-b951-d872f2087c98
* Make tabs highlight and accept clicks based on the shape of the rendered ↵beng@google.com2008-08-254-0/+91
| | | | | | | | tab, rather than the bounding box of the view that renders it. This allows for truer event handling. B=656878 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1327 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flicker of hover state on mouseover of tabs. The pulsating code was a ↵beng@google.com2008-08-251-6/+3
| | | | | | | | | little convoluted and was accidentally causing the non-highlighted state to be painted for the last frame of the animation. B=1317898 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1326 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a leak in HistoryProfileTest.TypicalProfileVersion.erikkay@google.com2008-08-251-8/+9
| | | | | | | | sqlite3_close returns SQLITE_BUSY if there are any outstanding statements. Since the SQLStatement object hadn't been destroyed, finalize hadn't been called, so the close failed and a lot of sqlite stuff leaked. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1321 0039d316-1c4b-4281-b951-d872f2087c98
* Add some new tests for NavigationController for navigations that come in ↵brettw@google.com2008-08-252-13/+224
| | | | | | when various navigations are pending. This doesn't actually change any behavior. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1314 0039d316-1c4b-4281-b951-d872f2087c98
* Make PlatformThread::SetName operate only on the current thread.deanm@google.com2008-08-252-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1306 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-18 05:08:03 +0000