summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Fix flaky AppApiTest.AppProcess.mpcomplete@chromium.org2010-04-261-6/+7
| | | | | | | | BUG=42497 Review URL: http://codereview.chromium.org/1745016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45630 0039d316-1c4b-4281-b951-d872f2087c98
* Honor the select_all argument to AutocompleteEditViewMac::FocusLocation.mark@chromium.org2010-04-261-3/+5
| | | | | | | | | | | | | | | | | | | | | | | Calling -[NSWindow makeFirstResponder:] to give focus to the AutocompleteTextField will select the entire contents of the field. If the field is already focused and "select all" is not desired, avoid making this call. If "select all" is desired, or if the field is not focused (regardless of the value of select_all), the field will be focused and its entire contents selected. BUG=40322, 40682 TEST=With a profile primed so that "google.com" is the first suggestion when typing "g" in the location bar, and no windows open, quickly press command-N and begin typing "google" while the tab is being created. Expect all of the entered characters to make it to the location bar. When the bug occurs, the location bar in its entirety will be selected at some point during or immediately following tab creation, which will cause previously-typed text to be lost or the first autocomplete suggestion to be chosen, and something like "ogle" or "google.com/ogle" to appear in the location bar. Review URL: http://codereview.chromium.org/1709010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45628 0039d316-1c4b-4281-b951-d872f2087c98
* Move event_sys.h, event_sys-inl.h and event_sys_unittest.cc to chrome/common ↵sanjeevr@chromium.org2010-04-2629-683/+27
| | | | | | | | | | | in preparation of moving TalkMediator and GaiaAuthenticator to chrome/common. No functional change, only file locations have changed. BUG=None TEST=Test Bookmakrs Sync Review URL: http://codereview.chromium.org/1739004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45626 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: partial fix position of context menu for trees.arv@chromium.org2010-04-261-1/+1
| | | | | | | | | | | When the user presses the context menu key we ask the tree for the rect where the context menu should be placed at. We incorrectly returned the rec for whole tree item, including its children. With this change we only return the rect for the row of the tree item. BUG=None TEST=None Review URL: http://codereview.chromium.org/1758009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45625 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Make sure we do not collapse whitespace in bookmark names.arv@chromium.org2010-04-263-12/+14
| | | | | | | | | | BUG=41911 TEST=Create a bookmark and a bookmark folder with the name " ". The item should still be shown in both the tree and the list. Review URL: http://codereview.chromium.org/1793002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45624 0039d316-1c4b-4281-b951-d872f2087c98
* Put an "(empty)" into the submenus of empty folders in the bookmark menu, to ↵avi@chromium.org2010-04-261-3/+10
| | | | | | | | | | | match the same in the non-menubar menus. BUG=http://crbug.com/41768 TEST=as in bug Review URL: http://codereview.chromium.org/1718016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45615 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/GTK: delete native bookmark manager code.viettrungluu@chromium.org2010-04-2610-1961/+33
| | | | | | | | | | | Views code still to be deleted; some cleanup will take place then. BUG=38908 TEST=everything keeps working as before Review URL: http://codereview.chromium.org/1753009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45612 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Ignore rapp events when the browser is shutting down.rohitrao@chromium.org2010-04-261-0/+6
| | | | | | | | BUG=42430 TEST=Suspected test case is to click on the dock icon immediately after quitting, but before the quit has finished. This is very timing-dependent, and I have never actually been able to reproduce the crash. Review URL: http://codereview.chromium.org/1796001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45609 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Support themes in the devtools window in GTK mode too.erg@chromium.org2010-04-265-2/+15
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1762009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45606 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing crash in BoundsAnimator. This patch largely justsky@chromium.org2010-04-262-8/+15
| | | | | | | | | | | | cleans things up and fixes some possible usage problems by TabStrip. I'm not confident this fixes the crash, but we'll see. BUG=41538 TEST=none Review URL: http://codereview.chromium.org/1710003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45602 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't display bookmark right click menu when bookmark bar is hidden.erg@chromium.org2010-04-261-1/+1
| | | | | | | | | | | | | | Because the event box is still visible when the bookmark bar is hidden and the event box is connected to the button-press-event, if you right click under the location bar or the browser action icons, you'll show the bookmark menu even if you have it hidden. BUG=none TEST=none Review URL: http://codereview.chromium.org/1704010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45601 0039d316-1c4b-4281-b951-d872f2087c98
* Fix save complete web page crasherestade@chromium.org2010-04-264-18/+28
| | | | | | | | | | | | | Repeatedly saving a page may cause a crash. See the bug for a full discussion. This fixes that by making sure the curretn SavePackage is the same one that called into SaveFileManager::RenameAllFiles. One more hack on the giant, teetering pile of hacks that is the SavePackage system. Can't hurt, right? BUG=42454 TEST=see bug Review URL: http://codereview.chromium.org/1729016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45599 0039d316-1c4b-4281-b951-d872f2087c98
* Search Engine experiment will crash if the user is importing to a non-empty ↵mirandac@chromium.org2010-04-261-0/+8
| | | | | | | | | | | | | profile, and has fewer than 3 default search engines *combined* in the non-empty chrome profile and the browser from which they are importing. BUG= 42554 TEST= Run with the search engine experiment enabled, importing from a browser with only 1 search engine in the list. Make sure the user data dir you are running from is non-empty, *and* that it has a profile with only 1 search engine in its list. Chrome should not crash (experiment will also not appear). Review URL: http://codereview.chromium.org/1736015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45595 0039d316-1c4b-4281-b951-d872f2087c98
* Add geolocation permission to extensions/apps.erikkay@chromium.org2010-04-266-3/+50
| | | | | | | | | BUG=41278 TEST=None Review URL: http://codereview.chromium.org/1695013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45590 0039d316-1c4b-4281-b951-d872f2087c98
* Declare TranslateInfobarController as implementing NSMenuDelegate, requiredmark@chromium.org2010-04-261-2/+3
| | | | | | | | | | for the 10.6 SDK build after r45553. BUG=none TEST=none Review URL: http://codereview.chromium.org/1733018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45587 0039d316-1c4b-4281-b951-d872f2087c98
* Added more keyboard shortcuts for other wizard screens.avayvod@google.com2010-04-261-7/+28
| | | | | | | | | BUG=37068 TEST=Boot so that any wizard is shown. Verify that Ctrl-Alt-{n, u, l, a} switch to network, update, login and account screens correspondingly. Review URL: http://codereview.chromium.org/1696011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45584 0039d316-1c4b-4281-b951-d872f2087c98
* RenderView::UpdateTargetURL should not look at GURL::spec().dglazkov@chromium.org2010-04-261-1/+1
| | | | | | | | | | | | | Doing so causes a DCHECK to fail if GURL does not consider it a valid URL. Contributed by Hans Wennborg <hans@chromium.org>. BUG=41562 TEST=unit_tests --gtest_filter=RenderViewTest.UpdateTargetURLWithInvalidURL Review URL: http://codereview.chromium.org/1718013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45582 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the tab menu to use pin and unpin instead of a check. The macsky@chromium.org2010-04-266-49/+28
| | | | | | | | | | | changes to use the right thing (pinned vs mini) will be done separately. BUG=none TEST=none Review URL: http://codereview.chromium.org/1725006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45581 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Kill off google_update_settings_mac.mm. It's functions are empty and ↵thomasvl@chromium.org2010-04-261-37/+0
| | | | | | | | | | nothing actually calls it. If we ever support rlz, we might need to add something back, but rlz.cc is pretty Windows heavy, so there doesn't seem to be a reason to have this empty shell in the mean time. BUG=39131 TEST=none Review URL: http://codereview.chromium.org/1729013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45580 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: support themes.pfeldman@chromium.org2010-04-262-3/+38
| | | | | | Review URL: http://codereview.chromium.org/1584016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45578 0039d316-1c4b-4281-b951-d872f2087c98
* Remove empty nodes when deleting cookies.jochen@chromium.org2010-04-263-105/+51
| | | | | | | | | BUG=39389 TEST=none Review URL: http://codereview.chromium.org/1751013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45575 0039d316-1c4b-4281-b951-d872f2087c98
* Clear non-wildcard content settings before setting from bubble or prompt.jochen@chromium.org2010-04-264-0/+26
| | | | | | | | | BUG=42359 TEST=manual Review URL: http://codereview.chromium.org/1707011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45571 0039d316-1c4b-4281-b951-d872f2087c98
* Allow user to choose what kind of container to launchaa@chromium.org2010-04-266-10/+89
| | | | | | | | applications in. Review URL: http://codereview.chromium.org/1784001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45570 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of more calls to FromWStringHack.tony@chromium.org2010-04-267-57/+39
| | | | | | | | | | | BUG=24672 TEST=compiles Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1750013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45568 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r45520. This adds a new browser type: EXTENSION_APP thataa@chromium.org2010-04-2618-52/+268
| | | | | | | | | has a larger titlebar and a big icon, along with a tabstrip, but no titlebar. Review URL: http://codereview.chromium.org/1774003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45566 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix use-after-free in translate infobar options menu.jeremy@chromium.org2010-04-251-6/+14
| | | | | | | | | | | | | | | The "About Translate" command opens a new tab which closes the infobar, we where trying to update the options menu which acccessed an already released object. The fix is to match Windows behavior and only rebuild the options menu when clicked. Thanks to Rohit for diagnosing the problem! BUG=42030 TEST=repro in bug description. Review URL: http://codereview.chromium.org/1756006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45553 0039d316-1c4b-4281-b951-d872f2087c98
* mark AppApiTest.AppProcess as flakynsylvain@chromium.org2010-04-251-1/+2
| | | | | | | | | TBR:mpcomplete BUG:42497 Review URL: http://codereview.chromium.org/1752015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45546 0039d316-1c4b-4281-b951-d872f2087c98
* Mac cleanup: get rid of probably-stale TODOs.viettrungluu@chromium.org2010-04-251-4/+0
| | | | | | | | | | | | See comments at <http://codereview.chromium.org/1737013>. TBR=jrg@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/1726007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45545 0039d316-1c4b-4281-b951-d872f2087c98
* Mac cleanup: remove a TODO and add ToolbarControllerTest.NoLocationBar ↵viettrungluu@chromium.org2010-04-242-4/+18
| | | | | | | | | | | (another TODO). BUG=none TEST=ToolbarControllerTest.NoLocationBar passes Review URL: http://codereview.chromium.org/1737013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45543 0039d316-1c4b-4281-b951-d872f2087c98
* Mac cleanup: Put consts and enums in info_bubble_view.h in a namespace.viettrungluu@chromium.org2010-04-2412-58/+66
| | | | | | | | | BUG=none TEST=everything still builds Review URL: http://codereview.chromium.org/1787001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45541 0039d316-1c4b-4281-b951-d872f2087c98
* No-op change to force a build (should fix the build).finnur@chromium.org2010-04-241-1/+1
| | | | | | | | | | (Previous cl included a grd change, so the build broke). BUG=None TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45538 0039d316-1c4b-4281-b951-d872f2087c98
* Add a first run bubble to show after installing an extension app.finnur@chromium.org2010-04-244-19/+94
| | | | | | | | | | | | | | | | | | | | | This is similar to what we show when installing a page action or browser action, albeit with a slightly different text. Also disable the install warning for extension apps, for the time being. And finally, in tab_strip.cc I accidentally checked in a comment, which I had commented out during testing. It was supposed to be on (related to my last cl). BUG=None TEST=Install an extension app, notice a first run bubble instead of a installation warning. The first run bubble should have a checkbox allowing you to create a desktop shortcut. Review URL: http://codereview.chromium.org/1693008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45537 0039d316-1c4b-4281-b951-d872f2087c98
* Minor style fixes.viettrungluu@chromium.org2010-04-242-5/+6
| | | | | | | | | | TBR=feldstein BUG=none TEST=none Review URL: http://codereview.chromium.org/1712012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45531 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix issue 19421: IMEs do not work well in the omnibox due to a race ↵suzhe@chromium.org2010-04-245-54/+136
| | | | | | | | | | | | | | | | condition This CL makes following major changes: 1. Exclude marked text from GetText()'s result. 2. When the text field is in editing mode, EmphasizeURLComponents() changes its attributes through its editor rather than reseting its content. 3. When the text field is in editing mode, SetText() sets its content through its editor. BUG=19421 TEST=See bug report. Review URL: http://codereview.chromium.org/1549033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45524 0039d316-1c4b-4281-b951-d872f2087c98
* Sigh. Revert r45520. Breaks ChromeOS.aa@chromium.org2010-04-2418-263/+52
| | | | | | TBR=jamesr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45523 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Browser actions container tweak.estade@chromium.org2010-04-241-1/+3
| | | | | | | | | | | | | | | | | don't change the show/hide state of the overflow chevron while animating the browser actions toolbar. BUG=none TEST=Don't regress: 1) correct display of browser actions toolbar on startup - when some browser actions are showing - when all browser actions are showing 2) dragging the slider correctly sets the overflow icon, still Fixes: 1) adding an action while the container is fully expanded does not temporarily show the overflow chevron Review URL: http://codereview.chromium.org/1751015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45521 0039d316-1c4b-4281-b951-d872f2087c98
* This adds a new kind of browser window: EXTENSION_APP. EXTENSION_APP windows ↵aa@chromium.org2010-04-2418-52/+263
| | | | | | | | have a bigger titlebar with a giant icon and title, and supports tabs. Review URL: http://codereview.chromium.org/1730010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45520 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes possible crash if the window hosting a menu was closed while thesky@chromium.org2010-04-232-1/+25
| | | | | | | | | | | | | menu was showing. When this happens the window the menu creates is implicitly destroyed (because the parent is going away). BUG=none TEST=Use the test case in 25563, but instead of opening a bookmark menu open either the page or wrench menus. Review URL: http://codereview.chromium.org/1739002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45518 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure that the sync backend host doesn't exist in a post-shutdown state, ↵dantasse@chromium.org2010-04-231-6/+13
| | | | | | | | | | | and make sure the preference is cleared before shutting down the backend. BUG=42269 TEST=none Review URL: http://codereview.chromium.org/1750010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45517 0039d316-1c4b-4281-b951-d872f2087c98
* Added sync_listen_notifications, a utility that connects to an XMPPakalin@chromium.org2010-04-233-0/+235
| | | | | | | | | | | | | | server and listens for sync notifications. It is also useful for debugging libjingle issues. BUG=none TEST=compiled and ran on all platforms Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45484 Review URL: http://codereview.chromium.org/1712002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45513 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused local variables now that subclasses don't need to track their ↵pkasting@chromium.org2010-04-2311-33/+0
| | | | | | | | | | own accessibile name. (In other words, I forgot to do this in r43558.) BUG=none TEST=none Review URL: http://codereview.chromium.org/1751018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45512 0039d316-1c4b-4281-b951-d872f2087c98
* Fix XP crasher in Search Engine Experiment.mirandac@google.com2010-04-232-6/+6
| | | | | | | | | | | This was causing a crash because the View "owns" its images, and was trying to delete the ImageView which had already been deleted in a scoped_ptr. Solution: put the ImageView in a regular pointer instead. BUG= 42346 TEST=run with search engine experiment enabled in XP, don't crash. Review URL: http://codereview.chromium.org/1696010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45510 0039d316-1c4b-4281-b951-d872f2087c98
* I fail at merging. Build fix.evan@chromium.org2010-04-231-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45506 0039d316-1c4b-4281-b951-d872f2087c98
* Add a widget delegate handler for the WM_SETTINGCHANGE message in windows. ↵johnnyg@chromium.org2010-04-232-0/+5
| | | | | | | | | | | This is sent when the size/position of the taskbar changes, and we need to move the desktop notifications if that happens. BUG=35464 TEST=open notifications and move taskbar Review URL: http://codereview.chromium.org/1622018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45504 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Support transparent web image drags.estade@chromium.org2010-04-232-8/+35
| | | | | | | | | | | | | This depends on a webkit side change before it has any effect. This only works on compositing WMs; non-compositing WMs will just not get a transparent image (it actually will appear slightly darkened). BUG=11457 TEST=manul Review URL: http://codereview.chromium.org/1756008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45503 0039d316-1c4b-4281-b951-d872f2087c98
* Minor code issues found by Clang.evan@chromium.org2010-04-232-3/+4
| | | | | | | | | Mostly that "extern const ... = ...;" is not legal. You need two lines to make a non-static const declaration. Review URL: http://codereview.chromium.org/1739005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45502 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Update location-bar icon as user types.shess@chromium.org2010-04-231-0/+3
| | | | | | | | | | | | | | | | | | | Update in |OnChanged()|, just like Windows. NOTE: This CL requires the following change else it breaks the build: http://src.chromium.org/viewvc/chrome?view=rev&revision=44775 [Didn't think to put this note on that change, sorry.] BUG=41362 TEST=Type "www.google.com". You should have a globe icon. TEST=Add a space after first 'w'. Should get search icon. TEST=Generally, icon will switch around as you type. Originally committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=44572 Review URL: http://codereview.chromium.org/1640012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45500 0039d316-1c4b-4281-b951-d872f2087c98
* Run the notifications info bar tests as interactive ui tests rather than ↵johnnyg@chromium.org2010-04-231-9/+10
| | | | | | | | | | | just ui tests. BUG=32807 TEST=included Review URL: http://codereview.chromium.org/1699007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45498 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Nigori unit tests on all platforms.albertb@chromium.org2010-04-233-13/+7
| | | | | | | | | BUG=none TEST=NigoriTest.* Review URL: http://codereview.chromium.org/1736008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45494 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45484 - Added sync_listen_notifications, a utility that connects to ↵akalin@chromium.org2010-04-232-230/+0
| | | | | | | | | | | | | | | | | an XMPP server and listens for sync notifications. It is also useful for debugging libjingle issues. BUG=none TEST=compiled and ran on all platforms Review URL: http://codereview.chromium.org/1712002 TBR=akalin@chromium.org Review URL: http://codereview.chromium.org/1739006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45493 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 00:57:40 +0000