| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This matches the effect when finishing dragging a button.
BUG=None
TEST=Go fullscreen. Omnibox should not have focus. Open a folder on the bookmarkbar and hover over one of its subentries. Overlay should not scroll back up. Dismiss the overlay. Overlay should animate out, not disappear instantly.
Review URL: http://codereview.chromium.org/803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
resized. This is used to close the AutoFill popup in the renderer.
BUG=31865
TEST=none
Review URL: http://codereview.chromium.org/805006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the fadeout animation to prevent the window object from leaking.
BUG=37717
TEST=none
Review URL: http://codereview.chromium.org/822007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
People not using my new code will be unaffected, but this change makes it so the new stuff works again.
Review URL: http://codereview.chromium.org/826003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
handle offline login.
TEST=Unittests, and also run on chromium OS device with --in-chrome-auth
Review URL: http://codereview.chromium.org/822006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. background window containing the status and visual background.
. WizardController creates it's own window for showing the various
wizard dialogs.
I needed to separate these two out as if you have logged in once I
still want the background, and may end up showing the
wizardcontrollers later.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/832002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Uptime was being reported only at startup, and then, for the previous session.
This meant that folks with a long uptime would be very slow to report.
This change moves the reporting to an incremental reporting, done as
often as we report pageloads etc. (i.e., in each UMA upload).
This also fixes several bugs relating to uptime calculation, by using
TimeTicks (which show process time) rather than Time (which shows wall
clock time, and is subject to corruption if the user changes the will
clock time on the computer). It also resolves a bug that may have caused
negative uptimes to be reported.
BUG=37630
r=hunar
Review URL: http://codereview.chromium.org/675001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added support for setting an alternate "pressed" image for status icons.
BUG=37375
TEST=updated unit tests
Review URL: http://codereview.chromium.org/752002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed a few compile errors as a result.
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/790002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have two conventions for declaring GTK+ callbacks in our code: We either
declare a bunch of static thunks in the header that redirect to the correct
object (and bloat up the header) OR we declare the callback methods static and
pass the object as the final parameter (and litter the implementation with
"context->"). The two styles are now about half/half...including mixing these
two styles in the same files. This madness must end!
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27039
TEST=none
TBR=phajdan.jr
Review URL: http://codereview.chromium.org/778006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29424
TEST=covered by browser_tests
Review URL: http://codereview.chromium.org/669133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no appearance change
Review URL: http://codereview.chromium.org/823001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
rendering code with the GPU Plug-in. The drawing model negotiation is currently disabled so this should have no visible impact to plug-ins.
BUG=32012
TEST=make sure the pepper GPU plug-ins still work.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make IsIncognitoEnabled take an Extension* as an argument as well and use that where possible.
BUG=4890
TEST=Select one more bookmarks and right click/tools and select "Open in incognito". The bookmarks should open in an incognito window.
Review URL: http://codereview.chromium.org/750001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
if the user selects a file via the filebrowser.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/749001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
r26348.
BUG=35578 (sort of), 35569 (when I fixed some of these in the past)
TEST=10.6 SDK build
Review URL: http://codereview.chromium.org/822003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The initial focus on x11/gtk was not working propertly. It was jsut
working by coincident, and chromeos's compact location bar revealed
the bug. This CL fixes by setting a focus when the window itself gets focus.
BUG=34159
TEST=on chromeos build, omnibox should have a focus on a new window.
Review URL: http://codereview.chromium.org/756002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- DEPS roll to pick up newer GTM with wrapping support.
- Bring the Mac dangerous download closer inline with what windows does, already have mail out to UX about a real spec since all 3 platforms do different things in different cases.
BUG=28705
TEST=see bug
Review URL: http://codereview.chromium.org/787004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/660087
http://codereview.chromium.org/669238
BUG=37533
TEST=none
Review URL: http://codereview.chromium.org/829001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring network library observer back.
Fix rare crash when connecting Ethernet on network selection screen.
BUG=35016
TEST=With --login-manager=network screen should be shown and when accessing encrypted Wifi network dialog box with password field should appear.
Review URL: http://codereview.chromium.org/726001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Things still look a bit off due to the lack of a gradient, but that's a
separate issue.)
BUG=35960
TEST=Make sure background tabs look the same as before in normal (non-fullscreen) mode, both when the window is active and when it isn't. Make sure background tabs look approximately correct in fullscreen mode, both when the fullscreen window is active and when it isn't (for the latter, make the floating bar visible by focusing the Omnibox, and switch to another app using Cmd-`); note that it won't look exactly right since we're still missing a gradient.
Review URL: http://codereview.chromium.org/661295
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added ifdef.
BUG=None
TEST=None
TBR=kkania
Review URL: http://codereview.chromium.org/822004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also convert app/gtk_dnd_util.h from a class to a namespace for consistency
with added app/gtk_util.h.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/669268
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1683
TEST=none
Review URL: http://codereview.chromium.org/793001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes a bug where we could end up with two sets of buttons after a reload.
BUG=37804
TEST=Go into edit mode and select and deselect a bunch of entries. The disabled state of the remove button should be in sync.
Review URL: http://codereview.chromium.org/815001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Note that the folder menu can't be showing its submenu when the user starts the drag. Since the submenu shows automatically, the user actually has to click once to get rid of it before starting the drag.
BUG=30066
TEST=put a folder node in the other bookmarks folder. Drag it out of the other bookmarks folder and onto the bookmarks bar.
Review URL: http://codereview.chromium.org/799004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=19791
TEST=Hit cmd-shift-f. Drool.
Review URL: http://codereview.chromium.org/661045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
sharing IPC and some rendering code with the GPU Plugin. The drawing model negotiation is currently disabled so this should have no visible impact to plugins.
BUG=32012
TEST=make sure the pepper GPU plugins still work.
Review URL: http://codereview.chromium.org/673001
TBR=pinkerton@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
rendering code with the GPU Plug-in. The drawing model negotiation is currently disabled so this should have no visible impact to plug-ins.
BUG=32012
TEST=make sure the pepper GPU plug-ins still work.
Review URL: http://codereview.chromium.org/673001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
kCWScanKeyMerge
BUG=http://crbug.com/37703
TEST={build on 10.5 & 10.6 } x {run browser on 10.5 & 10.6 }
Review URL: http://codereview.chromium.org/691005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This should cover most cases I'd like to cover.
TEST=none
BUG=30405
Review URL: http://codereview.chromium.org/718002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
test must wait on the extension being updated if no icon is
found.
I think this should fix the flakiness in the test.
BUG=None
TEST=Fixing a browser test (hopefully).
Review URL: http://codereview.chromium.org/772001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change integrates the custom AeroPeek implementation into Chromium, which shows the thumbnail list of all tabs and the preview image of the tab selected from the thumbnail list. It uses the AeroPeekManager object, which is a proxy between TabStripModel and Windows to translate events from TabStripModel for Windows, and vice versa. To listen events from TabStripModel without changing the existing part of Chromium, this AeroPeekManager class implements the TabStripModelObserver interface.
Even though this change doesn't include any automated tests for AeroPeek, I would like to send its automated UI test as a separate change. Nevertheless, it just creates/deletes a tab and see this AeroPeekManager can create its thumbnail window correctly.
BUG=6337
TEST=base_unittests.exe --gtest_filter=ScopedNativeLibrary.Basic
Review URL: http://codereview.chromium.org/303033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also refactor FirstRunTabs to use GURL instead of wstring.
BUG=none
TEST=Add master_preferences file to directory containing the chrome binary and
execute chrome with the --first-run option.
Original patch by bgmerrell@gmail.com at
http://codereview.chromium.org/551160
Review URL: http://codereview.chromium.org/796001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/668105.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/813001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Changes to add basic automation proxy support to chromeos login wizard
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/783003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
2. Adjust transparency of background tabs a little.
3. Implement loading animation for side tabs.
4. Deeper shadow for side tabstrip between browser view and side tabstrip.
http://crbug.com/34509
TEST=none
Review URL: http://codereview.chromium.org/610002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
o Icons fade out as they are moved off screen by resizing the window.
o Dragging the resizer actually resizes the container.
o Known issues include:
+ no chevron.
+ no updating of other windows if the size of the container changes.
+ the cursor is a bit wonky in updating its state.
o Fixes a slew of janky UI bugs relating to having a lot of extensions installed.
BUG=26990,29838
TEST=none
Review URL: http://codereview.chromium.org/657038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41114 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
mousecapturelost arrives after mouseup.
Review URL: http://codereview.chromium.org/743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Open the options page in a regular browser window.
- Rip out the "incognito" permission and revise the warning dialog.
BUG=37677
Review URL: http://codereview.chromium.org/749002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=1006
TEST=none
Review URL: http://codereview.chromium.org/788001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/745003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=4890
TEST=Start with --enable-tabbed-bookmark-manager
Review URL: http://codereview.chromium.org/780001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
by the SafeBrowsingInterstitialPage.
The interstitial page logic makes sure its Proceed/DontProceed
are called only once, but the DontProceed could also be called
when navigating back. Since the SafeBrowsingService::Client
is deleted when the SafeBrowsingService is notified, that would
cause a crasher on the 2nd notification.
BUG=http://crbug.com/30079
TEST=See bug.
Review URL: http://codereview.chromium.org/697002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41092 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=34391
Review URL: http://codereview.chromium.org/748002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/37690
TEST=as in comment 3 on the bug
Review URL: http://codereview.chromium.org/729002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41084 0039d316-1c4b-4281-b951-d872f2087c98
|