summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Fix location bar display.thakis@chromium.org2009-07-271-1/+1
| | | | | | | | | BUG=17667 TEST=see bug Review URL: http://codereview.chromium.org/160142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21634 0039d316-1c4b-4281-b951-d872f2087c98
* NNTP: Change the lower right section to say "What will we put here?"arv@google.com2009-07-271-2/+1
| | | | | | | | | | | | TBR=glen@chromium.org BUG=None Test=None Review URL: http://codereview.chromium.org/159393 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21633 0039d316-1c4b-4281-b951-d872f2087c98
* add test to verify mole data being readerikkay@chromium.org2009-07-261-0/+3
| | | | | | | | TBR=mpcomplete Review URL: http://codereview.chromium.org/160148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21632 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the concept of threading from ProxyService, and move it into the ↵ericroman@google.com2009-07-261-9/+29
| | | | | | | | | | | | | | | | | | | | | | | | ProxyResolver dependency. ProxyResolver may now complete requests asynchronously, and is defined to handle multiple requests. The code from ProxyService that queued requests onto the single PAC thread has moved into SingleThreadedProxyResolver. This refactor lays the groundwork for: (1) http://crbug.com/11746 -- Run PAC proxy resolving out of process. (Can inject an IPC bridge implementation of ProxyResolver) (2) http://crbug.com/11079 -- Run PAC proxy resolving on multiple threads. (Can implement a MultithreadedProxyResolver type class; still complications around v8 threadsafety though). BUG=http://crbug.com/11746, http://crbug.com/11079 TEST=existing unit-tests. Review URL: http://codereview.chromium.org/149525 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21631 0039d316-1c4b-4281-b951-d872f2087c98
* Fix exception in DownloadManager if the download has no extension.aa@chromium.org2009-07-261-1/+2
| | | | | | | TBR=erikkay Review URL: http://codereview.chromium.org/159392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21628 0039d316-1c4b-4281-b951-d872f2087c98
* Modify detection of Chrome extensions in download manager. Itaa@chromium.org2009-07-261-3/+17
| | | | | | | | | | | | | | turns out many servers send the no-sniff option, including the one we use for our sample extensions. So we can't rely on mime types to detect Chrome extensions, at least until we have some place to put our samples that doesn't have this problem. TBR=erikkay Review URL: http://codereview.chromium.org/159391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21627 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to commit r21622: Add infobar preview for themes,aa@chromium.org2009-07-267-39/+160
| | | | | | | | remove --enable-extension requirement. Review URL: http://codereview.chromium.org/159390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21626 0039d316-1c4b-4281-b951-d872f2087c98
* Revert revisions 21622-21624.aa@chromium.org2009-07-267-172/+47
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21625 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken tree.aa@chromium.org2009-07-261-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21624 0039d316-1c4b-4281-b951-d872f2087c98
* Fix broken tree on mac/linux.aa@chromium.org2009-07-263-1/+1
| | | | | | Review URL: http://codereview.chromium.org/159389 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21623 0039d316-1c4b-4281-b951-d872f2087c98
* Add infobar preview for themes, remove --enable-extensionaa@chromium.org2009-07-267-47/+172
| | | | | | | requirement. Review URL: http://codereview.chromium.org/160141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21622 0039d316-1c4b-4281-b951-d872f2087c98
* add mole info to toolstrip definition and enable moleserikkay@chromium.org2009-07-2611-90/+183
| | | | | | Review URL: http://codereview.chromium.org/159202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21621 0039d316-1c4b-4281-b951-d872f2087c98
* Make the download manager display a scary file warning if anaa@chromium.org2009-07-253-29/+51
| | | | | | | extensions is not from the gallery. Review URL: http://codereview.chromium.org/159379 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21620 0039d316-1c4b-4281-b951-d872f2087c98
* * notify theme loading with --load-extensionerikkay@chromium.org2009-07-251-11/+22
| | | | | | | | * fix crasher in theme parsing with no images Review URL: http://codereview.chromium.org/160124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21619 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the tips service by default.arv@google.com2009-07-254-12/+13
| | | | | | | | | | | | | Update the UI to not say tips or recommendations. BUG=None TEST=Starting chrome should not show any tips byt default Review URL: http://codereview.chromium.org/160138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21615 0039d316-1c4b-4281-b951-d872f2087c98
* Implement mimetype sniffing for extensions.aa@chromium.org2009-07-253-3/+13
| | | | | | | | | | | abarth: can you review the changes to mime_sniffer.cc? paul: everything else? BUG=13296 TEST=Added unit tests Review URL: http://codereview.chromium.org/159345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21612 0039d316-1c4b-4281-b951-d872f2087c98
* , INNTP: Adds 2 hard coded thumbnails.arv@google.com2009-07-252-4/+74
| | | | | | | | | | | | | This code needs to be rewritten after beta to handle localized content. BUG=15079 TEST=Start chrome with a new profile. There should be 2 thumbnails on the new tab page. Review URL: http://codereview.chromium.org/160126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21608 0039d316-1c4b-4281-b951-d872f2087c98
* Stop drawing the status bubble text highlight because it sucks for themes.glen@chromium.org2009-07-251-23/+16
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/159292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21604 0039d316-1c4b-4281-b951-d872f2087c98
* Use referrer_url instead of download url to decide whether aaa@chromium.org2009-07-256-18/+53
| | | | | | | theme installation can happens sans-prompt. Review URL: http://codereview.chromium.org/160087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21603 0039d316-1c4b-4281-b951-d872f2087c98
* Make some default file dialog titles for linux.estade@chromium.org2009-07-252-7/+14
| | | | | | | | | | | Seems Windows only lets you set some text inside the dialog above the tree view, and not in the titlebar. BUG=16890 TEST=should be obvious Review URL: http://codereview.chromium.org/159326 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21600 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Window modality in TOOLKIT_VIEWS, and allow windows to be centered ↵ben@chromium.org2009-07-251-1/+1
| | | | | | | | | | over their modal parent or the screen if there is no modal parent. This means child windows don't open at 0,0 anymore. BUG=none TEST=none Review URL: http://codereview.chromium.org/159335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21599 0039d316-1c4b-4281-b951-d872f2087c98
* Add in UMA logging for context menu playback controls.ajwong@chromium.org2009-07-251-0/+11
| | | | | | | | | BUG=15686 TEST=none Review URL: http://codereview.chromium.org/159371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21598 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 21588 to make Linux toolkit dbg happy.mhm@chromium.org2009-07-252-13/+12
| | | | | | | TBR: thiago Review URL: http://codereview.chromium.org/159378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21597 0039d316-1c4b-4281-b951-d872f2087c98
* Partial fix to 7028 - Pinning in Win7.A complete fix will require Gears to ↵brg@chromium.com2009-07-251-0/+6
| | | | | | | | | | set the application id as a property on the shortcut As of this cl, web applications hosted by Chrome will appear in their own groups on the task bar. However, they can not be pinned from the main application window nor can they be pinned from the shortcut. The former results in Chrome being pinned, and the latter results in a quick start button but does not group web applications under that button. Instead in the latter case a web appliation will form a new group. Bug=7028 Test=None. (When there is a Win7 trybot there may be at test to check if the windows group in the taskbar properly) Review URL: http://codereview.chromium.org/159336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21595 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 21593.mhm@chromium.org2009-07-251-3/+2
| | | | | | | TBR=thiago Review URL: http://codereview.chromium.org/159377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21594 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux Toolkit dbg bustage.mhm@chromium.org2009-07-251-2/+3
| | | | | | | | | BUG=None TEST=None TBR=nsylvain Review URL: http://codereview.chromium.org/159375 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21593 0039d316-1c4b-4281-b951-d872f2087c98
* Porting POINT to gfx::Point for automation providermhm@chromium.org2009-07-242-12/+13
| | | | | | | | | | | BUG=None TEST=None Patch by tfarina Original Review: http://codereview.chromium.org/155888 Review URL: http://codereview.chromium.org/160088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21588 0039d316-1c4b-4281-b951-d872f2087c98
* Move setlocale() to zygote_main_linux to make sure that it's calledjshin@chromium.org2009-07-241-0/+8
| | | | | | | | | | | | | | before the sandbox is triggered. BUG=16860 (http://crbug.com/16860 ) TEST=Run Chrome with LC_ALL=en_US.UTF-8. 1. Make sure that you don't see any warning about 'setlocale failing'. 2. Upload a file whose name contains non-ASCII characters in UTF-8 (e.g. "café.txt" or "一二.txt" ) . The filename field in a form should be populated with the name (rather than empty). Review URL: http://codereview.chromium.org/160112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21586 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 2 bugs in extensions autoupdate request parameters.asargent@chromium.org2009-07-242-17/+116
| | | | | | | | | | | | | -Separator that should be between id and version parameters was at the end of version -Missing the "uc" parameter which the gallery server code was expecting as indication of an update check BUG=http://crbug.com/17469 TEST=extensions auto-update should work Review URL: http://codereview.chromium.org/159224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21582 0039d316-1c4b-4281-b951-d872f2087c98
* Implement feature where tabs don't resize when using the close box until the ↵pinkerton@chromium.org2009-07-242-8/+95
| | | | | | | | | | mouse leaves the tab strip. Also turn off zordering fix from before, it regressed things. BUG=14912 TEST=creating a bunch of tabs and making sure that after you close them and mouse away, they return to the correct sizes. Creating new tabs after that should all be the correct size as well. Review URL: http://codereview.chromium.org/160116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21581 0039d316-1c4b-4281-b951-d872f2087c98
* fix toolkit_views compile due to AutocompleteEditViewGtk change.tc@google.com2009-07-241-0/+1
| | | | | | | | | TBR=estade Review URL: http://codereview.chromium.org/159367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21579 0039d316-1c4b-4281-b951-d872f2087c98
* Implement location only display mode (used by popup windows).tc@google.com2009-07-246-35/+96
| | | | | | | | | | | | This matches the pixel sizes on Windows. The location bar is a couple pixels shorter and the font is a little smaller. BUG=17580 Review URL: http://codereview.chromium.org/159303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21578 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't close info bubbles based on which toplevel is active.estade@chromium.org2009-07-242-21/+12
| | | | | | | | | | | | | | | This fixes the behavior for active toplevel windows and focus follows mouse that moving the mouse onto and then off of the bookmark bubble will close it. This also fixes that we might paint the tab strip active while the system title bar is painted inactive. Unfortunately we can't stop the browser window from painting inactive when using the system frame. This reverts us to the old bad behavior that you could drag around the browser window and the bookmark bubble will stay in place. It also reverts us to allowing the info bubble to being able to persist even if it doesnt have focus. This doesn't match windows, but I'm not convinced windows is all that great. BUG=none TEST=see above Review URL: http://codereview.chromium.org/159288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21576 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Let custom draw buttons specify their stock size as well as their stock ↵estade@chromium.org2009-07-248-20/+23
| | | | | | | | | | | | | image. I tried to also make the tab strip use stock gtk close button but that is gonna require a lot more work to get layout right so leave it alone for now. BUG=none TEST=close button on download shelf is sanely sized Review URL: http://codereview.chromium.org/159325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21575 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass FilePaths and strings by reference.jhawkins@chromium.org2009-07-242-7/+8
| | | | | | | | | CID=2716,4565,5054 BUG=none TEST=none Review URL: http://codereview.chromium.org/160120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21574 0039d316-1c4b-4281-b951-d872f2087c98
* A crasher from the field indicates that the focus manager can be NULL when ↵jcampan@chromium.org2009-07-241-4/+11
| | | | | | | | | | | | the FindBarWin is instanciated. It is not clear how this can happen. BUG=17056 TEST=None Review URL: http://codereview.chromium.org/161001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21573 0039d316-1c4b-4281-b951-d872f2087c98
* Change the background color of the NNTP lower sections.arv@google.com2009-07-241-1/+1
| | | | | | | | | | | BUG=None TEST=The background color of the lower sections on the NNTP should be light blue. Review URL: http://codereview.chromium.org/159350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21571 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass FilePaths by reference.jhawkins@chromium.org2009-07-242-3/+4
| | | | | | | | | CID=2696 BUG=none TEST=none Review URL: http://codereview.chromium.org/159353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21567 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass strings by reference.jhawkins@chromium.org2009-07-242-6/+7
| | | | | | | | | CID=2714,2715 BUG=none TEST=none Review URL: http://codereview.chromium.org/159351 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21566 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where an ongoing find operation would re-appear eventc@google.com2009-07-242-1/+5
| | | | | | | | | | | | | | | | | | though we already changed the find text. On Linux, we would continue doing a find operation. On Windows, the find operation would stop, but the find box would not be cleared. TEST=Go to a long page (like the html 5 spec). Do a find for a very common string (e.g., any single letter). Press backspace to clear the find box while results are still populating. The find box should be cleared and the find stopped. Review URL: http://codereview.chromium.org/159321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21555 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the win build. path is being modified and returned, so it can't be a ↵jhawkins@chromium.org2009-07-241-1/+1
| | | | | | | | const ref. TBR=finnur git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21547 0039d316-1c4b-4281-b951-d872f2087c98
* Fix frame overlay display in incognito mode, make location bar background ↵glen@chromium.org2009-07-242-2/+9
| | | | | | | | | | | follow theme tinting. BUG=none TEST=none Review URL: http://codereview.chromium.org/159340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21545 0039d316-1c4b-4281-b951-d872f2087c98
* More (temporary) cleanup for theme installation:aa@chromium.org2009-07-243-28/+52
| | | | | | | | | | | - Modify the gallery URL to only allow SSL. - Remove the special case that allowed theme installation without --enable-extension. Now that we have the gallery special case this is not necessary anymore. - Modify the dialog language to be a little less lame. Review URL: http://codereview.chromium.org/159301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21543 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Theme the tab close button.jhawkins@chromium.org2009-07-244-6/+62
| | | | | | | | BUG=none TEST=Open a browser window. The close button should be visible. Apply a theme with a colored close button. The close button color should match the theme. Review URL: http://codereview.chromium.org/159338 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21542 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass strings and GURLs by reference.jhawkins@chromium.org2009-07-243-6/+11
| | | | | | | | | CID=5051,5052,5053 BUG=none TEST=none Review URL: http://codereview.chromium.org/159343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21541 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Pass strings by reference.jhawkins@chromium.org2009-07-248-24/+28
| | | | | | | | | CID=4459,4563,4564,4566,4567,4569,4570,4571,4803 BUG=none TEST=none Review URL: http://codereview.chromium.org/159342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21540 0039d316-1c4b-4281-b951-d872f2087c98
* Some fixes to make NNTP themes work again.glen@chromium.org2009-07-242-7/+15
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21539 0039d316-1c4b-4281-b951-d872f2087c98
* Stop using strings for NTP logo inversionglen@chromium.org2009-07-241-3/+3
| | | | | | | | | BUG=14578 TEST=none Review URL: http://codereview.chromium.org/160105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21538 0039d316-1c4b-4281-b951-d872f2087c98
* linux: swap buttons on first run dialogevan@chromium.org2009-07-241-2/+2
| | | | | | | | Cancel goes on the left. Review URL: http://codereview.chromium.org/160103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21537 0039d316-1c4b-4281-b951-d872f2087c98
* Return Error Status Upon Blocking Requestsidanan@chromium.org2009-07-242-4/+29
| | | | | | | | | | | | | | | Blocked requests now return an error status so that the Chrome throbber does not spin indefinitely when blocking URL requests. This code shall be replaced with resource substitution next but gives a better experience until then. Same goes for the added type-based interception. TEST=none BUG=16932 Review URL: http://codereview.chromium.org/159214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21536 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 03:41:27 +0000