| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3867
TEST=manual. ran the unit_test as well.
Review URL: http://codereview.chromium.org/2764001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3683
TEST=manual
Review URL: http://codereview.chromium.org/2767001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3966
TEST=Open chewing options. Examine.
Review URL: http://codereview.chromium.org/2755003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reactivates them when screen is unlocked.
Note that if two or more keyboard layouts are active, you can switch layout by pressing the language hot-key (Shift+Alt), though the language indicator ("EN") is not clickable yet.
BUG=chromium-os:3936
BUG=chromium-os:2714
TEST=manual
Review URL: http://codereview.chromium.org/2771005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SyncCustomize.xib changes: Added checkbox for extensions and hooked it up
via KVO to SyncCustomizeController.
BUG=32413
TEST=manual
Review URL: http://codereview.chromium.org/2714006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: This was a TODO for akalin).
BUG=None
TEST=trybots, and manually
Review URL: http://codereview.chromium.org/2704002
TBR=tfarina@chromium.org
Review URL: http://codereview.chromium.org/2733009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49357 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basically this would mean that metrics reporting would be done directly
by ChromeFrame. Currently ChromeFrame uses Chrome to upload this data.
Refactored the chrome metrics service and metrics logging functionality into base classes defined in chrome\common\metrics_helpers.cc/.h. While
this refactoring is by no means complete it is a first step to avoid needless code duplication between chrome and chrome frame.
Bug=46057
Review URL: http://codereview.chromium.org/2744003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Note: This was a TODO for akalin).
BUG=None
TEST=trybots, and manually
Review URL: http://codereview.chromium.org/2704002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
already do.
This also makes GTK and Mac reset the location bar in the correct cases with various types of clicks on back/forward.
BUG=none
TEST=Middle-click reload. It should reload the page in a new background tab.
Review URL: http://codereview.chromium.org/2779011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38572
TEST=uitest, also "chrome/Debug/chrome.exe & chrome/Debug/chrome.exe"
Review URL: http://codereview.chromium.org/2664004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49348 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was unjustly reverted due to flaky unit-test failure.
Original review:
http://codereview.chromium.org/2358003
TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/2720003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49344 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It seems to be breaking the ExtensionAPIClientTest.CreateWindowW unit-test.
BUG=25564
TEST=none
Review URL: http://codereview.chromium.org/2358003
TBR=ctguil@chromium.org
Review URL: http://codereview.chromium.org/2782003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49343 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=25564
TEST=none
Review URL: http://codereview.chromium.org/2358003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49339 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
unpack directory.
BUG=35198,13044
TEST=FileUtilTest.NormalizeFilePathBasic,FileUtilTest. NormalizeFilePathReparsePoints,FileUtilTest.NormalizeFilePathSymlinks
Review URL: http://codereview.chromium.org/2088006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=18775
TEST=import passwords from Firefox on OS X.
Review URL: http://codereview.chromium.org/2725005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49336 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the outer application's Info.plist.
This ensures that the framework and other contents of the versioned directory
can be bit-for-bit identical for a given version, regardless of configured
Keystone channel. This will enable binary diff updates, because they will not
need knowledge of the channel a user is upgrading from.
BUG=45017
TEST=Keystone still functions properly, channel still shows up in the about
window and about:version of official builds
Review URL: http://codereview.chromium.org/2791001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49334 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a sound mute icon and swap between sound high and mute icon based on
volume change;
- Change sound button click to toggle volume mute;
- Show volume control when mouse over sound button and hide it when mouse
leaves;
- Call volumeChange after we setupPlaybackControls so that volume slider's
value syncs with media element's volume;
- Removed "controlbutton" class from "volume" element because it is really
a control button and "controlbutton" style sets its hight to 30px;
BUG=chromium-os:3148
TEST=Verify click on sound button mute/unmute audio and volume slider shows up when mouse over sound button.
Review URL: http://codereview.chromium.org/2722006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
as flaky on Windows
BUG=46198
TEST=XP/Vista bots do not turn red due to this test.
TBR=jcivelli
Review URL: http://codereview.chromium.org/2739005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49330 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
are leaking through as HTML in non-HTML notifications.
BUG=45859
TEST=see bug
Review URL: http://codereview.chromium.org/2743007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed redundent version from update string.
Added a line break to the ChromeOS version on test builds to improve appearence
(select and drag to see complete version).
Added margins to multiline edit fields without borders to make them match
single line edit fields in positioning.
Fixed an issue with setting the initial focus for GTK based windows. This
fixes the problem of the cursor showing up in the version field.
BUG=chromium-os:3571 1589 2967
TEST=none
Review URL: http://codereview.chromium.org/2620003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Build succeeds using 10.6 SDK
Review URL: http://codereview.chromium.org/2790005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
It was reverted due to breaking a valgrind test which has since been disabled.
Review URL: http://codereview.chromium.org/2763004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I got it to a point where we show HTML content from the extension within an infobar, but there are a few things missing.
Missing pieces:
- Infobar does not size based on the height of its content (between 36px and 72px).
- Infobar content always has a fixed width, but needs to fill out into the available infobar area.
- I've put in code to asynchronously fetch the image for the Infobar, but it needs to be shown and hooked up to the ExtensionAction context menu (same context menu we use for the browser action container icons).
- The background for HTML content should have a gradient, but is just solid blue at the moment.
BUG=39916
TEST=Infobars should show up on GTK.
Review URL: http://codereview.chromium.org/2753005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The reason I'm collapsing all the "create left/center/right sections" functions into one is because in the upcoming patch that moves "stop" from "go" onto "reload", I'll need to reorder bits within this unified block, and that change will be easier to review if this mechanical change lands first.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2781003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of adding window_contents_ as grab widget.
Explicitly adding grab widget was confusing gtk and the event has been handled by grab widget rather than by the window the event is forwarded to.
This CL fixes it by removing all grab widget and let gtk propagage event in target window.
BUG=none
TEST=open screen locker, type wrong password to show message bubble,
then close it by clicking close (x) button.
Review URL: http://codereview.chromium.org/2788001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
displaying in a tab. This could happen when the user types in a new query before
the AlternateNavURLFetcher was able to resolve the URL.
BUG=43378
TEST=Load two single word domains within quick succession in the same tab.
Review URL: http://codereview.chromium.org/2747006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:3462
TEST=none
Review URL: http://codereview.chromium.org/2758004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since some work is needed on Linux and Mac to use the new translate infobar delegate, I created a new version of the refactored classes instead of replacing them. Once Linux and Mac use the new classes, we can make the swicth.
The TranslateInfoBarDelegate now contains all states, so there is no more logic on the infobar classes.
I broke down the single infobar class into multiple ones (there is now an infobar for each state: before translate, translating, after translate, error): it makes the code simpler.
I had to fix ReplaceInfoBar on Windows as it was not working properly.
BUG=40828
TEST=Test thoroughly the translate feature.
Review URL: http://codereview.chromium.org/2602003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Before we carefully used the app (Chrome/Chromium) name, but:
1) these are for internal debugging use only, so why compute this name
2) on Linux the thread ids are limited to 16 characters, and "Chromium"
is too long
Review URL: http://codereview.chromium.org/2741003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
2. Timed updates of the database based on the number of sites changed.
BUG=None
TEST=TopSitesTest
Review URL: http://codereview.chromium.org/2746002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2746005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the layout of content and general page. Use the horizontal title and content layout for each option group.
BUG=18949
TEST=Open the option window, check the content and general pages.
Patch by Ningxin Hu <ningxin.hu@intel.com>.
Review URL: http://codereview.chromium.org/1969006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
BUG=46114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert from using NSBitmapImageRep plus context manipulation to
-[NSImage lockFocus].
BUG=none
TEST=Browser actions look the same as before.
Review URL: http://codereview.chromium.org/2635005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
A DictionaryValue we need to keep was being autoreleased in the Mac message loop. The import process uses only C++ code, so we just make a deep copy of the (very small, 5 strings) Dictionary when it's passed into the bridge.
BUG=46003
TEST=import works on Mac OS 10.6 and 10.5
Review URL: http://codereview.chromium.org/2715006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
AFAICT was being used by the star button, which is now a page action.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2675003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New mocks are attached to bug 44622. These changes replace the in-place editing of address and credit card records with a table of records and separate sheets for manipulating the record data. Changes to the layout of fields on the sheets has been done also.
AutoFillDialog.xib changes: Replaced disclosure based list of address and credit cards with an NSTableView of the same data. Added buttons for "Add", "Edit", and "Remove".
Replaced AutoFillAddressViewController.xib with sheet-based AutoFillAddressSheetController.xib.
Replaced AutoFillCreditCardViewController.xib with sheet-based AutoFillCreditCardSheetController.xib.
BUG=44621
TEST=AutoFillAddressModelTest,AutoFillAddressSheetControllerTest,AutoFillCreditCardModelTest,AutoFillCreditCardSheetControllerTest,AutoFillDialogControllerTest
Review URL: http://codereview.chromium.org/2673006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IndexedDBDispatcherHost::OnMessageReceivedWebKit()
before passing the message to IndexedDBDispatcherHost for processing.
This is a clone of
http://codereview.chromium.org/2657007/show
which was LGTM'ed by Jeremy Orlow.
Review URL: http://codereview.chromium.org/2711004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It was pulling internal geolocation headers into resource_message_filter.cc
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2742002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the other switch we were using in the plugins directory to the new file as well.
TEST=covered by UI test
BUG=none
Review URL: http://codereview.chromium.org/2716002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=All controls are disabled on "New User" screen with login is in progress
Review URL: http://codereview.chromium.org/2774004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is a clone of
http://codereview.chromium.org/2607001/show
which was reviewd and LGTM'ed by Jeremy Orlow.
Review URL: http://codereview.chromium.org/2740003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
library
Review URL: http://codereview.chromium.org/2510001
TBR=chaitanyag@chromium.org
Review URL: http://codereview.chromium.org/2770006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed drawing to use -drawInRect: rather than -drawAtPoint: so that
the neverFlipped: flag can be passed.
BUG=38943
TEST=Browser actions draw upright in both toolbar and overflow popup.
Review URL: http://codereview.chromium.org/2685001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Use it for "Can't access your account" link.
BUG= http://crosbug.com/3179
TEST=Open "Can't access your account" link from "New User" view.
Review URL: http://codereview.chromium.org/2675007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/2510001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Needs http://codereview.chromium.org/2002012 to build).
BUG=42695
TEST=manually visit about:sync
Review URL: http://codereview.chromium.org/1987009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:2413
TEST=Verify fix for chromium-os:2413.
Review URL: http://codereview.chromium.org/2779004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:1797
TEST=Verify fix for chromium-os:1791.
Review URL: http://codereview.chromium.org/2659004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49254 0039d316-1c4b-4281-b951-d872f2087c98
|