summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Move Emf class to the printing library. Also creates a platform agnostic ↵sverrir@google.com2009-07-068-42/+38
| | | | | | | | | | | NativeMetafile definition to ease platform porting. BUG=none TEST=none (No functional change) Review URL: http://codereview.chromium.org/149181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19943 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: preserve focus on activating dev tools window.pfeldman@chromium.org2009-07-066-0/+27
| | | | | | | | BUG=15912 Review URL: http://codereview.chromium.org/155068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19938 0039d316-1c4b-4281-b951-d872f2087c98
* Redraw the location bar on reload. This change is Mac port of ↵yusukes@google.com2009-07-061-1/+1
| | | | | | | | | | | http://codereview.chromium.org/100198. BUG=none TEST=open http://dev.chromium.org/, double click the location bar, press delete (delete URL string), press reload button, verify the URL is redrawn. Review URL: http://codereview.chromium.org/155070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19936 0039d316-1c4b-4281-b951-d872f2087c98
* Fix problems with render_widget_host_ being deleted out-of-sync with ↵shess@chromium.org2009-07-062-12/+32
| | | | | | | | | | | | | | | cocoa_view_. Right after Destroy() is called, render_widget_host_ is deleted. So clear render_widget_host_ and guard calls to render_widget_host_. http://crbug.com/14613 http://crbug.com/13514 http://crbug.com/12725 Review URL: http://codereview.chromium.org/155021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19933 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that VisitedLink listener Add event only fires when new fingerprint ↵dglazkov@chromium.org2009-07-043-17/+20
| | | | | | | | | | | | is added, and not during resizing/rebuilding or deleting fingerprints. R=brettw TEST=VisitedLinkTest.Listener BUG=15926 Review URL: http://codereview.chromium.org/149185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19931 0039d316-1c4b-4281-b951-d872f2087c98
* Add an ExtensionBrowserTest base class that allows in-process browser tests ↵aa@chromium.org2009-07-0420-363/+328
| | | | | | | | of extensions using ExtensionsService directly, rather than TestExtensionLoaded. Use it to re-enable some old browser tests that had been disabled. Review URL: http://codereview.chromium.org/150213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19930 0039d316-1c4b-4281-b951-d872f2087c98
* Initial html page views for print preview and setupmhm@chromium.org2009-07-034-0/+26
| | | | | | | | | | | This is still the foundation, has no implementation, just plain old html and its structure. BUG=173, 947 TEST=none Review URL: http://codereview.chromium.org/155051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19918 0039d316-1c4b-4281-b951-d872f2087c98
* Fix EOL style on this file.maruel@chromium.org2009-07-031-293/+293
| | | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19913 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Acid3 Test 48: LINKTEST, Chromium side....dglazkov@chromium.org2009-07-0324-115/+939
| | | | | | | | | | | | | | | | | R=brettw BUG=http://crbug.com/231 BUG=http://crubg.com/5160 TEST=ExpireHistoryTest.ArchiveSomeOldHistory TEST=ExpireHistoryTest.ExpiringVisitsReader TEST=VisitedLinkTest.Listener TEST=VisitedLinkTest.Resizing TEST=VisitedLinkRelayTest.* TEST=VisitedLinkEventsTest.* Review URL: http://codereview.chromium.org/113591 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19910 0039d316-1c4b-4281-b951-d872f2087c98
* Move RenderViewHostManager back to tab_contents. Moving it to renderer_hostbrettw@chromium.org2009-07-037-60/+95
| | | | | | | | | | | | | | | was a bad idea because of its significant dependencies on NavigationController and NavigationEntry. I'm trying to make renderer_host not depend on tab_contents at all. Remove the dependency on TabContents pointers for notifications from the ResourceDispatcherHost. Instead of having the broadcast code in the ResourceDispatcherHost, I made it call a RenderViewHostDelegate callback. Then TabContents implements the notification, so that it's really from the TabContents. Review URL: http://codereview.chromium.org/150069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19909 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unused notification in print code to simplify before refactoring.sverrir@google.com2009-07-037-112/+72
| | | | | | | | | | | | Removed the PRINTED_DOCUMENT_UPDATED notification and move the debug output from PrintJobManager to PrintedDocument. Also made the --debug-print startup parameter only active in non-official builds. BUG=none TEST=Should have no functional affect. Review URL: http://codereview.chromium.org/149148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19907 0039d316-1c4b-4281-b951-d872f2087c98
* Foundations for Print Preview and Setupmhm@chromium.org2009-07-036-13/+59
| | | | | | | | | | | | | Create the foundations of implementing a tab for printing should be in the form of: print:http://www.google.com I have followed similar approach as what has been done with view-source: and chrome-extension: BUG=173, 947 TEST=none Review URL: http://codereview.chromium.org/150207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19906 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Console tests.pfeldman@chromium.org2009-07-031-0/+11
| | | | | | Review URL: http://codereview.chromium.org/149178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19904 0039d316-1c4b-4281-b951-d872f2087c98
* Handle partial sends over the ChromeDevToolsProtocol.apavlov@chromium.org2009-07-031-9/+22
| | | | | | | send() can send parts of the buffer fed in. We should send parts of the buffer until the entire buffer has been transferred. Review URL: http://codereview.chromium.org/150229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19902 0039d316-1c4b-4281-b951-d872f2087c98
* Create a project for maintaining default extensions.finnur@chromium.org2009-07-031-0/+0
| | | | | | | | | | | | | | | | | | | | | This project is responsible for listing and copying the extensions we want to ship with Chrome by default. It copies the .crx files listed in the project plus a .json file from: src\chrome\browser\extensions\default_extensions to debug\extensions ... where the mini_installer will pick them up. At the moment only the json file is getting copied, but we can add .crx files when they are ready. BUG=None TEST=I will give a build to QA for testing this. Review URL: http://codereview.chromium.org/155016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19889 0039d316-1c4b-4281-b951-d872f2087c98
* Initializing the struct before using it, as mandated byfinnur@chromium.org2009-07-031-9/+9
| | | | | | | | | | | our Coverity overlord. BUG=None TEST=None Review URL: http://codereview.chromium.org/149155 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19887 0039d316-1c4b-4281-b951-d872f2087c98
* Make action buttons listen to the enter key.arv@google.com2009-07-033-67/+119
| | | | | | | | | | | | | | | | | | | | | | Hide menus when the window is blurred or the user presses Alt or Meta. Only show tootlip for the title of the thumbnail. Allow mouse over on the window menu. Made the windows opaque but with a hsla background color to make it more readable. Quote all background image URLs so that we can display icons for URLs with spaces in them. Call preventDefault when using the keyboard to navigate the options menu so that the page does not scroll. BUG=15268, 15503, 15715, 15769, 15411, 15458 TEST=See bug descriptions Review URL: http://codereview.chromium.org/149163 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19884 0039d316-1c4b-4281-b951-d872f2087c98
* Modify ThumbnailStore to make one call to the HistoryBackend using ↵meelapshah@chromium.org2009-07-035-400/+217
| | | | | | | | | | | QueryTopURLsAndRedirects instead of a seperate call for each URL. Also clean up some of the code and fix bug 14644. BUG=14644 TEST=none Review URL: http://codereview.chromium.org/149126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19879 0039d316-1c4b-4281-b951-d872f2087c98
* Another batch of performance improvements for NNTP.arv@google.com2009-07-033-167/+307
| | | | | | | | | | | | | | | | | | Hard code the DOM and the layout for the default case so that we do not need to do any js layout at startup. Be more careful when calling layout. I added a dirty bit so that we don't layout too often. CSS cleanup/optimization to make selectors faster. TEST=Run the perf test BUG=13362 Review URL: http://codereview.chromium.org/149127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19877 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Preview images in file chooser.estade@chromium.org2009-07-031-0/+36
| | | | | | | | | BUG=http://crbug.com/15500 TEST=select an image in a file chooser Review URL: http://codereview.chromium.org/151100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19874 0039d316-1c4b-4281-b951-d872f2087c98
* Fix showModalDialog regression.jam@chromium.org2009-07-032-1/+26
| | | | | | | | BUG=4202 TEST=added regression test. Review URL: http://codereview.chromium.org/149143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19872 0039d316-1c4b-4281-b951-d872f2087c98
* Change some numbers on the gtk bookmark bar.estade@chromium.org2009-07-032-2/+2
| | | | | | | | | | | | height = 29 matches windows constant padding between bookmark name and favico: I couldn't find a relevant constant in the windows code, so I experimentally matched the spacing between the two, for the same bookmark on linux and windows. BUG=http://crbug.com/15882 TEST=look at bookmark bar Review URL: http://codereview.chromium.org/155019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19871 0039d316-1c4b-4281-b951-d872f2087c98
* Knock out a couple more TODOs from the bookmark manager.estade@chromium.org2009-07-031-3/+34
| | | | | | | | | TEST=edit the name of a folder; it should update in the left pane. Add a new bookmark URL; it should show up selected in the right pane. Also, see bug BUG=http://crbug.com/15844 Review URL: http://codereview.chromium.org/149151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19870 0039d316-1c4b-4281-b951-d872f2087c98
* Re-show bookmark bar buttons whenever they're configured.estade@chromium.org2009-07-031-0/+2
| | | | | | | | | BUG=http://crbug.com/15859 TEST=see bug Review URL: http://codereview.chromium.org/155008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19869 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Initial implementation of using GTK themes, partially based on evan's ↵erg@google.com2009-07-0324-143/+650
| | | | | | | | | | | | | | | | | | | | | | | CL 118358. A lot of stuff works: - Colors are picked out of the GTK theme. - Buttons use the current GTK button theme. - We use the user's icon theme. A lot of stuff doesn't: - We could do a better job of picking colors for the skylines. - The omnibox hasn't been touched. - UI that's not part of the toolbar hasn't been touched. - We currently fail on themes like HighContrastInverse. TEST=Under Options>Personal Stuff, click GTK Theme. Colors and widgets should be rendered with the current GTK theme stuff. TEST=With chrome open and in GTK Theme mode, change your GTK theme or icon theme. chrome should pick up on the change immediately and reimport the colors and images. http://crbug.com/13967 Review URL: http://codereview.chromium.org/150176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19868 0039d316-1c4b-4281-b951-d872f2087c98
* Add getFileSize support to chromiumvictorw@chromium.org2009-07-038-0/+281
| | | | | | | | | | | | | | | | | The current implementation only allows getting file size if the child process has been granted permission to upload file. May need to update the policy checking code if getFileSize is needed in other cases. Here is the webkit implementation to support this: https://bugs.webkit.org/show_bug.cgi?id=26521 TEST=none BUG=9102 Review URL: http://codereview.chromium.org/131082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19866 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 19829.mirandac@chromium.org2009-07-026-223/+9
| | | | | | | | BUG= http://crbug.com/1455 Review URL: http://codereview.chromium.org/149156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19861 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some issues with extension messaging:mpcomplete@chromium.org2009-07-024-18/+25
| | | | | | | | | | | | | | - Disconnect ports properly (javascript mistake). - Use the right port ID when dispatching the disconnect event. - Fix a bug with 2 extensions loaded in the same process. BUG=12686 BUG=15798 TEST=Load an extension that uses messaging, and make sure it disconnects when you navigate or close the connecting. Review URL: http://codereview.chromium.org/152003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19844 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Linux2 build.brettw@chromium.org2009-07-023-3/+3
| | | | | | | | I removed the extra argument from WidgetGTK::Init but didn't update these sites. Review URL: http://codereview.chromium.org/155006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19843 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: when doing a drag from a web page, pass a recent mouse down to ↵estade@chromium.org2009-07-022-6/+12
| | | | | | | | | | | | | | | | | | | gtk_drag_begin() so it has a better idea what time to pass to gdk_grab_pointer(). I believe the following was happening: - render view gets mouse down, forwards to webkit - render view gets motion, forwards to webkit - user releases mouse button, that event is added to the queue - browser gets message from webkit that a drag has begun, calls gtk_drag_begin() with no event - gtk_drag_begin initiates a cursor grab, but it only applies to events that have not yet been added to the queue - mouse release comes up in queue; passed to render view rather than the drag widget TEST=You can't get stuck in really short render view drags. Whereas it was really easy to repro before (especially in Xephyr), I can repro no longer. BUG=http://crbug.com/15768 Review URL: http://codereview.chromium.org/150204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19839 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bookmark util crashestade@chromium.org2009-07-021-0/+4
| | | | | | | | | BUG=http://crbug.com/15853 TEST=none Review URL: http://codereview.chromium.org/155004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19838 0039d316-1c4b-4281-b951-d872f2087c98
* Pop-up chrome.jrg@chromium.org2009-07-024-6/+54
| | | | | | | | | | | | | | | | | | | | | | | BUG=http://crbug.com/15727 TEST=Load a web page that has a popup. Example: <!DOCTYPE html> Click button to open a new window. <br> <button onclick="w = window.open('http://www.google.com', 'New Window', 'width=512,height=512'); w.moveTo(300,300);">Open with w,h</button> Now click on the button to get a pop-up. In the new window, make sure there is no "tab" area above the URL bar, and no "new tab" button. Hit Cmd-T to create a new tab, and make sure it gets created in the OTHER window. More work is needed to minimize pop-up chrome more, but this'll prevent the most brutal failures (e.g. team meeting "demo" today). Review URL: http://codereview.chromium.org/151135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19837 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a typo I came across while debugging.eroman@chromium.org2009-07-022-3/+3
| | | | | | | | | | BUG=None TEST=None TBR=brettw Review URL: http://codereview.chromium.org/149128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19832 0039d316-1c4b-4281-b951-d872f2087c98
* Add more functionality to the gtk task manager:jhawkins@chromium.org2009-07-023-14/+64
| | | | | | | | | | * Columns are resizable. * Resource icon displayed by resource name. BUG=11392 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19830 0039d316-1c4b-4281-b951-d872f2087c98
* Change status bubble so that it expands to accommodate URL's that are ↵mirandac@chromium.org2009-07-026-9/+223
| | | | | | | | | | | abridged in the standard width. BUG= http://crbug.com/1455 TEST= Mouse over a link which is abridged in the status bubble. Hover for 2 seconds. Link should expand to show as much as possible without extending out of the view in which it is contained. Review URL: http://codereview.chromium.org/146043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19829 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Clean up some bookmark related UI hacks.estade@chromium.org2009-07-023-57/+34
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/150203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19827 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Add and Update for PasswordStoreMac.stuartmorgan@chromium.org2009-07-028-49/+148
| | | | | | | | | | | Modify LoginDatabase slightly to give PasswordStoreMac enough information to do the right thing. Add creator code for keychain items we create, and unit tests to make sure. BUG=11745 TEST=Visit a site for which you have a password in the Keychain. Type your username, unfocus the field, and then log in with the filled password. Log out, return to the login page, and the username and password should now autofill without user interaction. Review URL: http://codereview.chromium.org/151176 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19822 0039d316-1c4b-4281-b951-d872f2087c98
* Convert menu strings to UTF16, fix some views-GTK build errors.brettw@chromium.org2009-07-0217-76/+76
| | | | | | Review URL: http://codereview.chromium.org/150171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19820 0039d316-1c4b-4281-b951-d872f2087c98
* TBR:rafaelw@chromium.org2009-07-021-2/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19817 0039d316-1c4b-4281-b951-d872f2087c98
* reenable RenderViewHostManager browertest, add DownloadsCompleteObserver to ↵rafaelw@chromium.org2009-07-021-4/+12
| | | | | | | | | | ui_test_utils. R=aa Review URL: http://codereview.chromium.org/151189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19811 0039d316-1c4b-4281-b951-d872f2087c98
* This reverts 2 CLs that worked around a problem with NSGradient on 10.6,jeremy@chromium.org2009-07-021-34/+5
| | | | | | | | | | | the underlying issue is fixed in the latest seed so we don't need the workaround anymore: * r16073 "Fixup colors for inactive tab." * r15328 "Fixes for 10.6" (only the changes to tab_cell.mm) Review URL: http://codereview.chromium.org/151197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19810 0039d316-1c4b-4281-b951-d872f2087c98
* Add split with devtools container into the browser view.pfeldman@chromium.org2009-07-022-6/+55
| | | | | | Review URL: http://codereview.chromium.org/151150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19807 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Spurious SQL error message is logged in priming SQLite database cache.yuzo@chromium.org2009-07-022-21/+2
| | | | | | | | | | | | | | | | | | | | This patch depends on the MetaTableHelper refactoring in: http://codereview.chromium.org/150094 Currently, a spurious SQL error message is logged every time a unit test that access SQLite database runs. Example: [----------] 6 tests from HistoryBackendTest [ RUN ] HistoryBackendTest.Loaded [5660:5304:0630/150705:414864129:ERROR:sqlite_utils.cc(204)] SQLStatement.prepare_v2 failed: no such table: meta BUG=none TEST=n/a Review URL: http://codereview.chromium.org/150095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19803 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor MetaTableHelper to remove redundant table name prefixing with databaseyuzo@chromium.org2009-07-023-17/+74
| | | | | | | | | | | | name. Also, PrimeCache logic duplicated in HistoryBackend and SQLitePersistentCookieStore is moved to this class. BUG=none TEST=n/a Review URL: http://codereview.chromium.org/150094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19802 0039d316-1c4b-4281-b951-d872f2087c98
* Paint infobar background as gradient.estade@chromium.org2009-07-021-5/+33
| | | | | | | | | TEST=look at an infobar BUG=none Review URL: http://codereview.chromium.org/151162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19801 0039d316-1c4b-4281-b951-d872f2087c98
* Prefer arraysize() over sizeof().cmp@google.com2009-07-021-1/+1
| | | | | | | | | | | | | Fix a call to sizeof() on a static array to use arraysize() instead. Maybe fixes a coverity issue, too. BUG=none TEST=none Review URL: http://codereview.chromium.org/150202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19800 0039d316-1c4b-4281-b951-d872f2087c98
* Fix performance issues with NNTP.arv@google.com2009-07-023-33/+40
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | My tests show it as not as fast as the old NTP but it is a lot better than before these changes: Old NTP: 208 223 211 205 211 Average: 211.6 NNTP before this change: 732 718 718 713 Average: 720.25 NNTP with this change: 255 248 257 254 257 Average: 254.2 There is still room for improvements but this brings the NNTP perf closer to being acceptable. BUG=13362 TEST=Perf test at http://build.chromium.org/buildbot/perf/xp-release-dual-core/new-tab-ui-cold/report.html?history=200 Review URL: http://codereview.chromium.org/150194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19797 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some debugging code in hopes of tracking down asky@chromium.org2009-07-012-0/+5
| | | | | | | | | | | | | | | | crash. Specifically: . Adds a CHECK to IDMap that evaluates to true if adding NULL. The default isn't to do this check. . browser_shutdown CHECKs if the # RPHs changes while iterating through the RPHs. BUG=15615 TEST=none Review URL: http://codereview.chromium.org/150181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19779 0039d316-1c4b-4281-b951-d872f2087c98
* Adds user metrics for tab overview.sky@chromium.org2009-07-014-2/+22
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/151172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19776 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a bunch of low-level keychain helper tests that are now redundant ↵stuartmorgan@chromium.org2009-07-013-426/+252
| | | | | | | | | | | | with tests of the newer higher-level methods. Start collecting the helpers into a cohesive class that serves as a translation layer between keychain items and password forms. BUG=none TEST=Keychain passwords should still fill after a username is typed on the Mac (no change in behavior). Review URL: http://codereview.chromium.org/151164 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19773 0039d316-1c4b-4281-b951-d872f2087c98