| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
a HANDLE from CreateEvent was used for signaling, both within a process and across processes.
WaitableEvent is the cross platform replacement for this. To convert:
* HANDLE -> base::WaitableEvent*
* ScopedHandle -> scoped_ptr<base::WaitableEvent>
* CreateEvent -> new base::WaitableEvent
* SetEvent -> base::WaitableEvent::Signal
* ResetEvent -> base::WaitableEvent::Reset
* ObjectWatcher -> base::WaitableEventWatcher
* WaitForMultipleObjects -> static base::WaitableEvent::WaitMany
ObjectWatcher remains for Windows specific code. WaitableEventWatcher has an identical interface save,
* It uses WaitableEvents, not HANDLEs
* It returns void from StartWatching and StopWatcher, rather than errors. System internal errors are fatal to the address space
IMPORTANT: There are semantic differences between the different platforms. WaitableEvents on Windows are implemented on top of events. Windows events work across process and this is used mostly for modal dialog support. Windows events can be duplicated with DuplicateHandle.
On other platforms, WaitableEvent works only within a single process. In the future we shall have to replace the current uses of cross-process events with IPCs.
BEWARE: HANDLE, on Windows, is a void *. Since any pointer type coerces to void *, you can pass a WaitableEvent * where a HANDLE is expected without any build-time errors.
Review URL: http://codereview.chromium.org/16554
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8126 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
relayout should not force resize relayout.
This is proposed solution one from the comment#5 which is to
create new tabs without resizing existing tabs unless there is
no room for the new tab.
BUG=3258
Change from Itai Danan (idanan@google.com)
Code review: http://codereview.chromium.org/14050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18263
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18274
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Also moves AuthCache::HttpKey() --> GetSignonRealmKey().
Review URL: http://codereview.chromium.org/18218
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
so it failed when the test run order happened to change.
This change fixes that.
Review URL: http://codereview.chromium.org/18222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
in this CL: http://codereview.chromium.org/18259
Review URL: http://codereview.chromium.org/18083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change is a bit gross. It calls out to GetSystemMetrics() all over this code, which just shows how many places are sizing themselves from the window edge instead of from the window border edge. When cleaning this file up to be more sane, I intend to make most of these functions position themselves based on the border edge, which should cut down the number of these calls to just a couple (and perhaps collapse some of the constants together too).
BUG=5054
TEST=In both Classic and Luna, use the Display control panel to set your active/inactive border widths to something nonstandard (try 20, that's real noticeable) and maximize a Chrome window. Make sure the window controls appear where you expect instead of partly or totally off the screen edges.
Review URL: http://codereview.chromium.org/18255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bubble relative to the client area and then converting to parent coordinates instead of trying to position it absolutely with hardcoded constants.
Also changes an Offset() call to ConvertPointToView(), which is functionally the same but I think clearer in intent.
BUG=5054
TEST=In both Classic and Luna, use the Display control panel to set your active/inactive border widths to something nonstandard (try 20, that's real noticeable) and maximize a Chrome window. Make sure when hovering a link that the status bubble appears aligned with the screen corner instead of partly offscreen.
Review URL: http://codereview.chromium.org/18253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18250
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/18069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
would not get focused.
This is because when the tab was shown its browser window is not yet active.
BUG=6380
TEST=Open an app (ex: gmail), press CTRL-T, this opens a new browser with a new tab. Navigate to google.com in the new tab. Go back to the app, press CTRL-T again, a new tab should be opened and the location bar should have focus.
Review URL: http://codereview.chromium.org/18017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
r8020 tickled an issue by removing altbase.h from a header file where it
shouldn't have been needed.
Review URL: http://codereview.chromium.org/18228
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8022 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserWindow with only a TabStrip. I also converted two ui tests over
to unit tests to make sure it all worked. I had to add a bunch of null
checks to Browser and a couple of other places.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/17386
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=evan
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=joshia,iyengar
Review URL: http://codereview.chromium.org/18220
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=dimich
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=zork
Review URL: http://codereview.chromium.org/18032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
comment I wrote saying something should be changed was wrong. So fix the comment.
Review URL: http://codereview.chromium.org/18028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
process
Review URL: http://codereview.chromium.org/14907
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
tabstrip positioned correctly for normal and incognito windows, in both restored and maximized modes.The chief change was to correctly transform the bounds returned by the non-client view into the BrowserView's coordinate system, as the Views system expected. To make this not break the world I then had to actually return the right coordinates in the non-client view :). Updated comments on function declarations to hopefully match reality.For convenience this also introduces a function to get the horizontal border size and cleans up existing code to use it.BUG=5054
Review URL: http://codereview.chromium.org/18019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7976 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
switch.
Remove WinHttpThrottle and CertStatusCache, which are only
used by HttpTransactionWinHttp.
Fix nits reported by cpplint.py.
R=eroman,darin
BUG=6323
Review URL: http://codereview.chromium.org/17635
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/17361
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7932 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/17631
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/17628
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/17226
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
of the chrome team.
Review URL: http://codereview.chromium.org/10272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
relative to the OTR icon, sadly.
Much of the issue here is because the OTR image was a child view in the old code and isn't in the new. As a result, we have to:
* Change the drawing order to draw the OTR image after the tabstrip (like a child view would normally have been drawn), so the tabstrip's semi-transparent pixels don't overlay it
* Change the bounds calculation and drawing code to clip the image properly in maximized mode (where a child view would have been clipped naturally)
Since I changed the calling order of the OTR functions, I also changed their declaration/definition order to follow suit.
This also tries to rename a few constants to be more consistent. I can't figure out how to make any of these read nicely :(
BUG=5054
Review URL: http://codereview.chromium.org/17362
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
OriginalFileName didn't work, since different filenames might still have the same value (i.e. QuickTime). Instead I did what Firefox does, which is collect the list of directories in one pass, then crawl them in another.
Review URL: http://codereview.chromium.org/17367
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
before invoking on it. not doing this causes a UT test
'VisibleBrowserTest.WindowOpenClose' to crash frequently.
Review URL: http://codereview.chromium.org/17366
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When a browser window is closed, we just terminate
all existing renderers for fast shutdown. If we have
any renderers hosted externally using automation they
are also killed during this process.
The fix is to prevent fast termination if any of the
tabs are hosted by automation.
Review URL: http://codereview.chromium.org/17453
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for specific RenderViewHosts.
This is used by the interstitial code to prevent the original page from making network requests while the interstitial is showing.
Several UI tests are still required to test this. Because of the inherent complexity of the scenarios to test this, I'm afraid these tests are going to be flakey and soon after disabled (like many of the interstitial UI tests at this point).
This will be done next as part of my next effort to mock some of the WebContents stuff.
TEST=Run the unit tests. Create a page that does XMLHttpRequests and log when the requests complete with the time it did. While that page is shown, switch to a malware/bad SSL page. Come back to the page, ensure no requests were processed while the interstitial was showing.
BUG=None
Review URL: http://codereview.chromium.org/16546
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When SafeBrowsingDatabaseBloom is going out of scope (see stack trace below) Close() is called.
When insert_transaction_ is non NULL, it holds a pointer to the database, |db_|, which is owned by SafeBrowsingDatabaseBloom.
Close() closes the database but did not free |insert_transaction_| which causes |insert_transaction_| to attempt to rollback the transaction with an invalid database pointer.
The fix is simply to reset the transaction before closing the database.
Stack:
0:009> kP
ChildEBP RetAddr
0579fa14 027e73e0 ntdll!RtlEnterCriticalSection+0xb
0579fa24 027958e6 chrome_12d0000!winMutexEnter(
struct sqlite3_mutex * p = 0xdddddddd)+0x10 [c:\chromium\src\third_party\sqlite\src\mutex_w32.c @ 185]
0579fa34 0278d76c chrome_12d0000!sqlite3_mutex_enter(
struct sqlite3_mutex * p = 0xdddddddd)+0x16 [c:\chromium\src\third_party\sqlite\src\mutex.c @ 111]
0579fa80 029655f8 chrome_12d0000!sqlite3_exec(
struct sqlite3 * db = 0x06df6618,
char * zSql = 0x043feec0 "ROLLBACK",
<function> * xCallback = 0x00000000,
void * pArg = 0x00000000,
char ** pzErrMsg = 0x00000000)+0x4c [c:\chromium\src\third_party\sqlite\src\legacy.c @ 50]
0579faa4 02965523 chrome_12d0000!SQLTransaction::EndCommand(
char * command = 0x043feec0 "ROLLBACK")+0x48 [c:\chromium\src\chrome\common\sqlite_utils.cc @ 96]
0579fab8 029654ea chrome_12d0000!SQLTransaction::Rollback(void)+0x23 [c:\chromium\src\chrome\common\sqlite_utils.h @ 57]
0579fac4 02965496 chrome_12d0000!SQLTransaction::~SQLTransaction(void)+0x2a [c:\chromium\src\chrome\common\sqlite_utils.cc @ 82]
0579fad0 01ad0cdf chrome_12d0000!SQLTransaction::`scalar deleting destructor'(void)+0x16
0579faf0 01ac8c49 chrome_12d0000!scoped_ptr<SQLTransaction>::~scoped_ptr<SQLTransaction>(void)+0x3f [c:\chromium\src\base\scoped_ptr.h @ 72]
0579fafc 01ac8a86 chrome_12d0000!SafeBrowsingDatabaseBloom::~SafeBrowsingDatabaseBloom(void)+0x49 [c:\chromium\src\chrome\browser\safe_browsing\safe_browsing_database_bloom.cc @ 61]
0579fb08 017bb3a0 chrome_12d0000!SafeBrowsingDatabaseBloom::`scalar deleting destructor'(void)+0x16
0579fb28 01c66a99 chrome_12d0000!DeleteTask<SafeBrowsingDatabase>::Run(void)+0x40 [c:\chromium\src\base\task.h @ 227]
0579fbd8 01c66b45 chrome_12d0000!MessageLoop::RunTask(
class Task * task = 0x0800df10)+0xb9 [c:\chromium\src\base\message_loop.cc @ 308]
0579fbe8 01c67029 chrome_12d0000!MessageLoop::DeferOrRunPendingTask(
struct MessageLoop::PendingTask * pending_task = 0x0579fc04)+0x35 [c:\chromium\src\base\message_loop.cc @ 319]
0579fc24 01cea44c chrome_12d0000!MessageLoop::DoWork(void)+0xe9 [c:\chromium\src\base\message_loop.cc @ 408]
0579fd04 01c663bb chrome_12d0000!base::MessagePumpDefault::Run(
class base::MessagePump::Delegate * delegate = 0x0579feb4)+0xbc [c:\chromium\src\base\message_pump_default.cc @ 23]
0579fdb0 01c66220 chrome_12d0000!MessageLoop::RunInternal(void)+0xfb [c:\chromium\src\base\message_loop.cc @ 197]
0579fde8 01c660aa chrome_12d0000!MessageLoop::RunHandler(void)+0x90 [c:\chromium\src\base\message_loop.cc @ 181]
0579fe10 01c86d38 chrome_12d0000!MessageLoop::Run(void)+0x3a [c:\chromium\src\base\message_loop.cc @ 155]
0579ffa4 01c86071 chrome_12d0000!base::Thread::ThreadMain(void)+0xb8 [c:\chromium\src\base\thread.cc @ 156]
Review URL: http://codereview.chromium.org/17617
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
point to the same plugin. Check plugin versions and load the latest version if multiple versions are found.I've also refactored and cleaned PluginList so that it doesn't depend on PluginLib, which only made sense a long time ago when plugins were loaded in process. Now PluginLib will only be loaded in the plugin process (and not in the browser process as well).
Review URL: http://codereview.chromium.org/17451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
extension installation.
Review URL: http://codereview.chromium.org/17320
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Update spellchecker to use version 1.2 dictionaries for 19 languages.
Issue=2837
Review URL: http://codereview.chromium.org/17337
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
I'm looking at; mostly just making code shorter. I tried not to remove temps where they added significant clarity, e.g. where they prevented nested ?: operators. A few cases like LayoutOTRAvatar() are kinda gross-looking, partly because the final version of those will be a bit simpler.
Review URL: http://codereview.chromium.org/17614
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/17277
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
download shelf from
AddDownload to AddDownload View...
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
recent changes and get rid of cut-and-paste:
* Add generation of the new net_resource.vcproj file.
* Accomodate the net\net.vsprops file.
* New base.vcproj dependency in activex_shim_dll.vcproj.
* New tld_cleanup.vcproj dependency in net.vcproj.
* New ondemand_updates.vcproj dependencies in
gcapi_{dll,lib}.vcproj.
* Re-order dump_cache.vcproj dependencies to match new
checked-in solutions.
* New input file directory layout in zlib (minizip folder)
and testing\gtest (hierarchy).
* Use a new dest= argument to ChromeMSVSSolution()
and ChromeMSVSProject() to get rid of cut-and-pste
installation code, and provide a central point for
controlling when/whether we want to generate the files
only under the build directory, or drop them in place
for checking in.
* Comment out an unnecessarily verbose warning if the
buildtarget is executed with an action that we don't
map to specific Visual Studio settings. Sometimes
this is normal and okay, but the warning should get
restored at some point when we work out the precise
conditions under which it makes sense.
Review URL: http://codereview.chromium.org/17602
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/16805
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/17433
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7836 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I'm doing this to avoid confusion with the Firefox version of Greasemonkey and
also because 'user script' is really the correct generic term.
At the same time, I also moved user_script_master* into extensions/ because I want these two pieces to get closer and closer such that standalone user scripts are just a very small extension. Also extensions will be relying on most of the user script code.
Review URL: http://codereview.chromium.org/17281
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
make the main routine a little cleaner. Unify the parameters of each of the "main" entry points so we can more easily abstract platform differences in the future. BUG=5323
Review URL: http://codereview.chromium.org/17426
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7825 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
avoid the testserver.py stalling issue.
Review URL: http://codereview.chromium.org/17305
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows us to hide it when the page loses focus.
(doing that previously would have caused the popup to be hidden before the click in the popup was sent to the renderer).
Most of the file changes are just renaming focus_on_show to activatable.
TEST=Open a form and make an autofill popup. Focus another window, the popup should disappear. Ensure the autofill still work properly, and the combo-box as well.
BUG=3844,5830
Review URL: http://codereview.chromium.org/17455
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7823 0039d316-1c4b-4281-b951-d872f2087c98
|