summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* This CL ensures we don't store empty values in the autofill form DB.jcampan@chromium.org2009-02-117-21/+98
| | | | | | | | | | Also it applies a clean-up to remove any empty values previously stored in the DB. BUG=6111 TEST=Submit a form and leave some fields empty. Come back to that form, click on a field that was empty. No autofill popup should show up (or if one show up, it should not contains empty values). Review URL: http://codereview.chromium.org/21217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9570 0039d316-1c4b-4281-b951-d872f2087c98
* Redo my IPC change, undoing the linker dependency.jam@chromium.org2009-02-111-442/+438
| | | | | | Review URL: http://codereview.chromium.org/21225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9557 0039d316-1c4b-4281-b951-d872f2087c98
* Handle tooltip message so we get fewer NOTIMPLEMENTED()s.evan@chromium.org2009-02-111-1/+6
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9552 0039d316-1c4b-4281-b951-d872f2087c98
* Construct AudioRendererHost in BrowserRendererProcessHost, also constructhclam@chromium.org2009-02-118-18/+114
| | | | | | | | ResourceMessageFilter with pointer to it so we can delegate requests to it from IPC later. Review URL: http://codereview.chromium.org/20131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9551 0039d316-1c4b-4281-b951-d872f2087c98
* Implement browser scrolling on posix.estade@chromium.org2009-02-112-72/+33
| | | | | | | | This code still has not been tested on nested scroll frames (e.g. webkit/data/test_shell/iframes/test1.html) because they don't render correctly yet. But it does work for scrolling horizontally and vertically on the main frame. Review URL: http://codereview.chromium.org/20244 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9550 0039d316-1c4b-4281-b951-d872f2087c98
* Draw custom buttons in toolbar.evan@chromium.org2009-02-112-42/+151
| | | | | | | | | The menu buttons aren't quite right yet, but the rest seem pretty good. Review URL: http://codereview.chromium.org/20252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9548 0039d316-1c4b-4281-b951-d872f2087c98
* Port some strings in download/save_package.ccestade@chromium.org2009-02-114-189/+150
| | | | | | Review URL: http://codereview.chromium.org/23004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9547 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a potential infinite loop in TabRestoreUITest.RestoreToDifferentWindow.patrick@chromium.org2009-02-111-0/+1
| | | | | | | The variable tab_count is never changed inside the while loop. Review URL: http://codereview.chromium.org/21200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9543 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a browser crash when the URLRequestChromeJob goes awayrvargas@google.com2009-02-111-2/+4
| | | | | | | | | | from the NotifyReadComplete notification. BUG=7485 Review URL: http://codereview.chromium.org/20162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9541 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a browser crash when the async resource handler keeps anrvargas@google.com2009-02-111-1/+6
| | | | | | | | | | | | | | | | IOBuffer after a failed attempt to send the data to a (now gone) renderer. The shared memory section is unmapped so the buffer must not be kept around and possibly re-used. I'm also fixing a leak reported by purify. BUG=7487 BUG=7374 Review URL: http://codereview.chromium.org/21222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9540 0039d316-1c4b-4281-b951-d872f2087c98
* Unittest gardening on MacOS X:shess@chromium.org2009-02-112-6/+2
| | | | | | | | | | | | | | | | | | | | - base/gfx/rect_unittest.cc had a typo - base/waitable_event_watcher_unittest.cc enabled - chrome/common/pref_member_unittest.cc enabled - chrome/common/json_value_serializer_unittest.cc had a Windows-only bit which currently works fine on Mac. - These worked once an anonymous namespace was cleared up: chrome/browser/history/query_parser_unittest.cc chrome/browser/history/url_database_unittest.cc chrome/common/json_value_serializer_unittest.cc Some required minor editting to remove anonymous namespaces for test classes. Review URL: http://codereview.chromium.org/20241 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9539 0039d316-1c4b-4281-b951-d872f2087c98
* Maintain a refcounted AutomationProvider pointer in the ↵ananta@chromium.org2009-02-112-4/+22
| | | | | | | | | | | | | | | | | | ExternalTabContainer. This ensures that we don't crash the browser while trying to dereference a freed AutomationProvider pointer. When a Chrome browser instance starts up, we attempt to locate an already running instance and defer to it to complete the navigation request. However it is quite possible for the running instance to exit while we attempt to send a WM_COPYDATA message to it. This caused a bunch of ASSERTS to fire off in the browser. Fixes as below:- 1. If GetWindowThreadProcessId fails, we bail out and try to launch a new chrome instance 2. If SendMessageTimeout fails, we check if the window is still valid. If not we bail out and try to launch a new chrome instance. 3. We return an error from the WM_COPYDATA handler if the chrome instance is in the process of shutting down. We handle this at the caller end, i.e. in NotifyOtherProcess. Bug=1643310 Review URL: http://codereview.chromium.org/23016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9536 0039d316-1c4b-4281-b951-d872f2087c98
* Make browsing_data_remover.cc compile on Mac and Linux.jhawkins@chromium.org2009-02-112-4/+15
| | | | | | Review URL: http://codereview.chromium.org/21232 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9533 0039d316-1c4b-4281-b951-d872f2087c98
* Fill in more gtk callbacks in RenderWidgetHostViewGtk.estade@chromium.org2009-02-101-3/+15
| | | | | | | | Mostly ripped directly from WebWidgetHostGtk. Review URL: http://codereview.chromium.org/24009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9531 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at preventing a crasher.jcampan@chromium.org2009-02-101-0/+15
| | | | | | | | | | In some cases TaskManagerResource can still be alive and pointing to a deleted WebContents, not sure how it can happen. Now also listening for TabContent destruction notifications in case we are missing the WebContents one for some reason. BUG=7321 Review URL: http://codereview.chromium.org/21233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9527 0039d316-1c4b-4281-b951-d872f2087c98
* Optionally support URLPatterns in standalone useraa@chromium.org2009-02-103-19/+86
| | | | | | | | | | | scripts via the @match declaration. In the future, maybe @include will be deprecated and result in a warning. Review URL: http://codereview.chromium.org/20127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9526 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on Mac cursor support now that we're already linking in the world.avi@chromium.org2009-02-102-8/+19
| | | | | | Review URL: http://codereview.chromium.org/21227 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9522 0039d316-1c4b-4281-b951-d872f2087c98
* Move opener/group relationship forgetting on navigation into TabStripModel ↵ben@chromium.org2009-02-105-49/+168
| | | | | | | | from browser, and write unit tests for it. Review URL: http://codereview.chromium.org/20233 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9518 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9493.kuchhal@chromium.org2009-02-1024-304/+88
| | | | | | Review URL: http://codereview.chromium.org/21231 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9517 0039d316-1c4b-4281-b951-d872f2087c98
* Make character_encoding.cc compile on Mac and Linux.jhawkins@chromium.org2009-02-102-3/+1
| | | | | | Review URL: http://codereview.chromium.org/21220 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9513 0039d316-1c4b-4281-b951-d872f2087c98
* MovePluginWindows should always be called, even if suppress_view_updating_ ↵jam@chromium.org2009-02-101-4/+6
| | | | | | | | | is true. This fixes a regression when the code got refactored. BUG=7541 Review URL: http://codereview.chromium.org/20211 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9512 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from HWNDs to NativeViews, take 2. (First attempt was r9409, in which ↵avi@chromium.org2009-02-1019-62/+64
| | | | | | | | I missed a file.) Review URL: http://codereview.chromium.org/20226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9507 0039d316-1c4b-4281-b951-d872f2087c98
* Do some more work on RenderWidgetHostViewGtkestade@chromium.org2009-02-102-75/+92
| | | | | | | | | | * hook up mouse presses * hook up resizes * move gtk widget code into a container class (a la WebWidgetHostGtk) Review URL: http://codereview.chromium.org/20230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9506 0039d316-1c4b-4281-b951-d872f2087c98
* Disable context menu item "Open image in new tab" from context menu for ↵sidchat@google.com2009-02-101-0/+8
| | | | | | | | | | thumbnail images for Most Visited page. Issue=2608 Review URL: http://codereview.chromium.org/24003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9505 0039d316-1c4b-4281-b951-d872f2087c98
* Switch the Mac accessor method name to match the GTK one (consistency is good).avi@chromium.org2009-02-103-6/+2
| | | | | | Review URL: http://codereview.chromium.org/21221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9501 0039d316-1c4b-4281-b951-d872f2087c98
* Remove tab_util from scaffolding.paul@chromium.org2009-02-101-1/+0
| | | | | | Review URL: http://codereview.chromium.org/20207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9495 0039d316-1c4b-4281-b951-d872f2087c98
* revert my ipc change due to compile failure in debug ipc_testsjam@chromium.org2009-02-101-2/+19
| | | | | | Review URL: http://codereview.chromium.org/20229 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9494 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding of http://codereview.chromium.org/16488.mad@chromium.org2009-02-1024-88/+304
| | | | | | | | Adding proper project dependency in chrome.sln. Review URL: http://codereview.chromium.org/21188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ipc logging for non browser processes. I broke this in my last ↵jam@chromium.org2009-02-101-19/+2
| | | | | | | | refactoring, since the logger functions only got registered in the browser. This fix registers them using a global object for each message type (that's only compiled when debugging is enabled). One less thing to take care of when creating new message types. Review URL: http://codereview.chromium.org/20213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9492 0039d316-1c4b-4281-b951-d872f2087c98
* Porting unit tests in chrome/phajdan.jr@chromium.org2009-02-107-40/+38
| | | | | | | | | | | | | | | | | | | | | - Make following unit tests compile and pass on Linux: browser/ command_updater_unittest.cc metrics/metrics_log_unittest.cc search_engines/template_url_parser_unittest.cc search_engines/template_url_prepopulate_data_unittest.cc - Add renderer/renderer_main_unittest.cc to list of compiled files (currently stubbed out on Linux) - Remove DebuggerWrapper stubs and make more files from browser/debugger build on Linux. - Sync XCode project file. - Misc cleanups needed for GCC. Review URL: http://codereview.chromium.org/21181 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9490 0039d316-1c4b-4281-b951-d872f2087c98
* Hook views up.avi@chromium.org2009-02-102-0/+5
| | | | | | Review URL: http://codereview.chromium.org/21212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9487 0039d316-1c4b-4281-b951-d872f2087c98
* fix compile failurekuchhal@chromium.org2009-02-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9482 0039d316-1c4b-4281-b951-d872f2087c98
* Try reverting r9409 to see if it fixes crashes on chromebot.kuchhal@chromium.org2009-02-1018-61/+59
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/21215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9481 0039d316-1c4b-4281-b951-d872f2087c98
* Reapplying tab support (change 9388). I synced and re-applied my change and ↵tommi@chromium.org2009-02-104-33/+86
| | | | | | | | | | | | | | found the automation tests not hanging. I also took a look at the logs from the hanging buildbots and the reverted change didn't touch on any of the code that appeared to be hanging. I also put breakpoints on the modified functions while running ui_tests.exe and nothing hit, so it looks like a fluke. I did get a hang though when running an old build of ui_tests.exe with a new version of chrome.dll. Is there any chance that there could have been a stale version on the build bots? Review URL: http://codereview.chromium.org/20214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9478 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix crash in OnGetScreenInfoagl@chromium.org2009-02-101-1/+4
| | | | | | | | | | | | | | | | | | | | In the ViewMsg_New, we pass a NativeViewId to the renderer. When WebKit wishes to know the metrics of the window, it echos that id back in a ViewHostMsg_GetScreenInfo. Without this patch, it echos back NULL and the browser crashes. This highlights a semi-major TODO for the porting effort at some point. We need to abstract the NativeViewIds from the NativeViews as we cannot trust pointer values from the renderers. The conversion code is in base/gfx/native_widget_types.h and currently just casts between them (which is correct for Windows, where both typedefs are HWNDs). One, maybe interresting idea is that we could generate a random secret key in the browser and HMAC sign the pointer values. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9476 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix uninited variableagl@chromium.org2009-02-101-1/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9469 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: porting effortagl@chromium.org2009-02-102-2/+0
| | | | | | | | Commit a few cleanups from my tree before starting on getting async resources working. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9465 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some debugging code in hopes of isolating bug 6316. I suspect thesky@google.com2009-02-103-3/+34
| | | | | | | | | | | | RVH is getting deleted some how and the RVHM isn't cleanly up correctly. BUG=6316 TEST=none Review URL: http://codereview.chromium.org/20185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9457 0039d316-1c4b-4281-b951-d872f2087c98
* #ifdef around a DCHECK in a Windows-specific code path.evan@chromium.org2009-02-101-0/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9451 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dead code from last commit.estade@chromium.org2009-02-101-7/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9450 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: save BrowserWindowGtk's vbox as a member variableestade@chromium.org2009-02-102-4/+12
| | | | | | | | also update the WebContents display hack to not crash on startup Review URL: http://codereview.chromium.org/21204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9449 0039d316-1c4b-4281-b951-d872f2087c98
* Re-check in some of my dynamic linking change.evan@chromium.org2009-02-107-26/+51
| | | | | | | | | | | | | We can't link in any more of these fixed .cc files because of a chain of dependencies: - temp_scaffolding_stubs defines the same symbols as these files - removing the scaffolding pulls in more source - pulling in that extra source breaks on Mac. I have resigned myself to checking in this small bit. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9448 0039d316-1c4b-4281-b951-d872f2087c98
* Revert basically everything I've done today as it fails mysteriouslyevan@chromium.org2009-02-1015-63/+50
| | | | | | | and I lack the patience to diagnose why mac doesn't link in libjpeg. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9447 0039d316-1c4b-4281-b951-d872f2087c98
* Get the renderer closer to rendering something on linux.estade@chromium.org2009-02-104-5/+18
| | | | | | | | | | * implement some stubbed functions * comment out some unimplemented IPC calls * hack a webcontents widget into BrowserWindow so that something displays Review URL: http://codereview.chromium.org/20204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9445 0039d316-1c4b-4281-b951-d872f2087c98
* Bring a bunch more headers into the non-Windows build:evan@chromium.org2009-02-1015-50/+63
| | | | | | | | | | | | | - history - autocomplete - bookmarks These were all reviewed separately but turned out to be interdependent. :~( Review URL: http://codereview.chromium.org/21170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9444 0039d316-1c4b-4281-b951-d872f2087c98
* Fix UI test regression, there's a better way to refactor this anyway.pkasting@chromium.org2009-02-103-0/+20
| | | | | | | TBR=glen Review URL: http://codereview.chromium.org/24007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9443 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: add command line option to launch renderers in a wrapperagl@chromium.org2009-02-101-1/+16
| | | | | | | | | For example, ./Hammer/chrome --renderer-cmd-prefix="gdb --args" Review URL: http://codereview.chromium.org/21190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9438 0039d316-1c4b-4281-b951-d872f2087c98
* Make aero glass code look more like other nonclient views in hopes of easing ↵pkasting@chromium.org2009-02-097-260/+167
| | | | | | | | | refactoring. More cleanup. Change tabstrip layout to match opaque frame. BUG=5054 Review URL: http://codereview.chromium.org/20161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9433 0039d316-1c4b-4281-b951-d872f2087c98
* Speling fix.avi@chromium.org2009-02-092-4/+4
| | | | | | Review URL: http://codereview.chromium.org/21185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9432 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE. Fix EOL in autofill_manager.cc.maruel@chromium.org2009-02-091-110/+110
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9429 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 13:21:16 +0000