summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Share the code that builds the page menu in a common model, make Mac and Win ↵pinkerton@chromium.org2009-12-0911-187/+719
| | | | | | | | | | use it. Implement a mac menu controller that takes this model and generates an NSMenu. Remove the Page Menu NSMenu from Toolbar.xib since it's now created in code. BUG=22646 TEST=page menu should work as before Review URL: http://codereview.chromium.org/465130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34179 0039d316-1c4b-4281-b951-d872f2087c98
* Change most callers of NativeScrollbar size functions to use a dedicated ↵pkasting@chromium.org2009-12-093-19/+10
| | | | | | | | | | function that matches WebKit instead, since the callers really care about content area scrollbars. BUG=none TEST=none Review URL: http://codereview.chromium.org/463061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34177 0039d316-1c4b-4281-b951-d872f2087c98
* fix for memory leak and illegal access, 2nd attempt.oshima@chromium.org2009-12-091-8/+9
| | | | | | | | | | | | | | * ExternalMetrics class requires scoped_refptr. original CL : http://codereview.chromium.org/470006 BUG=None TEST=Run unit_test with valgrind. patch from issue 470006 Review URL: http://codereview.chromium.org/465140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34176 0039d316-1c4b-4281-b951-d872f2087c98
* Define X509Certificate::intermediate_ca_certs_ as a std::vector ofwtc@chromium.org2009-12-091-7/+6
| | | | | | | | | | | | | | | | OSCertHandle so that we can also use it on Windows. Remove the unused SSLClientSocketMac::intermediate_certs_ member. R=hawk BUG=28744 TEST=Can visit good HTTPS sites with no certificate errors. Clicking the "Certificate information" button in the page security information window should show a complete certificate chain (as opposed to just the server certificate). Review URL: http://codereview.chromium.org/452042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34175 0039d316-1c4b-4281-b951-d872f2087c98
* Fix delete day so that font is correct and it can be reached through tab.mirandac@chromium.org2009-12-091-1/+2
| | | | | | | | | | Landing for eisinger. BUG= 21459 TEST= On history page, font for delete day msg is correct, and you can tab to it. Review URL: http://codereview.chromium.org/473004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34168 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34161 - Enable Pepper support by default, including building the test ↵sehr@google.com2009-12-091-1/+0
| | | | | | | | | | | | | | | | | | | | plugin. This is needed because the NaCl plugin code that runs in the renderer needs to use Pepper APIs all the time, and NaCl support has been enabled by default for several months now. To cause an untrusted Pepper plugin to run in the renderer one needs to specify the internalpepper flag. I have also removed the enable_pepper flag from gyp. As the build of the GPU process was tied to this flag, I have renamed the flag to enable_gpu. TEST=none BUG=none Review URL: http://codereview.chromium.org/464074 TBR=sehr@google.com Review URL: http://codereview.chromium.org/475004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34162 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Pepper support by default, including building the test plugin.sehr@google.com2009-12-091-0/+1
| | | | | | | | | | | | | | | This is needed because the NaCl plugin code that runs in the renderer needs to use Pepper APIs all the time, and NaCl support has been enabled by default for several months now. To cause an untrusted Pepper plugin to run in the renderer one needs to specify the --internal-pepper flag. I have also removed the enable_pepper flag from gyp. As the build of the GPU process was tied to this flag, I have renamed the flag to enable_gpu. TEST=none BUG=none Review URL: http://codereview.chromium.org/464074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34161 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium: support custom WebCore context menu items in Chromium port ↵pfeldman@chromium.org2009-12-094-4/+49
| | | | | | | | (downstream). Review URL: http://codereview.chromium.org/465123 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34154 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34146 - A place to store the pid>mach_port_t mapping.thakis@chromium.org2009-12-097-287/+3
| | | | | | | | | | | | | | | | Not yet for review. Landing to measure perf impact, will revert immediately. BUG=13156 TEST=unittests Review URL: http://codereview.chromium.org/460126 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/466088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34147 0039d316-1c4b-4281-b951-d872f2087c98
* A place to store the pid->mach_port_t mapping.thakis@chromium.org2009-12-097-3/+287
| | | | | | | | | | | | | Not yet for review. Landing to measure perf impact, will revert immediately. BUG=13156 TEST=unittests Review URL: http://codereview.chromium.org/460126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34146 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts my r4300 and re-fixes Issue 3156 and 13500.hbono@chromium.org2009-12-092-23/+16
| | | | | | | | | | | | | | | | | | My r4300, which is a fix Issue 3156, has been causing regressions (Issue 9596, Issue 13500, Issue 29290, etc.) Every time when this change caused regressions, we added more code to Chromium and made Chromium code more complicated. So, I think it is better to revert this change once and find another solution for Issue 3156 rather than to add another workaround for Issue 29290. To look into Issue 3156 more deeply, it is caused by a recursive message-handler call. When SetWindowText() is called while an IME is composing text, the IME calls SendMessage() to send a WM_IME_COMPOSITION message. When we receive this WM_IME_COMPOSITION message, it updates the omnibox and calls SetWindowText()... This recursive call caused not only Issue 3156 but also caused some other IME issues, such as Issue 13500. BUG=3156,13500,29290 TEST=On XP, open a new tab, set the IME to Hiragana, type 'c', and then click an entry in the popup. The browser should navigate and show the popup URL without a crash. TEST=Open Gmail, compose a new e-mail (without using a tear-off window), set the IME to Hiragana, type 'c' in its message body, and wait for the draft auto-saving. The browser should show the 'c' character. Review URL: http://codereview.chromium.org/467015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34145 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bugs with panels. We weren't setting the type at the right timesky@chromium.org2009-12-092-2/+4
| | | | | | | | | | | | and needed to set a size_request so that the title gets the right size. BUG=none TEST=none Review URL: http://codereview.chromium.org/466081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34141 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug so that if we restore popups (as we do on chrome os) wesky@chromium.org2009-12-091-2/+2
| | | | | | | | | | | restore them to the correct size. BUG=none TEST=none Review URL: http://codereview.chromium.org/471002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34140 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes issue where clicking on a <SELECT> dropdown in an extension popup ↵andybons@chromium.org2009-12-096-6/+106
| | | | | | | | | | | | | window would hard crash the browser. I'm hoping that this will open up discussions for refactoring work amongst ExtensionHost and TabContentsView, since so much code is shared between the two and both need sufficient Mac love. BUG=29353 TEST=load a browser action with a popup that contains a SELECT element. click on the element and observe that it acts normally (no crashing). Review URL: http://codereview.chromium.org/465108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34136 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34134 - Viewsbased login window for Chrome OS. Doesn't yet actually ↵jrg@chromium.org2009-12-098-377/+16
| | | | | | | | | | | do anything Review URL: http://codereview.chromium.org/449023 TBR=cmasone@google.com Review URL: http://codereview.chromium.org/467060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34135 0039d316-1c4b-4281-b951-d872f2087c98
* Views-based login window for Chrome OS. Doesn't yet actually do anythingcmasone@google.com2009-12-098-16/+377
| | | | | | Review URL: http://codereview.chromium.org/449023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34134 0039d316-1c4b-4281-b951-d872f2087c98
* Minor cleanup; remove deprecate file_util function and some obsolete TODOs.estade@chromium.org2009-12-093-16/+5
| | | | | | Review URL: http://codereview.chromium.org/467030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34133 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34110 - Fix leak of ShutdownDetector. Broke Mac startup_test.willchan@chromium.org2009-12-091-48/+30
| | | | | | | | | | | | For some reason I thought that nonjoinable threads would always delete their delegates. I was wrong. BUG=http://crbug.com/29675 Review URL: http://codereview.chromium.org/460144 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/460154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34121 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: add UMA calls for drag-and-drop of URLs on tab strip.viettrungluu@chromium.org2009-12-091-0/+2
| | | | | | | | | | | (Chrome/Win already has these, and we use the same names.) BUG=29799 TEST=none Review URL: http://codereview.chromium.org/465139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34120 0039d316-1c4b-4281-b951-d872f2087c98
* Have the utility process run out of process on Linux again bytony@chromium.org2009-12-094-27/+4
| | | | | | | | | | | | using the /proc/self/exe trick we use for plugins. Since we don't need any resources from .pak files, this should be safe. BUG=22703 TEST=Install a theme, verify that it worked properly. Review URL: http://codereview.chromium.org/464073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34117 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34099 - fix for memory leak and illegal access. (found in valgrind test)asargent@chromium.org2009-12-092-12/+8
| | | | | | | | | | | | | | | | * name, values for callback seems to be on stack. i changed const char* to string so that it can copy, and also expect_eq can print string when failed. BUG=None TEST=Run unit_tests on valgrind. Review URL: http://codereview.chromium.org/470006 TBR=oshima@chromium.org Review URL: http://codereview.chromium.org/466083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34114 0039d316-1c4b-4281-b951-d872f2087c98
* Make "delete history for day" message have the correct font on Mac.mirandac@chromium.org2009-12-091-1/+1
| | | | | | | | | | | Committing for feldstein. BUG= 21459 TEST= History tab on mac should show correct font in "delete day" message. Review URL: http://codereview.chromium.org/460148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34111 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak of ShutdownDetector.willchan@chromium.org2009-12-091-30/+48
| | | | | | | | | For some reason I thought that non-joinable threads would always delete their delegates. I was wrong. BUG=http://crbug.com/29675 Review URL: http://codereview.chromium.org/460144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34110 0039d316-1c4b-4281-b951-d872f2087c98
* Revert this, it didn't compile on linux_views (argh)pkasting@chromium.org2009-12-081-2/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34109 0039d316-1c4b-4281-b951-d872f2087c98
* Try re-enabling the resize corner on Windows to see if it still causes perf ↵pkasting@chromium.org2009-12-081-5/+2
| | | | | | | | | | regressions. BUG=458 TEST=The bottom right corner of the window whould have a resize corner. Review URL: http://codereview.chromium.org/465133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34108 0039d316-1c4b-4281-b951-d872f2087c98
* fix for memory leak and illegal access. (found in valgrind test)oshima@chromium.org2009-12-082-8/+12
| | | | | | | | | | | | | * name, values for callback seems to be on stack. i changed const char* to string so that it can copy, and also expect_eq can print string when failed. BUG=None TEST=Run unit_tests on valgrind. Review URL: http://codereview.chromium.org/470006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34099 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix theme loading bubble position.derat@chromium.org2009-12-081-0/+4
| | | | | | | | | BUG=29539 TEST=tried it Review URL: http://codereview.chromium.org/464058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34077 0039d316-1c4b-4281-b951-d872f2087c98
* Notifications should resize themselves to the content within min-max bounds, ↵johnnyg@chromium.org2009-12-0811-92/+218
| | | | | | | | | | | | | rather than being all the same size. CL hooks into RenderView callbacks to detect the size of the content, and contains some refactoring so that conceptually balloon size = content size + frame, rather than content size = balloon size - frame as it has been. BUG=26691 TEST=included Review URL: http://codereview.chromium.org/460131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34076 0039d316-1c4b-4281-b951-d872f2087c98
* Add Cocoa window interposing for plugin processstuartmorgan@chromium.org2009-12-085-104/+92
| | | | | | | | | | | | | | Adds support for noticing window show/hide done via Cocoa APIs. Also adds interposing on a couple more Carbon calls that I came across while debugging. Refactors to make things a bit less messy: - Moves responsibility for re-activating the browser when the last plugin window closes into the browser, to simplify that logic. - Moves utility method for activating the plugin process into the plugin, rather than the interpose library, so the Cocoa code can use it too. - Add a data-holder and a couple of wrapper methods to reduce code duplication in the window show/hide handling. BUG=28009, 29321 TEST=Plugin-opened windows (Gmail attachments, full-screen Flash, etc.) should work as expected again. Review URL: http://codereview.chromium.org/465111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34074 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Don't show all of the print dialog's children, including widgets ↵thestig@chromium.org2009-12-081-1/+1
| | | | | | | | | | normally not displayed. BUG=26872 TEST=Default print dialog should not have the conflict warning. Review URL: http://codereview.chromium.org/460138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34072 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor: Eliminte locking from PrefetchObserver and DnsMaster in favor of ↵eroman@chromium.org2009-12-086-231/+250
| | | | | | | | | | | | | | | | | making these classes non-threadsafe. Conceptually, PrefetchObserver and DnsMaster live on the IO thread, and their methods can only be called from the IO thread. In the cases where calls do need to be made from the UI thread, we post a task to be run on the IO loop and return without blocking. The only time where we block is during shutdown, when we must wait on the IO thread to get us the startup list and referral list. BUG=25335 Review URL: http://codereview.chromium.org/300032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34066 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] A chunk of browser_tests for extensions:thomasvl@chromium.org2009-12-083-4/+14
| | | | | | | | | | | | | | | | - Bring up extension_apitest on mac - stub browser_action_apitest but get it compiling - stubs_apitest passes - compile cross_origin_xhr_apitest, but we don't pass it. - content_script_all_frames_apitest passes - execute_script_apitest passes BUG=none TEST=waterfall stays green Review URL: http://codereview.chromium.org/465121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34065 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Browser_tests workthomasvl@chromium.org2009-12-081-1/+1
| | | | | | | | | | | | | | | | - Drop the GYP variables that were only used in one place (the indirection seems more complicated then helpful) - don't bother with a conditional for breakpad_mac_stubs (1/2 of the file didn't since the excludes handle it) - Continue bring browser_tests stuff online: - extension_browsertest support for other tests - TaskManagerBrowserTest passes - SSLUITest passes - BlacklistManagerBrowserTest passes BUG=none TEST=tests show up on the waterfall/trybot and pass. Review URL: http://codereview.chromium.org/467046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34059 0039d316-1c4b-4281-b951-d872f2087c98
* Addition of a new parameter to the popup.show(...) Chrome extension API that ↵twiz@google.com2009-12-086-16/+48
| | | | | | | | | | | | | | | allows the caller to specify the behaviour of the window focus when the pop-up is displayed. I added a test for the new parameter in the ExtensionApiTest.FLAKY_Popup test. I also corrected a truncated string in the unit-test. Because the pop-up actually uses two windows, I had to change the WidgetWin::Show() routine to also reposition the window at the top. If a window is shown and activated, it is automatically brought to the front. Because we don't activate the pop-up when we want to keep the focus in the current extension view, I had to bring it to the front so that it wouldn't be hidden behind the 'chrome-bubble' window. BUG=none TEST=ExtensionApiTest.FLAKY_Popup Review URL: http://codereview.chromium.org/454019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34037 0039d316-1c4b-4281-b951-d872f2087c98
* Make POSIX SIGTERM/SIGINT/SIGHUP handler async signal safe.willchan@chromium.org2009-12-081-31/+104
| | | | | | | | | | * Don't use LOG/CHECK. Replace with RAW_LOG/DCHECK (newly added to logging.h) * Don't directly post a task to the UI loop. Write to a magic pipe. Read this from a separate thread which will post to a task to the UI loop. BUG=http://crbug.com/29240 Review URL: http://codereview.chromium.org/460094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34036 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 23221: accesskey is not supported on Chromium Mac.suzhe@chromium.org2009-12-082-16/+19
| | | | | | | | | | | The key point is to provide correct unmodifiedText field for fabricated Char events, because in webkit, unmodifiedText is used for matching accesskey. BUG=23221 TEST=See bug report. Review URL: http://codereview.chromium.org/460105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34035 0039d316-1c4b-4281-b951-d872f2087c98
* printing: replace the deprecated macro (DISALLOW_EVIL_CONSTRUCTORS).maruel@chromium.org2009-12-082-2/+2
| | | | | | | | | | Use DISALLOW_COPY_AND_ASSIGN instead. Patch contributed by Thiago Farina Review URL: http://codereview.chromium.org/460087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34030 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Allow silent extension installations from the extensions gallery - ↵rafaelw@chromium.org2009-12-0819-254/+61
| | | | | | | | | | | | | | | Part 1." Original CL: http://codereview.chromium.org/400018/show Looks like we're no longer hoping to get this approach into mstone4 release, so I'm unwinding this. BUG=27431 TBR=aa Review URL: http://codereview.chromium.org/467042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34025 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Show group separators in the keyword editorrsesek@chromium.org2009-12-083-20/+167
| | | | | | | | | BUG=23570,21640 TEST=Chromium-->Preferences-->Manage. (1) See "Default" group. (2) Add an engine and it appears under an "Other" group header. (3) Make that new engine default and it moves under the "Default" group and the "Other" header disappears. Review URL: http://codereview.chromium.org/466022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34024 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 34008 - Adds basic group policy support. Resubmitting r33093 with a ↵gwilson@chromium.org2009-12-075-906/+0
| | | | | | | | | | | | | | | new unit test. TBR=cpu TEST=unit test included BUG=19374 Review URL: http://codereview.chromium.org/450037 Review URL: http://codereview.chromium.org/460128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34014 0039d316-1c4b-4281-b951-d872f2087c98
* Remove IsPrefRegistered function from PrefService API and fix the callers totony@chromium.org2009-12-079-13/+13
| | | | | | | | | | | | | | call FindPreference directly. BUG=None TEST=compiles and passes existing tests Original patch by Thiago Farina <thiago.farina@gmail.com> at http://codereview.chromium.org/460117/show Review URL: http://codereview.chromium.org/463044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34010 0039d316-1c4b-4281-b951-d872f2087c98
* Adds basic group policy support. Resubmitting r33093 with a new unit test.gwilson@google.com2009-12-075-0/+906
| | | | | | | | | | R=kuchhal TEST=unit test included BUG=19374 Review URL: http://codereview.chromium.org/450037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34008 0039d316-1c4b-4281-b951-d872f2087c98
* Extensions: create a simple model for the browser action buttons toolstrip ↵estade@chromium.org2009-12-076-44/+183
| | | | | | | | | | | | | | | | and use it on Linux. TODO: persist the order of buttons TODO: use the model on windows, mac TODO: let the view change the order of buttons My plan for persisting the order is just to write/read a simple text file to/from disk, one extension id per line. Similar to the bookmark model, except that is structured data (because they try to hold more information). BUG=26990 Review URL: http://codereview.chromium.org/462026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34005 0039d316-1c4b-4281-b951-d872f2087c98
* Use gfx::Point instead of GET_X/Y_LPARAM to reduce the dependency on ATL. jhawkins@chromium.org2009-12-073-4/+5
| | | | | | | | | | | Patch from Thiago Farina <thiago.farina@gmail.com> Original review: http://codereview.chromium.org/465004 BUG=5027 TEST=None Review URL: http://codereview.chromium.org/460121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33996 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where we wouldn't force a maximized window on Chrome OSsky@chromium.org2009-12-071-2/+6
| | | | | | | | | | | | | | | | during login. This happens because on Chrome OS we start the WM and Chrome at the same time, which means it's possiblef for us not to be able to get the name of the window manager. I've changed the code to assume that if we can't get the name of the window manager we're on Chrome OS. This isn't perfect. Hopefully once the WM tells us we're maximized before we're shown we can do away with this code. BUG=ChromeOS bug 929 TEST=none Review URL: http://codereview.chromium.org/463042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33985 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix painting on the NTP and elsewhere.agl@chromium.org2009-12-071-2/+2
| | | | | | BUG=29504 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33980 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Pump renderer messages in web content right-click context menu.shess@chromium.org2009-12-071-0/+6
| | | | | | | | | | | | Allow nestable tasks while processing the menu so that video and the like doesn't pause. BUG=25055 TEST=Start a video somewhere. Right-click in the content. Video should keep running. Review URL: http://codereview.chromium.org/366021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33973 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: implement "Search the Web..." (Opt-Cmd-F).viettrungluu@chromium.org2009-12-073-1/+23
| | | | | | | | | | | | | | This focuses the Omnibox with '?' in the contents with the text insertion point immediately after (and no selection), unless the Omnibox already has something beginning with '?' in which case it selects the text after the '?'. This is what Ctrl-K does on other platforms. On the Mac, we get a menu item (under Edit -> Find), and the Mac-standard shortcut of Opt-Cmd-F (users can set Cmd-K as a short cut in System Preferences if they really want). Changes to MainMenu.xib: added ^IDS_EDIT_SEARCH_WEB_MAC menu item ("Search the Web...", tag 39002, Opt-Cmd-F as keyboard shortcut, sending -commandDispatch: to first responder) as first item in Find submenu, followed by a separator. BUG=29501 TEST=Check that this feature has the behaviour described above (using both the menu item and using Opt-Cmd-F), with (1) nothing in the Omnibox to begin with, (2) a random URL in the Omnibox, and (3) "?<some search term(s)>". Check that the Omnibox is properly focused (so set focus to various places, and make sure that the Omnibox gets focused). Review URL: http://codereview.chromium.org/460111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33971 0039d316-1c4b-4281-b951-d872f2087c98
* Add notification for autofill changes.skrul@chromium.org2009-12-073-2/+48
| | | | | | | | | | This is the first in a series of changes for adding notifications to autofill. This change adds the notification plumbing to WebDataService::AddFormFieldValues that sends a simple notification. The next change will add a Details<> payload to the notification with a list of changes that were performed, and then I will expand the notifications to the other autofill mutation methods. Review URL: http://codereview.chromium.org/455027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33970 0039d316-1c4b-4281-b951-d872f2087c98
* Land http://codereview.chromium.org/467012 on behalf of tfarina.zork@chromium.org2009-12-072-1/+88
| | | | | | Review URL: http://codereview.chromium.org/465079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33968 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 21:13:35 +0000