summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Use grit to generate locale rc files and remove the old locale rc ↵tc@google.com2009-03-034-40/+39
| | | | | | | | | | | files from the tree." Revert "window_ is null during BrowserWindow creation. Assume full screen" Revert "Move SupportsWindowFeature from BrowserView to Browser so" git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10814 0039d316-1c4b-4281-b951-d872f2087c98
* Enables bookmark_model_unittest on Mac and Linux.avi@chromium.org2009-03-031-19/+19
| | | | | | | | | | Committed on behalf of rohitrao. http://codereview.chromium.org/28299/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10813 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 10794.avi@chromium.org2009-03-035-7/+13
| | | | | | Review URL: http://codereview.chromium.org/40027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10808 0039d316-1c4b-4281-b951-d872f2087c98
* Removing CRLFs from extensions.htmlrafaelw@chromium.org2009-03-031-86/+86
| | | | | | Review URL: http://codereview.chromium.org/39025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10807 0039d316-1c4b-4281-b951-d872f2087c98
* Ship some tests which aren't related to what I'm working on:shess@chromium.org2009-03-032-9/+1
| | | | | | | | | | | | RenderViewHostTest, RenderWidgetHostTest (added to gyp) RenderDnsMasterTest, DnsQueueTest (already in gyp) MetricsLogTest, MetricsResponseTest (already in gyp) NOTE: Now that we're all-gyp-all-the-time, only the first couple tests are really being added. Review URL: http://codereview.chromium.org/27297 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10806 0039d316-1c4b-4281-b951-d872f2087c98
* window_ is null during BrowserWindow creation. Assume full screentc@google.com2009-03-031-1/+1
| | | | | | | | | | is false. TBR=pkasting Review URL: http://codereview.chromium.org/39023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10805 0039d316-1c4b-4281-b951-d872f2087c98
* Move SupportsWindowFeature from BrowserView to Browser sotc@google.com2009-03-034-39/+40
| | | | | | | | | | | we can share the code on all platforms. I still left a SupportsWindowFeature method in BrowserView that handles fullscreen mode which is (for now) a Windows specific feature. Review URL: http://codereview.chromium.org/27372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10804 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression where escape was not removing a newly bookmarkedsky@google.com2009-03-031-1/+2
| | | | | | | | | | | | | | page. BUG=none TEST=press the star button on a page you haven't bookmarked. The star should light up. Press escape, the bubble should close and the bookmark should be removed. Repeat with an existing bookmark and make sure pressing escape doesn't remove the bookmark. Review URL: http://codereview.chromium.org/40019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10803 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up a few comments / formatting related to the location bar.deanm@chromium.org2009-03-032-11/+17
| | | | | | | | Correct the includes, forward declare TabContents. Review URL: http://codereview.chromium.org/39011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10800 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb GetLocationBar through to the toolbar.deanm@chromium.org2009-03-034-2/+13
| | | | | | | | | The toolbar will own the LocationBarView, which implements the LocationBar interface. Plumb the request for the LocationBar through from the browser window to the toolbar. Review URL: http://codereview.chromium.org/40008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10799 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more ifdefs where all platforms now share the implementation.pinkerton@chromium.org2009-03-032-10/+1
| | | | | | Review URL: http://codereview.chromium.org/39017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10797 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing WebKeyboardEvent. Third time's the charm.avi@chromium.org2009-03-035-13/+7
| | | | | | Review URL: http://codereview.chromium.org/27332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10794 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some instances of NOTIMPLEMENTED in favor of hooking up functionality ↵pinkerton@chromium.org2009-03-038-12/+47
| | | | | | | | or filing a bug as a placeholder. Reduces noise at startup. Review URL: http://codereview.chromium.org/27353 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10790 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some include guards in browser/gtk.deanm@chromium.org2009-03-033-10/+10
| | | | | | Review URL: http://codereview.chromium.org/39012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10789 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup the autocomplete model includes. Move from a deprecated ↵deanm@chromium.org2009-03-033-31/+4
| | | | | | | | | | | std::wstring to utf8 url fixer upper function. These files should now compile on Linux. Review URL: http://codereview.chromium.org/28323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10788 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when installing plugins.jhawkins@chromium.org2009-03-031-2/+5
| | | | | | | | | | | * Make sure the scoped_ptr is initialized before trying to open a file. * Assign the result of FilePath::Append to download_file_path_. R=ananta BUG=8087 Review URL: http://codereview.chromium.org/28349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10787 0039d316-1c4b-4281-b951-d872f2087c98
* Make our IME backend platform-independent.hbono@chromium.org2009-03-031-3/+3
| | | | | | | This change makes our IME backend run not only on Windows but also on Linux and Mac. This change also adds another unit-test which verifies the backend runs on Linux and Mac without problems. Review URL: http://codereview.chromium.org/27124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10783 0039d316-1c4b-4281-b951-d872f2087c98
* Make history and downloads open once per window unless the user modifies ↵glen@chromium.org2009-03-033-16/+9
| | | | | | | | | | | | their view. Also fix the back dropdown so that it opens the DOMUI version of History rather than the NativeUI version. BUG=8086,8297 Review URL: http://codereview.chromium.org/39002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10782 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a small issue changing back to glass frame from opaque where theben@chromium.org2009-03-031-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10779 0039d316-1c4b-4281-b951-d872f2087c98
* Make it so that dropdown selects don't deactivate the main frame when opened ↵ben@chromium.org2009-03-037-0/+21
| | | | | | http://crbug.com/8247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10777 0039d316-1c4b-4281-b951-d872f2087c98
* Resolve crash when deleting history by preventing the deleter from being ↵glen@chromium.org2009-03-035-78/+163
| | | | | | | | called multiple times. We need to add UI to make what's happening clearer to the user, but this gets us over the hump for now. Also change the history page to queue deletions.Allow history search from the new tab page.Make history title inclusion safer (createTextNode changes).Show starred status on history page.BUG=8214,8163,8271,8284 Review URL: http://codereview.chromium.org/28308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10773 0039d316-1c4b-4281-b951-d872f2087c98
* Don't expose --single-process and --in-process-plugins for official Chrome ↵jam@chromium.org2009-03-031-0/+4
| | | | | | | | releases. Review URL: http://codereview.chromium.org/28347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10771 0039d316-1c4b-4281-b951-d872f2087c98
* Port Replace(First)SubstringsAfterOffset to string16.dsh@google.com2009-03-034-43/+59
| | | | | | Review URL: http://codereview.chromium.org/28324 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10767 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome/apps/result_codes.h to chrome/common/result_codes.hthestig@chromium.org2009-03-0312-18/+13
| | | | | | Review URL: http://codereview.chromium.org/28279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10761 0039d316-1c4b-4281-b951-d872f2087c98
* Register an onmessage handler with the external host binding instead of ↵ananta@chromium.org2009-03-034-9/+6
| | | | | | | | | | | explicitly passing in a target Javascript function to execute. The onmessage handler is a one argument Javascript function for now. Review URL: http://codereview.chromium.org/28291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10760 0039d316-1c4b-4281-b951-d872f2087c98
* Support DWM switching.ben@chromium.org2009-03-0323-1033/+736
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This completes the collapsing of window types and browser frames around a single class: views::Window. CustomFrameWindow is removed with this change. The Browser window is represented by a single views::Window subclass: BrowserFrame, which replaces both AeroGlassFrame and OpaqueFrame. NonClientView is now a container of two sibling classes - the Window's ClientView (in the Browser's case, BrowserView), and a NonClientFrameView subclass, which provides the rendering for the non-client portions of the window. These Views are siblings rather than the ClientView a child of the NonClientFrameView because when the DWM is toggled, the ClientView would have to be re-parented. Many Views make the assumption they are only inserted into a View hierarchy once, and so this is problematic. By having the views be siblings, this is avoided. With this in mind, all of the former NonClientViews now become NonClientFrameView subclasses: DefaultNonClientView -> CustomFrameView (non-existent, NonClientView) -> NativeFrameView AeroGlassNonClientView -> GlassBrowserFrameView OpaqueNonClientView -> OpaqueBrowserFrameView The latter two derive from NonClientFrameView via BrowserNonClientFrameView, which adds some extras. I also had to modify the TabRenderer class to know how to drop its cache of tab background images when the theme changes since it uses different ones for Glass and non-Glass. This change also fixes a few non-client flicker issues relating to window non-client activation by using more ScopedRedrawLocks. (Touches info_bubble.cc, window.cc) Bugs fixed: http://crbug.com/153 http://crbug.com/747 http://crbug.com/2371 http://crbug.com/3264 http://crbug.com/8234 Plumbing for http://crbug.com/8247 Design docs: http://dev.chromium.org/developers/design-documents/views-windowing http://dev.chromium.org/developers/design-documents/browser-window Review URL: http://codereview.chromium.org/27317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10757 0039d316-1c4b-4281-b951-d872f2087c98
* Enable spellcheck_unittest.cc.mark@chromium.org2009-03-031-5/+4
| | | | | | Review URL: http://codereview.chromium.org/28335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10754 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash introduced in r10563 where we modified a RenderWidgetHost after it ↵erg@google.com2009-03-032-4/+12
| | | | | | | | had been deallocated. Review URL: http://codereview.chromium.org/27363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10751 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ExtensionViewTest and reenable it.mpcomplete@google.com2009-03-034-10/+38
| | | | | | | | | Also, normalize extension IDs to lower case when reading them in. GURL lower cases them when used as hostnames, so string comparisons need to be done in lower case to work. Review URL: http://codereview.chromium.org/28331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10750 0039d316-1c4b-4281-b951-d872f2087c98
* Proposed change to support resource loading for media files.hclam@chromium.org2009-03-024-0/+98
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Highlights of changes: - Added methods to disk_cache::Entry: - Entry::PrepareTargetAsExternalFile(int index) Prepare a stream in an entry to use external file for storage. - Entry::GetExternalFile(int index) Get the external file backing the stream in the entry. - Added a property "CacheType type_" to HttpCache, along with setter and getter. There shall be two cache types, COMMON_CACHE and MEDIA_CACHE for distinguishing between different purpose of HttpCache. We have this property to trigger special behavior for caching needs of media files. - Added static methods to ChromeURLRequestContext - ChromeURLRequestContext::CreateOriginalForMedia Create a URLRequestContext for media files for the original profile. - ChromeURLRequestContext::CreateOffTheRecordForMedia Create a URLRequestContext for media files for off the record profile. - Added method to Profile interface. - GetRequestContextForMedia To get the request context for media files from the context. Design decissions: - Enforce writing to external file by calling methods to Entry rather than construct Backend by a different flag. Since we only want a valid and full response to go into an external file rather than redirection response or erroneous response, we should let HttpCache::Transaction to decide when to have an external file for response data. We eliminate a lot of useless external cache files. - Adding the CacheType enum and property to HttpCache, we could allow possible (?) future extensions to HttpCache to handle other different caching needs. And there's no need to add change constructors of HttpCache, but maybe we should add a specific constructor to accomodate a media HttpCache? - Adding Profile::GetRequestContextForMedia() Since we will need to use this new request context in ResourceDispatcherHost, I think the best place to keep it is in the profile. Also we will expose to user that there's a separate cache for media, so it's better to expose it in the Profile level to allow settings to the media cache, e.g. max file size, etc. Review URL: http://codereview.chromium.org/19747 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10745 0039d316-1c4b-4281-b951-d872f2087c98
* Add file that got missing from main checkin.ericroman@google.com2009-03-021-0/+2
| | | | | | | TBR=wtc@chromium.org Review URL: http://codereview.chromium.org/27357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10744 0039d316-1c4b-4281-b951-d872f2087c98
* Convert encryptor.cc and friends to string16.thestig@chromium.org2009-03-024-51/+55
| | | | | | Review URL: http://codereview.chromium.org/28292 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10740 0039d316-1c4b-4281-b951-d872f2087c98
* Fix order of downloads list (HTH it happened, I don't know).glen@chromium.org2009-03-021-1/+1
| | | | | | | | BUG=8283 Review URL: http://codereview.chromium.org/28328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10735 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bookmark and menu drag images by making a halo around them. This makesbrettw@chromium.org2009-03-0213-5/+18
| | | | | | | | | | | | | the ClearType composited on the correct color to fix the semitransparent pixels into 1-bit transparency pixels. Remove some unnecessary header file dependencies on ChromeCanvas I noticed when compiling this patch. BUG=8258 Review URL: http://codereview.chromium.org/27321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10732 0039d316-1c4b-4281-b951-d872f2087c98
* Add site_instance_unittest.cc to the Posix build.jhawkins@chromium.org2009-03-021-2/+2
| | | | | | Review URL: http://codereview.chromium.org/27299 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10726 0039d316-1c4b-4281-b951-d872f2087c98
* Enable focus-change via tabbing on Linux.estade@chromium.org2009-03-026-19/+90
| | | | | | Review URL: http://codereview.chromium.org/28248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10725 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a slight error in the atl includes. We are using the CRect class from ↵maruel@chromium.org2009-03-021-1/+2
| | | | | | | | | WTL and not from ATL... TBR=deanm Review URL: http://codereview.chromium.org/28326 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10722 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compilations errors introduced by revision 10712.maruel@chromium.org2009-03-025-13/+21
| | | | | | | TBR=deanm Review URL: http://codereview.chromium.org/27347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10721 0039d316-1c4b-4281-b951-d872f2087c98
* Remove includes to the newly removed edit_drop_target.h header.deanm@chromium.org2009-03-022-2/+0
| | | | | | Review URL: http://codereview.chromium.org/28319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10715 0039d316-1c4b-4281-b951-d872f2087c98
* Separate the AutocompleteEditView from the cross-platform code.deanm@chromium.org2009-03-0215-2662/+2806
| | | | | | | | | | | | Separate the platform specific AutocompleteEditView from the cross-platform model and controller. This leaves the model/controller in autocomplete_edit.{h,cc}, and moves the view into autocomplete_edit_view.h and autocomplete_edit_view_win.{h,cc}. There is now an abstract interface (AutocompleteEditView) which the model uses to talk to the view. Other views (for example, the LocationBarView) will still talk directly to the AutocompleteEditViewWin, which is the full Chrome view. This change also pulled in the Windows specific edit_drop_target code into autocomplete_edit_view_win.cc. Review URL: http://codereview.chromium.org/27327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10712 0039d316-1c4b-4281-b951-d872f2087c98
* Create the PopupView from the EditView, not the PopupModel.deanm@chromium.org2009-03-028-228/+244
| | | | | | | | | | | | | | It is hard to instantiate platform-specifc classes (like the AutocompletePopupView) from cross-platform classes (like the model). This does what makes more sense, create platform specific instances from platform specific code. The AutocompleteEditView now creates the AutocompletePopupView. The AutocompletePopupView now creates the AutocompletePopupModel. This also requires exposing AutocompletePopupViewWin, so that in the future the AutcompletePopupViewWin will be able to be created with an AutocompleteEditViewWin pointer. This sort of reverts some of my previous changes, as is pulls the interface out of autocomplete_popup_view_win.cc and into autocomplete_popup_view_win.h. This is sad but neccessary. This removes the AutocompletePopupView::CreatePopupView factory, and replaces it by directly instantiating the platform-specific view instance. Review URL: http://codereview.chromium.org/28313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10707 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash; dom_ui_ is destroyed by LoadURL.glen@chromium.org2009-03-011-1/+3
| | | | | | | | BUG=8158 Review URL: http://codereview.chromium.org/27285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10689 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the misspelling of GetLaunchShortcutKind().mal@chromium.org2009-02-281-3/+3
| | | | | | | TBR= cpu Review URL: http://codereview.chromium.org/27314 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10683 0039d316-1c4b-4281-b951-d872f2087c98
* Run the unload tests in single process mode, after my fix to single process ↵jam@chromium.org2009-02-281-35/+0
| | | | | | | | | mode. BUG=7933 Review URL: http://codereview.chromium.org/27311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10680 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Windows ifdefs, all views will need to implement this method.deanm@chromium.org2009-02-281-5/+1
| | | | | | Review URL: http://codereview.chromium.org/27274 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10679 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing this.ananta@chromium.org2009-02-281-3/+17
| | | | | | | | | | | | | | | | | | | | Don't call SetPriorityClass if CBSText.dll is loaded in the browser process. The CBSText.dll loads as a global GetMessage hook into the browser process and intercepts/unintercepts the kernel32 API SetPriorityClass in a background thread. If the browser calls this API just when it is intercepted the dlls interceptor proc messes up the stack while returning back, which causes random crashes in the browser. The hacky fix for now is to check for this dll and not invoke the API. We will beautify this fix if it works in the wild. This fixes http://code.google.com/p/chromium/issues/detail?id=6418 Bug=6418 Review URL: http://codereview.chromium.org/27298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10676 0039d316-1c4b-4281-b951-d872f2087c98
* Initial work on chrome-ui://extensions/ page. URL now displays a static ↵rafaelw@chromium.org2009-02-287-0/+249
| | | | | | | | template page Review URL: http://codereview.chromium.org/28172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10675 0039d316-1c4b-4281-b951-d872f2087c98
* Fix system menu positioning in fullscreen mode to be at the upper left ↵pkasting@chromium.org2009-02-282-8/+11
| | | | | | | | | corner of the screen. BUG=8151 Review URL: http://codereview.chromium.org/28247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10674 0039d316-1c4b-4281-b951-d872f2087c98
* Adapt (and move) mark@chromium.org's Keystone integration to Chromium.jrg@chromium.org2009-02-281-1/+6
| | | | | | | | | | | | | | | | | | | | Call it from the Browser. (no-op if not packaged for branding). Add new build target "app_packaging" to package (if possible). (app_packaging target intentionally left out of "All"). For convenience, here is the app_packaging script embedded in the xcodeproj: PACKAGER="${PROJECT_DIR}/tools/mac/package_chrome.sh" if [ -f "${PACKAGER}" ]; then "${PACKAGER}" fi Mark, I know this is not in gyp... I am happy to have this klobbered and redo it (in gyp) at the appropriate time. Review URL: http://codereview.chromium.org/27293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10668 0039d316-1c4b-4281-b951-d872f2087c98
* Wire chrome shortcuts tooltip (installation)cpu@google.com2009-02-281-1/+4
| | | | | | | | | | | - Not complete since we are waiting for translations - For chromium the tooltip says "Browse the internet" BUG=b/1522969 Review URL: http://codereview.chromium.org/28272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10666 0039d316-1c4b-4281-b951-d872f2087c98