summaryrefslogtreecommitdiffstats
path: root/chrome/browser
Commit message (Collapse)AuthorAgeFilesLines
* Cleans up notifications for the NavigationController. There were severalbrettw@google.com2008-08-1911-62/+170
| | | | | | | | | | | | notifications before and some of them were very unclear and misused (STATE_CHANGED). This one, and PRUNED were called unnecessarily in some cases as well. I replaced STATE_CHANGED and INDEX_CHANGED with ENTRY_COMMITTED which is more clear and covers (I think!) all the cases that the callers care about. I added a simple notification testing helper class, and used in the navigation controller unit tests to make sure we get the proper notifications. I had to change NotificationSource/Details to have a = and copy constructor so I can track them easily in my helper. I don't see why this would be bad. BUG=1325636,1321376,1325779 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1039 0039d316-1c4b-4281-b951-d872f2087c98
* Make the otr avatar icon not show in detached OTR popup windows.beng@google.com2008-08-195-28/+29
| | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1038 0039d316-1c4b-4281-b951-d872f2087c98
* Factor the SSL state out of the main NavigationEntry into a helper class. Thisbrettw@google.com2008-08-1915-175/+187
| | | | | | | | | | | makes it easier to find stuff and also copy ssl state (just assign). I made one "real" change in web_contents where I copy the entire SSL state now to the new entry rather than just a few fields like the old one. I couldn't figure out why this was necessary: running it shows that this leaves the other two fields in the uninitialized state which seems wrong. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1032 0039d316-1c4b-4281-b951-d872f2087c98
* Use LF for newlines in all DEPS filesmmentovai@google.com2008-08-181-19/+19
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1011 0039d316-1c4b-4281-b951-d872f2087c98
* * Land the fix for issue 1322174 (which is not last-minute) on the trunk. ↵pkasting@google.com2008-08-181-13/+7
| | | | | | | | | | | This has already landed on branch. * Revert one of my earlier fixes to hack some RTL engine names to be "LTR-friendly" to work around bugs in the engine management dialog. We also show these names in _other_ places (like the keyword UI in the omnibox) which are not buggy, so I broke these. * Change the URLs for msn.co.il, which unlike seemingly all other MSN sites is actually really using MSN and not Live Search under the hood, and thus has a different URL layout. BUG=1322174,1329557,1329566 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1003 0039d316-1c4b-4281-b951-d872f2087c98
* First set of changes to start separating Google specific branding from ↵rahulk@google.com2008-08-181-2/+5
| | | | | | | | | | | | | Chromium. This change mostly tries to modify installer to install Chromium or Google Chrome depending on a compile flag. The goal is to try to isolate all the differences in a single class that can be overridden for customization. There is also a lot of refactoring to make this happen. Some changes are yet to be done but I didn't want to make this change even bigger than it already is. With all these changes the default build should still work as it is (Google Chrome should get installed/uninstalled). The changes yet to be done: - Separating string resources (this is marked by TODO in one of the files) - Generate different chrome.7z (Chromium will not include rlz.dll) for mini_installer BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@999 0039d316-1c4b-4281-b951-d872f2087c98
* The CL is consist of CLs(1624,1580) for bug:1281734 which are reviewed and ↵jnd@google.com2008-08-1820-40/+121
| | | | | | | | | LG by brett. I just merge them to single one for passing compilation. The CL is to fix bug http://b/issue?id=1281734. FireFox uses encoding used by the original webpage to decode the source of the webpage, Chrome does not. We need to add a new parameter which carries the override encoding when opening a view-source URL for viewing its source. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@997 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the window icon for app windows, with a throbber etc.beng@google.com2008-08-189-37/+174
| | | | | | Also add support for OTR icon.B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@992 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly include logging.h in a header that assumed it was already getting ↵maruel@google.com2008-08-161-4/+9
| | | | | | | | included. TBR=nsylvain@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@972 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build break.iyengar@google.com2008-08-152-0/+37
| | | | | | | TBR=joshia git-svn-id: svn://svn.chromium.org/chrome/trunk/src@965 0039d316-1c4b-4281-b951-d872f2087c98
* Added support for PostMessage from the automation framework toiyengar@google.com2008-08-152-0/+8
| | | | | | | the renderer. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@964 0039d316-1c4b-4281-b951-d872f2087c98
* git-svn-id: svn://svn.chromium.org/chrome/trunk/src@963 ↵brettw@google.com2008-08-1510-166/+59
| | | | 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing files from the previous changejoshia@google.com2008-08-153-0/+15
| | | | | | | TBR=iyengar git-svn-id: svn://svn.chromium.org/chrome/trunk/src@959 0039d316-1c4b-4281-b951-d872f2087c98
* Code to facilitate sending message to external host.joshia@google.com2008-08-155-0/+24
| | | | | | | | | | Note that at this time the parameters to the message are still tentative. The call goes as a sync call from renderer to the browser. From then onwards it happens async and no return value is available yet. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@957 0039d316-1c4b-4281-b951-d872f2087c98
* Cleans up notifications for the NavigationController. There were severalbrettw@google.com2008-08-1510-59/+166
| | | | | | | | | | | | | | | | | | | | | | | | notifications before and some of them were very unclear and misused (STATE_CHANGED). This one, and PRUNED were called unnecessarily in some cases as well. I replaced STATE_CHANGED and INDEX_CHANGED with ENTRY_COMMITTED which is more clear and covers (I think!) all the cases that the callers care about. I added a simple notification testing helper class, and used in the navigation controller unit tests to make sure we get the proper notifications. I had to change NotificationSource/Details to have a = and copy constructor so I can track them easily in my helper. I don't see why this would be bad. As part of this, I got very frustrated recompiling the world whenever navigation_types.h changed. So I removed this dependency from the notification service which everybody includes. Most of the changed files are adding notification_types.h in the .cc file where it's needed. BUG=1325636,1321376,1325779 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@956 0039d316-1c4b-4281-b951-d872f2087c98
* Copy from http://chrome-reviews.prom.corp.google.com/1237 (new gcl ↵timsteele@google.com2008-08-1510-3/+155
| | | | | | | | | | | | | | | | | | | changelist model). Description was: Conditionally include personalization/ code by surrounding the hooks into this module with #ifdef CHROME_PERSONALIZATION in various .h/.cc files. Building with the module requires adding this macro as a preprocessor definition in build/internal/essential.vsprops, and adding it to the VCResourceCompiler tool's command line (using /d). We will try and make this easier in the future. TBR=darin git-svn-id: svn://svn.chromium.org/chrome/trunk/src@955 0039d316-1c4b-4281-b951-d872f2087c98
* Step 1 at making Gears run in the renderer process (enabled by switchmpcomplete@google.com2008-08-154-1/+34
| | | | | | | | | "--gears-in-renderer"). Requires some changes to gears to work. Most things work if you disable the sandbox. One major hole is that update tasks don't report status to the appropriate renderer. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@954 0039d316-1c4b-4281-b951-d872f2087c98
* Large patch set (159 files total) to cleanup the includes.maruel@google.com2008-08-1585-257/+415
| | | | | | | | | | - Slightly reduce the size of the generated .lib files ~3%. - Reduce the number of implicit and explicit atl and windows includes. hooray! - Help incremental build by reducing the number of unnecessary included files. - Split some template class in two, one base class for the common code and the specialization that inherits from the base class. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@937 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce MessagePump to represent the native message pump used to drive adarin@google.com2008-08-1513-65/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | MessageLoop. A MessageLoop now has a MessagePump. This will make it possible to port the MessagePump interface to other platforms as well as to use an IO completion port for our worker threads on Windows. Currently, there is only MessagePumpWin, which attempts to preserve the pre-existing behavior of the MessageLoop. API changes to MessageLoop: 1. MessageLoop::Quit means return from Run when the MessageLoop would otherwise wait for more work. 2. MessageLoop::Quit can no longer be called outside the context of an active Run call. So, things like this: MessageLoop::current()->Quit(); MessageLoop::current()->Run(); are now: MessageLoop::current()->RunAllPending(); 3. MessageLoop::Quit can no longer be called from other threads. This means that PostTask(..., new MessageLoop::QuitTask()) must be used explicitly to Quit across thread boundaries. 4. No protection is made to deal with nested MessageLoops involving watched objects or APCs. In fact, an assertion is added to flag such cases. This is a temporary measure until object watching and APC facilities are removed in favor of a MessagePump designed around an IO completion port. As part of this CL, I also changed the automation system to use an IPC::ChannelProxy instead of an IPC::Channel. This moves the automation IPC onto Chrome's IO thread where it belongs. I also fixed some abuses of RefCounted in the AutomationProvider class. It was deleting itself in some cases! This led to having to fix the ownership model for AutomationProvider, which explains the changes to AutomationProviderList and so on. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@928 0039d316-1c4b-4281-b951-d872f2087c98
* Make theme change notifications for the renderer originate from the ↵beng@google.com2008-08-1510-37/+18
| | | | | | | | | RenderWidgetHostHWND, not the frame. B=1326392 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@918 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the system menu in new frames.erg@google.com2008-08-144-1/+121
| | | | | | BUG=1319684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@908 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that the default download directory exists when thepaulg@google.com2008-08-143-0/+13
| | | | | | | | DownloadManager is initialized. BUG=1324355 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@907 0039d316-1c4b-4281-b951-d872f2087c98
* git-svn-id: svn://svn.chromium.org/chrome/trunk/src@904 ↵sidchat@google.com2008-08-143-19/+152
| | | | 0039d316-1c4b-4281-b951-d872f2087c98
* Some printers advertise longer printable length than the page length. Remove ↵maruel@google.com2008-08-141-3/+3
| | | | | | the DCHECK that was verifying this. I would have liked to had a buffer to accept ~5 inch of difference but at that point, the dpi is not known. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@893 0039d316-1c4b-4281-b951-d872f2087c98
* A first stab at testing browser close behavior when there are unload listenersojan@google.com2008-08-141-0/+47
| | | | | | | | registered. There are still a ton of tests to add as listed in the TODO, but I figured it would be good to get this reviewed first before delving too far into figuring out how to deal with beforeunload dialogs. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@890 0039d316-1c4b-4281-b951-d872f2087c98
* Make the FindInPageController implement its own delegate interface forbrettw@google.com2008-08-149-114/+91
| | | | | | | | | | | | | RenderViewHost so that we can get rid of the pass-throughs in WebContents. I removed some redundant checks in WebContents when calling view() for render_view_host() since that internally checks the null-ness of render_view_host(). BUG=1323267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@881 0039d316-1c4b-4281-b951-d872f2087c98
* Add End-session handling and app modal dialog handling to BrowserView2/New ↵beng@google.com2008-08-147-8/+82
| | | | | | | | | Frames. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@879 0039d316-1c4b-4281-b951-d872f2087c98
* Moving GoogleUpdateSettings to util. Installer as well as Chrome needs these ↵rahulk@google.com2008-08-143-3/+3
| | | | | | | | | settings. BUG=1296800 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@877 0039d316-1c4b-4281-b951-d872f2087c98
* git-svn-id: svn://svn.chromium.org/chrome/trunk/src@873 ↵awalker@google.com2008-08-144-9/+9
| | | | 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bugs in NavigationController:sky@google.com2008-08-141-5/+3
| | | | | | | | | | | | | | | . TabContentsWasDestroyed wasn't removing from the collector map, resulting. . The collector map wasn't cleared in Destroy when it should have been. This was the cause of random ui failures. BUG=1324555 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@870 0039d316-1c4b-4281-b951-d872f2087c98
* Removing the code which enables using the renderer dib in the browser backingiyengar@google.com2008-08-142-57/+1
| | | | | | | | | store as this hurts performance. Bug=1314407 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@858 0039d316-1c4b-4281-b951-d872f2087c98
* HuntForZombieChromeProcesses() is killing the child process of upgradecpu@google.com2008-08-141-1/+2
| | | | | | | | | | - remove call from MessageWindow::~MessageWindow() - fix bug in zombie killer so it recognizes own childs BUG=1323601 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@851 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup spell check file to stop using reference counted pointers without need.jar@google.com2008-08-142-16/+7
| | | | | | | | | | | | | | | | | I don't really believe this will solve anything (in terms of the bug), but it did remove some needless complexity above the crash site in the stack. There is a tiny chance that there is a shutdown race, where the destruction of the containing object raced ahead of the execution (and resulting destruction) of a task. I think the destruction of the task by the containing object would probably be bad anyway, and I doubt that it even happens... so this is all about being cleaner. bug=1318039 r=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@850 0039d316-1c4b-4281-b951-d872f2087c98
* Use %ls instead of %s in wprintf format strings for wchar_t fields.mmentovai@google.com2008-08-149-12/+12
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@846 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy change.jabdelmalek@google.com2008-08-131-1/+1
| | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@835 0039d316-1c4b-4281-b951-d872f2087c98
* Make Javascript alerts do IDN and proper handling of non-standard and filebrettw@google.com2008-08-131-5/+16
| | | | | | | | | | schemes. BUG=1323921,1323917 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@834 0039d316-1c4b-4281-b951-d872f2087c98
* git-svn-id: svn://svn.chromium.org/chrome/trunk/src@831 ↵sky@google.com2008-08-131-22/+3
| | | | 0039d316-1c4b-4281-b951-d872f2087c98
* Add new bookmark_bar_context_menu_tonroller*.cc files and newsgk@google.com2008-08-131-0/+1
| | | | | | | | bookmark_editor_view_unittest.cc file. Overlooked adding browser_views.lib to link of unit_tests.exe. TBR: sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@830 0039d316-1c4b-4281-b951-d872f2087c98
* Tests for KeywordEditorView.sky@google.com2008-08-133-10/+191
| | | | | | | | BUG=1324185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@828 0039d316-1c4b-4281-b951-d872f2087c98
* The width of the version field is not wide enough for all cases. We used to ↵finnur@google.com2008-08-131-3/+7
| | | | | | | | | use set_default_width, but that gives you a size based on the average font size, so if you pass in 15 you might only fit ie. 11 chars, depending on what the text is. I'd like to just say, take up all the width you have available - up to the icon in the dialog, that is, but the icon is part of a background image, so I just define a set width for the text field. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@826 0039d316-1c4b-4281-b951-d872f2087c98
* Don't save the window position of popup windows.beng@google.com2008-08-131-0/+4
| | | | | | | B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@825 0039d316-1c4b-4281-b951-d872f2087c98
* Set the svn:eol-style to LF on all SConscript filestc@google.com2008-08-133-553/+553
| | | | | | TBR=evanm git-svn-id: svn://svn.chromium.org/chrome/trunk/src@823 0039d316-1c4b-4281-b951-d872f2087c98
* Copy contents of FrameView into BrowserView2. Once the old frames retire, we ↵beng@google.com2008-08-132-1/+127
| | | | | | | | won't need this separate class. B=1031852 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@818 0039d316-1c4b-4281-b951-d872f2087c98
* Tests for BookmarkEditorView.sky@google.com2008-08-133-5/+241
| | | | | | | | | BUG=1323423 TEST=this is some tests. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@817 0039d316-1c4b-4281-b951-d872f2087c98
* Changes printf to fprintf(stderr) in hopes of determining flakiness.sky@google.com2008-08-131-21/+21
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@813 0039d316-1c4b-4281-b951-d872f2087c98
* First, this removes the dependency of NavigationController on thebrettw@google.com2008-08-1318-167/+155
| | | | | | | | | | | | | | | | | | | | | | SessionService. There were already some notifications that could be used to tell what's going on, and I filled out the rest. I moved some notifications from various places to the NavigationController. In ssl_blocking_page, I removed a notification because it also calls DidNavigateToEntry which does the notification (we got duplicate calls before). In browser.cc I removed the tab parented notification since this is already called by NavigationController::SetWindowID. I removed some obsolete notifications and associated structures, especially in history (like HOST_DELETED that was never issued). I renamed the window_map_ in the MetricsService becuase it was actually a map of controllers and Windows. This also reorders the navigation_types header file to try to bring some order to it. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@807 0039d316-1c4b-4281-b951-d872f2087c98
* Moves bookmark bar context menu controller into its own files alongsky@google.com2008-08-136-391/+686
| | | | | | | | | | | with a test. BUG=none TEST=none; just make sure context menu for bookmark bar still works git-svn-id: svn://svn.chromium.org/chrome/trunk/src@805 0039d316-1c4b-4281-b951-d872f2087c98
* Enable back SavePageTest.SaveHTMLOnly since it was mostly failing on Windows ↵maruel@google.com2008-08-131-2/+6
| | | | | | | | | | 2000 and add debugging information to know how SavePageTest.SaveCompleteHTML is failing. TBR=rocking git-svn-id: svn://svn.chromium.org/chrome/trunk/src@801 0039d316-1c4b-4281-b951-d872f2087c98
* Disable PrintingLayoutTest.Delayed on Windows 2000 (even though it's already ↵maruel@google.com2008-08-131-1/+5
| | | | | | disabled). Also disable PrintingLayoutTest.IFrame, it's still flaky. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@800 0039d316-1c4b-4281-b951-d872f2087c98
* Two changes to help track down why session restore test is failing:sky@google.com2008-08-133-11/+32
| | | | | | | | | | | | | 1. Adds a timeout in waiting for a tab to be restored. 2. Adds a bunch of printfs that will hopefully let me figure out where the test is failing. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@797 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 01:29:12 +0000